Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Changes (by brendan): * status: reopened => closed * resolution: => fixed Comment: (In [e6f958b093b6]) Make GPGME backend generate a RFC3156-compliant micalg parameter (blush). Based on a patch by Stefan Haun. Closes #2901. --

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Comment (by LeSpocky): Replying to [comment:10 MrTux]: > Thanks for the suggestion. I am not that familar with mutt, so I did not know about function. > > Patch version 4 (second attachment) uses ascii_tolower and follows the hint giv

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Comment (by MrTux): Replying to [comment:9 Sertaç Ö. Yıldız]: > tolower() is not locale safe so this might not give what you intend to > get on some (Turkish) locales. ascii_tolower() might be more > appropriate. Thanks for the sugges

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Comment (by Sertaç Ö. Yıldız): {{{ [05.Haz.07 15:38 -] Mutt: > The following patch solves the problem: […] > + if (!get_micalg (ctx, buf+4, sizeof buf - 4)) > +{ > + /* > + * Convert result according to RFC3156

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Changes (by MrTux): * status: closed => reopened * resolution: fixed => Comment: Replying to [comment:7 Brendan Cully]: > You probably don't want to close the bug until the patch has actually > been applied. Otherwise there's a g

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Comment (by Brendan Cully): {{{ On Tuesday, 05 June 2007 at 15:38, Mutt wrote: > #2901: wrong parameter micalg with mutt 1.5.15 and gpgme > > Changes (by MrTux): > > * status: new => closed > * resolution: => fixed You proba

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Comment (by Paul Walker): {{{ On Tue, Jun 05, 2007 at 04:00:56PM -, Mutt wrote: > But, in this case, I do not consider it critical; to create the situation > you refer to, the source code must be altered in an unlikely way. Hav

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Comment (by MrTux): Replying to [comment:4 Paul Walker]: > If I've understood it right, if sizeof(buf) < 4 that loop will dereference > off the end of the array before checking the boundary condition. Maybe > switch the checks around?

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

On Tue, Jun 05, 2007 at 03:38:45PM -, Mutt wrote: > + for (i = 4; buf[i] && i < sizeof buf; i++) > + buf[i] = tolower(buf[i]); If I've understood it right, if sizeof(buf) < 4 that loop will dereference off the end of the array before checking the boundary condition. Maybe switch

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Changes (by MrTux): * status: new => closed * resolution: => fixed Comment: The following patch solves the problem: {{{ Index: crypt-gpgme.c === RCS file: /home/r

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Comment (by lespocky): I looked around a bit to find hints to solve this problem. First is RFC3156 saying the following: The "micalg" parameter for the "application/pgp-signature" protocol MUST contain exactly one hash-symbol of

[Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme I compiled a clean mutt 1.5.15 with gcc 3.4.5 as follows: {{{ ./configure --prefix=/usr \ --build=i386-pc-linux-gnu \ --sysconfdir=/etc \ --localstatedir=/var/lib \

Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme Changes (by lespocky): * keywords: => gpgme micalg -- Ticket URL: