Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-25 Thread raf
rs are Kevin's. Many others are translation-related. Other than those, most names appear once or twice other than Remco Rijnders, Vincent Lefevre, Maxim Tarasov, William Yardley and Aitor Soroa. Sorry if I've read the commit logs badly. cheers, raf

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-25 Thread raf
On Tue, May 24, 2022 at 11:19:43AM -0700, "Kevin J. McCarthy" wrote: > On Tue, May 24, 2022 at 09:58:08AM -0700, Kevin J. McCarthy wrote: > > On Fri, May 20, 2022 at 05:56:58PM +1000, raf wrote: > > > +#define SHELL_NON_SPACE_META_CHARACTERS "|&;()<>[]

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-24 Thread raf
On Tue, May 24, 2022 at 09:58:08AM -0700, "Kevin J. McCarthy" wrote: > On Fri, May 20, 2022 at 05:56:58PM +1000, raf wrote: > > +#define SHELL_NON_SPACE_META_CHARACTERS "|&;()<>[]{}$`'~\"\\*?" > > + if (Sendmail[str

Re: [PATCH] Add error when $sendmail has shell metachars

2022-05-24 Thread raf
On Tue, May 24, 2022 at 09:38:50AM -0700, "Kevin J. McCarthy" wrote: > Thanks for the patch, raf. > > While it *probably* wouldn't cause any harm, I don't think the benefit > outweighs the potential risk for committing this to stable. (Also, I > generally d

[PATCH] Add error when $sendmail has shell metachars

2022-05-22 Thread raf
--- sendlib.c | 8 1 file changed, 8 insertions(+) diff --git a/sendlib.c b/sendlib.c index 430b5d73..05039714 100644 --- a/sendlib.c +++ b/sendlib.c @@ -2706,6 +2706,14 @@ mutt_invoke_sendmail (ADDRESS *from, /* the sender */ return -1; } + /* check for shell meta-charact