[PATCH] Re: [PATCH] Re: Segfault with CVS mutt

2007-02-21 Thread Ken Brush
(reposted since I think it got lost in the thread...) After giving this some thought last night, I realized that it's probably better if we don't create a structure full of possible holes (we trust h.sid a little too much at this point). So here's a potentially better fix. It renders my previou

Re: [PATCH] Re: [PATCH] Re: Segfault with CVS mutt

2007-02-12 Thread Ken Brush
On 2/11/07, Ken Brush <[EMAIL PROTECTED]> wrote: On 2/11/07, Kees Cook wrote: > On Sat, Feb 10, 2007 at 10:32:24PM -0800, Ken Brush wrote: > > Ok, I've attached a patch that fixes this bug. > > I've adjust this to check for the NULL deref just before the header da

Re: Segfault with CVS mutt

2007-02-11 Thread Ken Brush
On 2/11/07, Brendan Cully <[EMAIL PROTECTED]> wrote: On Monday, 05 February 2007 at 16:54, David Shaw wrote: > When opening an IMAPS mailbox, I am getting a crash with the > head-of-CVS mutt. The mailbox starts to read in the headers, then > mutt prints out "Error opening mailbox" and segfaults.

[PATCH] Re: [PATCH] Re: Segfault with CVS mutt

2007-02-11 Thread Ken Brush
On 2/11/07, Kees Cook wrote: On Sat, Feb 10, 2007 at 10:32:24PM -0800, Ken Brush wrote: > Ok, I've attached a patch that fixes this bug. I've adjust this to check for the NULL deref just before the header data free call: I like how you did it better. Here's the 2nd revisio

[PATCH] Re: Segfault with CVS mutt

2007-02-10 Thread Ken Brush
On 2/10/07, David Shaw <[EMAIL PROTECTED]> wrote: On Sat, Feb 10, 2007 at 08:14:44PM -0800, Ken Brush wrote: > There's the problem this line: > 5< a0005 NO There is insufficient disk space to complete operation. > > There is a problem with your imap server. Most clien

Re: Segfault with CVS mutt

2007-02-10 Thread Ken Brush
When opening an IMAPS mailbox, I am getting a crash with the head-of-CVS mutt. The mailbox starts to read in the headers, then mutt prints out "Error opening mailbox" and segfaults. Here is a backtrace, 'mutt -v' output is below that, and the tail of .muttdebug0 is after that. David Here