Re: [PATCH v2] Add a receive_timeout option for sockets

2022-11-29 Thread David Vernet
ff-by: Matthew Sotoudeh Thanks, Matthew. Looks good other than 1 suggestion below. Acked-by: David Vernet > --- > > Thanks for the great tips! Hope this is a bit nicer formatted :) > (Also, happy to move to gitlab if preferable & more changes desired for > this. Sent her

Re: [PATCH] Updated: add a receive_timeout option for sockets

2022-11-28 Thread David Vernet
On Mon, Nov 28, 2022 at 06:48:38PM -0800, Kevin J. McCarthy wrote: > On Mon, Nov 28, 2022 at 07:45:00PM -0600, David Vernet wrote: > > On Mon, Nov 28, 2022 at 04:14:10PM -0800, Matthew Sotoudeh via Mutt-dev > > wrote: > > > Per feedback from Kevin & David (thanks!),

Re: [PATCH] Updated: add a receive_timeout option for sockets

2022-11-28 Thread David Vernet
On Mon, Nov 28, 2022 at 04:14:10PM -0800, Matthew Sotoudeh via Mutt-dev wrote: > Per feedback from Kevin & David (thanks!), moved the timeout code into > socket_connect and updated the description to be more descriptive and > more closely match the existing connect_timeout. I'm not sure how the mu

Re: [PATCH] Add a receive_timeout option for sockets

2022-11-28 Thread David Vernet
On Sat, Nov 26, 2022 at 11:38:24AM -0800, Matthew Sotoudeh via Mutt-dev wrote: > On an unreliable connection (e.g., laptop put to sleep and changing wifi > networks) I've had mutt fairly regularly become stuck in SSL_read and > have to be killed. > > Per some of the comments on > https://stackover

Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-20 Thread David Vernet
On Thu, Oct 20, 2022 at 09:57:56AM -0700, Kevin J. McCarthy wrote: > On Wed, Oct 19, 2022 at 09:42:55PM -0500, David Vernet wrote: > > On Wed, Oct 19, 2022 at 04:20:22PM -0700, Kevin J. McCarthy wrote: > > > That's fine, or I'll be happy to touch it up myself a

Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-19 Thread David Vernet
On Wed, Oct 19, 2022 at 04:20:22PM -0700, Kevin J. McCarthy wrote: > On Wed, Oct 19, 2022 at 02:16:12PM -0500, David Vernet wrote: > > On Wed, Oct 19, 2022 at 10:47:26AM -0700, Kevin J. McCarthy wrote: > > > The documentation should be fixed for that. > > > > Ack, th

Re: [PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-19 Thread David Vernet
On Wed, Oct 19, 2022 at 10:47:26AM -0700, Kevin J. McCarthy wrote: > Hi David, > > Thanks for the patch. > > On Wed, Oct 19, 2022 at 12:01:36PM -0500, David Vernet wrote: > > In imap_check_mailbox(), there is an if clause where we potentially poll > > IMAP with

[PATCH] Account for Timeout <= 0 for sending IMAP NOOP cmd

2022-10-19 Thread David Vernet
tance going from almost being completely unusable in the pager due to latencies on almost every command, to much more seamless. Signed-off-by: David Vernet --- imap/imap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/imap/imap.c b/imap/imap.c index b92c2dcfbccd..bba49b1a