Wrong location of manual.txt in 1.14.1 in Muttrc

2020-05-25 Thread Dave Wood
Using: Mutt 1.14.1 Slackware -current 64 bit. Hello all, I hope it's OK to post this here rather than in the Mutt Users list. I noticed that in 1.14.1, manual.txt is installed into --docdir or --with-docdir as it was in previous versions, but the path is put in the system Muttrc as /usr/local/

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Kevin J. McCarthy
On Mon, May 25, 2020 at 10:04:40AM -0400, Remco Rijnders wrote: Having made these changes, I get build errors of the kind: Remco, sorry I missed a few of those issues. In general you'll want to follow the pattern of other files: * Your mutt_random.h should have #defines to prevent double inc

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Remco Rijnders
On Mon, May 25, 2020 at 04:24:41PM +0200, Oswald wrote in <20200525142441.GC855843@ugly>: Well, the idea for z4 is really to pick another seed than any other user running mutt on the same system would have. every process gets its own address space, so it will be the same in each process, unless

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Oswald Buddenhagen
On Mon, May 25, 2020 at 09:05:21AM -0400, Remco Rijnders wrote: On Sun, May 24, 2020 at 06:49:03PM -0700, Kevin wrote in <20200525014903.ga1...@afu.lan>: + z1 = ((u_int32_t) tv.tv_sec << 20) | tv.tv_usec; + z2 = getpid(); + z3 = getppid(); + z4 = (intptr_t) &z4; +} Comments on the seed choi

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Remco Rijnders
On Sun, May 24, 2020 at 06:49:03PM -0700, Kevin wrote in <20200525014903.ga1...@afu.lan>: diff --git a/mutt_random.h b/mutt_random.h +#include +#include +#include +#include Mutt traditionally puts these inside the .c file. So I'd prefer to see them moved there. +extern void mutt_to_

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Remco Rijnders
On Mon, May 25, 2020 at 08:02:54AM +0200, Petr wrote in <20200525060254.ga3...@album.bayer.uni.cx>: Software distributors are not happy seeing various software carrying its own cryptographic code. Could you please keep using the system-provided functions if available? Hi Petr, Thank you for yo

Re: [PATCH 1/3] Use LFSR113 PRNG for mutt's internal random needs

2020-05-25 Thread Remco Rijnders
On Sun, May 24, 2020 at 06:49:03PM -0700, Kevin wrote in <20200525014903.ga1...@afu.lan>: On Sun, May 24, 2020 at 04:59:24PM -0400, Remco Rijnders wrote: By implementing the LFSR113 function by Pierre L'Ecuyer mutt gets a fast and high quality PRNG that, given the same seeds, results in the same