Re: [PATCHv2] Add support for LMDB header cache backend

2017-01-27 Thread Clemens Lang
Hi, On Fri, Jan 27, 2017 at 10:47:38AM +0100, Fabian Groffen wrote: > On 27-01-2017 09:58:52 +0100, Fabian Groffen wrote: > > > - There's a missing free(&ctx) in hcache_lmdb_open() when > > >mdb_env_create() fails. > > > > I'll add it, thanks. > > I looked at this but can't see a problem in

Re: [PATCH] Add support for LMDB header cache backend

2017-01-27 Thread Kevin J. McCarthy
On Fri, Jan 27, 2017 at 12:07:19PM +, Richard Russon wrote: > > > Please find attached a patch against current Mutt tip to add LMDB > > > This was actually next on my list > > I appreciate you bundling this up and sending it to the list! > > Would you consider *all* of our hcache changes? > -

Re: [PATCH] Add support for LMDB header cache backend

2017-01-27 Thread Richard Russon
> > Please find attached a patch against current Mutt tip to add LMDB > This was actually next on my list > I appreciate you bundling this up and sending it to the list! Would you consider *all* of our hcache changes? - LMDB - kyotocabinet - refactor to separate hcaches Pietro Cerutti (gahr) ref

[PATCHv2] Add support for LMDB header cache backend

2017-01-27 Thread Fabian Groffen
On 27-01-2017 09:58:52 +0100, Fabian Groffen wrote: > > Two minor issues: > > - You may want to set LMDB_DB_SIZE to a larger value, see > >https://github.com/neomutt/neomutt/issues/267 > > Ok, I'll add that. > > > - There's a missing free(&ctx) in hcache_lmdb_open() when > >mdb_env_crea

Re: [PATCH] Add support for LMDB header cache backend

2017-01-27 Thread Fabian Groffen
On 26-01-2017 22:16:51 +0100, Clemens Lang wrote: > Hi, > > On Thu, Jan 26, 2017 at 11:03:19AM -0800, Will Yardley wrote: > > On Thu, Jan 26, 2017 at 10:40:37AM -0800, Kevin J. McCarthy wrote: > > > On Thu, Jan 26, 2017 at 06:42:10PM +0100, Fabian Groffen wrote: > > > > Please find attached a patc