Re: [Mutt] #3866: interrupting mutt operations

2016-09-06 Thread Mutt
#3866: interrupting mutt operations +-- Reporter: antonio@… | Owner: mutt-dev Type: defect | Status: new Priority: major | Milestone: Component: mutt |Version: 1.7.0 Resolution: | Keywords: ---

Re: [Mutt] #3866: interrupting mutt operations

2016-09-06 Thread Mutt
#3866: interrupting mutt operations +-- Reporter: antonio@… | Owner: mutt-dev Type: defect | Status: new Priority: major | Milestone: Component: mutt |Version: 1.7.0 Resolution: | Keywords: ---

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-06 Thread Derek Martin
On Tue, Sep 06, 2016 at 12:36:12PM -0700, Kevin J. McCarthy wrote: > On Mon, Sep 05, 2016 at 07:07:18PM -0500, Derek Martin wrote: > I need to think about this. I'm nervous about this approach, because > I'm not convinced all the possible string truncations are of sufficient > severity to warrant

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-06 Thread Kevin J. McCarthy
On Tue, Sep 06, 2016 at 01:39:18PM -0400, Damien Riegel wrote: > Quick question, mutt has snprintf.c which implements snprintf and > vsnprintf. Now that mutt requires a C99 compiler, is this file (and > checks in configure) still needed? Probably not. I'm not really in a hurry to rip it out, thou

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-06 Thread Kevin J. McCarthy
On Mon, Sep 05, 2016 at 07:07:18PM -0500, Derek Martin wrote: > The abort on failure is annoying, but better than a potential security > hole caused by silently truncating sensitive data, and the abort > mostly shouldn't ever happen. I need to think about this. I'm nervous about this approach, be

Re: Sidebar patch and question

2016-09-06 Thread isdtor
Kevin J. McCarthy writes: [...] > > The question is, does it make sense to add them to more than just > > index and pager maps. I don't feel that strongly about it. > > This is more complicated than it sounds, as we'd have to handle changing > mailboxes in places where this might not make sense.

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-06 Thread Damien Riegel
On Mon, Sep 05, 2016 at 07:07:18PM -0500, Derek Martin wrote: > On Mon, Sep 05, 2016 at 10:32:40AM -0500, Derek Martin wrote: > > Is strfcpy() widely available? > > Ah, now I see that strfcpy() is a Mutt-specific macro that intends to > make strncpy() safer. I was actually thinking of strlcpy()

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-06 Thread Derek Martin
On Tue, Sep 06, 2016 at 01:10:36PM +0200, Vincent Lefevre wrote: > On 2016-09-05 19:07:18 -0500, Derek Martin wrote: > > On Mon, Sep 05, 2016 at 10:32:40AM -0500, Derek Martin wrote: > > > Is strfcpy() widely available? > > > > Ah, now I see that strfcpy() is a Mutt-specific macro that intends t

Re: [SPAM?] [PATCH] doc: A css fix to ease reading the manual on big screens

2016-09-06 Thread Alexander Gromnitsky
On Tue, Sep 06, 2016 at 01:26:15PM +0200, Vincent Lefevre wrote: > Unfortunately px is underspecified. What do you mean? >> Perhaps it would be beneficial to add >> >> >> >> to `mutt.xsl` to ask a browser to use an "ideal" viewport of the >> device. > But then, it seems that you may have prob

Re: [SPAM?] [PATCH] doc: A css fix to ease reading the manual on big screens

2016-09-06 Thread Vincent Lefevre
On 2016-09-06 06:21:18 +0300, Alexander Gromnitsky wrote: > On Mon, Sep 05, 2016 at 06:04:59PM -0500, Derek Martin wrote: > > On Sat, Sep 03, 2016 at 05:09:46AM +0300, Alexander Gromnitsky wrote: > >> -body { margin-left:2%; margin-right:2%; font-family:serif; } > >> +@media (min-width: 768px) { >

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-06 Thread Vincent Lefevre
On 2016-09-05 19:07:18 -0500, Derek Martin wrote: > On Mon, Sep 05, 2016 at 10:32:40AM -0500, Derek Martin wrote: > > Is strfcpy() widely available? > > Ah, now I see that strfcpy() is a Mutt-specific macro that intends to > make strncpy() safer. I was actually thinking of strlcpy(), which is >