Re: [PATCH 2/4] Generate version string during make not configure

At 19:25 -0600 14 Dec 2012, David Champion wrote: That's good. If mutt still supports non-GNU makes we should leave it that way. Building from CVS (hg) has required GNU for so long I no longer think of as optional. :/ I don't know if it actually works, but the `INSTALL` file implies that th

Re: [PATCH 4/4] version.sh: Get detailed version info from git

* On 14 Dec 2012, Aaron Schrab wrote: > At 18:10 -0600 14 Dec 2012, David Champion wrote: > >This is good to add support for, but note that the ${a#b} and ${a%b} > >family of parameter expressions is nonportable. These are commonly > >accepted bashisms that also work in zsh, but not in xpg4 shel

Re: [PATCH 2/4] Generate version string during make not configure

* On 14 Dec 2012, Aaron Schrab wrote: > >.PHONY: version.h ? > > I did it that way to try to be more portable. The docs for gnu make state: > > Using `.PHONY' is more explicit and more efficient. However, other > versions of `make' do not support `.PHONY'; thus `FORCE' appears in >

Re: [PATCH 4/4] version.sh: Get detailed version info from git

At 18:10 -0600 14 Dec 2012, David Champion wrote: This is good to add support for, but note that the ${a#b} and ${a%b} family of parameter expressions is nonportable. These are commonly accepted bashisms that also work in zsh, but not in xpg4 shells. Can you redo with seds, or something? I h

Re: [PATCH 2/4] Generate version string during make not configure

At 18:06 -0600 14 Dec 2012, David Champion wrote: +version.h: FORCE + echo '#define MUTT_VERSION "'`sh "$(srcdir)/version.sh"`'"' > $@.tmp + (cmp -s $@ $@.tmp) && rm -f $@.tmp || mv $@.tmp $@ +FORCE: + .PHONY: version.h ? I did it that way to try to be more portable. The docs fo

Re: [PATCH 4/4] version.sh: Get detailed version info from git

This is good to add support for, but note that the ${a#b} and ${a%b} family of parameter expressions is nonportable. These are commonly accepted bashisms that also work in zsh, but not in xpg4 shells. Can you redo with seds, or something? * On 13 Dec 2012, Aaron Schrab wrote: > From: Aaron Schr

Re: [PATCH 2/4] Generate version string during make not configure

I haven't tested this myself, but in general it looks like a good idea. Thanks for splitting it into conceptual staged changes -- review is much easier. Comments inline as needed. * On 13 Dec 2012, Aaron Schrab wrote: > From: Aaron Schrab > > Switch to generating the version string during make

[PATCH 2 of 3] Add subjectrx command to replace matching subjects with something else

# HG changeset patch # User David Champion # Date 1355527743 21600 # Branch HEAD # Node ID ecae1a363182797c2c157e88ff51d07c82f0a20c # Parent 7a90f541ff6942f05c4ad36130c2354238b1d67d Add subjectrx command to replace matching subjects with something else. This lets you define regular expressions-r

[PATCH 3 of 3] Adds mailboxrx (and unmailboxrx) command

# HG changeset patch # User David Champion # Date 1355527745 21600 # Branch HEAD # Node ID 8f4ff2c8f2e7314e3d62e879aaf91bb035d92da0 # Parent ecae1a363182797c2c157e88ff51d07c82f0a20c Adds mailboxrx (and unmailboxrx) command. Mailboxrx allows you to define a regular expression and replacement temp

[PATCH 1 of 3] Abstract the SPAM_LIST as a generic REPLACE_LIST

# HG changeset patch # User David Champion # Date 1355527735 21600 # Branch HEAD # Node ID 7a90f541ff6942f05c4ad36130c2354238b1d67d # Parent c4c65eadeb7142764bbd73ae63aeef3970669bed Abstract the SPAM_LIST as a generic REPLACE_LIST REPLACE_LIST can be used more generally as a list of pattern matc

[PATCH 0 of 3] Regex replacement on Subject

Questions about subject replacement have come up twice recently in mutt-users, and Michael has expressed support for the principle, so I'm resending this patch to the -dev list for review. Patch 1: refactors the regex replacement used by spam matching into a more abstract replacement mechanism, RE

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [PATCH] Make imap_free_header_data type-safe

On 2012-12-14 14:28:14 +1100, Cameron Simpson wrote: > On 09Sep2012 20:00, Andrew Gaul wrote: > | - /* suppress GCC aliasing warning */ > | - imap_free_header_data ((void**) (void*) &h.data); > > Pardon my ignorance, but what is (was?) the use of a cast like: > > (void**) (void*)