Re: [mp2] [PATCH] implement ap_save_brigade

2005-05-17 Thread Dorian Taylor
> I'm not getting very far with this, Dorian. Neither httpd-dev nor apr-dev > are taking it anywhere. So at the moment ap_save_brigade is sort of an > unstable API, so other developers think we shouldn't expose it in the core > API. So at the moment you have two options: hm, this is unfortunate

Re: [mp2] [PATCH] implement ap_save_brigade

2005-05-17 Thread Stas Bekman
Dorian Taylor wrote: I'm not getting very far with this, Dorian. Neither httpd-dev nor apr-dev are taking it anywhere. So at the moment ap_save_brigade is sort of an unstable API, so other developers think we shouldn't expose it in the core API. So at the moment you have two options: hm, this i

Re: [mp2] [PATCH] implement ap_save_brigade

2005-05-12 Thread Stas Bekman
Stas Bekman wrote: Dorian Taylor wrote: it'd be nice to run a benchmark. I wonder why ap_save_brigade was marked as ! in the map file. Which normally means it's not going to be exposed. Did you by chance look at the archives for possible references to it? there's a mention of it in the APR::Buc

Re: [mp2] [PATCH] implement ap_save_brigade

2005-05-09 Thread Stas Bekman
Dorian Taylor wrote: it'd be nice to run a benchmark. I wonder why ap_save_brigade was marked as ! in the map file. Which normally means it's not going to be exposed. Did you by chance look at the archives for possible references to it? there's a mention of it in the APR::Bucket manpage. i could

Re: [mp2] [PATCH] implement ap_save_brigade

2005-05-09 Thread Dorian Taylor
> it'd be nice to run a benchmark. I wonder why ap_save_brigade was marked > as ! in the map file. Which normally means it's not going to be exposed. > Did you by chance look at the archives for possible references to it? there's a mention of it in the APR::Bucket manpage. i couldn't find anythi

Re: [mp2] [PATCH] implement ap_save_brigade

2005-05-09 Thread Stas Bekman
Dorian Taylor wrote: How is that related? i think that's some cargo culting that i didn't clean up. that can be disregarded. sure So you think this approach will be faster than flattening bb on each filter invocation and concatenating the scalar? honestly i didn't give it any thought. when i wro

Re: [mp2] [PATCH] implement ap_save_brigade

2005-05-09 Thread Dorian Taylor
> How is that related? i think that's some cargo culting that i didn't clean up. that can be disregarded. > So you think this approach will be faster than flattening bb on each > filter invocation and concatenating the scalar? honestly i didn't give it any thought. when i wrote this i just want

Re: [mp2] [PATCH] implement ap_save_brigade

2005-05-09 Thread Stas Bekman
Dorian Taylor wrote: no tests currently, but there's a module on cpan that uses it. http://search.cpan.org/~DORIAN/Apache-TrapSubRequest-0.01/ Thanks Dorian, please see comments below. diff -ur mod_perl-2.0.0-RC4/lib/Apache/Pa