Re: [RFC PATCH BUG DBI] Apache::AuthDBI broken

2006-04-03 Thread Jonathan Vanasco
On Apr 3, 2006, at 8:19 PM, [EMAIL PROTECTED] wrote: I don't think there's any down-side to adding DISTINCT. (Is it standard sql? I think it probably is, but I don't have a reference.) If there is, it would be worth adding another yes/no knob to the config. SELECT DISTINCT behaves radica

Re: [RFC PATCH BUG DBI] Apache::AuthDBI broken

2006-04-03 Thread Philip M. Gollucci
[EMAIL PROTECTED] wrote: I just noticed one additional tweak that would be worth adding to your list: It would be good to add "DISTINCT" to the group select statement... That is, change (after my patch): my $select= "SELECT $Attr->{grp_field}, $Attr->{uid_field}"; to: my $select= "S

Re: [RFC PATCH BUG DBI] Apache::AuthDBI broken

2006-04-03 Thread pedersen
I just noticed one additional tweak that would be worth adding to your list: It would be good to add "DISTINCT" to the group select statement... That is, change (after my patch): my $select= "SELECT $Attr->{grp_field}, $Attr->{uid_field}"; to: my $select= "SELECT DISTINCT $Attr->{grp_

Re: [RFC PATCH BUG DBI] Apache::AuthDBI broken

2006-03-29 Thread Philip M. Gollucci
[EMAIL PROTECTED] wrote: The newest version of Apache::AuthDBI is broken. When used under Apache 1, it has compile-time errors introduced with Apache 2 compatability. This diff fixes that, and also some older problems: - fixes case sensitivity of usernames and passwords - fixes O(n) searc