Dominique Quatravaux wrote:
I wrote:
Stop the press! My patch was incomplete:
... and this one was incomplete too, I forgot about the POD. It looks
like I am doomed to make a fool of myself in every conceivable way on
this list :-( Apologies yet again.
[...]
That's cool, it wasn't committed yet :
I wrote:
> Stop the press! My patch was incomplete:
... and this one was incomplete too, I forgot about the POD. It looks
like I am doomed to make a fool of myself in every conceivable way on
this list :-( Apologies yet again.
Index: ModPerl-Registry/lib/ModPerl/PerlRun.pm
==
I wrote:
>The other problem is that I cannot Do The Right Thing while keeping
>the current API intact. I propose the attached patch as an alternative,
Stop the press! My patch was incomplete: I forgot to rename
"rewrite_shebang()" into "shebang_to_perl()" in subclasses
ModPerl::Registry and ModPe
Dominique Quatravaux wrote:
In which case you will end up with use warnings on the same line as the
shebang line, no? which will look strange in the debugger
Actually I find this pretty idiomatic, look:
use warnings; #!/usr/bin/perl -w
No? :-)
It may confuse some users who may claim that mod_
> In which case you will end up with use warnings on the same line as the
> shebang line, no? which will look strange in the debugger
Actually I find this pretty idiomatic, look:
use warnings; #!/usr/bin/perl -w
No? :-) Besides this line is seldom debugged anyway (at least in my
experience)
Dominique Quatravaux wrote:
Actually it was one, but Thunderbird munged it :-(. Retrying with
mutt... Sorry for yet another blunder.
[...]
- 'w' => sub { "use warnings;\n" },
+ 'w' => sub { "use warnings; " },
);
sub rewrite_shebang {
In which case you will end up with use warnings on the s
> Thanks, Dominique. But care to post a unified patch? 'diff -u'
> Thanks!
Actually it was one, but Thunderbird munged it :-(. Retrying with
mutt... Sorry for yet another blunder.
Index: ModPerl-Registry/lib/ModPerl/RegistryCooker.pm
===
Dominique Quatravaux wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Because ModPerl::RegistryCooker->rewrite_shebang() adds a line on top
of the file in order to honor e.g. the "-w" in "#!/usr/bin/perl -w",
the debugger loses count.
The (trivial) patch below against SVN trunk fixes that (the
