[PATCH] modem-helpers-qmi: include string.h for memset()

2018-10-16 Thread Ben Chan
This patch fixes the following compiler warning: mm-modem-helpers-qmi.c:568:5: error: implicitly declaring library function 'memset' with type 'void *(void *, int, unsigned int)' [-Werror,-Wimplicit-function-declaration] memset (extended_qmi_lte_bands, 0, extended_qmi_lte_bands_size * sizeof

Re: [PATCH] sim-qmi: avoid unnecessary MM_SIM_QMI() call on MMSimQmi object

2018-10-16 Thread Ben Chan
On Tue, Oct 16, 2018 at 9:42 AM Dan Williams wrote: > On Wed, 2018-10-10 at 23:11 -0700, Ben Chan wrote: > > --- > > src/mm-sim-qmi.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > LGTM > > Pushed to git master. Thanks! ___

Re: [review v2] Voice implementation fixes (with audio channel setup handlers)

2018-10-16 Thread Dan Williams
On Fri, 2018-08-10 at 15:31 +0200, Aleksander Morgado wrote: > Hey Dan, Bob & all, > > I've updated the "aleksander/voice-fixes" branch to include the > "AT^CVOICE based support for Huawei modems that Dan worked on a while > ago in his "dcbw/huawei-voice" branch. > > https://gitlab.freedesktop.or

Re: [review] Voice implementation fixes

2018-10-16 Thread Dan Williams
On Tue, 2018-10-16 at 12:10 -0500, Dan Williams wrote: > On Fri, 2018-06-15 at 01:05 +0200, Aleksander Morgado wrote: > > Hey, > > > > I've pushed a branch to gitlab for review: > > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_ > > re > > quests/2 > > > > It includes several

Re: [review] Voice implementation fixes

2018-10-16 Thread Dan Williams
On Fri, 2018-06-15 at 01:05 +0200, Aleksander Morgado wrote: > Hey, > > I've pushed a branch to gitlab for review: > https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_re > quests/2 > > It includes several fixed and improvements in the voice API > implementation for generic and hu

Re: [PATCH] sim-qmi: avoid unnecessary MM_SIM_QMI() call on MMSimQmi object

2018-10-16 Thread Dan Williams
On Wed, 2018-10-10 at 23:11 -0700, Ben Chan wrote: > --- > src/mm-sim-qmi.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) LGTM > diff --git a/src/mm-sim-qmi.c b/src/mm-sim-qmi.c > index 725e073e..e8c0afef 100644 > --- a/src/mm-sim-qmi.c > +++ b/src/mm-sim-qmi.c > @@ -449,7

Re: ModemManager PPA for Ubuntu

2018-10-16 Thread Aleksander Morgado
Hey, > Could you check > https://launchpad.net/~aleksander-m/+archive/ubuntu/modemmanager-bionic > - it doesn't seem to have triggered a new build and thus still only > has packages for amd64/i386. > I should push the latest stable releases to all those PPAs, that should trigger the new build. Wi