Re: [PATCH] base-modem: remove explicit GDestroyNotify cast on g_object_unref

2018-10-06 Thread Aleksander Morgado
On 10/5/18 7:49 PM, Ben Chan wrote: > g_object_unref is in form of `void (*)(gpointer)`, which matches the > GDestroyNotify signature. An explicit GDestroyNotify cast on > g_object_unref is thus not needed. > --- Pushed to git master, thanks > src/mm-base-modem.c | 4 ++-- > 1 file changed, 2 i

Re: bearer mbim: ipv6_config set to dhcp when no ipv6 is available

2018-10-06 Thread Aleksander Morgado
On 10/5/18 8:51 PM, Dan Williams wrote: >> I noticed, that in ip_configuration_query_ready() ipv6_config will be >> allocated and method will be set to MM_BEARER_IP_METHOD_DHCP even >> when >> ipv6configurationavailable is false, just based on the value of >> ctx->ip_type. >> >> So essentially ever

[review] Support for extended band list in QMI

2018-10-06 Thread Aleksander Morgado
Hey, The following MR implements support for handling E-UTRAN bands that are only managed via the "extended LTE band" TLV in the QMI protocol. https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/44 Comments welcome. -- Aleksander https://aleksander.es __