Re: bearer mbim: ipv6_config set to dhcp when no ipv6 is available

2018-10-05 Thread Dan Williams
On Fri, 2018-10-05 at 11:39 +0200, Andreas Fett wrote: > Hi list, > > I noticed, that in ip_configuration_query_ready() ipv6_config will be > allocated and method will be set to MM_BEARER_IP_METHOD_DHCP even > when > ipv6configurationavailable is false, just based on the value of > ctx->ip_type. >

[PATCH] base-modem: remove explicit GDestroyNotify cast on g_object_unref

2018-10-05 Thread Ben Chan
g_object_unref is in form of `void (*)(gpointer)`, which matches the GDestroyNotify signature. An explicit GDestroyNotify cast on g_object_unref is thus not needed. --- src/mm-base-modem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mm-base-modem.c b/src/mm-base-mo

bearer mbim: ipv6_config set to dhcp when no ipv6 is available

2018-10-05 Thread Andreas Fett
Hi list, I noticed, that in ip_configuration_query_ready() ipv6_config will be allocated and method will be set to MM_BEARER_IP_METHOD_DHCP even when ipv6configurationavailable is false, just based on the value of ctx->ip_type. So essentially every bearer which was *configured* with ip_type v6 or