Re: [PATCH 04/10] api: new ReportKernelEvent() api method to report kernel device addition/removals

2016-09-14 Thread Aleksander Morgado
On Mon, Aug 29, 2016 at 11:25 AM, Aleksander Morgado wrote: >> In the API docs it talks about USB vid/pid, but MM does support at >> least one PCI-native device; the Option Nozomi. SDIO also uses 16-bit >> vid/pid, though I'm not sure why anyone would use SDIO to hook up a >> WWAN modem :) Maybe

Re: New 'u-blox' plugin (review)

2016-09-14 Thread Aleksander Morgado
Hey! > > I'll put in another recommendation for g_clear_object() :) > Yeah... I'll try to do that from now on :) >> ublox: new +UIPADDR=N response parser >> ublox: new +CGCONTRDP=N response parser >> ublox: implement connection using the 2G/3G logic in router or bridge > > It seems like the +CGC

Re: Code Review, Upstream & Certifications

2016-09-14 Thread Aleksander Morgado
On Wed, Sep 14, 2016 at 6:00 PM, matthew stanger wrote: > I haven't heard back from anyone on the patch I submitted on 9/6. I'm not > trying to be pushy, I know everyone here is a volunteer and has their own > lives :) but I'm really eager to get feedback on the code. Our engineering > team at Tri

Re: New 'u-blox' plugin (review)

2016-09-14 Thread Dan Williams
Hi Aleksander, I'll put in another recommendation for g_clear_object() :) > ublox: new +UIPADDR=N response parser > ublox: new +CGCONTRDP=N response parser > ublox: implement connection using the 2G/3G logic in router or bridge It seems like the +CGCONTRDP parsing code could be generic and not l

Code Review, Upstream & Certifications

2016-09-14 Thread matthew stanger
Hi everyone, I haven't heard back from anyone on the patch I submitted on 9/6. I'm not trying to be pushy, I know everyone here is a volunteer and has their own lives :) but I'm really eager to get feedback on the code. Our engineering team at Trimble will be using MM and the patches for a new pro