Re: [Mjpeg-users] [PATCH 133/493] remove use of __devexit_p

2013-01-03 Thread Greg KH
On Thu, Jan 03, 2013 at 12:43:10PM +0100, Guennadi Liakhovetski wrote: > Hi Bill > > On Mon, 19 Nov 2012, Bill Pemberton wrote: > > > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer > > needed. > > Doesn't this also make the use of __refdata in many locations like this > >

Re: [Mjpeg-users] [PATCH 4/8] staging: media: zoran: add debugfs

2021-09-04 Thread Greg KH
On Fri, Sep 03, 2021 at 07:15:36PM +, Corentin Labbe wrote: > Add debugfs for displaying zoran debug and stats information. > > Signed-off-by: Corentin Labbe > --- > drivers/staging/media/zoran/Kconfig | 10 ++ > drivers/staging/media/zoran/zoran.h | 5 +++ > drivers/staging/m

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-22 Thread Greg KH
On Thu, Apr 21, 2022 at 08:30:25PM -0400, Ian Cowan wrote: > On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote: > > On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote: > > > > > > For using the dev_dbg() macro, do you define this in the header file > > > (i.e. for this it would

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-23 Thread Greg KH
On Sat, Apr 23, 2022 at 01:23:31AM -0400, Ian Cowan wrote: > On Fri, Apr 22, 2022 at 07:10:34AM +0200, Greg KH wrote: > > On Thu, Apr 21, 2022 at 08:30:25PM -0400, Ian Cowan wrote: > > > On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote: > > > > On Thu, Ap

Re: [Mjpeg-users] [PATCH 1/4] staging: media: zoran: add zrdev_dbg() macros

2022-04-25 Thread Greg KH
On Sun, Apr 24, 2022 at 09:22:30PM -0400, Ian Cowan wrote: > On Sun, Apr 24, 2022 at 09:17:22PM +0200, LABBE Corentin wrote: > > Hello > > > > Thanks for your patchs, removing dprintk is a good idea. > > Please use pci_xxx() instead of dev_xxx() to be consistent with the rest of > > the driver. >