Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-23 Thread Ian Cowan
On Fri, Apr 22, 2022 at 07:10:34AM +0200, Greg KH wrote: > On Thu, Apr 21, 2022 at 08:30:25PM -0400, Ian Cowan wrote: > > On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote: > > > On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote: > > > > > > > > For using the dev_dbg() macro, d

[Mjpeg-users] [PATCH 3/4] staging: media: zoran: replace all pr_err() with zrdev_err()

2022-04-23 Thread Ian Cowan
This replaces all of the pr_err() calls to the preferred zrdev_err() macro that calls the dev_dbg() macro. Signed-off-by: Ian Cowan --- drivers/staging/media/zoran/videocodec.c | 32 +--- drivers/staging/media/zoran/zr36016.c| 28 + drivers/staging/med

[Mjpeg-users] [PATCH 1/4] staging: media: zoran: add zrdev_dbg() macros

2022-04-23 Thread Ian Cowan
This adds the zrdev_dbg() (pointing to dev_dbg()), zrdev_err() (pointing to dev_err()), and zrdev_info() (pointing to dev_info()) macros to the zoran drivers. These are the preferred method for debugging and this will allow to extract the device from the zoran struct to make the call. Signed-off-b

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-23 Thread Greg KH
On Sat, Apr 23, 2022 at 01:23:31AM -0400, Ian Cowan wrote: > On Fri, Apr 22, 2022 at 07:10:34AM +0200, Greg KH wrote: > > On Thu, Apr 21, 2022 at 08:30:25PM -0400, Ian Cowan wrote: > > > On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote: > > > > On Thu, Apr 21, 2022 at 11:22:00AM -0400,

[Mjpeg-users] [PATCH 2/4] staging: media: zoran: setup videocodec header for zrdev_dbg macros

2022-04-23 Thread Ian Cowan
This adds inline functions in the videocodec header file to convert the videocodec and videocodec_master structs to their respective contained zoran struct. This will be used to pass the zoran struct to the zrdev_dbg() macros defined in the zoran header. In the zoran header, the new include is add

[Mjpeg-users] [PATCH 4/4] staging: media: zoran: replace dprintk with zrdev_dbg

2022-04-23 Thread Ian Cowan
This replaces all of the dprintk() macro calls to the zrdev_dbg(), zrdev_info(), or zrdev_err() calls as appropriate. This allows for the removal of the dprintk() macro from each file it is defined in, along with removal of the module params that track the debugging level. In the case that a debug