Re: [Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 8:15 AM, Christoph Hellwig wrote: > On Tue, Apr 24, 2018 at 10:40:45PM +0200, Arnd Bergmann wrote: >> @@ -221,6 +222,7 @@ struct zoran_fh { >> >> struct zoran_overlay_settings overlay_settings; >> u32 *overlay_mask; /* overlay mask */ >> +

Re: [Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Christoph Hellwig
On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: > > That probably also means it can use dma_mmap_coherent instead of the > > handcrafted remap_pfn_range loop and the PageReserved abuse. > > I'd rather not touch that code. How about adding a comment about > the fact that it should us

[Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
No drivers should use virt_to_bus() any more. This converts one of the few remaining ones to the DMA mapping interface. Signed-off-by: Arnd Bergmann --- drivers/media/pci/zoran/Kconfig| 2 +- drivers/media/pci/zoran/zoran.h| 10 +-- drivers/media/pci/zoran/zoran_card.c | 1

Re: [Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 9:21 AM, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: >> > That probably also means it can use dma_mmap_coherent instead of the >> > handcrafted remap_pfn_range loop and the PageReserved abuse. >> >> I'd rather not touch that cod

Re: [Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Christoph Hellwig
On Tue, Apr 24, 2018 at 10:40:45PM +0200, Arnd Bergmann wrote: > No drivers should use virt_to_bus() any more. This converts > one of the few remaining ones to the DMA mapping interface. > > Signed-off-by: Arnd Bergmann > --- > drivers/media/pci/zoran/Kconfig| 2 +- > drivers/media/pci/

Re: [Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Bernhard Praschinger
Hallo Christoph Hellwig wrote: On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: That probably also means it can use dma_mmap_coherent instead of the handcrafted remap_pfn_range loop and the PageReserved abuse. I'd rather not touch that code. How about adding a comment about the