Re: [Mjpeg-users] [PATCH 1/4] staging: media: zoran: add zrdev_dbg() macros

2022-04-25 Thread LABBE Corentin
Le Sat, Apr 23, 2022 at 01:17:45AM -0400, Ian Cowan a écrit : > This adds the zrdev_dbg() (pointing to dev_dbg()), zrdev_err() (pointing > to dev_err()), and zrdev_info() (pointing to dev_info()) macros to the > zoran drivers. These are the preferred method for debugging and this > will allow to ex

Re: [Mjpeg-users] [PATCH v3 00/14] staging: media: zoran: fusion in one module

2021-11-16 Thread LABBE Corentin
Le Mon, Nov 08, 2021 at 09:21:22AM +0100, Hans Verkuil a écrit : > On 07/11/2021 17:35, LABBE Corentin wrote: > > Le Wed, Nov 03, 2021 at 05:29:46PM +0100, Hans Verkuil a écrit : > >> On 03/11/2021 16:57, LABBE Corentin wrote: > >>> Le Wed, Nov 03, 2021 at 04:21:02

Re: [Mjpeg-users] [PATCH v3 00/14] staging: media: zoran: fusion in one module

2021-11-05 Thread LABBE Corentin
Le Wed, Nov 03, 2021 at 05:29:46PM +0100, Hans Verkuil a écrit : > On 03/11/2021 16:57, LABBE Corentin wrote: > > Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit : > >> Hi Corentin, > >> > >> On 26/10/2021 21:34, Corentin Labbe wrote: > >&g

Re: [Mjpeg-users] [PATCH v3 00/14] staging: media: zoran: fusion in one module

2021-11-03 Thread LABBE Corentin
Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit : > Hi Corentin, > > On 26/10/2021 21:34, Corentin Labbe wrote: > > Hello > > > > The main change of this serie is to fusion all zoran related modules in > > one. > > This fixes the load order problem when everything is built-in. > >

Re: [Mjpeg-users] [PATCH v2 04/10] staging: media: zoran: add debugfs

2021-11-03 Thread LABBE Corentin
Le Tue, Nov 02, 2021 at 08:40:28PM +0300, Dan Carpenter a écrit : > On Sun, Oct 17, 2021 at 10:05:06PM +0200, LABBE Corentin wrote: > > Le Thu, Oct 14, 2021 at 10:37:52AM +0300, Dan Carpenter a écrit : > > > On Wed, Oct 13, 2021 at 06:58:06PM +, Corentin Labbe wrot

Re: [Mjpeg-users] [PATCH v2 00/10] staging: media: zoran: fusion in one module

2021-10-25 Thread LABBE Corentin
Le Mon, Oct 25, 2021 at 05:13:04PM +0200, Hans Verkuil a écrit : > On 25/10/2021 16:21, LABBE Corentin wrote: > > Le Mon, Oct 25, 2021 at 02:45:02PM +0200, Hans Verkuil a écrit : > >> Hi Corentin, > >> > >> On 13/10/2021 20:58, Corentin Labbe wrote: > >&g

Re: [Mjpeg-users] [PATCH v2 00/10] staging: media: zoran: fusion in one module

2021-10-25 Thread LABBE Corentin
Le Mon, Oct 18, 2021 at 11:55:40AM +0200, Hans Verkuil a écrit : > Hi Corentin, > > I noticed some code review comments from Dan and a kernel test robot issue. > Can you post a v3 fixing those by the end of the week? Next week I will have > access again to my zoran board, so then I can test the v3

Re: [Mjpeg-users] [PATCH v2 00/10] staging: media: zoran: fusion in one module

2021-10-25 Thread LABBE Corentin
Le Mon, Oct 25, 2021 at 02:45:02PM +0200, Hans Verkuil a écrit : > Hi Corentin, > > On 13/10/2021 20:58, Corentin Labbe wrote: > > Hello > > > > The main change of this serie is to fusion all zoran related modules in > > one. > > This fixes the load order problem when everything is built-in. > >

Re: [Mjpeg-users] [PATCH v2 06/10] staging: media: zoran: fusion all modules

2021-10-18 Thread LABBE Corentin
Le Thu, Oct 14, 2021 at 11:01:55AM +0300, Dan Carpenter a écrit : > On Wed, Oct 13, 2021 at 06:58:08PM +, Corentin Labbe wrote: > > The zoran driver is split in many modules, but this lead to some > > problems. > > One of them is that load order is incorrect when everything is built-in. > > >

Re: [Mjpeg-users] [PATCH v2 04/10] staging: media: zoran: add debugfs

2021-10-18 Thread LABBE Corentin
Le Thu, Oct 14, 2021 at 10:37:52AM +0300, Dan Carpenter a écrit : > On Wed, Oct 13, 2021 at 06:58:06PM +, Corentin Labbe wrote: > > +config VIDEO_ZORAN_DEBUG > > + bool "Enable zoran debugfs" > > + depends on VIDEO_ZORAN > > + depends on DEBUG_FS > > + help > > + Say y to enable zor

Re: [Mjpeg-users] [PATCH 6/8] staging: media: zoran: fusion all modules

2021-09-06 Thread LABBE Corentin
Le Mon, Sep 06, 2021 at 12:41:32PM +0200, Hans Verkuil a écrit : > On 03/09/2021 21:15, Corentin Labbe wrote: > > The zoran driver is split in many modules, but this lead to some > > problems. > > One of them is that load order is incorrect when everything is built-in. > > > > Having more than one

Re: [Mjpeg-users] [PATCH 0/8] staging: media: zoran: fusion in one module

2021-09-06 Thread LABBE Corentin
Le Mon, Sep 06, 2021 at 04:11:16PM +0200, Hans Verkuil a écrit : > On 06/09/2021 15:49, LABBE Corentin wrote: > > Le Mon, Sep 06, 2021 at 01:03:56PM +0200, Hans Verkuil a écrit : > >> Hi Corentin, > >> > >> I finally had the opportunity to test the staging zor

Re: [Mjpeg-users] [PATCH 4/8] staging: media: zoran: add debugfs

2021-09-06 Thread LABBE Corentin
Le Sat, Sep 04, 2021 at 07:53:00AM +0200, Greg KH a écrit : > On Fri, Sep 03, 2021 at 07:15:36PM +, Corentin Labbe wrote: > > Add debugfs for displaying zoran debug and stats information. > > > > Signed-off-by: Corentin Labbe > > --- > > drivers/staging/media/zoran/Kconfig | 10 ++ >

Re: [Mjpeg-users] [PATCH 0/8] staging: media: zoran: fusion in one module

2021-09-06 Thread LABBE Corentin
Le Mon, Sep 06, 2021 at 01:03:56PM +0200, Hans Verkuil a écrit : > Hi Corentin, > > I finally had the opportunity to test the staging zoran driver. > > I found several issues when running v4l2-compliance -s (I posted a patch > for that), but more seriously is the fact that trying to capture MJPG

Re: [Mjpeg-users] [PATCH v3 05/16] docs: driver-api: media: drivers: zoran.rst: replace some characters

2021-05-17 Thread LABBE Corentin
Le Sun, May 16, 2021 at 12:18:22PM +0200, Mauro Carvalho Chehab a écrit : > The conversion tools used during DocBook/LaTeX/html/Markdown->ReST > conversion and some cut-and-pasted text contain some characters that > aren't easily reachable on standard keyboards and/or could cause > troubles when pa

Re: [Mjpeg-users] [PATCH v2 -next] media: zoran: convert comma to semicolon

2021-01-11 Thread LABBE Corentin
Le Fri, Jan 08, 2021 at 05:21:19PM +0800, Zheng Yongjun a écrit : > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/staging/media/zoran/zoran_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

Re: [Mjpeg-users] [PATCH -next] media: zoran: use resource_size

2021-01-06 Thread LABBE Corentin
Le Wed, Jan 06, 2021 at 05:51:00PM +0300, Dan Carpenter a écrit : > On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote: > > Use resource_size rather than a verbose computation on > > the end and start fields. > > > > Signed-off-by: Zheng Yongjun > > --- > > drivers/staging/media/zoran

Re: [Mjpeg-users] [PATCH] media: zoran.rst: place it at the right place this time

2020-10-05 Thread LABBE Corentin
On Sun, Oct 04, 2020 at 06:00:30PM +0200, Mauro Carvalho Chehab wrote: > I was too quick moving zoran.rst... it ends that the original > patch didn't do the right thing and forgot to update the files > that references it. > > Fix it. > > Fixes: 6b90346919d4 ("media: zoran: move documentation file

Re: [Mjpeg-users] [PATCH 1/4] media: zoran: move documentation file to the right place

2020-10-05 Thread LABBE Corentin
On Sat, Oct 03, 2020 at 10:41:54AM +0200, Mauro Carvalho Chehab wrote: > The zoran revert patch misplaced the Zoran doc file. Move it to > the right place. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/driver-api/media/drivers/index.rst | 1 + > .../{media => dri

Re: [Mjpeg-users] [PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful

2020-10-05 Thread LABBE Corentin
On Fri, Oct 02, 2020 at 11:16:20AM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pci_err error message. Fix this and > make the error message a little more meaningful. > > Signed-off-by: Colin Ian King > --- > drivers/staging/media/zoran/zoran_driver.c |

Re: [Mjpeg-users] [PATCH 2/3] media: zoran: get rid of an unused var

2020-10-02 Thread LABBE Corentin
On Thu, Oct 01, 2020 at 11:28:14AM +0200, Mauro Carvalho Chehab wrote: > The jpeg_error in lowercase is not used anywhere. Drop it. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/staging/media/zoran/zoran.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/

Re: [Mjpeg-users] [PATCH 3/3] media: zoran: fix mixed case on vars

2020-10-02 Thread LABBE Corentin
On Thu, Oct 01, 2020 at 11:28:15AM +0200, Mauro Carvalho Chehab wrote: > Use this small script to replace CamelCase and wrong case > on vars: > > > FILES=$(find "$1" -type f|grep -e '.c$' -e '.h$') > CAMEL_VARS=$(cat tags|perl -ne 'print "$1\n" if > (m/^(\w*[A-Z]\w*[a-z]\w*)\s/)') > for i in $CA