Re: [Mjpeg-users] [PATCH] media: staging: media: zoran: Removed braces for single statement block

2022-08-24 Thread Hans Verkuil
Hi Abhijeet, Thank you for the zoran patches, unfortunately these are a duplicate of https://patchwork.linuxtv.org/project/linux-media/patch/20220810115445.2302477-2-hverkuil-ci...@xs4all.nl/ I wish I'd noticed your patches earlier, it would have saved me some work :-( I'm marking your patches

Re: [Mjpeg-users] [PATCH v2 4/4] staging: media: zoran: replace dprintk with new debugging macros

2022-04-28 Thread Hans Verkuil
Hi Ian, On 25/04/2022 16:41, Ian Cowan wrote: > This replaces all of the dprintk() macro calls to the zrdev_dbg(), > zrdev_info(), or zrdev_err() calls as appropriate. This allows for the > removal of the dprintk() macro from each file it is defined in, along > with removal of the module params th

Re: [Mjpeg-users] [PATCH v3 00/14] staging: media: zoran: fusion in one module

2021-11-08 Thread Hans Verkuil
On 07/11/2021 17:35, LABBE Corentin wrote: > Le Wed, Nov 03, 2021 at 05:29:46PM +0100, Hans Verkuil a écrit : >> On 03/11/2021 16:57, LABBE Corentin wrote: >>> Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit : >>>> Hi Corentin, >>>> >

Re: [Mjpeg-users] [PATCH v3 00/14] staging: media: zoran: fusion in one module

2021-11-03 Thread Hans Verkuil
On 03/11/2021 16:57, LABBE Corentin wrote: > Le Wed, Nov 03, 2021 at 04:21:02PM +0100, Hans Verkuil a écrit : >> Hi Corentin, >> >> On 26/10/2021 21:34, Corentin Labbe wrote: >>> Hello >>> >>> The main change of this serie is to fusion all zoran rel

Re: [Mjpeg-users] [PATCH v3 00/14] staging: media: zoran: fusion in one module

2021-11-03 Thread Hans Verkuil
Hi Corentin, On 26/10/2021 21:34, Corentin Labbe wrote: > Hello > > The main change of this serie is to fusion all zoran related modules in > one. > This fixes the load order problem when everything is built-in. I've been testing this series, and while the module load/unload is now working, I'm

Re: [Mjpeg-users] [PATCH v2 00/10] staging: media: zoran: fusion in one module

2021-10-25 Thread Hans Verkuil
On 25/10/2021 16:21, LABBE Corentin wrote: > Le Mon, Oct 25, 2021 at 02:45:02PM +0200, Hans Verkuil a écrit : >> Hi Corentin, >> >> On 13/10/2021 20:58, Corentin Labbe wrote: >>> Hello >>> >>> The main change of this serie is to fusion all zoran rel

Re: [Mjpeg-users] [PATCH v2 00/10] staging: media: zoran: fusion in one module

2021-10-25 Thread Hans Verkuil
Hi Corentin, On 13/10/2021 20:58, Corentin Labbe wrote: > Hello > > The main change of this serie is to fusion all zoran related modules in > one. > This fixes the load order problem when everything is built-in. > > Regards > > Changes since v1: > - add missing debugfs cleaning > - clean some r

Re: [Mjpeg-users] [PATCH v2 00/10] staging: media: zoran: fusion in one module

2021-10-18 Thread Hans Verkuil
Hi Corentin, I noticed some code review comments from Dan and a kernel test robot issue. Can you post a v3 fixing those by the end of the week? Next week I will have access again to my zoran board, so then I can test the v3 series. BTW, I agree with Dan, just drop the 'Enable zoran debugfs' confi

Re: [Mjpeg-users] [PATCH 6/8] staging: media: zoran: fusion all modules

2021-09-06 Thread Hans Verkuil
On 03/09/2021 21:15, Corentin Labbe wrote: > The zoran driver is split in many modules, but this lead to some > problems. > One of them is that load order is incorrect when everything is built-in. > > Having more than one module is useless, so fusion all zoran modules in > one. After applying thi

Re: [Mjpeg-users] [PATCH 0/8] staging: media: zoran: fusion in one module

2021-09-06 Thread Hans Verkuil
On 06/09/2021 15:49, LABBE Corentin wrote: > Le Mon, Sep 06, 2021 at 01:03:56PM +0200, Hans Verkuil a écrit : >> Hi Corentin, >> >> I finally had the opportunity to test the staging zoran driver. >> >> I found several issues when running v4l2-compliance -s (I post

Re: [Mjpeg-users] [PATCH 0/8] staging: media: zoran: fusion in one module

2021-09-06 Thread Hans Verkuil
On 06/09/2021 16:56, LABBE Corentin wrote: > Le Mon, Sep 06, 2021 at 04:11:16PM +0200, Hans Verkuil a écrit : >> On 06/09/2021 15:49, LABBE Corentin wrote: >>> Le Mon, Sep 06, 2021 at 01:03:56PM +0200, Hans Verkuil a écrit : >>>> Hi Corentin, >>>> >

Re: [Mjpeg-users] [PATCH 0/8] staging: media: zoran: fusion in one module

2021-09-06 Thread Hans Verkuil
Hi Corentin, I finally had the opportunity to test the staging zoran driver. I found several issues when running v4l2-compliance -s (I posted a patch for that), but more seriously is the fact that trying to capture MJPG at resolutions 384x288 or less just hangs my PC. It works OK with 768x576. I

Re: [Mjpeg-users] [PATCH 4/8] staging: media: zoran: add debugfs

2021-09-06 Thread Hans Verkuil
On 03/09/2021 21:15, Corentin Labbe wrote: > Add debugfs for displaying zoran debug and stats information. > > Signed-off-by: Corentin Labbe > --- > drivers/staging/media/zoran/Kconfig | 10 ++ > drivers/staging/media/zoran/zoran.h | 5 +++ > drivers/staging/media/zoran/zoran_card

Re: [Mjpeg-users] bringing back media/zoran driver

2019-09-23 Thread Hans Verkuil
On 9/21/19 7:03 PM, Corentin Labbe wrote: > hello > > I am the owner of a zoran based DC10+ card. > I am in the need of using it since yesterday and I found that its driver was > removed. > > Reverting the removing patch made to a temporary working situation. > > If I understand correctly, it w

Re: [Mjpeg-users] [PATCH] staging: media: zoran: fix trailing whitespaces

2019-04-10 Thread Hans Verkuil
On 4/8/19 8:51 AM, Dan Carpenter wrote: > On Mon, Apr 08, 2019 at 01:35:30AM -0300, Arthur Moraes do Lago wrote: >> There were several form feeds(^L) in the file, this patch removes them >> to conform with the coding style. >> >> Signed-off-by: Arthur Moraes do Lago >> --- >> drivers/staging/medi

[Mjpeg-users] [PATCH] zoran: move to staging in preparation for removal

2018-05-11 Thread Hans Verkuil
l. If someone is interested in working on this driver to prevent its removal, then please contact the linux-media mailinglist. Signed-off-by: Hans Verkuil --- MAINTAINERS | 2 +- drivers/media/pci/Kconfig | 1 - drivers/

Re: [Mjpeg-users] [PATCH] media: zoran: move to dma-mapping interface

2018-05-07 Thread Hans Verkuil
es people do, but >>> most often no one does. >> >> Let's start with this one (zoran) then, as Mauro is keen on having >> all media drivers compile-testable on x86-64 and arm. >> >> Trent Piepho and Hans Verkuil both worked on this driver in the >>

Re: [Mjpeg-users] [PATCH 09/14] zoran: fix indent

2015-04-30 Thread Hans Verkuil
ered from git logs. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/drivers/media/pci/zoran/zoran_device.c > b/drivers/media/pci/zoran/zoran_device.c > index b6801e035ea4..40119b3c52c1 100644 > --- a/drivers/media/pci/zoran/zoran_d

Re: [Mjpeg-users] [patch] [media] zoran: remove duplicate ZR050_MO_COMP define

2014-07-05 Thread Hans Verkuil
On 07/05/2014 04:54 PM, Bernhard Praschinger wrote: > Hallo > > I did remove some mailinglists because I think that it is not important > for them. > > Anyway I'm surprised that someone still seems to has such a card built > into the computer. > >>> More than 15 years have passed since the fir

Re: [Mjpeg-users] [patch] [media] zoran: remove duplicate ZR050_MO_COMP define

2014-06-27 Thread Hans Verkuil
Hi Bernhard, On 06/12/2014 07:28 PM, Bernhard Praschinger wrote: > Hallo > > More than 15 years have passed since the first working module for a > zoran chipset based PCI card existed. Well not included into the > Linux kernel at that time. According to my experience, the driver > started to make