Re: [Mjpeg-users] [PATCH] media: staging: media: zoran: Fixed Block comments

= zoran_enum_output, > - .vidioc_g_output= zoran_g_output, > - .vidioc_s_output= zoran_s_output,*/ > + * .vidioc_g_output= zoran_g_output, > + * .vidioc_s_output= zoran_s_outp

Re: [Mjpeg-users] [PATCH v2 4/4] staging: media: zoran: replace dprintk with new debugging macros

ubmitted v3. > > What did you use to see these issues? When I ran the checkpatch script > and compiled, I did not see any of this. > I have written a blog entry about checking kernel code with Smatch: https://staticthinking.wordpress.com/2022/04/25/how-to-run-smatch-on-your-code/ regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Re: [Mjpeg-users] [PATCH 3/4] staging: media: zoran: replace all pr_err() with zrdev_err()

://download.01.org/0day-ci/archive/20220426/202204260911.ppsncmg4-...@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/staging/media/zoran

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

at how it's used. pr_debug() might be an option, but I don't know if we will accept that, we prefer dev_dbg(). regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

specified level of debugging */ > +#define dprintk(debug, num, format, args...) \ > +do { \ > + if (debug > num) \ > + printk(format, ##args); \ > +} while (0) > + I don't like the new format. It needs to have a KERN_DEBUG at the start. Passing the param_

Re: [Mjpeg-users] [PATCH v2 04/10] staging: media: zoran: add debugfs

On Sun, Oct 17, 2021 at 10:05:06PM +0200, LABBE Corentin wrote: > Le Thu, Oct 14, 2021 at 10:37:52AM +0300, Dan Carpenter a écrit : > > On Wed, Oct 13, 2021 at 06:58:06PM +, Corentin Labbe wrote: > > > +config VIDEO_ZORAN_DEBUG > > > + bool "Enable zoran debugfs

Re: [Mjpeg-users] [PATCH v2 04/10] staging: media: zoran: add debugfs

->map_mode = ZORAN_MAP_MODE_RAW; > > +#ifdef CONFIG_VIDEO_ZORAN_DEBUG > + zr->dbgfs_dir = debugfs_create_dir(ZR_DEVNAME(zr), NULL); > + debugfs_create_file("debug", 0444, > + zr->dbgfs_dir, zr, > +

Re: [Mjpeg-users] [PATCH v2 06/10] staging: media: zoran: fusion all modules

video_codec); if (result < 0) { pci_err(pdev, "failed to load codec %s: %d\n", codec_name, result); zr->card.video_codec = 0; } regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Re: [Mjpeg-users] [PATCH v2 06/10] staging: media: zoran: fusion all modules

ails, the probe function still does zoran_setup_videocodec() on the failed codec. These would be better in a .h file. #ifdef CONFIG_VIDEO_ZORAN_ZR36060 int zr36060_init_module(void); #else int zr36060_init_module(void) { return -EINVAL; } #endif regards, dan carpenter _

Re: [Mjpeg-users] [PATCH -next] media: zoran: use resource_size

On Wed, Jan 06, 2021 at 09:19:58PM +0100, LABBE Corentin wrote: > Le Wed, Jan 06, 2021 at 05:51:00PM +0300, Dan Carpenter a écrit : > > On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote: > > > Use resource_size rather than a verbose computation on > > &g

Re: [Mjpeg-users] [PATCH -next] media: zoran: use resource_size

se of the + 1 on part of the "end - start + 1"... It's sometimes hard to know if we should add the + 1 which resource_size() does or not. (That check is ancient and not up to modern standards). regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Re: [Mjpeg-users] [PATCH] staging: media: zoran: fix trailing whitespaces

nsecutive blank lines so really we should just delete the lines entirely... But this driver is scheduled for deletion in May. Let's not bother with cleaning it up. regards, dan carpenter ___ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users

[Mjpeg-users] [patch] [media] zoran: remove duplicate ZR050_MO_COMP define

The ZR050_MO_COMP define is cut and pasted twice so we can delete the second instance. Signed-off-by: Dan Carpenter diff --git a/drivers/media/pci/zoran/zr36050.h b/drivers/media/pci/zoran/zr36050.h index 9f52f0c..ea083ad 100644 --- a/drivers/media/pci/zoran/zr36050.h +++ b/drivers/media/pci

[Mjpeg-users] [patch] [media] zoran: bit-wise vs logical and

zr->frame_num is a counter and && was intended here instead of &. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/zoran/zoran_device.c b/drivers/media/video/zoran/zoran_device.c index b02007e..e8a2784 100644 --- a/drivers/media/video/zoran/zoran_device.c +++ b/driv

[Mjpeg-users] potential null deref in mpeg_open()

17.c 59 #define dprintk(level, fmt, arg...)\ 60 do { if (v4l_debug >= level) \ 61 printk(KERN_DEBUG "%s: " fmt, dev->name , ## arg);\ 62 } while (0) regards, dan carpenter ---