Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-21 Thread Ian Cowan
On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote: > On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote: > > > > For using the dev_dbg() macro, do you define this in the header file > > (i.e. for this it would be videocodec.h), or where should this be > > included from? > > dev

[Mjpeg-users] [PATCH] staging: media: zoran: modify kernel debugging function

2022-04-21 Thread Ian Cowan
This removed the dprintk() function which used the printk() function for kernel debug printing. These have all been replaced with the appropriate pr_X() functions. Where the log level is necessary, this has been replace by using CONSOLE_LOGLEVEL_DEFAULT. Signed-off-by: Ian Cowan --- drivers/stag

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-21 Thread Ian Cowan
On Thu, Apr 21, 2022 at 06:52:04PM +0300, Dan Carpenter wrote: > On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote: > > > > For using the dev_dbg() macro, do you define this in the header file > > (i.e. for this it would be videocodec.h), or where should this be > > included from? > > dev

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-21 Thread Ian Cowan
On Thu, Apr 21, 2022 at 05:21:54PM +0300, Dan Carpenter wrote: > On Wed, Apr 20, 2022 at 08:23:16PM -0400, Ian Cowan wrote: > > This is a patch to refactor the zoran debugging function. This function > > existed in all of the changed files and they also all import the > > videocodec header file. Th

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-21 Thread Dan Carpenter
On Thu, Apr 21, 2022 at 11:22:00AM -0400, Ian Cowan wrote: > > For using the dev_dbg() macro, do you define this in the header file > (i.e. for this it would be videocodec.h), or where should this be > included from? dev_dbg() is defined in include/linux/dev_printk.h. Look around at how it's use

[Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-21 Thread Ian Cowan
This is a patch to refactor the zoran debugging function. This function existed in all of the changed files and they also all import the videocodec header file. This patch moves the dprintk function into the videocodec header file and out of each of the individual files. Signed-off-by: Ian Cowan

Re: [Mjpeg-users] [PATCH] media: staging: zoran: refactor printk debugging function

2022-04-21 Thread Dan Carpenter
On Wed, Apr 20, 2022 at 08:23:16PM -0400, Ian Cowan wrote: > This is a patch to refactor the zoran debugging function. This function > existed in all of the changed files and they also all import the > videocodec header file. This patch moves the dprintk function into the > videocodec header file a