Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Bernhard Praschinger
Hallo Christian Ebert wrote: > * Trent Piepho on Friday, October 15, 2010 at 11:33:01 -0700 >> On Fri, Oct 15, 2010 at 10:58 AM, Christian Ebertwrote: >>> Index: yuvdenoise/main.c >>> === >>> RCS file: /cvsroot/mjpeg/mjpeg_play/yuvden

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Trent Piepho on Friday, October 15, 2010 at 11:33:01 -0700 > On Fri, Oct 15, 2010 at 10:58 AM, Christian Ebert wrote: >> Index: yuvdenoise/main.c >> === >> RCS file: /cvsroot/mjpeg/mjpeg_play/yuvdenoise/main.c,v >> retrieving revisio

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Trent Piepho
On Fri, Oct 15, 2010 at 10:58 AM, Christian Ebert wrote: > No! Trent nudged me in the right direction I believe. By applying > the same fix to the other asm volatile line I was able to build > it here as well. This change makes it build, but of course I've > no idea what I was doing: > > Index: yu

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Christian Ebert on Friday, October 15, 2010 at 19:49:02 +0200 > With this change, yuvdenoise builds again, but someone in the > know should check whether I've broken other stuff: And I did break it, but this seems to work: Index: yuvdenoise/main.c ===

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Christian Ebert on Friday, October 15, 2010 at 19:58:28 +0200 > * Bernhard Praschinger on Friday, October 15, 2010 at 19:17:13 +0200 >> I have at home a OSX 10.4.11 (PowerPC) and 10.6.4 (Intel) with gcc 4.2.1 >> and it compiles without problems on both computers. >> >> I did a "make clean" in t

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Bernhard Praschinger on Friday, October 15, 2010 at 19:17:13 +0200 >>> I tested your better version. And it compiles here on my linux and Intel >>> osx box. I did also a quick test with the new version on the linux box. >>> And it works well. >>> >>> So I would appreciate a feedback if it works

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Trent Piepho on Friday, October 15, 2010 at 10:19:20 -0700 > On Fri, Oct 15, 2010 at 12:40 AM, Christian Ebert wrote: > >> * Trent Piepho on Thursday, October 14, 2010 at 17:38:39 -0700 >>> Looks like you didn't actually change the needed lines. >> >> No, I didn't but Bernhard did: >> + >> #if

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Trent Piepho
On Fri, Oct 15, 2010 at 12:40 AM, Christian Ebert wrote: > * Trent Piepho on Thursday, October 14, 2010 at 17:38:39 -0700 > > On Thu, Oct 14, 2010 at 2:43 PM, Christian Ebert > wrote: > > Easy fix would just be the change the sse detection asm to save and > restore ebx. > > >>

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Bernhard Praschinger
Hallo >> I tested your better version. And it compiles here on my linux and Intel >> osx box. I did also a quick test with the new version on the linux box. >> And it works well. >> >> So I would appreciate a feedback if it works on a mac. > > Thanks for looking into this, but I get: > > gcc -DHA

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Trent Piepho on Thursday, October 14, 2010 at 17:38:39 -0700 > On Thu, Oct 14, 2010 at 2:43 PM, Christian Ebert wrote: > >> * Bernhard Praschinger on Thursday, October 14, 2010 at 19:06:33 +0200 Oh yeah, this isn't on Linux. OSX probably has some kind of API for checking if sse2 is a