Re: What we do and don't expose to window management

2016-09-02 Thread Brandon Schaefer
Alan is right with the modify surface *could* possibly confine a surface thats unfocused though this would quickly resolve it self if someone where to switch windows. The issue is we dont check if the surface we are modifying in AbstractShell:modify_surface() is focused. Ill get a fix up for that.

Re: What we do and don't expose to window management

2016-09-02 Thread Andreas Pokorny
Hi, On Thu, Sep 1, 2016 at 1:02 PM, Alan Griffiths wrote: > Inspired by a discussion with Chris I've been reading our code and spotted > some inconsistencies: > > 1. In AbstractShell::modify_surface() we carefully consume the streams > settings *and apply* them before giving window management a

What we do and don't expose to window management

2016-09-01 Thread Alan Griffiths
Inspired by a discussion with Chris I've been reading our code and spotted some inconsistencies: 1. In AbstractShell::modify_surface() we carefully consume the streams settings /and apply/ them before giving window management a chance to consider the modification request. Contrast this