Re: More quality quality

2014-05-12 Thread Daniel van Vugt
I trust helgrind after using it for years... it always won the argument despite not being able to easily answer "what's wrong with my code?". The eraser algorithm is extremely reliable and provably correct. Although we don't always understand the errors it reports, that's a human problem :) I

Re: More quality quality

2014-05-12 Thread Christopher James Halse Rogers
On Tue, May 13, 2014 at 4:21 PM, Daniel van Vugt wrote: The std::atomic issue is minor and well understood (helgrind only understands critical sections implemented using pthread primitives). We can either suppress std::atomic using valgrind rules or replace it (less efficiently). That said, pl

Re: More quality quality

2014-05-12 Thread Daniel van Vugt
The std::atomic issue is minor and well understood (helgrind only understands critical sections implemented using pthread primitives). We can either suppress std::atomic using valgrind rules or replace it (less efficiently). That said, plenty of people using std::atomic are actually writing rac

Re: More quality quality

2014-05-12 Thread Christopher James Halse Rogers
On Tue, May 13, 2014 at 1:52 PM, Daniel van Vugt wrote: All, I'd like (in the somewhat distant future) for us to be able to run Mir's tests under helgrind [1] so that we can automatically detect races in continuous integration. It's not going to be a short journey, as there's a fair amount

More quality quality

2014-05-12 Thread Daniel van Vugt
All, I'd like (in the somewhat distant future) for us to be able to run Mir's tests under helgrind [1] so that we can automatically detect races in continuous integration. It's not going to be a short journey, as there's a fair amount of errors to fix yet. They're mostly benign but the noise