Re: [Mingw-w64-public] dirent changes (was: getmainargs changes)

2025-01-26 Thread Pali Rohár
On Sunday 26 January 2025 19:06:59 Lasse Collin wrote: > On 2025-01-25 Pali Rohár wrote: > > On Saturday 25 January 2025 18:52:26 Lasse Collin wrote: > > > Even if wide char functions were always used to read filenames, > > > perhaps AreFileApisANSI() needs to be taken into account in > > > readdir

Re: [Mingw-w64-public] dirent changes (was: getmainargs changes)

2025-01-26 Thread Lasse Collin
On 2025-01-25 Pali Rohár wrote: > On Saturday 25 January 2025 18:52:26 Lasse Collin wrote: > > Even if wide char functions were always used to read filenames, > > perhaps AreFileApisANSI() needs to be taken into account in > > readdir() to determine if the wide char names should be converted > > to

Re: [Mingw-w64-public] dirent changes (was: getmainargs changes)

2025-01-25 Thread Pali Rohár
On Saturday 25 January 2025 18:52:26 Lasse Collin wrote: > On 2025-01-25 Lasse Collin wrote: > > On 2025-01-25 Pali Rohár wrote: > > > Also what could be different is that _findfirst may be affected by > > > setlocale function as IIRC UCRT supports changing process locale but > > > only for UCRT fu

Re: [Mingw-w64-public] dirent changes (was: getmainargs changes)

2025-01-25 Thread Lasse Collin
On 2025-01-25 Lasse Collin wrote: > On 2025-01-25 Pali Rohár wrote: > > Also what could be different is that _findfirst may be affected by > > setlocale function as IIRC UCRT supports changing process locale but > > only for UCRT functions. > > > > Another important thing is that FindFirstFile is

Re: [Mingw-w64-public] dirent changes (was: getmainargs changes)

2025-01-25 Thread Lasse Collin
On 2025-01-25 Pali Rohár wrote: > On Saturday 25 January 2025 12:39:19 Lasse Collin wrote: > > The CRT functions prodide timestamps in time_t while Win32 API > > provides FILETIME. Perhaps the conversion wastes time. The dirent > > functions don't need file timestamps. > > Maybe that time conver

Re: [Mingw-w64-public] dirent changes (was: getmainargs changes)

2025-01-25 Thread Pali Rohár
On Saturday 25 January 2025 12:39:19 Lasse Collin wrote: > On 2025-01-17 Pali Rohár wrote: > > On Friday 17 January 2025 15:22:30 Lasse Collin wrote: > > > Another possible change could be to call FindFirstFileW directly > > > instead of going via _wfindfirst. > > > > Personally I would prefer t

Re: [Mingw-w64-public] dirent changes (was: getmainargs changes)

2025-01-25 Thread Lasse Collin
On 2025-01-17 Pali Rohár wrote: > On Friday 17 January 2025 15:22:30 Lasse Collin wrote: > > Another possible change could be to call FindFirstFileW directly > > instead of going via _wfindfirst. > > Personally I would prefer to stay with _wfindfirst as it is from > MS C runtime library. Callin