Re: [Mingw-w64-public] [PATCH] headers: undef register in case projects define it.

2024-12-30 Thread Christoph Reiter
On Mon, Dec 30, 2024 at 9:47 PM Jacek Caban wrote: > As I mentioned in the other thread, doxygen appears to tamper with the > register definition only for outdated flex versions. If that’s the case, > this might be an MSYS2 packaging issue. Are there other instances of > similar problems? Good ca

Re: [Mingw-w64-public] [PATCH] headers: undef register in case projects define it.

2024-12-30 Thread LIU Hao
在 2024-12-31 04:46, Jacek Caban 写道: Assuming this is indeed a concern for mingw-w64, the patch seems fine to me. However, I’m not fully convinced it’s necessary, -Dregister= is a rather awful hack in general. As I mentioned in the other thread, doxygen appears to tamper with the register defini

Re: [Mingw-w64-public] [PATCH 1/3] headers: Treat __MSVCRT_VERSION__=0x600 as compiling for msvcrt.dll ABI

2024-12-30 Thread Pali Rohár
On Monday 30 December 2024 18:50:57 Pali Rohár wrote: > On Monday 30 December 2024 15:32:16 Martin Storsjö wrote: > > On Thu, 12 Dec 2024, Martin Storsjö wrote: > > > > > On Thu, 12 Dec 2024, LIU Hao wrote: > > > > > > > 在 2024-12-12 21:17, Martin Storsjö 写道: > > > > > On Thu, 28 Nov 2024, Pali R

Re: [Mingw-w64-public] [RFC PATCH 2/2] crt: Merge lib32/ws2_32.def into lib-common/ws2_32.def.in

2024-12-30 Thread Pali Rohár
On Sunday 29 December 2024 17:46:22 Martin Storsjö wrote: > On Sat, 14 Dec 2024, Pali Rohár wrote: > > > Now all I386 symbols in lib-common/ws2_32.def.in file are defined with > > stdcall @ suffixes. These suffixes are automatically removed for > > non-I386 builds by Makefile.am rule during proces

Re: [Mingw-w64-public] [PATCH] headers: undef register in case projects define it.

2024-12-30 Thread Jacek Caban
On 30.12.2024 20:09, Jeremy Drake via Mingw-w64-public wrote: For example, doxygen defines `register` to shut up an error due to it being deprecated/removed in ISO C++ 17, but that causes issues with this construct, which is an extension and still supported. Fixes: f0044963d7ba ("headers: Use re

[Mingw-w64-public] [PATCH] headers: undef register in case projects define it.

2024-12-30 Thread Jeremy Drake via Mingw-w64-public
For example, doxygen defines `register` to shut up an error due to it being deprecated/removed in ISO C++ 17, but that causes issues with this construct, which is an extension and still supported. Fixes: f0044963d7ba ("headers: Use register variable for NtCurrentTeb implementation on aarch64.") -

Re: [Mingw-w64-public] [PATCH 1/3] headers: Treat __MSVCRT_VERSION__=0x600 as compiling for msvcrt.dll ABI

2024-12-30 Thread Pali Rohár
On Monday 30 December 2024 15:32:16 Martin Storsjö wrote: > On Thu, 12 Dec 2024, Martin Storsjö wrote: > > > On Thu, 12 Dec 2024, LIU Hao wrote: > > > > > 在 2024-12-12 21:17, Martin Storsjö 写道: > > > > On Thu, 28 Nov 2024, Pali Rohár wrote: > > > > > msvcrt.dll preinstalled as part of the Windows

Re: [Mingw-w64-public] [PATCH 1/3] headers: Treat __MSVCRT_VERSION__=0x600 as compiling for msvcrt.dll ABI

2024-12-30 Thread Martin Storsjö
On Thu, 12 Dec 2024, Martin Storsjö wrote: On Thu, 12 Dec 2024, LIU Hao wrote: 在 2024-12-12 21:17, Martin Storsjö 写道: On Thu, 28 Nov 2024, Pali Rohár wrote: msvcrt.dll preinstalled as part of the Windows system provides more functions than the original Visual C++ 6.0, but still it is compati

Re: [Mingw-w64-public] [PATCH 3/3] headers: Use register variable for NtCurrentTeb implementation on aarch64.

2024-12-30 Thread Jacek Caban
On 29.12.2024 18:57, Jeremy Drake wrote: On Sun, 29 Dec 2024, Jacek Caban wrote: We may need to revert use of register keyword for TEB access or make it conditional if that's indeed problematic for C++. I couldn't reproduce the warning with Clang. I did some playing with godbolt.org. It seems