Re: [Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

2017-07-03 Thread funfunctor
On 2017-07-03 08:47, Timothy Arceri wrote: While it produces functioning code the pass creates worse code for arrays of arrays. See the comment added in this patch for more detail. V2: skip splitting of AoA of matrices too. Reviewed-by: Edward O'Callaghan --- src/compiler/glsl/opt_array_sp

Re: [Mesa-dev] [PATCH v2 1/3] nir: NULL check lower_copies_to_load_store()

2017-07-03 Thread funfunctor
On 2017-07-03 08:47, Timothy Arceri wrote: Allows us to disable array spliting for arrays of arrays without regressing tests such as: ES31-CTS.functional.shaders.arrays_of_arrays.return.explicit.struct_3x1x3_fragment Reviewed-by: Edward O'Callaghan --- src/compiler/nir/nir_lower_vars_to_ss

Re: [Mesa-dev] [PATCH v2 2/3] nir: fix nir_opt_copy_prop_vars() for arrays of arrays

2017-07-03 Thread funfunctor
On 2017-07-03 08:47, Timothy Arceri wrote: Previous we only incremented the guide for a single dimension/wildcard. V2: rework logic to avoid code duplication Reviewed-by: Edward O'Callaghan --- src/compiler/nir/nir_opt_copy_prop_vars.c | 12 ++-- 1 file changed, 6 insertions(+), 6