Re: [Mesa-dev] [PATCH] panfrost: Skip shading unaffected tiles

2019-06-20 Thread Tomeu Vizoso
On Thu, 20 Jun 2019 at 16:56, Alyssa Rosenzweig wrote: > > > Isn't enough with ctx->blitter->running ? > > What if we're legitimately blitting something? Forgot about that. Reviewed-by: Tomeu Vizoso Thanks! Tomeu ___

[Mesa-dev] [PATCH] panfrost: ci: Update expectations

2019-06-20 Thread Tomeu Vizoso
These tests have been fixed recently. Signed-off-by: Tomeu Vizoso --- .../drivers/panfrost/ci/expected-failures.txt | 54 --- 1 file changed, 54 deletions(-) diff --git a/src/gallium/drivers/panfrost/ci/expected-failures.txt b/src/gallium/drivers/panfrost/ci/expected

Re: [Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

2019-06-20 Thread Tomeu Vizoso
On 6/20/19 6:33 PM, Rohan Garg wrote: Not sure I understand how this works. Isn't this going to cause unnecessary container builds? And, why cannot developers just add whatever they want to DEBIAN_TAG to that end? This will spin a container for each branch, yes, though I think that is how it

Re: [Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

2019-06-21 Thread Tomeu Vizoso
On 6/21/19 12:23 PM, Rohan Garg wrote: Hey Good stuff, but isn't this change making us hit assertions? Hm, I thought it only enabled debugging symbols. Do you have a recommendation on how to enable debug symbols but not enabling assertions? I think assertions should be limited to the most ba

[Mesa-dev] [PATCH] panfrost: ci: Fix parsing of crashed tests

2019-06-21 Thread Tomeu Vizoso
Without this fix, LAVA isn't parsing crashes as failed tests, because the shell logging is interspersed within the fake deqp output. Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/ci/deqp-runner.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ga

Re: [Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

2019-06-21 Thread Tomeu Vizoso
unsigned dep_2 = m->job_dependency_index_2; + +if (BITSET_TEST(edge_removal_1, node_m)) +dep_1 = 0; + + if (BITSET_TEST(edge_removal_2, node_m)) +dep_2 = 0; + +

Re: [Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

2019-06-21 Thread Tomeu Vizoso
On 6/21/19 3:05 PM, Alyssa Rosenzweig wrote: Very nice, this will fix a few tests. Ah, of course :) Good riddance! To be fair, a lot of that just got moved in with panfrost_job.. :) Can we remove now the has_draws arg? Maybe? The has_draws arg controls a lot of things beyond just, y

[Mesa-dev] [PATCH] Add support for OES_standard_derivatives in GLSL ES

2012-07-16 Thread Tomeu Vizoso
Previously, we advertised the extension but the builtin functions were enabled only for GLSL and not for ES. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52003 Signed-off-by: Tomeu Vizoso Reviewed-by: Ian Romanick --- .../profiles/OES_standard_derivatives.frag | 20

Re: [Mesa-dev] [PATCH] Add support for OES_standard_derivatives in GLSL ES

2012-07-23 Thread Tomeu Vizoso
On Mon, Jul 16, 2012 at 8:45 PM, Tomeu Vizoso wrote: > Previously, we advertised the extension but the builtin functions > were enabled only for GLSL and not for ES. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52003 > > Signed-off-by: Tomeu Vizoso > Revi

Re: [Mesa-dev] [PATCH] Add support for OES_standard_derivatives in GLSL ES

2012-08-01 Thread Tomeu Vizoso
On Mon, Jul 23, 2012 at 4:30 PM, Tomeu Vizoso wrote: > On Mon, Jul 16, 2012 at 8:45 PM, Tomeu Vizoso wrote: >> Previously, we advertised the extension but the builtin functions >> were enabled only for GLSL and not for ES. >> >> Bugzilla: https://bugs.freedeskto

[Mesa-dev] [PATCH] egl_dri2: Fix checking DRI version in the swrast driver

2012-08-17 Thread Tomeu Vizoso
--- src/egl/drivers/dri2/egl_dri2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 423d18d..a6ee9e1 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++ b/src/egl/drivers/dri2/egl_dri2.c @@ -481,7 +481,8 @@

Re: [Mesa-dev] [PATCH] egl_dri2: Fix segmentation fault

2012-08-18 Thread Tomeu Vizoso
On Sat, Aug 18, 2012 at 5:20 AM, Ian Romanick wrote: > On 08/17/2012 10:08 AM, Paulo Alcantara wrote: >> >> The segmentation fault occurs when DRI2 is not loaded up and >> dri2_setup_screen() function deferences dri2_dpy->dri2 (since it's NULL >> at this point). >> >> This patch fixes the segmenta

[Mesa-dev] [PATCH] mesa/es: Define GL_MAX_TEXTURE_MAX_ANISOTROPY_EXT enum for all GLs

2012-09-11 Thread Tomeu Vizoso
instead of just for GL and ES1. --- src/mesa/main/get.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 24d2a18..e40569d 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -536,6 +536,11 @@ static const struc

Re: [Mesa-dev] [PATCH] mesa/es: Define GL_MAX_TEXTURE_MAX_ANISOTROPY_EXT enum for all GLs

2012-09-11 Thread Tomeu Vizoso
On Tue, Sep 11, 2012 at 5:00 PM, Kenneth Graunke > > > Reviewed-by: Kenneth Graunke Could you please push it for me? I'm not a committer yet. Forgot to add my s-o-b to the commit: Signed-off-by: Tomeu Vizoso Thanks, Tomeu ___ mesa-de

Re: [Mesa-dev] [PATCH] mesa/es: Define GL_MAX_TEXTURE_MAX_ANISOTROPY_EXT enum for all GLs

2012-09-16 Thread Tomeu Vizoso
On Tue, Sep 11, 2012 at 5:34 PM, Tomeu Vizoso wrote: > On Tue, Sep 11, 2012 at 5:00 PM, Kenneth Graunke > >> >> Reviewed-by: Kenneth Graunke > > Could you please push it for me? I'm not a committer yet. > > Forgot to add my s-o-b to the commit: > > Si

<    1   2   3