nds on patch 5, otherwise the
GPU would try to execute a shader in a memory region marked as not
executable.
Will be sending a v2 with Caio's suggestion.
Cheers,
Tomeu
> On Mon, Aug 05, 2019 at 05:18:32PM +0200, Tomeu Vizoso wrote:
> > Some hash functions (eg. key_u64_hash) will attemp
On Mon, 5 Aug 2019 at 19:01, Alyssa Rosenzweig wrote:
>
> > +for (unsigned c = 0; c < 4; ++c) {
> > +struct panfrost_blend_rt *rt = &blend->rt[c];
> > +_mesa_hash_table_u64_clear(rt->shaders,
> > panfrost_delete_blend_shader);
> > +}
>
> What's the
On Mon, 5 Aug 2019 at 19:06, Alyssa Rosenzweig wrote:
>
> > +if (screen->kernel_version >= 1) {
>
> Maybe have some #defines for kernel versions instead of magic numbers?
> Also, maybe make it clear that this is a minor version -- what does
> happen if we bump the major version at some poi
,
Tomeu
>
> On Mon, Aug 05, 2019 at 05:18:36PM +0200, Tomeu Vizoso wrote:
> > Signed-off-by: Tomeu Vizoso
> > ---
> > src/gallium/drivers/panfrost/pan_drm.c | 10 +-
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/gal
These tests have been fixed by:
b514f411837b ("glcpp: use pre-expansion line number for __LINE__")
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/expected-failures.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/expected-failu
On Tue, 6 Aug 2019 at 16:58, Alyssa Rosenzweig wrote:
>
> > Android should be fine, as they use it in their own code.
>
> Hmm, still uncomfortable, but tentative R-b I guess :/
>
> I just.. don't like relying on glibc specific behaviour. Even if bionic
> implements it too, I mean... what happe
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_drm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index 71eda2d1e328..36a6b975680a
table).
v2: - Store compiled blend shaders in a malloc'ed buffer, to avoid
reading from GPU-accessible memory when patching (Alyssa).
- Free struct panfrost_blend_shader (Alyssa).
- Give the job a reference to regular shaders when emitting
(Alyssa).
Signed-off-by: Tomeu Vizoso
eeded.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_drm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index 6d1e0c08d33d..71eda2d1e328 100644
---
Some hash functions (eg. key_u64_hash) will attempt to dereference the
key, causing an invalid access when passed DELETED_KEY_VALUE (0x1) or
FREED_KEY_VALUE (0x0).
To avoid this problem, stuff the fake keys into a hash_key_u64 struct
and pass the pointer to it instead.
Signed-off-by: Tomeu
Unless a BO has the EXECUTABLE flag, mark it as NOEXEC.
v2: - Rework version detection (Alyssa).
Signed-off-by: Tomeu Vizoso
---
include/drm-uapi/panfrost_drm.h | 27 +++
src/gallium/drivers/panfrost/pan_drm.c| 6 -
src/gallium/drivers/panfrost
On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote:
>
> On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso
> wrote:
> >
> > Instead of all shaders being stored in a single BO, have each shader in
> > its own.
> >
> > This removes the need for a 16MB allocation
On Thu, 8 Aug 2019 at 00:52, Rob Herring wrote:
>
> On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso
> wrote:
> >
> > Signed-off-by: Tomeu Vizoso
> > Reviewed-by: Alyssa Rosenzweig
> > ---
> > src/gallium/drivers/panfrost/pan_drm.c | 10 +-
> >
On Thu, 8 Aug 2019 at 16:19, Rob Herring wrote:
>
> On Wed, Aug 7, 2019 at 11:23 PM Tomeu Vizoso
> wrote:
> >
> > On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote:
> > >
> > > On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso
> > > wrote:
> >
On Thu, 8 Aug 2019 at 16:50, Rob Herring wrote:
>
> On Wed, Aug 7, 2019 at 5:47 PM Alyssa Rosenzweig
> wrote:
> >
> > > This is using the
> > > untranslated flags, but I think it should be the 'translated_flags' as
> > > those are the ones changing the allocation.
> >
> > It's a little more compl
Both patches look good to me.
Reviewed-by: Tomeu Vizoso
Thanks!
Tomeu
On Fri, 9 Aug 2019 at 21:53, Rob Herring wrote:
>
> The kernel now supports madvise ioctl to indicate which BOs can be freed
> when there is memory pressure. Mark BOs purgeable when they are in the
> BO cache.
Some runners may be configured such that the qemu binary might not be
available by the time we need to start running commands within the
chroot.
So make sure that it's there to avoid suprising problems in that case.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/d
A number of things can go wrong when building the rootfs from within a
non-native chroot, so make sure to print the bootstrap.log so we can
tell what's going on.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian-install.sh | 3 +++
1 file changed, 3 insertions(+)
To help make sure we are running tests in the ideal number of threads,
print load stats to make obvious when there's a problem with
utilization.
This will be specially useful when we run tests on a wider variety of
devices.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci
There's lots of locking changes going into the Panfrost kernel driver,
so better be prepared.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/arm64.config | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/arm64.conf
so we are
hitting a few more failures in tests that previously were being skipped.
The time to run the tests decreases from around 8 minutes to 1:45
minutes, allowing for extending coverage without increasing CI times too
much.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/create
On 8/21/19 7:48 PM, Alyssa Rosenzweig wrote:
Otherwise, there is too much noise to see what's going on.
I'm afraid this doesn't improve things much, as you can see below:
https://gitlab.freedesktop.org/tomeu/mesa/-/jobs/524402
Jakob has kindly offered to add this weekend a mode that prints on
Some functionality has been added to deqp-volt to only print
regressions, so update our version of it and use the new options.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 9 ++---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +-
2 files changed, 7
Now that Volt supports armhf, build again images and submit to LAVA for
RK3288.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/debian-install.sh | 10 ++--
.../drivers/panfrost/ci/deqp-runner.sh| 3 ++
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 53
On Fri, 6 Sep 2019 at 03:23, Rob Clark wrote:
>
> On Wed, Sep 4, 2019 at 1:42 PM Eric Anholt wrote:
> >
> > If you haven't seen this MR:
> >
> > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1632
> >
> > I feel ready to enable CI of freedreno on Mesa MRs. There are some docs
> > here:
So repositories don't need to be specially configured with a token to
access LAVA, store this token in a bind volume for a special runner.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --
Now that Volt supports armhf, build again images and submit to LAVA for
RK3288.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/debian-install.sh | 10 ++--
.../drivers/panfrost/ci/deqp-runner.sh| 3 ++
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 53
Sometimes LAVA jobs will timeout due to transient issues, and the Gitlab
job will fail in that case. Increase the timeouts to reduce the
likeliness of that happening and reduce false positives.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/lava-deqp.yml.jinja2 | 4 ++--
1 file
Instead of running it with the Wayland platform, which introduces
unwanted dependencies and complexity.
Makes tests run 30% faster, as well.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/create-rootfs.sh | 2 +-
.../drivers/panfrost/ci/debian-install.sh | 35
So we can better correlate different results to versions of the runner.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian-install.sh | 8 +---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src
We haven't updated in a long time, so better do it now and again when
5.3 is released.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/debian-install.sh | 2 +-
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_drm.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index f4580da9f509..0a7cf47c6a36 100644
--- a/src/gallium
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost/pan_context.c
index d242c3f90cea..c513791615ea 100644
--- a/src/gallium/drivers/panfrost
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_drm.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index 887bf19148e7..c30beaf2b500 100644
--- a/src/gallium/drivers/panfrost/pan_drm.c
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_drm.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_drm.c
b/src/gallium/drivers/panfrost/pan_drm.c
index 0a7cf47c6a36..887bf19148e7 100644
--- a/src/gallium
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pandecode/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pandecode/cmdline.c
b/src/gallium/drivers/panfrost/pandecode/cmdline.c
index b2ba21cfe414..07bffdb5c493 100644
On Fri, 29 Mar 2019 at 02:48, Alyssa Rosenzweig wrote:
>
> Fixes crash in dEQP-GLES2.functional.buffer.*
>
> Signed-off-by: Alyssa Rosenzweig
> ---
> src/gallium/drivers/panfrost/pan_context.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/gallium/drivers
kbase any more (and
if so, I can always go back in time).
Reviewed-by: Tomeu Vizoso
Thanks!
Tomeu
Signed-off-by: Alyssa Rosenzweig
Cc: Tomeu Vizoso
Cc: Rob Herring
---
src/gallium/drivers/panfrost/.gitignore| 1 -
src/gallium/drivers/panfrost/meson.build
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_swizzle.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/panfrost/pan_swizzle.c
b/src/gallium/drivers/panfrost/pan_swizzle.c
index 291bd1f88aea..52a907ddd55d 100644
--- a/src/gallium/drivers/panfrost
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pandecode/mmap.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pandecode/mmap.h
b/src/gallium/drivers/panfrost/pandecode/mmap.h
index 1a208336e814..e9acae877f7f 100644
--- a/src
On 4/26/19 6:24 PM, Alyssa Rosenzweig wrote:
We start by building a container in Docker that contains a suitable
rootfs and kernel for the DUT, deqp and all dependencies for building
Mesa itself.
Out of curiosity, what's the performance impact of this? If there are no
changes to the kernel or t
On 4/26/19 9:14 PM, Eric Anholt wrote:
Alyssa Rosenzweig writes:
We start by building a container in Docker that contains a suitable
rootfs and kernel for the DUT, deqp and all dependencies for building
Mesa itself.
Out of curiosity, what's the performance impact of this? If there are no
cha
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index d4d26b9a25e9..f5d8c3e0f2c1 100644
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index 348ec861404a..d4d26b9a25e9 100644
Valgrind was complaining of those.
NIR_PASS only sets progress to TRUE if there was progress.
nir_const_load_to_arr() only sets as many constants as components has
the instruction.
This was causing some dEQP tests to flip-flop.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost
On Tue, 7 May 2019 at 23:47, Alyssa Rosenzweig wrote:
>
> Tentative R-b, but I'm baffled what the flip-flops would be about. Could
> you link the list of failures introduced (we're maybe relying on buggy
> behaviour anyway)?
I was testing with
dEQP-GLES2.functional.fragment_ops.blend.equation_src
These tests add too much time to the total run time, and some of them
even hang the DUTs, even if I haven't been able to reproduce it locally.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/dr
Make sure we have only test case names in the list, excluding names of
test groups.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
b/src
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
index a2133b489d6a..992560f8cd40 100644
To improve robustness, check that we got the expected number of results.
Right now we hard-code the expected number of tests run, but with some
effort we may be able to infer it.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 1 +
1 file changed, 1 insertion
Hi,
these patches take the current CI for Panfrost to a more useful
stage.
Results should be much more stable now and we also run the tests on a
machine with a different SoC and a different Midgard IP (RK3288 with
T760).
Some tests that are unstable have been added to a list of flip-flops to
be
(in
/home/tomeu/deqp-build/modules/gles2/deqp-gles2)
==6589==by 0x47A253: glu::ShaderProgram::init(glw::Functions const&,
glu::ProgramSources const&) (in /home/tomeu/deqp-build/modules/gles2/deqp-gles2)
Signed-off-by: Tomeu Vizoso
Fixes: d41cdef2a591 ("nir: Use the flrp l
Build artifacts for armhf and schedule them on a Veyron Chromebook with
RK3288.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/Dockerfile| 97 +---
src/gallium/drivers/panfrost/ci/arm.config| 45
.../drivers/panfrost/ci/deqp-runner.sh| 4
.functional.fragment_ops.blend.equation_src_func_dst_func.add_src_color_constant_color
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
b/src/gallium/drivers/panfrost/midgard
These tests aren't giving reliable results. Mask them for now.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 53 +--
1 file changed, 48 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/gitlab-ci.yml
b/src/ga
ff-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
index 992560f8cd40..68d9bc1fc878 100644
--- a/src/ga
This matches the current state of things on both RK3288 and RK3399.
Hopefully, from now on we'll only remove stuff from this list.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/expected-failures.txt | 86 ++-
1 file changed, 7 insertions(+), 79 deletions(-)
diff
: glu::CallLogWrapper::glTexImage2D(unsigned int, int, int, int,
int, int, unsigned int, unsigned int, void const*) (in
/home/tomeu/deqp-build/modules/gles2/deqp-gles2)
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_swizzle.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
Just do what everybody else but Nouveau does and return 0.0f.
This prevents the repeated logging of these messages on startup:
Unexpected PIPE_CAPF 6 query
Unexpected PIPE_CAPF 7 query
Unexpected PIPE_CAPF 8 query
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_screen.c | 5
On Thu, 9 May 2019 at 17:16, Emil Velikov wrote:
>
> On Thu, 9 May 2019 at 07:35, Tomeu Vizoso wrote:
> >
> > These tests add too much time to the total run time, and some of them
> > even hang the DUTs, even if I haven't been able to reproduce it locally.
> &
As with the previous value of 5000 we seemed to be reaching OOM in some
circumstances.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/deqp-runner.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
b/src/gallium
Since last Friday, these two tests have been fixed:
dEQP-GLES2.functional.shaders.functions.control_flow.return_in_nested_loop_fragment
dEQP-GLES2.functional.shaders.linkage.varying_7
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/expected-failures.txt | 2 --
1 file changed
Jump over the container stage if we haven't changed any of the files
that involved in building the container images.
This saves 1-2 minutes in each run and helps conserve resources.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 52 +++
1
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/Dockerfile | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/Dockerfile
b/src/gallium/drivers/panfrost/ci/Dockerfile
index 268edf224a20..8c4a4e0444ec 100644
--- a/src/gallium
We are currently leaking resources if they were sampled from. Once we
are done with a sampler, we should dereference that resource.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/gallium
.
Suggested-by: Rob Clark
Signed-off-by: Alyssa Rosenzweig
Cc: Tomeu Vizoso
This is a great cleanup, thanks!
Reviewed-by: Tomeu Vizoso
Cheers,
Tomeu
---
.../drivers/panfrost/include/panfrost-job.h | 8 +--
src/gallium/drivers/panfrost/pan_context.c| 54 +++
src
And instead, link them as they are added.
Makes things a bit clearer and prepares future work such as FB reload
jobs.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 120 +
src/gallium/drivers/panfrost/pan_context.h | 2 +-
2 files changed, 54
*.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/meson.build | 1 -
src/gallium/drivers/panfrost/pan_context.c | 91 +-
src/gallium/drivers/panfrost/pan_wallpaper.c | 274 ---
src/gallium/drivers/panfrost/pan_wallpaper.h | 33 ---
4 files changed, 88
On Wed, 29 May 2019 at 17:10, Alyssa Rosenzweig wrote:
>
> Does this address the issues with the previous version raised on IRC? In
> particular:
>
> Does mpv work? (Including the on-screen display)
> Does sway work?
Have never tested those, tbh. Do you know if I should be able to
On Wed, 29 May 2019 at 17:37, Alyssa Rosenzweig wrote:
>
> > Have never tested those, tbh. Do you know if I should be able to test
> > those with whatever is packaged for Debian?
>
> I don't think sway isn't packaged in testing yet (I think it's in
> experimental)? mpv is definitely packaged; you
On Tue, 28 May 2019 at 08:17, Tomeu Vizoso wrote:
>
> On 5/26/19 1:51 AM, Alyssa Rosenzweig wrote:
> > The mesa/st flips the viewport, so we respect that rather than
> > trying to flip the framebuffer itself and ignoring the viewport and
> > using a messy heuristic.
>
The compiler configuration was hardened to fail on format warnings and
things stopped building.
Fixes: c9c1e2610647 ("mesa: prevent common string formatting security issues")
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/bifrost/disassemble.c | 2 +-
1 file changed, 1
On 6/6/19 6:10 PM, Michel Dänzer wrote:
On 2019-05-20 11:33 a.m., Tomeu Vizoso wrote:
Jump over the container stage if we haven't changed any of the files
that involved in building the container images.
This saves 1-2 minutes in each run and helps conserve resources.
Signed-off-by:
Use the infrastructure in wayland/ci-templates to build the container
images.
This prevents from getting into some situations in which the images
wouldn't be rebuilt, and allows us to share some infrastructure with
other projects in freedesktop.org.
Signed-off-by: Tomeu Vizoso
Suggest
On Fri, 7 Jun 2019 at 09:51, Eduardo Lima Mitev wrote:
>
> On 5/20/19 11:33 AM, Tomeu Vizoso wrote:
> > Signed-off-by: Tomeu Vizoso
> > ---
> > src/gallium/drivers/panfrost/ci/Dockerfile | 7 +++
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
Rosenzweig
Looks good too me!
Reviewed-by: Tomeu Vizoso
Thanks,
Tomeu
> ---
> src/gallium/drivers/panfrost/pan_context.c | 22 +++---
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/src/gallium/drivers/panfrost/pan_context.c
> b/src/ga
Any ideas on why these two changes get kmscube working on T720?
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost
Some tests got fixed since the last update, but also some regressions
crept in.
To keep the CI green, add the regressions to the expected failures.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/expected-failures.txt | 98 +--
1 file changed, 5 insertions(+), 93
These are tests that regressed in RK3288 but still pass on RK3399.
So we still have a CI we can rely on, add them to the flip-flop list for
now.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 51 ++-
1 file changed, 50 insertions(+), 1 deletion
We hadn't updated the kernel header after the driver got into mainline.
Signed-off-by: Tomeu Vizoso
---
include/drm-uapi/panfrost_drm.h| 6 --
src/gallium/drivers/panfrost/pan_drm.c | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/drm
Alyssa fixed some failing tests last night.
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/ci/expected-failures.txt | 15 ---
1 file changed, 15 deletions(-)
diff --git a/src/gallium/drivers/panfrost/ci/expected-failures.txt
b/src/gallium/drivers/panfrost/ci/expected
On Tue, 18 Jun 2019 at 15:19, Alyssa Rosenzweig
wrote:
>
> Not sure what would have fixed any of these but sure, A-b, I won't say
> no to fixed tests ^_^
>
> What about the fragment_ops.scissor.* tests?
Don't know, what about them? They seem to pass.
Cheers,
Tomeu
__
We have some serious leaks, so plug some and also move to ralloc to
limit the lifetime of some objects to that of their parent.
Lots more such work to do.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 24 +++--
src/gallium/drivers/panfrost/pan_drm.c
Hi there,
this patch seems to have caused the following regressions:
+dEQP-GLES2.functional.shaders.conversions.vector_combine.bvec2_float_to_bvec3_fragment
+dEQP-GLES2.functional.shaders.conversions.vector_combine.float_bool_to_bvec2_fragment
+dEQP-GLES2.functional.shaders.conversions.vector_com
On Tue, 18 Jun 2019 at 17:00, Alyssa Rosenzweig
wrote:
>
> Now that sRGB formats are supported for both rendering and sampling,
> advertise support.
>
> Signed-off-by: Alyssa Rosenzweig
Hi there,
this patch seems to have caused the following regressions:
dEQP-GLES2.functional.fbo.render.recrea
On Wed, 19 Jun 2019 at 07:44, Tomeu Vizoso wrote:
>
> On Tue, 18 Jun 2019 at 17:00, Alyssa Rosenzweig
> wrote:
> >
> > Now that sRGB formats are supported for both rendering and sampling,
> > advertise support.
> >
> > Signed-off-by: Alyssa Rosenzweig
>
This reverts commit 9402970751ca04c4d6edb3a0441a4063a975295c.
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
b/src/gallium/drivers/panfrost/midgard/midgard_comp
Hi,
the two commits reverted introduced some regressions and don't have an
obvious fix, so I propose to revert them while we fix them properly.
I also add some tests to the ignore list because they pass and fail
randomly.
Thanks,
Tomeu
Tomeu Vizoso (3):
Revert "panfrost/midga
This reverts commit bfca21b622dfd2fcfe32494339aea9061070c7e5.
---
src/gallium/drivers/panfrost/pan_context.c | 8
src/gallium/drivers/panfrost/pan_job.c | 12
src/gallium/drivers/panfrost/pan_job.h | 4
3 files changed, 8 insertions(+), 16 deletions(-)
diff --
These tests are failing at times, blacklist for now:
dEQP-GLES2.functional.fbo.render.shared_colorbuffer_clear.tex2d_rgba
dEQP-GLES2.functional.fbo.render.shared_colorbuffer_clear.tex2d_rgb
dEQP-GLES2.functional.shaders.matrix.mul.dynamic_highp_mat4_vec4_vertex
Signed-off-by: Tomeu Vizoso
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_job.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_job.c
b/src/gallium/drivers/panfrost/pan_job.c
index 14efa71fb055..ecc0ac7be8e1 100644
--- a/src/gallium/drivers/panfrost
Signed-off-by: Tomeu Vizoso
---
.../drivers/panfrost/midgard/compiler.h | 2 +
.../panfrost/midgard/midgard_compile.c| 13 +-
.../panfrost/midgard/midgard_compile.h| 17 ++-
.../drivers/panfrost/midgard/midgard_ra.c | 116 ++
.../panfrost/midgard
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_context.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost/pan_context.c
index 7c0ba679dd91..78976facda3d 100644
--- a/src/gallium
Hi,
we often OOM when trying to run test suites as the leaks quickly
accumulate.
With these patches things get much better.
Thanks,
Tomeu
Tomeu Vizoso (3):
panfrost: Move ra_regs to the screen context
panfrost: Release transient pools
panfrost: Allocate panfrost_job in panfrost_context
On 6/20/19 3:28 PM, Alyssa Rosenzweig wrote:
NAK. There's a patch for this I pushed to your repo which should fix
these regressions (they were legitimate bugs that had nothing to do with
autovectorization and would have cropped up anyhow).
You mean this commit?
https://gitlab.freedesktop.org/t
Right now we are doing it at a moment when we don't have all the
information we need.
Signed-off-by: Tomeu Vizoso
Suggested-by: Alyssa Rosenzweig
Cc: Rohan Garg
Fixes: bfca21b622df ("panfrost: Figure out job requirements in pan_job.c")
---
src/gallium/drivers/panfrost/pa
On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote:
>
> ---
> src/gallium/drivers/panfrost/ci/create-rootfs.sh | 2 +-
> src/gallium/drivers/panfrost/ci/deqp-runner.sh | 6 ++
> src/gallium/drivers/panfrost/ci/gitlab-ci.yml| 4 ++--
> src/gallium/drivers/panfrost/ci/lava-deqp.ym
Good commit, but the "what" should be in the subject line and the
"why" in the body.
With that change:
Reviewed-by: Tomeu Vizoso
Thanks,
Tomeu
On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote:
>
> Change to /artifacts in order to potentially fix
> debootstrap fa
On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote:
>
> This enables developers to add packages to the container
> when working on their own branches by creating
> a container tag which features the branch name.
Not sure I understand how this works. Isn't this going to cause
unnecessary container bui
On 6/20/19 4:18 PM, Alyssa Rosenzweig wrote:
Looking at the scissor, we can discard some tiles. We specifially don't
care about the scissor on the wallpaper, since that's a no-op if the
entire tile is culled.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c |
101 - 200 of 215 matches
Mail list logo
