Re: [Mesa-dev] [PATCH 1/4] mesa: replace UsesClipDistance with ClipDistanceArraySize

2015-10-18 Thread Tobias Klausmann
On 18.10.2015 19:14, Marek Olšák wrote: From: Marek Olšák This is more practical and needed by gallium. --- src/glsl/linker.cpp| 33 +++-- src/glsl/nir/glsl_to_nir.cpp | 3 ++- src/mesa/drivers/dri/i965/brw_vs.c | 2 +- src/mesa/main/mt

Re: [Mesa-dev] [PATCH 3/4] st/mesa: pass the clip distance array size to drivers

2015-10-18 Thread Tobias Klausmann
On 18.10.2015 19:52, Marek Olšák wrote: On Sun, Oct 18, 2015 at 7:25 PM, Ilia Mirkin wrote: Patches 1-3 are Reviewed-by: Ilia Mirkin . Not familiar with the tgsi scan stuff. Do you have plans on finishing cull distance support btw? Dave Airlie and Tobias Klaussman have both made attempts at

[Mesa-dev] [PATCH] st/nine: Mark end of non-void function unreachable

2015-02-09 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/state_trackers/nine/nine_pipe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_pipe.h b/src/gallium/state_trackers/nine/nine_pipe.h index 17844d5..3480aad 100644 --- a/src/gallium

[Mesa-dev] Re: [PATCH] st/nine: Mark end of non-void function unreachable

2015-02-09 Thread Tobias Klausmann
Right, the function isn't even defined in that scope, tired me shouldn't even try to write code ;-) On 10.02.2015 04:48, Jan Vesely wrote: On Tue, 2015-02-10 at 04:43 +0100, Tobias Klausmann wrote: Signed-off-by: Tobias Klausmann --- src/gallium/state_trackers/nine/nine_pipe.h

[Mesa-dev] [PATCH 1/2] gallium: define unreachable macro

2015-02-11 Thread Tobias Klausmann
This is done the same way for glsl et al. already Signed-off-by: Tobias Klausmann --- src/gallium/include/pipe/p_compiler.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/gallium/include/pipe/p_compiler.h b/src/gallium/include/pipe/p_compiler.h index fb018bf

[Mesa-dev] [PATCH 2/2] st/nine: Mark end of non-void function unreachable

2015-02-11 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/state_trackers/nine/nine_pipe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_pipe.h b/src/gallium/state_trackers/nine/nine_pipe.h index 17844d5..b8e728e 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH 1/2] gallium: define unreachable macro

2015-02-11 Thread Tobias Klausmann
SERT and likely/unlikely in p_compiler.h We could clean these up there and include macros.h there... On Wed, Feb 11, 2015 at 10:47 AM, Tobias Klausmann wrote: This is done the same way for glsl et al. already Signed-off-by: Tobias Klausmann --- src/gallium/include/pipe/p_

[Mesa-dev] [PATCH 1/2] gallium: include util/macros.h

2015-02-12 Thread Tobias Klausmann
The most common macros are defined there, no use to duplicate these Clean up the already redefinded macros Signed-off-by: Tobias Klausmann --- src/gallium/include/pipe/p_compiler.h | 57 ++- 1 file changed, 2 insertions(+), 55 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 2/2] st/nine: Mark end of non-void function unreachable

2015-02-12 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/state_trackers/nine/nine_pipe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_pipe.h b/src/gallium/state_trackers/nine/nine_pipe.h index 17844d5..b8e728e 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH 1/2] gallium: include util/macros.h

2015-02-23 Thread Tobias Klausmann
Can somebody push this please?! Thanks, Tobias On 12.02.2015 23:04, Jose Fonseca wrote: LGTM. On 12/02/15 17:31, Tobias Klausmann wrote: The most common macros are defined there, no use to duplicate these Clean up the already redefinded macros Signed-off-by: Tobias Klausmann --- src

Re: [Mesa-dev] [PATCH 1/2] gallium: include util/macros.h

2015-02-24 Thread Tobias Klausmann
On 24.02.2015 14:57, Mark Janes wrote: Hi Tobias, FYI, This commit failed build-test after it was pushed. Whoops, did not build that driver, right! Sorry for that! Eric fixed it up in 1d1e820. -Mark Thanks for the quick fix :) Greetings, Tobias Tobias Klausmann writes: snip

[Mesa-dev] [PATCH] glsl: Extend lowering pass for gl_ClipDistance to support other arrays

2015-08-17 Thread Tobias Klausmann
This will come in handy when we want to lower gl_CullDistance into gl_CullDistanceMESA. Signed-off-by: Tobias Klausmann --- src/glsl/Makefile.sources| 2 +- src/glsl/ir_optimization.h | 1 + src/glsl/lower_clip_distance.cpp | 574 src/glsl

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: avoid using inline vertex data submit when gl_VertexID is used

2015-08-24 Thread Tobias Klausmann
On 24.08.2015 17:51, Ilia Mirkin wrote: The hardware only generates vertexid when vertices come from a VBO. This fixes: vertexid-drawelements vertexid-drawarrays Signed-off-by: Ilia Mirkin Cc: "11.0" --- src/gallium/drivers/nouveau/nv50/nv50_program.c| 1 + src/gallium/driv

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Tobias Klausmann
On 31.08.2015 17:19, Marcos Paulo de souza wrote: ping :) Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: instead of call prog->getTarget(), since the target never change in prog. It is not changing now, don't know if it will in the future. Using prog->getTarget() may save us from has

Re: [Mesa-dev] [PATCH] nouveau: Use targ in nv50_ir_generate_code

2015-08-31 Thread Tobias Klausmann
On 31.08.2015 18:23, Ilia Mirkin wrote: On Mon, Aug 31, 2015 at 12:21 PM, Tobias Klausmann wrote: On 31.08.2015 17:19, Marcos Paulo de souza wrote: ping :) Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: instead of call prog->getTarget(), since the target never change in prog.

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-01 Thread Tobias Klausmann
On 01.10.2016 21:46, Marek Olšák wrote: Hi, I propose that we use versioning in the form of "year.quarter". 2017 would start with 17.0, then 17.1, 17.2, 17.3 for following quarters of the year, respectively. 2018 would start with 18.0, then 18.1, 18.2, 18.3. The motivation is that you can ea

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-02 Thread Tobias Klausmann
On 02.10.2016 13:56, Nicolai Hähnle wrote: On 01.10.2016 22:22, Tobias Klausmann wrote: On 01.10.2016 21:46, Marek Olšák wrote: Hi, I propose that we use versioning in the form of "year.quarter". 2017 would start with 17.0, then 17.1, 17.2, 17.3 for following quarters o

Re: [Mesa-dev] [PATCH 2/4] nvc0/ir: don't dual issue instructions which depend on each other

2016-08-13 Thread Tobias Klausmann
== OPCLASS_FLOW) return false; + + if (b->dependsOn(a)) + return false; + // anything with MOV if (a->op == OP_MOV || b->op == OP_MOV) return true; Reviewed-by: Tobias Klausmann ___ mesa-dev

Re: [Mesa-dev] [PATCH 1/4] nv50: add target->hasDualIssueing()

2016-08-13 Thread Tobias Klausmann
; + virtual bool hasDualIssueing() const; virtual bool canDualIssue(const Instruction *, const Instruction *) const; virtual int getLatency(const Instruction *) const; virtual int getThroughput(const Instruction *) const; Reviewed-by: Tobias Klausmann ___

Re: [Mesa-dev] [PATCH 3/4] nvc0/ir: dual issue two min/max instructions

2016-08-13 Thread Tobias Klausmann
Hi Karol, one question inline. On 13.08.2016 12:02, Karol Herbst wrote: min/max pairs can be dual issued on Kepler1 changes for ./GpuTest /test=pixmark_piano /benchmark /no_scorebox /msaa=0 /benchmark_duration_ms=6 /width=1024 /height=640: without dual_issue pass: inst_executed: 1.03G in

[Mesa-dev] [RFC] st: guard against NULL pipe_surface

2016-08-17 Thread Tobias Klausmann
OpenMW tries to upload a new surface (mouse pointer) which fails in the now guarded update_framebuffer_size() as the surface is NULL. This is not inteded as a real "fix", as it would just hide the immediate crash. So if somebody could take a look at this... Reported-by: Signed-off-

Re: [Mesa-dev] [RFC] st: guard against NULL pipe_surface

2016-08-18 Thread Tobias Klausmann
ral in update_framebuffer_size(). Greetings, Tobias [1] https://homepages.thm.de/~tjkl80/openmw_backtrace.txt On 18.08.2016 11:55, Marek Olšák wrote: Hi, Do you have a test case? Marek On Thu, Aug 18, 2016 at 1:44 AM, Tobias Klausmann <mailto:tobias.johannes.klausm...@mni.thm.de>> wrot

[Mesa-dev] [PATCH] mesa/main: Fix missing return in non void function

2016-08-25 Thread Tobias Klausmann
This was found by obs: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function main/program_resource.c:109 Signed-off-by: Tobias Klausmann --- src/mesa/main/program_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main

[Mesa-dev] [PATCH v2] mesa/main: Fix missing return in non void function

2016-08-25 Thread Tobias Klausmann
This was found by obs: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function main/program_resource.c:109 Signed-off-by: Tobias Klausmann Reviewed-by: Ian Romanick --- V2: Remove the !, cosmetic change, as the macro expansion stringifies everything: __assert_fail

[Mesa-dev] [PATCH v3 0/4] Constant folding of new Instructions

2014-06-03 Thread Tobias Klausmann
Yet another try for constant folding of Instructions for nvc0. Please Review this again! (Hopefully the last time ;-) ) Tobias Klausmann (4): nvc0/ir: clear subop when folding constant expressions nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions nvc0/ir

[Mesa-dev] [PATCH v3 4/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- V2: Add support for a single-argument version of POPCNT for Maxwell (SM5) V3: Clean up a bit more src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH v3 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- V2: Handle the instruction right (shift after reverse) V3: Reverse once, not independently for every TYPE src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH v3 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann Reviewed-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium

[Mesa-dev] [PATCH v3 3/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- V3: Use BuildUtil for the Immediate instead of a type conversion .../drivers/nouveau/codegen/nv50_ir_peephole.cpp| 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src

[Mesa-dev] [PATCH 2/3] nvc0: mark scissor in nvc0_clear_{}

2014-06-14 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c index c28ec6d..72227b8 100644 --- a/src/gallium/drivers

[Mesa-dev] [PATCH 1/3] nvc0: implement multiple viewports/scissors, enable ARB_viewport_array

2014-06-14 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 7 +- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 20 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 + src/gallium

[Mesa-dev] [PATCH 3/3] nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX and its last consumer

2014-06-14 Thread Tobias Klausmann
We use TGSI_SEMANTIC_VIEWPORT_INDEX for nvc0 now as well. Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h| 1 - src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 0/3] ARB_viewport_array for nvc0

2014-06-14 Thread Tobias Klausmann
This patch-series implements the ARB_viewport_array for nvc0 and does a little house-cleanig afterwords. Tobias Klausmann (3): nvc0: implement multiple viewports/scissors, enable ARB_viewport_array nvc0: mark scissor in nvc0_clear_{} nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX and its last

[Mesa-dev] [PATCH v2 1/3] nvc0: implement multiple viewports/scissors, enable ARB_viewport_array

2014-06-15 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 7 +- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 20 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 + src/gallium

[Mesa-dev] [PATCH v2 2/3] docs: update GL3.txt, relnotes: mark GL_ARB_viewport_array as done for nvc0

2014-06-15 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- docs/GL3.txt| 2 +- docs/relnotes/10.3.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index f5f940c..a392b92 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -132,7 +132,7 @@ GL 4.1

[Mesa-dev] [PATCH v2 0/3] ARB_viewport_array for nvc0

2014-06-15 Thread Tobias Klausmann
This patch-series implements the ARB_viewport_array for nvc0 and does a little house-cleanig afterwords. V2: Add Release-Notes, mark this in GL3 as done for nvc0 Don't mark the scissors dirty when we don't need to do that Tobias Klausmann (3): nvc0: implement multiple viewport

[Mesa-dev] [PATCH v2 3/3] nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX

2014-06-15 Thread Tobias Klausmann
Use TGSI_SEMANTIC_VIEWPORT_INDEX for the last consumer. Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h| 1 - src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src

[Mesa-dev] [PATCH] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 1 + .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 27 -- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h b

[Mesa-dev] [PATCH v2] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
ter on each emit. This fixes the remaining piglit tests in ARB_viewport_array for nvc0. Note: Not tested on nv50 Signed-off-by: Tobias Klausmann --- V2: provide description fix naming of vars .../drivers/nouveau/codegen/nv50_ir_driver.h | 1 + .../drivers/nouveau/code

[Mesa-dev] [PATCH v3] nv50/ir: make ARB_viewport_array behave like it does with other drivers

2014-06-23 Thread Tobias Klausmann
ter on each emit. This fixes the remaining piglit tests in ARB_viewport_array for nvc0. Note: Not tested on nv50 Signed-off-by: Tobias Klausmann --- V2: provide description fix naming of vars V3: spare a function call, use the idx we already have second arg to mkSymbol changed to 0,

[Mesa-dev] [PATCH] nv50/ir: Handle OP_CVT when folding constant expressions

2014-07-02 Thread Tobias Klausmann
Folding for conversions: F32/64->(U16/32, S16/32) and (U16/32, S16/32)->F32 No piglit regressions observed! Signed-off-by: Tobias Klausmann --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 74 ++ 1 file changed, 74 insertions(+) diff --git a/src/gallium/d

[Mesa-dev] [PATCH v3 2/2] nv50/ir: Handle OP_CVT when folding constant expressions

2014-07-03 Thread Tobias Klausmann
Folding for conversions: F32/64->(U16/32, S16/32) and (U16/32, S16/32)->F32 No piglit regressions observed on nv50 and nvc0! Signed-off-by: Tobias Klausmann --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 74 ++ 1 file changed, 74 insertions(+) diff --git

[Mesa-dev] [PATCH v3 1/2] nv50/ir: Add support for the double Type to BuildUtil

2014-07-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- .../drivers/nouveau/codegen/nv50_ir_build_util.cpp | 17 + .../drivers/nouveau/codegen/nv50_ir_build_util.h| 2 ++ 2 files changed, 19 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_build_util.cpp b/src

[Mesa-dev] [PATCH] nvc0: Implement buffer_clear for this type of hardware

2014-05-26 Thread Tobias Klausmann
--- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 171 1 file changed, 171 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c index 6b7c30c..987b6c4 100644 --- a/src/gallium/drivers/nouveau/nvc

[Mesa-dev] Implement buffer_clear for nvc0

2014-05-26 Thread Tobias Klausmann
Hi, please review the following patch! Thanks, Tobias Klausmann ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH V2] nvc0: implement clear_buffer

2014-05-26 Thread Tobias Klausmann
v2: change patch according to Ilia Mirkins review --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 151 1 file changed, 151 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c index 6b7c30c..24

[Mesa-dev] [PATCH V3] nvc0: implement clear_buffer

2014-05-26 Thread Tobias Klausmann
- don't mark the framebuffer dirty for if we don't touch the GPU Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 151 1 file changed, 151 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c

[Mesa-dev] Add constant folding for new opcodes

2014-05-29 Thread Tobias Klausmann
when folding constant expressions src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) Thanks, Tobias Klausmann ___ mesa-dev mailing list mesa-dev

[Mesa-dev] [PATCH 1/4] nvc0/ir: clear subop when folding constant expressions

2014-05-29 Thread Tobias Klausmann
Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-05-29 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp

[Mesa-dev] [PATCH 4/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-05-29 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index 68b9a6d

[Mesa-dev] [PATCH 3/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-05-29 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index 93f7c2a..68b9a6d

Re: [Mesa-dev] [PATCH 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-05-29 Thread Tobias Klausmann
ify that you tested how the HW handles this, as well as exactly how you did it (i.e. how did you modify the code + piglit test, what the results were, etc) On Thu, May 29, 2014 at 3:43 PM, Tobias Klausmann wrote: Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/code

[Mesa-dev] [PATCH v2 0/4] Constant folding of new Instructions

2014-06-03 Thread Tobias Klausmann
And another try for constant folding of Instructions for nvc0. Please Review this! Thanks, Tobias Klausmann Tobias Klausmann (4): nvc0/ir: clear subop when folding constant expressions nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions nvc0/ir: Handle

[Mesa-dev] [PATCH v2 1/4] nvc0/ir: clear subop when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Some operations (e.g. OP_MUL/OP_MAD/OP_EXTBF might have a subop set. After folding, make sure that it is cleared Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH v2 3/4] nvc0/ir: Handle OP_BFIND when folding constant expressions

2014-06-03 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index a214ffc

[Mesa-dev] [PATCH v2 4/4] nvc0/ir: Handle OP_POPCNT when folding constant expressions

2014-06-03 Thread Tobias Klausmann
V2: Add support for a single-argument version of POPCNT for Maxwell (SM5) Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b

[Mesa-dev] [PATCH v2 2/4] nvc0/ir: Handle reverse subop for OP_EXTBF when folding constant expressions

2014-06-03 Thread Tobias Klausmann
V2: Handle the instruction right (shift after reverse) Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b

[Mesa-dev] [PATCH RESEND] nv50/ir: use unordered_set instead of list to keep track of var defs

2014-12-02 Thread Tobias Klausmann
The set of variable defs does not need to be ordered in any way, and removing/adding elements is a fairly common operation in various optimization passes. This shortens runtime of piglit test fp-long-alu to ~11s from ~22s No piglit regressions observed on nvc0! Signed-off-by: Tobias Klausmann

[Mesa-dev] [RFC] mesa/st: Avoid passing a NULL buffer to the drivers

2015-01-07 Thread Tobias Klausmann
If we capture transform feedback from n stream in (n-1) buffers we face a NULL buffer, use the buffer (n-1) to capture the output of stream n. This fixes one piglit test with nvc0: arb_gpu_shader5-xfb-streams-without-invocations Signed-off-by: Tobias Klausmann --- src/mesa/state_tracker

[Mesa-dev] Re: [Nouveau] [RFC] mesa/st: Avoid passing a NULL buffer to the drivers

2015-01-11 Thread Tobias Klausmann
On 11.01.2015 06:05, Ilia Mirkin wrote: Can you elaborate a bit as to why that's the right thing to do? On Wed, Jan 7, 2015 at 1:52 PM, Tobias Klausmann wrote: If we capture transform feedback from n stream in (n-1) buffers we face a NULL buffer, use the buffer (n-1) to capture the o

[Mesa-dev] Re: [Nouveau] [RFC] mesa/st: Avoid passing a NULL buffer to the drivers

2015-01-11 Thread Tobias Klausmann
On 12.01.2015 01:57, Ilia Mirkin wrote: On Sun, Jan 11, 2015 at 7:43 PM, Tobias Klausmann wrote: On 11.01.2015 06:05, Ilia Mirkin wrote: Can you elaborate a bit as to why that's the right thing to do? On Wed, Jan 7, 2015 at 1:52 PM, Tobias Klausmann wrote: If we capture tran

[Mesa-dev] [PATCH] mesa: fix no return in two format functions

2015-01-15 Thread Tobias Klausmann
I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/format_utils.c:180 E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/glformats.c:2714 --- src/mesa/main/format_utils.c | 1 + src/mesa/main/glformats.c| 1 + 2 files changed, 2 insert

Re: [Mesa-dev] [PATCH] mesa: fix no return in two format functions

2015-01-15 Thread Tobias Klausmann
On 15.01.2015 19:35, Jan Vesely wrote: On Thu, 2015-01-15 at 19:26 +0100, Tobias Klausmann wrote: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/format_utils.c:180 E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/glformats.c:2714

Re: [Mesa-dev] [PATCH] mesa: fix no return in two format functions

2015-01-19 Thread Tobias Klausmann
On 16.01.2015 15:05, Jan Vesely wrote: On Thu, 2015-01-15 at 20:49 +0100, Tobias Klausmann wrote: On 15.01.2015 19:35, Jan Vesely wrote: On Thu, 2015-01-15 at 19:26 +0100, Tobias Klausmann wrote: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function ../../src

Re: [Mesa-dev] [PATCH] mesa: fix no return in two format functions

2015-01-19 Thread Tobias Klausmann
On 19.01.2015 19:54, Matt Turner wrote: On Thu, Jan 15, 2015 at 10:26 AM, Tobias Klausmann wrote: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/format_utils.c:180 E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/glformats.c

[Mesa-dev] [PATCH] mesa: change assert to unreachable in two format functions

2015-01-19 Thread Tobias Klausmann
This fixes two problems reported by osc: I: Program returns random data in a function E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/format_utils.c:180 E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/glformats.c:2714 Signed-off-by: Tobias Klausmann --- src/mesa/main

[Mesa-dev] [PATCH] glsl/parser: (trivial) fix indentation in one function

2015-01-21 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/glsl/glcpp/glcpp-parse.y | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index e5bebe5..8b545da 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl

Re: [Mesa-dev] [PATCH] glsl/parser: (trivial) fix indentation in one function

2015-01-21 Thread Tobias Klausmann
On 21.01.2015 22:22, Matt Turner wrote: On Wed, Jan 21, 2015 at 1:12 PM, Tobias Klausmann wrote: (snip) We're messing up the indentation here. But really we want to get rid of tabs, not add more. glcpp is unfortunately full of tabs. Alright ignore this one then. Thanks, T

[Mesa-dev] [PATCH] vulkan/util: meson build - add wayland client include

2019-03-16 Thread Tobias Klausmann
terminated. The above misses the include directory for wayland: -I/usr/include/wayland Signed-off-by: Tobias Klausmann --- src/vulkan/util/meson.build | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/vulkan/util/meson.build b/src/vulkan/util/meson.build index

Re: [Mesa-dev] [PATCH] vulkan/util: meson build - add wayland client include

2019-03-17 Thread Tobias Klausmann
src/vulkan/meson.build as they apply to the overlay, utils & wsi. Since it's correct though, I landed Tobias' patch with my r-b and Cc: stable (I dropped the unnecessary [] though), and I sent MR !460 with your suggestion. Thanks, -Lionel On 16/03/2019 18:56, Tobias Klausmann w

Re: [Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

2016-04-04 Thread Tobias Klausmann
On 04.04.2016 04:48, Timothy Arceri wrote: On Mon, 2016-04-04 at 12:15 +1000, Dave Airlie wrote: From: Tobias Klausmann Signed-off-by: Tobias Klausmann Const.MaxClipPlanes); + } else if (strcmp("gl_CullDistance", name) == 0 + && size > state

Re: [Mesa-dev] [PATCH 11/12] nvc0: Implement cull_distance as a special form of clip distance

2016-04-04 Thread Tobias Klausmann
On 04.04.2016 04:32, Ilia Mirkin wrote: On Sun, Apr 3, 2016 at 10:15 PM, Dave Airlie wrote: From: Tobias Klausmann This enables ARB_cull_distance. This isn't enough - something needs to lower the CULLDIST into CLIPDIST (or some combined thing). Ideally they'd both just come in a

Re: [Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

2016-04-04 Thread Tobias Klausmann
On 05.04.2016 00:06, Dave Airlie wrote: On 4 April 2016 at 23:07, Tobias Klausmann wrote: On 04.04.2016 04:48, Timothy Arceri wrote: On Mon, 2016-04-04 at 12:15 +1000, Dave Airlie wrote: From: Tobias Klausmann Signed-off-by: Tobias Klausmann Const.MaxClipPlanes); + } else if (strcmp

Re: [Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

2016-04-05 Thread Tobias Klausmann
On 05.04.2016 01:32, Timothy Arceri wrote: On Mon, 2016-04-04 at 15:07 +0200, Tobias Klausmann wrote: On 04.04.2016 04:48, Timothy Arceri wrote: On Mon, 2016-04-04 at 12:15 +1000, Dave Airlie wrote: From: Tobias Klausmann Signed-off-by: Tobias Klausmann Const.MaxClipPlanes); + } else if

Re: [Mesa-dev] [Nouveau] [PATCH] nv50/ir: only enable mul saturate on G200+

2015-05-09 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann On 09.05.2015 09:31, Ilia Mirkin wrote: Commit 44673512a84 enabled support for saturating fmul. However experimentally this does not seem to work on the older chips. Restrict the feature to G200 (NVA0) and later. Reported-by: Pierre Moreau Bugzilla: https

Re: [Mesa-dev] [PATCH 1/2] nv50: add a header file for nv50_query

2015-05-17 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann On 17.05.2015 18:19, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources| 1 + src/gallium/drivers/nouveau/nv50/nv50_context.h | 12 +--- src/gallium/drivers/nouveau/nv50/nv50_query.c | 21

Re: [Mesa-dev] [PATCH 1/2] nvc0: add a header file for nvc0_query

2015-05-17 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann On 17.05.2015 18:21, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources| 1 + src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 12 +-- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 28

Re: [Mesa-dev] [PATCH 1/2] nv50: add a header file for nv50_query

2015-05-18 Thread Tobias Klausmann
On 18.05.2015 10:43, Samuel Pitoiset wrote: Thanks for the review. Can I get your R-b for the other patches of the series. :-) Oh silly me, it was meant to be a R-b for patch 1+2 on both series, sorry :) On 05/17/2015 06:46 PM, Tobias Klausmann wrote: Reviewed-by: Tobias Klausmann On

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann On 18.05.2015 11:29, Marek Olšák wrote: From: Marek Olšák This fixes a crash in nouveau which can't handle set_constant_buffer(PIPE_SHADER_TESS_*). where is the S-o-b ? ;-) --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ src

Re: [Mesa-dev] [PATCH v2] nv50/ir: avoid messing up arg1 of PFETCH

2015-05-23 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann On 23.05.2015 18:56, Ilia Mirkin wrote: There can be scenarios where the "indirect" arg of a PFETCH becomes known, and so the code will attempt to propagate it. Use this opportunity to just fold it into the first argument, and prevent the load propag

[Mesa-dev] [PATCH 11/11] nouveau/nvc0: implement cull_distance as a special form of clip distance

2015-05-24 Thread Tobias Klausmann
This enables ARB_cull_distance. Signed-off-by: Tobias Klausmann --- docs/GL3.txt | 2 +- docs/relnotes/10.7.0.html | 4 +++- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 6 +- src/gallium/drivers/nouveau/nvc0

[Mesa-dev] [RFC PATCH 00/11] Implement ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
This patch series adds the needed support for this extension to the various parts of mesa to finally enable it for nvc0. Dave Airlie (1): glsl: lower cull_distance into cull_distance_mesa Tobias Klausmann (10): glapi: add GL_ARB_cull_distance mesa/main: add support for GL_ARB_cull_distance

[Mesa-dev] [PATCH 02/11] mesa/main: add support for GL_ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/mesa/main/extensions.c | 1 + src/mesa/main/get.c | 26 ++ src/mesa/main/get_hash_params.py | 4 src/mesa/main/mtypes.h | 22 +- src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 08/11] i965: rename UsesClipDistanceOut to UsesClipCullDistanceOut

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vs.c

[Mesa-dev] [PATCH 09/11] gallium: add support for arb_cull_distance

2015-05-24 Thread Tobias Klausmann
Add another pipe cap so we can savely enable of disable this extension Signed-off-by: Tobias Klausmann --- src/gallium/auxiliary/cso_cache/cso_context.c| 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium

[Mesa-dev] [PATCH 05/11] glsl: Add a helper to see if an array was unsize in the shader

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/glsl/glsl_types.cpp | 8 src/glsl/glsl_types.h | 10 -- src/glsl/linker.cpp | 2 +- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index f675e90..4bc7324 100644

[Mesa-dev] [PATCH 04/11] mesa/st: add support for GL_ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/mesa/state_tracker/st_extensions.c | 4 src/mesa/state_tracker/st_program.c| 34 ++ 2 files changed, 38 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c

[Mesa-dev] [PATCH 07/11] glsl: Add arb_cull_distance support

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/glsl/ast_to_hir.cpp | 14 + src/glsl/builtin_variables.cpp | 13 +++- src/glsl/glcpp/glcpp-parse.y| 3 + src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 3 + src/glsl/link_varyings.cpp

[Mesa-dev] [PATCH 10/11] nouveau/codegen: sort in galliums cull_distance semantic into the drivers bitmask

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp index ecd115f..381a958

[Mesa-dev] [PATCH 03/11] mesa/prog: Add varyings for arb_cull_distance

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/mesa/program/prog_print.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/program/prog_print.c b/src/mesa/program/prog_print.c index d588d07..e8855cd 100644 --- a/src/mesa/program/prog_print.c +++ b/src/mesa/program/prog_print.c @@ -147,6

[Mesa-dev] [PATCH 06/11] glsl: lower cull_distance into cull_distance_mesa

2015-05-24 Thread Tobias Klausmann
From: Dave Airlie Signed-off-by: Tobias Klausmann --- src/glsl/Makefile.sources| 1 + src/glsl/ir_optimization.h | 1 + src/glsl/link_varyings.cpp | 15 +- src/glsl/link_varyings.h | 3 +- src/glsl/linker.cpp | 1 + src/glsl

[Mesa-dev] [PATCH 01/11] glapi: add GL_ARB_cull_distance

2015-05-24 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/mapi/glapi/gen/gl_API.xml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 3090b9f..a792056 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++ b/src/mapi/glapi/gen

Re: [Mesa-dev] [PATCH 07/11] glsl: Add arb_cull_distance support

2015-05-24 Thread Tobias Klausmann
hi, replay inline. On 25.05.2015 00:34, Timothy Arceri wrote: On Sun, 2015-05-24 at 19:58 +0200, Tobias Klausmann wrote: Signed-off-by: Tobias Klausmann --- src/glsl/ast_to_hir.cpp | 14 + src/glsl/builtin_variables.cpp | 13 +++- src/glsl/glcpp/glcpp-parse.y

Re: [Mesa-dev] [PATCH 07/11] glsl: Add arb_cull_distance support

2015-05-24 Thread Tobias Klausmann
On 25.05.2015 01:19, Timothy Arceri wrote: On Mon, 2015-05-25 at 00:46 +0200, Tobias Klausmann wrote: hi, replay inline. On 25.05.2015 00:34, Timothy Arceri wrote: On Sun, 2015-05-24 at 19:58 +0200, Tobias Klausmann wrote: Signed-off-by: Tobias Klausmann --- src/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH] docs: Mark ARB_cull_distance as in progress

2015-05-25 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- I'm already getting emails wanting me to do this, so just mark it, wont change anything really docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 44a824b..8e1c8cd 100644 --- a/docs/GL3.txt

Re: [Mesa-dev] [PATCH] docs: Mark ARB_cull_distance as in progress

2015-05-25 Thread Tobias Klausmann
Can you push this with your newly won commit access? Makes up a nice trial ;-) Am 25.05.2015 um 16:49 schrieb Samuel Pitoiset: yeah, very important thing to do *before* starting to write a new extension. ;) Reviewed-by: Samuel Pitoiset On 05/25/2015 03:57 PM, Tobias Klausmann wrote

Re: [Mesa-dev] [PATCH 09/11] gallium: add support for arb_cull_distance

2015-05-25 Thread Tobias Klausmann
least for llvmpipe, I'm not entirely sure for softpipe) if not there's some unaccounted difference somewhere how we'd thought of how this should work for dx10 vs. opengl). Hey nice to know llvmpipe already supports this, i'll test it! Tobias Roland Am 24.05.2015 um

Re: [Mesa-dev] [PATCH] glsl: avoid leaking linked gl_shader when there's a late linker error

2015-05-25 Thread Tobias Klausmann
pong the unhappyness case will hopefully soon be extended with cull_distance + clipvertex, so good to see this fixed! Reviewed-by: Tobias Klausmann On 25.05.2015 21:42, Ilia Mirkin wrote: ping On Sun, May 17, 2015 at 5:56 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- Just

Re: [Mesa-dev] [PATCH 2/4] nouveau/compiler: init the size and code variables to NULL/0

2015-06-05 Thread Tobias Klausmann
Mh especially GCC 5 seems to be picky about code, if we don't work around we soon will only see warnings for every file. Even if the compiler is buggy/to picky we should fix the code to not drown in warnings... :-) On 05.06.2015 22:23, Ilia Mirkin wrote: Sure. Fix it in GCC :) disable the bo

  1   2   >