Re: [Mesa-dev] [PATCH 0/2] debug feature to dump "get configs" and "chosen configs"

On Fri, Nov 09, 2018 at 06:04:10PM +, Silvestrs Timofejevs wrote: > This patch series provides an easy way to see what configs > have been returned by the 'eglGetConfigs' and 'eglChooseConfig' > functions, and give an overview of config attributes. > >

Re: [Mesa-dev] [PATCH 2/2] egl: add config debug printout

Eric, thank you for reviewing my patch. I have expanded little bit on some of your comments bellow. I will be sending fallow up V2 of the patch shortly. On Thu, Dec 06, 2018 at 11:00:25AM +, Eric Engestrom wrote: > On Friday, 2018-11-09 18:04:12 +0000, Silvestrs Timofejevs wrote: > >

[Mesa-dev] debug feature to dump "get configs" and "chosen configs" (v2)

This patch series provides an easy way to see what configs have been returned by the 'eglGetConfigs' and 'eglChooseConfig' functions, and give an overview of config attributes. v2: a) refactor the code in line with Eric's comments b) rename function _snprintfStrcat, split it out and put into

[Mesa-dev] [PATCH v2 1/3] util: introduce the util_strnappend function

This function is similar to strncat, but unlike strncat it allows to concatenate the buffer with a formatted string. The alternative would be to have an intermediate string that is formated first, and then appended via strncat. Signed-off-by: Silvestrs Timofejevs --- src/util/u_string.h | 16

[Mesa-dev] [PATCH v2 2/3] egl: introduce a log level getter function

Being able to retrieve the log level can be useful to enable/disable debug code. The alternative, which is calling 'getenv' function every time to retrieve the log level, is more "expensive". Signed-off-by: Silvestrs Timofejevs --- src/egl/main/egllog.c | 9 + src/e

[Mesa-dev] [PATCH v2 3/3] egl: add config debug printout (v2)

their index in the chosen configs array. v2: a) refactor the code in line with Eric's comments b) rename function _snprintfStrcat, split it out and put into the src/util/u_string.h, make it a separate patch. Signed-off-by: Silvestrs Timofejevs --- src/egl/Makefile.sources

[Mesa-dev] [PATCH v3 1/3] util: introduce the util_strnappend function (v2)

-by: Silvestrs Timofejevs Reviewed-by: Eric Engestrom --- src/util/u_string.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/util/u_string.h b/src/util/u_string.h index e408146..2036815 100644 --- a/src/util/u_string.h +++ b/src/util/u_string.h @@ -223,6 +223,21

[Mesa-dev] debug feature to dump "get configs" and "chosen configs" (v3)

This patch series provides an easy way to see what configs have been returned by the 'eglGetConfigs' and 'eglChooseConfig' functions, and give an overview of config attributes. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedes

[Mesa-dev] [PATCH v3 2/3] egl: introduce a log level getter function

Being able to retrieve the log level can be useful to enable/disable debug code. The alternative, which is calling 'getenv' function every time to retrieve the log level, is more "expensive". Signed-off-by: Silvestrs Timofejevs Reviewed-by: Eric Engestrom --- src/e

[Mesa-dev] [PATCH v3 3/3] egl: add config debug printout (v3)

their index in the chosen configs array. v2: a) refactor the code in line with Eric's comments b) rename function _snprintfStrcat, split it out and put into the src/util/u_string.h, make it a separate patch. v3: remove unnecessary 'const' qualifiers from the function p

[Mesa-dev] [PATCH 0/2] debug feature to dump "get configs" and "chosen configs"

This patch series provides an easy way to see what configs have been returned by the 'eglGetConfigs' and 'eglChooseConfig' functions, and give an overview of config attributes. Silvestrs Timofejevs (2): egl: introduce a log level getter function egl: add config debu

[Mesa-dev] [PATCH 2/2] egl: add config debug printout

their index in the chosen configs array. Signed-off-by: Silvestrs Timofejevs --- src/egl/Makefile.sources | 4 +- src/egl/main/eglconfig.c | 20 ++- src/egl/main/eglconfigdebug.c | 277 ++ src/egl/main/eglconfigdebug.h | 55 + src/eg

[Mesa-dev] [PATCH 1/2] egl: introduce a log level getter function

Being able to retrieve the log level can be useful to enable/disable debug code. The alternative, which is calling 'getenv' function every time to retrieve the log level, is more "expensive". Signed-off-by: Silvestrs Timofejevs --- src/egl/main/egllog.c | 9 + src/e

Re: [Mesa-dev] [PATCH v3 2/3] egl: introduce a log level getter function

Hi Emil, thank you for your review. On Mon, Jan 14, 2019 at 07:55:07PM +, Emil Velikov wrote: > On Mon, 14 Jan 2019 at 18:20, Emil Velikov wrote: > > > > On 2019/01/11, Silvestrs Timofejevs wrote: > > > Being able to retrieve the log level can be useful to enable/

Re: [Mesa-dev] [PATCH v3 3/3] egl: add config debug printout (v3)

On Mon, Jan 14, 2019 at 08:20:09PM +, Emil Velikov wrote: > e aOn Fri, 11 Jan 2019 at 16:34, Silvestrs Timofejevs > wrote: > > > > Feature to print out EGL returned configs for debug purposes. > > > > 'eglChooseConfig' and 'eglGetConfigs'

[Mesa-dev] debug feature to dump "get configs" and "chosen configs" (v4)

This patch series provides an easy way to see what configs have been returned by the 'eglGetConfigs' and 'eglChooseConfig' functions, and give an overview of config attributes. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedes

[Mesa-dev] [PATCH v4 2/2] egl: add config debug printout (v4)

rototype v4: a) re-factor the code in line with review comments b) move util_strnappend from utils back to eglconfigdebug.c. In my opinion this function is the best way of achieving the desired result, so it still used but made private to eglconfigdebug.c. Signed-off-by: Silvestrs Tim

[Mesa-dev] [PATCH v4 1/2] egl: introduce a log level getter function

Being able to retrieve the log level can be useful to enable/disable debug code. The alternative, which is calling 'getenv' function every time to retrieve the log level, is more "expensive". Signed-off-by: Silvestrs Timofejevs Reviewed-by: Eric Engestrom --- src/e