Prevent Coverity seeing potential errors when src is
no initialized in the switch case.
Coverity-Id: 1396397
Signed-off-by: Robert Foss
---
Patch can be found here:
https://git.collabora.com/cgit/user/robertfoss/mesa.git/log/?h=cov_1396397_v1
src/amd/vulkan/radv_cmd_buffer.c | 2 ++
1 file
Add assert checking that num_sources is never larger than 3.
This prevents Coverity from concluding that the improperly handled
cases of num_sources not being 0-3 are relevant.
Coverity-Id: 1399480-1399489
Signed-off-by: Robert Foss
---
Patch can be found here:
https://git.collabora.com
On 2017-01-30 05:37 PM, Timothy Arceri wrote:
On Mon, 2017-01-30 at 16:27 -0500, Robert Foss wrote:
Add assert checking that num_sources is never larger than 3.
This prevents Coverity from concluding that the improperly handled
cases of num_sources not being 0-3 are relevant.
Coverity-Id
Add assert checking that num_sources is never larger than 3.
This prevents Coverity from concluding that the improperly handled
cases of num_sources not being 0-3 are relevant.
Coverity-Id: 1399480-1399489
Signed-off-by: Robert Foss
---
src/mesa/drivers/dri/i965/brw_eu_validate.c | 1 +
1 file
Add assert checking that num_sources is never larger than 3.
This prevents Coverity from concluding that the unhandled
cases of num_sources not being 0-3 are relevant.
Coverity-Id: 1399480-1399489
Signed-off-by: Robert Foss
Reviewed-by: Anuj Phogat
---
src/mesa/drivers/dri/i965
Add assert checking that num_sources is never larger than 3.
This prevents Coverity from concluding that the unhandled
cases of num_sources not being 0-3 are relevant.
Coverity-Id: 1399480-1399489
Signed-off-by: Robert Foss
Reviewed-by: Anuj Phogat
Reviewed-by: Iago Toral Quiroga
---
src
On 2016-10-11 01:37 PM, Chad Versace wrote:
On Tue 11 Oct 2016, Emil Velikov wrote:
On 10 October 2016 at 20:41, Rob Clark wrote:
On Mon, Oct 10, 2016 at 1:43 PM, Chad Versace wrote:
Testing:
I haven't yet tested EGL_ANDROID_native_fence_sync with these patches, but
the series d
On 2016-10-13 04:37 PM, Rafael Antognolli wrote:
Hi all,
On Tue, Oct 11, 2016 at 01:47:37PM -0400, Robert Foss wrote:
On 2016-10-11 01:37 PM, Chad Versace wrote:
On Tue 11 Oct 2016, Emil Velikov wrote:
On 10 October 2016 at 20:41, Rob Clark wrote:
On Mon, Oct 10, 2016 at 1:43 PM, Chad
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
gregkh-staging/staging-next [1], and this test is targeted at verifying the
functionality implemented in that series.
The sw_sync
From: Robert Foss
Base functions to help testing the Sync File Framework (explicit fencing
mechanism ported from Android).
These functions allow you to create, use and destroy timelines and fences.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/Makefile.sources | 2
From: Robert Foss
This subtest verifies that waiting, timing out on a wait and that counting
fences in various states works.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 66 +
1 file changed, 66 insertions(+)
diff --git a/tests
From: Robert Foss
This subtest verifies that merging two fences works in the simples possible
case.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 102647d..851430e 100644
--- a
From: Robert Foss
Add initial tests for sw_sync.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
---
lib/sw_sync.c | 13 ++---
lib/sw_sync.h | 2 +-
tests/Makefile.sources | 1 +
tests/sw_sync.c| 51
From: Robert Foss
This subtest verifies merging a fence with itself does not fail.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 00ac44b..db03f48 100644
--- a/tests
From: Robert Foss
This subtest verifies the access ordering of multiple consumer threads.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 103
1 file changed, 103 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index
From: Robert Foss
This subtest verifies that waiting on fences works properly.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 851430e..07e9638 100644
--- a/tests
From: Robert Foss
Add subtest test_sync_merge that tests merging fences and the validity of the
resulting merged fence.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 67 +
1 file changed, 67 insertions(+)
diff --git a/tests/sw_sync.c
From: Robert Foss
This test verifies that stressing the kernel by creating multiple
consumer/producer threads that wait on a single timeline to be incremented
by another conumer/producer thread does not fail.
And that the order amongst the threads is maintained.
Signed-off-by: Robert Foss
From: Robert Foss
This subtest verifies that creating many timelines and merging random fences
from each timeline with eachother results in merged fences that are fully
functional.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 73 +
1
From: Robert Foss
This subtest runs a single consumer thread and multiple producer thread that
are synchronized using multiple timelines.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 139
1 file changed, 139 insertions(+)
diff
From: Robert Foss
This subtests tests that creating fences on negative timelines fail.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index a8c8ca4..102647d 100644
--- a/tests/sw_sync.c
+++ b/tests
From: Robert Foss
Add subtest alloc_fence that verifies that it's possible to allocate a fence
on a timeline.
Signed-off-by: Robert Foss
---
tests/sw_sync.c | 16
1 file changed, 16 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index d2d4c42..a8c8ca4 1
On 2016-08-24 02:01 AM, Daniel Vetter wrote:
On Tue, Aug 23, 2016 at 01:56:02PM -0400, robert.f...@collabora.com wrote:
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
gregkh
On 2016-08-23 06:56 PM, Eric Engestrom wrote:
On Tue, Aug 23, 2016 at 01:56:02PM -0400, robert.f...@collabora.com wrote:
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
From: Robert Foss
This series implements the sw_sync test and the lib/sw_sync helper functions
for said test.
Gustavo Padovans sw_sync series was just de-staged in
gregkh-staging/staging-next [1], and this test is targeted at verifying the
functionality implemented in that series.
The sw_sync
From: Robert Foss
Base functions to help testing the Sync File Framework (explicit fencing
mechanism ported from Android).
These functions allow you to create, use and destroy timelines and fences.
Signed-off-by: Gustavo Padovan
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
lib
From: Robert Foss
Add initial tests for sw_sync.
Signed-off-by: Robert Foss
Signed-off-by: Gustavo Padovan
Reviewed-by: Eric Engestrom
---
tests/Makefile.sources | 1 +-
tests/sw_sync.c| 51 +++-
2 files changed, 52 insertions(+), 0 deletions
From: Robert Foss
This test verifies that stressing the kernel by creating multiple
consumer/producer threads that wait on a single timeline to be incremented
by another conumer/producer thread does not fail.
And that the order amongst the threads is maintained.
Signed-off-by: Robert Foss
From: Robert Foss
This subtest verifies that creating many timelines and merging random fences
from each timeline with eachother results in merged fences that are fully
functional.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 73
From: Robert Foss
This subtest verifies that merging two fences works in the simples possible
case.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 23 +++
1 file changed, 23 insertions(+), 0 deletions(-)
diff --git a/tests/sw_sync.c b/tests
From: Robert Foss
This subtest runs a single consumer thread and multiple producer thread that
are synchronized using multiple timelines.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 139 +-
1 file changed, 139
From: Robert Foss
This subtests tests that creating fences on negative timelines fail.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 7 +++
1 file changed, 7 insertions(+), 0 deletions(-)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index a8c8ca4
From: Robert Foss
This subtest verifies that waiting, timing out on a wait and that counting
fences in various states works.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 66 ++-
1 file changed, 66 insertions
From: Robert Foss
This subtest verifies the access ordering of multiple consumer threads.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 103 +-
1 file changed, 103 insertions(+), 0 deletions(-)
diff --git a/tests
From: Robert Foss
Add subtest test_sync_merge that tests merging fences and the validity of the
resulting merged fence.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 67 ++-
1 file changed, 67 insertions(+), 0
From: Robert Foss
This subtest verifies merging a fence with itself does not fail.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 27 +++
1 file changed, 27 insertions(+), 0 deletions(-)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
From: Robert Foss
This subtest verifies that waiting on fences works properly.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 38 ++
1 file changed, 38 insertions(+), 0 deletions(-)
diff --git a/tests/sw_sync.c b/tests
From: Robert Foss
Add subtest alloc_fence that verifies that it's possible to allocate a fence
on a timeline.
Signed-off-by: Robert Foss
Reviewed-by: Eric Engestrom
---
tests/sw_sync.c | 16
1 file changed, 16 insertions(+), 0 deletions(-)
diff --git a/tests/sw_syn
I gave this patch a spin on a Qemu+Virgl+AOSP setup, and it seems to
work rather well.
Thanks Rob!
Tested-by: Robert Foss
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Thanks for upstreaming this, this patch has been tested and confirmed
working on a qemu setup.
Tested-by: Robert Foss
On Fri, 2016-11-18 at 08:39 -0500, Rob Clark wrote:
> From: Gustavo Padovan
>
> ---
> src/gallium/drivers/virgl/virgl_context.c | 47 +++-
> -
On 2/10/19 6:58 PM, Robert Foss wrote:
This patch is
s/patch/series
Reviewed-by: Robert Foss
On 2/9/19 2:21 AM, Alyssa Rosenzweig wrote:
Via the prototyping cycle, a substantial amount of dead code and other
cruft has accumulated in the Panfrost tree, which is a burden for both
maintenance
This patch is
Reviewed-by: Robert Foss
On 2/9/19 2:21 AM, Alyssa Rosenzweig wrote:
Via the prototyping cycle, a substantial amount of dead code and other
cruft has accumulated in the Panfrost tree, which is a burden for both
maintenance and aesthetic.
This patch series removes dead code when
From: Robert Foss
Avoid out of bounds access of the array 'src'.
'src' is passed along:
nir_eval_const_opcode()
evaluate_bitfield_insert()
In evaluate_bitfield_insert() an access to src[3] is made
if bit_size==32 wich it always will be due to the
asser
From: Robert Foss
Avoid leaking buffer allocated for task if an
error has occured.
Coverity id: 1213929
Signed-off-by: Robert Foss
---
src/gallium/state_trackers/omx/vid_enc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/omx/vid_enc.c
b/src/gallium
From: Robert Foss
Avoid out of bounds access of the array 'src'.
'src' is passed along:
nir_eval_const_opcode()
evaluate_bitfield_insert()
In evaluate_bitfield_insert() an access to src[3] is made
if bit_size==32 wich it always will be due to the
asser
Alright, I'll mark this as rejected in patchwork.
On 2016-06-03 01:28 PM, Jason Ekstrand wrote:
None of the Opcode's evaluated as specialization constants have four
sources so this will never be a problem. Hence the assert on the next
line. I think we should just mark this as a false positive.
From: Robert Foss
Make fd2_program_validate return failure information to avoid de-allocated
memory from being used.
coverity: 1362467
Signed-off-by: Robert Foss
---
src/gallium/drivers/freedreno/a2xx/fd2_program.c | 12 +---
src/gallium/drivers/freedreno/a2xx/fd2_program.h | 2 +-
2
From: Robert Foss
Make sure that fd2_emit_state does not fail. If it does fail, some of shader
data structes may be de-allocated.
coverity: 1362467
Signed-off-by: Robert Foss
---
src/gallium/drivers/freedreno/a2xx/fd2_draw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Robert Foss
Make sure that fd2_program_validate does not fail. If it does fail, some of
shader data structes may be de-allocated.
Also fd2_draw_vbo to return booleans to indicate failure.
coverity: 1362467
Signed-off-by: Robert Foss
---
src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 5
From: Robert Foss
Make delete_shader set the fd2_shader_stateobj ptr to NULL, to simplify
debugging and finding use after free errors.
Signed-off-by: Robert Foss
---
src/gallium/drivers/freedreno/a2xx/fd2_program.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers
This patch has been tested on Android on the iMX6.
Tested-by: Robert Foss
On Thu, 2017-06-08 at 20:56 +0200, Lucas Stach wrote:
> This allows to import an FD with an explicit modifier passed through
> userspace protocols.
>
> Signed-off-by: Lucas Stach
> ---
> src/g
This patch has been tested on Android on the iMX6.
Tested-by: Robert Foss
On Thu, 2017-06-08 at 20:56 +0200, Lucas Stach wrote:
> This implements a way to import FDs with modifiers on plain GBM
> devices,
> without the need to go through EGL. This is mostly to the benefit of
>
-review.googlesource.com/566793
Signed-off-by: Tomasz Figa
Reviewed-by: Chad Versace
Signed-off-by: Robert Foss
---
src/egl/drivers/dri2/platform_android.c | 39 +++--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/src/egl
Hey Rob,
On Mon, 2017-11-27 at 13:42 -0600, Rob Herring wrote:
> On Mon, Nov 27, 2017 at 8:14 AM, Robert Foss om> wrote:
> > From: Tomasz Figa
> >
> > There is no API available to properly query the
> > IMPLEMENTATION_DEFINED
> > format. As a workaroun
Hey,
On Tue, 2017-11-28 at 11:49 +, Emil Velikov wrote:
> On 28 November 2017 at 10:45, Tapani Pälli
> wrote:
> > Hi;
> >
> >
> > On 11/27/2017 04:14 PM, Robert Foss wrote:
> > >
> > > From: Tomasz Figa
> > &g
On Thu, 2017-11-30 at 11:14 -0600, Rob Herring wrote:
> On Thu, Nov 30, 2017 at 12:11 AM, Tapani Pälli m> wrote:
> >
> >
> > On 11/30/2017 06:13 AM, Tomasz Figa wrote:
> > >
> > > On Thu, Nov 30, 2017 at 3:43 AM, Robert Foss > > ra.com>
>
-review.googlesource.com/566793
Signed-off-by: Tomasz Figa
Reviewed-by: Chad Versace
Signed-off-by: Robert Foss
---
Changes since v1:
- Replaced bug id with full link
src/egl/drivers/dri2/platform_android.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a
On Tue, 2017-12-05 at 18:22 +0900, Tomasz Figa wrote:
> On Sat, Dec 2, 2017 at 4:43 AM, Rob Herring wrote:
> > On Fri, Dec 1, 2017 at 8:44 AM, Tomasz Figa
> > wrote:
> > > On Fri, Dec 1, 2017 at 11:20 PM, Rob Herring
> > > wrote:
> > > >
From: Tomeu Vizoso
Signed-off-by: Robert Foss
---
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c
b/src/gallium/drivers/etnaviv/etnaviv_compiler.c
index eafb511bb8..8f73113059 100644
--- a/src
Signed-off-by: Robert Foss
---
src/egl/drivers/dri2/platform_android.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/src/egl/drivers/dri2/platform_android.c
index 7a73419d14..5550f580a8 100644
--- a/src/egl/drivers/dri2
texture-float
android: add etnaviv driver build support
Robert Foss (1):
egl/android: Fix typ-o
Tomeu Vizoso (2):
etnaviv: Add return statement to etna_amode so compiler is happy
android: build imx-drm winsys
Android.common.mk | 1 +
Android.mk
From: Tomeu Vizoso
Signed-off-by: Tomeu Vizoso
---
Android.mk| 5 +++--
src/gallium/Android.mk| 1 +
src/gallium/winsys/imx/drm/Android.mk | 40 +++
3 files changed, 44 insertions(+), 2 deletions(-)
create mode 10064
From: Rob Herring
Signed-off-by: Rob Herring
---
src/gbm/backends/dri/gbm_dri.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index 19be440d48..58b62ac361 100644
--- a/src/gbm/backends/dri/gbm_dri.c
+++ b/src/
From: Rob Herring
This is required by freedreno at least for GLES3 support.
See docs/patents.txt for information about turning this on for s/w
renderers.
Signed-off-by: Rob Herring
---
Android.common.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/Android.common.mk b/Android.common.mk
From: Rob Herring
Add etnaviv to Android makefiles.
Signed-off-by: Rob Herring
---
Android.mk| 5 +--
src/gallium/Android.mk| 1 +
src/gallium/auxiliary/Android.mk | 5 +--
src/gallium/auxiliary/renderonly/renderonly.c
From: Rob Herring
Signed-off-by: Rob Herring
---
src/gallium/auxiliary/os/os_process.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/os/os_process.c
b/src/gallium/auxiliary/os/os_process.c
index 6622b9b2bc..af5d22bf84 100644
--- a/src/gallium/au
From: Tomeu Vizoso
Signed-off-by: Robert Foss
Reviewed-by: Tapani Pälli
---
Changes since v1:
Emil Velikov
- Switch return statement to unreachable call
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/etnaviv
From: Rob Herring
The function getprogname() is available on Android, since it reuses
various BSD solutions C runtime.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
Reviewed-by: Emil Velikov
---
Changes since v1:
Emil Velikov
- Added commit msg
- Dropped whitepace change
src
From: Tomeu Vizoso
Signed-off-by: Robert Foss
Reviewed-by: Tapani Pälli
---
Changes since v1:
Emil Velikov
- Replaced return with unreachable call
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/etnaviv
This series enables etnaviv and imx for the android platform.
This is done through updating the Android build scripts.
Rob Herring (3):
gallium: os_process fixes for Android
gbm: add XBGR support for dumb buffers
android: add etnaviv driver build support
Tomeu Vizoso (2):
etnaviv: Ad
From: Rob Herring
Add GBM_FORMAT_XBGR format support which is needed for Android.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
Reviewed-by: Daniel Stone
Reviewed-by: Emil Velikov
---
Changes since v1:
Emil Velikov
- Added commit msg
src/gbm/backends/dri/gbm_dri.c | 2 +-
From: Rob Herring
Add etnaviv to Android makefiles.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
---
Changes since v1:
Tapani Pälli
- Remove copy-pasta
Emil Velikov
- Remove libmesa_loader inclusion
- Remove copy-pasta
- Remove spurious include
- Fix C_SOURCES inc
From: Tomeu Vizoso
Signed-off-by: Tomeu Vizoso
Reviewed-by: Tapani Pälli
---
Changes since v1:
Emil Velikov
- Fix C_SOURCES include
- Fix GALLIUM_LIBS assignment
Android.mk| 5 +++--
src/gallium/Android.mk| 1 +
src/gallium/winsys/imx/drm
From: Tomeu Vizoso
Signed-off-by: Robert Foss
Reviewed-by: Tapani Pälli
---
Chages since v2:
- Rebased on upstream/master
Changes since v1:
Emil Velikov
- Replaced return with unreachable call
src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++
1 file changed, 2 insertions
This series enables etnaviv and imx for the android platform.
This is done through updating the Android build scripts.
Rob Herring (3):
gallium: os_process fixes for Android
gbm: add XBGR support for dumb buffers
android: add etnaviv driver build support
Tomeu Vizoso (2):
etnaviv: Add
From: Rob Herring
Add GBM_FORMAT_XBGR format support which is needed for Android.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
Reviewed-by: Daniel Stone
Reviewed-by: Emil Velikov
---
Changes since v2:
- Rebased on upstream/master
Changes since v1:
Emil Velikov
- Added co
From: Rob Herring
The function getprogname() is available on Android, since it reuses
various BSD solutions C runtime.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
Reviewed-by: Emil Velikov
---
Changes since v2:
- Rebased on upstream/master
Changes since v1:
Emil Velikov
- Ad
From: Rob Herring
Add etnaviv to Android makefiles.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
---
Changes since v2:
- Rebased on upstream/master
Changes since v1:
Tapani Pälli
- Remove copy-pasta
Emil Velikov
- Remove libmesa_loader inclusion
- Remove copy-pasta
From: Tomeu Vizoso
Add Android.mk for winsys/imx/drm.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Tapani Pälli
---
Changes since v2:
- Rebased on upstream/master
- Added commit message
Changes since v1:
Emil Velikov
- Fix C_SOURCES include
- Fix GALLIUM_LIBS assignment
Android.mk
Switch to using strncopy to avoid potential overflow of
name array in struct hud_graph.
Coverity-id: 1413760
Signed-off-by: Robert Foss
---
src/gallium/auxiliary/hud/hud_cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/hud/hud_cpu.c
b/src/gallium
Define the length of the name field of struct hud_graph with
HUD_GRAPH_NAME_LEN.
Signed-off-by: Robert Foss
---
src/gallium/auxiliary/hud/hud_private.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/hud/hud_private.h
b/src/gallium/auxiliary/hud
Switch to using strncopy to avoid potential overflow of
name array in struct hud_graph.
Coverity-id: 1413761
Signed-off-by: Robert Foss
---
src/gallium/auxiliary/hud/hud_cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/hud/hud_cpu.c
b/src/gallium
Switch to using strncopy to avoid potential overflow of
name array in struct hud_graph.
Coverity-id: 1413761
Signed-off-by: Robert Foss
---
src/gallium/auxiliary/hud/hud_cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/hud/hud_cpu.c
b/src/gallium
Define the length of the name field of struct hud_graph with
HUD_GRAPH_NAME_LEN.
Signed-off-by: Robert Foss
---
src/gallium/auxiliary/hud/hud_private.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/hud/hud_private.h
b/src/gallium/auxiliary/hud
Switch to using strncopy to avoid potential overflow of
name array in struct hud_graph.
Coverity-id: 1413760
Signed-off-by: Robert Foss
---
Changes since v1:
Gustaw Smolarczyk
- Fix strcpy -> strncpy typo
src/gallium/auxiliary/hud/hud_cpu.c | 2 +-
1 file changed, 1 insertion(+)
Hey Brian,
On Thu, 2017-06-29 at 07:28 -0600, Brian Paul wrote:
> On 06/29/2017 07:21 AM, Robert Foss wrote:
> > Switch to using strncopy to avoid potential overflow of
> > name array in struct hud_graph.
> >
> > Coverity-id: 1413761
> >
> > Signed-off-by:
On Thu, 2017-06-29 at 15:28 +0100, Emil Velikov wrote:
> On 28 June 2017 at 22:52, Robert Foss
> wrote:
> > From: Tomeu Vizoso
> >
> > Add Android.mk for winsys/imx/drm.
> >
> > Signed-off-by: Tomeu Vizoso
> > Reviewed-by: Tapani Pälli
> &
On Thu, 2017-06-29 at 15:29 +0100, Emil Velikov wrote:
> On 28 June 2017 at 22:52, Robert Foss
> wrote:
> > From: Tomeu Vizoso
> >
> > Signed-off-by: Robert Foss
> > Reviewed-by: Tapani Pälli
>
> Fwiw
> Reviewed-by: Emil Velikov
>
> Any addition
On Thu, 2017-06-29 at 07:28 -0600, Brian Paul wrote:
> On 06/29/2017 07:21 AM, Robert Foss wrote:
> > Switch to using strncopy to avoid potential overflow of
> > name array in struct hud_graph.
> >
> > Coverity-id: 1413761
> >
> > Signed-off-by: Robert Fo
Add strncpy wrapper that makes sure that the string is always ends
with a null byte.
Signed-off-by: Robert Foss
---
Changes since v2:
Brian Paul
- Patch added
src/util/u_string.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/util/u_string.h b/src/util/u_string.h
index
Switch to using util_strncat to avoid potential overflow of
name array in struct hud_graph.
Coverity-id: 1413760
Signed-off-by: Robert Foss
---
Changes since v2:
Brian Paul
- Switch to using new util_strncpy function
Changes since v1:
Gustaw Smolarczyk
- Fix strcpy -> strncpy t
Switch to using util_strncpy to avoid potential overflow of
name array in struct hud_graph.
Also extract the name element length into a define so that it can
be used for strncpy et al.
Coverity-id: 1413761
Signed-off-by: Robert Foss
---
Changes since v2:
Brian Paul
- Combined patch with
On Sun, 2017-07-02 at 21:06 -0700, Matt Turner wrote:
> Otherwise known as strlcpy()?
I didn't realize this, a wrapper would be needed for all platformsou
that don't support it natively.
Do you know which platforms support strlcpy?
Rob.
___
mesa-dev
From: Tomeu Vizoso
Add Android.mk for winsys/imx/drm.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Tapani Pälli
Reviewed-by: Emil Velikov
---
Changes sicne v3:
Emil Velikov
- Add GALLIUM_TARGET_DRIVERS addition
Changes since v2:
- Rebased on upstream/master
- Added commit message
Cha
This series enables etnaviv and imx for the android platform.
This is done through updating the Android build scripts.
Rob Herring (1):
android: add etnaviv driver build support
Tomeu Vizoso (1):
android: build imx-drm winsys
Android.mk| 6 +++--
src/gallium
From: Rob Herring
Add etnaviv to Android makefiles.
Signed-off-by: Rob Herring
Reviewed-by: Tapani Pälli
Reviewed-by: Emil Velikov
---
Changes sicne v3:
Emil Velikov
- Add GALLIUM_TARGET_DRIVERS addition
Changes since v2:
- Rebased on upstream/master
Changes since v1:
Tapani Pälli
Switch to using util_strlcpy to avoid potential overflow of
name array in struct hud_graph.
Also extract the name element length into a define so that it can
be used for strncpy et al.
Coverity-id: 1413761
Signed-off-by: Robert Foss
---
Changes since v3:
Matt Turner
- Switch from
Switch to using util_strlcpy to avoid potential overflow of
name array in struct hud_graph.
Coverity-id: 1413760
Signed-off-by: Robert Foss
---
Changes since v3:
Matt Turner
- Switch from util_strncpy to util_strlcpy
Brian Paul
- Fix comment to mention the correct string copy
Add local strlcpy implementation.
Signed-off-by: Robert Foss
---
Changes since v3:
Matt Turner
- Change name of util_strncpy to util_strlcpy
Changes since v2:
Brian Paul
- Patch added
src/util/u_string.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/util
Add local strlcpy implementation.
Signed-off-by: Robert Foss
---
Changes since v4:
Gustaw Smolarczyk
- Make util_strlcpy have the same behaviour as strlcpy
Changes since v3:
Matt Turner
- Change name of util_strncpy to util_strlcpy
Changes since v2:
Brian Paul
- Patch added
1 - 100 of 266 matches
Mail list logo
