Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-09-04 Thread Olivier Fourdan
Hi Dave, On Thu, Aug 9, 2018 at 8:57 PM Dave Airlie wrote: > Sounds like a missing make current somewhere. Humm, the reproducer does a `glXMakeCurrent(dpy, 0, 0)` prior to destroying the context with `glXDestroyContext()`, removing that call to `glXMakeCurrent(dpy, 0, 0)` avoids the crash but it

Re: [Mesa-dev] [PATCH 2/2] loader/dri3: Don't wait for fence of old buffer when re-allocating it

2018-09-04 Thread Olivier Fourdan
t; ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Both patches are successfully: Tested-by: Olivier Fourdan Cheers, Olivier ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-09-05 Thread Olivier Fourdan
Hi Marek, On Thu, Aug 9, 2018 at 7:27 PM Marek Olšák wrote: > > This will leak the renderbuffer, but that's not the biggest problem. > > In your bug report, you said that the renderbuffer was created by > intel_new_renderbuffer, but this change is for st/mesa. Something is My comment in the bugz

Re: [Mesa-dev] [PATCH v4 1/2] wayland/egl: initialize window surface size to window size

2018-10-25 Thread Olivier Fourdan
Hi, On Tue, Aug 7, 2018 at 5:50 PM Juan A. Suarez Romero wrote: > > When creating a windows surface with eglCreateWindowSurface(), the > width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is > invalid until buffers are updated (like calling glClear()). > > But according to EGL 1.5 s

Re: [Mesa-dev] [PATCH v4 1/2] wayland/egl: initialize window surface size to window size

2018-10-25 Thread Olivier Fourdan
On Thu, Oct 25, 2018 at 12:05 PM Olivier Fourdan wrote: > > Hi, > > On Tue, Aug 7, 2018 at 5:50 PM Juan A. Suarez Romero > wrote: > > > > When creating a windows surface with eglCreateWindowSurface(), the > > width and height returned by eglQuerySurface(EGL_{WI

Re: [Mesa-dev] [PATCH] wayland/egl: Resize EGL surface on update buffer for swrast

2018-10-25 Thread Olivier Fourdan
Oops got the mesa-dev address wrong... On Thu, Oct 25, 2018 at 2:40 PM Olivier Fourdan wrote: > > After commit a9fb331ea ("wayland/egl: update surface size on window > resize"), the surface size is updated as soon as the resize is done, and > `update_buffers()` would resi

[Mesa-dev] [PATCH] wayland/egl: Resize EGL surface on update buffer for swrast

2018-10-25 Thread Olivier Fourdan
win size and not the attached size. Fixes: a9fb331ea - wayland/egl: update surface size on window resize Signed-off-by: Olivier Fourdan CC: Daniel Stone CC: Juan A. Suarez Romero CC: mesa-sta...@lists.freedesktop.org --- Resending because I got the "mesa-dev" address wrong! And a repl

Re: [Mesa-dev] [PATCH] wayland/egl: Resize EGL surface on update buffer for swrast

2018-11-06 Thread Olivier Fourdan
Hi On Thu, Oct 25, 2018 at 5:51 PM Juan A. Suarez Romero wrote: > > On Thu, 2018-10-25 at 14:48 +0200, Olivier Fourdan wrote: > > After commit a9fb331ea ("wayland/egl: update surface size on window > > resize"), the surface size is updated as soon as the resize is d

Re: [Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

2018-07-11 Thread Olivier Fourdan
Hi, On Tue, 10 Jul 2018 at 18:56, Jason Ekstrand wrote: > > Ugh... not so good. According to Oliver on the bug, this just make the > assert go away and doesn't actually fix anything. Likely this is needed but > not sufficient. Well, maybe not even needed, at least in my case I don't hit that

[Mesa-dev] [PATCH] dri3: Do not get supported modifiers on pixmaps

2018-07-25 Thread Olivier Fourdan
dri3_alloc_render_buffer() in which case avoid using get_supported_modifiers() and fallback to the good old pixmap_from_buffer() method as before. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107117 Fixes: 069fdd5 ("egl/x11: Support DRI3 v1.1") Signed-off-by: Olivier Fourdan ---

[Mesa-dev] [PATCH v2] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Olivier Fourdan
ned-off-by: Olivier Fourdan --- v2: Use the root window instead of reverting to pixmap_from_buffer() as suggested by Eric. src/loader/loader_dri3_helper.c | 31 +-- src/loader/loader_dri3_helper.h | 1 + 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/

[Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Olivier Fourdan
ned-off-by: Olivier Fourdan --- v2: Use the root window instead of reverting to pixmap_from_buffer() as suggested by Eric. v3: Much simpler patch, no need to issue an xcb_get_geometry() twice, we already did it in dri3_update_drawable(), just save the root window from there... Sorry for

Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-27 Thread Olivier Fourdan
Hi, On Thu, 26 Jul 2018 at 19:53, Eric Anholt wrote: > > Olivier Fourdan writes: > > > get_supported_modifiers() and pixmap_from_buffers() requests both > > expect a window as drawable, passing a pixmap will fail as the Xserver > > will fail to match the given drawabl

[Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-08-02 Thread Olivier Fourdan
ct st_context *) 0x0 Check for a non-NULL st_context pointer as well to avoid the crash. Bugzilla: https://bugzilla.redhat.com/1611140 Signed-off-by: Olivier Fourdan --- Note: This fixes several bug reported downstream, like: https://bugzilla.redhat.com/1611140 https://bugs.launchpad.net/ubuntu

Re: [Mesa-dev] [PATCH] glx: Demand success from CreateContext requests

2018-08-06 Thread Olivier Fourdan
Hey On Fri, Aug 3, 2018 at 7:44 PM Adam Jackson wrote: > > GLXCreate{,New}Context, like most X resource creation requests, does not > emit a reply and therefore is emitted into the X stream asynchronously. > However, unlike most resource creation requests, the GLXContext we > return is a handle t

Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-08-07 Thread Olivier Fourdan
Hi, On Fri, Aug 3, 2018 at 7:03 PM Aaron Watry wrote: > > Tested-by: Aaron Watry > > Yay, I can finally use gnome/wayland with the Slack snap again without > insta-crashing my session. > > --Aaron > > On Thu, Aug 2, 2018 at 7:29 AM, Olivier Fourdan wrote: >

Re: [Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

2019-07-24 Thread Olivier Fourdan
Hi, On Wed, May 22, 2019 at 4:01 AM Ian Romanick wrote: > > On Thu, Jul 19, 2018 at 12:08 PM andrey simiklit > > > > Jason, can we reconsider Andrii's patch? It still applies cleanly > > (https://patchwork.freedesktop.org/patch/237490/) > > Looking at the patch and the "Simple reproducer" in the

Re: [Mesa-dev] [PATCH] i965/tex: ignore the diff between GL_TEXTURE_2D and GL_TEXTURE_RECTANGLE

2019-05-21 Thread Olivier Fourdan
Hi all, On Thu, Jul 19, 2018 at 12:08 PM andrey simiklit wrote: > > Ugh... not so good. According to Oliver on the bug, this just make the > > assert go away and doesn't actually fix anything. Likely this is needed > > but not sufficient. > > So as far as I understand Oliver found the bad com