Re: [Mesa-dev] [PATCH] util/radv/adv: move *_get_function_timestamp() to utils

2017-02-10 Thread Nils Wallménius
Hi Tim, one comment below BR Nils Den 10 feb. 2017 3:03 fm skrev "Timothy Arceri" : --- src/amd/vulkan/radv_device.c | 22 +++--- src/intel/vulkan/anv_device.c | 20 ++-- src/util/disk_cache.h | 17 + 3 files changed, 22 insertions(+), 3

[Mesa-dev] [PATCH] main: memcpy larger chunks in _mesa_propagate_uniforms_to_driver_storage

2016-07-13 Thread Nils Wallménius
Radeon R9 380. Piglit hangs randomly on this system both with and without the patch so i could not make a comparison. Signed-off-by: Nils Wallménius --- src/mesa/main/uniform_query.cpp | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH] main: memcpy larger chunks in _mesa_propagate_uniforms_to_driver_storage

2016-07-14 Thread Nils Wallménius
Den 13 juli 2016 9:48 em skrev "Kenneth Graunke" : > > On Wednesday, July 13, 2016 1:53:26 PM PDT Nils Wallménius wrote: > > When possible, do the memcpy on larger blocks. This reduces cycles > > spent in _mesa_propagate_uniforms_to_driver_storage from > >

[Mesa-dev] [PATCH v2] main: memcpy larger chunks in _mesa_propagate_uniforms_to_driver_storage

2016-07-22 Thread Nils Wallménius
Radeon R9 380. Piglit hangs randomly on this system both with and without the patch so i could not make a comparison. v2: fixed whitespace Signed-off-by: Nils Wallménius Reviewed-by: Nicolai Hähnle --- src/mesa/main/uniform_query.cpp | 29 +++-- 1 file changed, 23

[Mesa-dev] [PATCH] st/mesa: mark constant array of swizzles as static const

2015-01-22 Thread Nils Wallménius
This saves about 0.5k in the text section for a gallium driver on amd64. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 2ed7a3b..f1131d

Re: [Mesa-dev] [PATCH 1/2] amd/addrlib: import Raven support

2017-05-10 Thread Nils Wallménius
Hi Marek, A comment below Den 10 maj 2017 20:29 skrev "Marek Olšák" : From: Marek Olšák Cc: 17.1 Reviewed-by: Alex Deucher Reviewed-by: Nicolai Hähnle --- src/amd/addrlib/gfx9/gfx9addrlib.cpp | 57 ++ ++ src/amd/addrlib/gfx9/gfx9addrlib.h | 8 +++-- src/a

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Nils Wallménius
Hi Samuel, A comment below. Den 17 maj 2017 11:18 fm skrev "Samuel Pitoiset" : RadeonSI needs to do a special lowering for Gather4 with integer formats, but with bindless samplers we just can't access the index. Instead, store the return type in the instruction like the target. Signed-off-by:

Re: [Mesa-dev] [PATCH 13/15] radeon: remove duplicate 'const' specifier

2017-04-11 Thread Nils Wallménius
Den 11 apr. 2017 20:00 skrev "Samuel Pitoiset" : Fixes the following Clang warning. In file included from radeon_debug.c:32: ./radeon_common_context.h:500:19: warning: duplicate 'const' declaration specifier [-Wduplicate-decl-specifier] extern const char const *radeonVendorString; Signed-off-by:

Re: [Mesa-dev] [PATCH v2 3/4] mesa: move glMultiDrawArrays to vbo and fix error handling

2017-04-14 Thread Nils Wallménius
Den 13 apr. 2017 9:29 em skrev "Nicolai Hähnle" : From: Nicolai Hähnle When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. v2: - provide the function in all contexts, including GLES - adjust validation accordingly to include the xfb check --

Re: [Mesa-dev] [PATCH v2 3/4] mesa: move glMultiDrawArrays to vbo and fix error handling

2017-04-15 Thread Nils Wallménius
Hi Nicolai, Re-replying as I seem to have messed up the quoting. Anyway a question about a loop index below. Den 13 apr. 2017 21:29 skrev "Nicolai Hähnle" : From: Nicolai Hähnle [snip] +/** + * Called to error check the function parameters. + * + * Note that glMultiDrawArrays is not part of

Re: [Mesa-dev] [PATCH 02/20] nir: clarify some nit_loop_info member names

2018-12-09 Thread Nils Wallménius
Den lör 8 dec. 2018 00:10 skrev Jason Ekstrand : > Replacing min with max without changing any real code always looks a biit > weird but it does make sense. :-) > > Reviewed-by: Jason Ekstrand > > On Thu, Dec 6, 2018 at 9:08 PM Timothy Arceri > wrote: > >> Following commits will introduce additi

Re: [Mesa-dev] [PATCH 06/16] nir: improve convert_yuv_to_rgb when fuse_ffma=true

2018-12-19 Thread Nils Wallménius
Den ons 19 dec. 2018 17:44 skrev Jonathan Marek : > When ffma is available, we can use a different arrangement of constants to > get a better result. On freedreno/ir3, this reduces the YUV->RGB to 7 > scalar ffma. On freedreno/a2xx, it will allow YUV->RGB to be 3 vec4 ffma. > > Signed-off-by: Jona

Re: [Mesa-dev] [PATCH 3/2] intel/nir: Call nir_lower_io_to_scalar_early

2018-07-31 Thread Nils Wallménius
Hi, sorry for the drive-by but a comment in line below Den tis 31 juli 2018 16:09Jason Ekstrand skrev: > Shader-db results on Kaby Lake: > > total instructions in shared programs: 15166953 -> 15073611 (-0.62%) > instructions in affected programs: 2390284 -> 2296942 (-3.91%) > helped:

Re: [Mesa-dev] [PATCH 4/4] radv: implement VK_AMD_shader_core_properties

2018-04-06 Thread Nils Wallménius
Hi Samuel, a question below Den fre 6 apr. 2018 14:28Samuel Pitoiset skrev: > Simple extension that only returns information for AMD hw. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 71 > +++ > src/amd/vulkan/radv_extensions