[Mesa-dev] [PATCH v4 06/18] anv/cmd_buffer: Don't partially fast clear image layers

v2: Don't pass in the command buffer (Jason Ekstrand). v3: Remove an incorrect assertion and an if condition for gen7. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH v4 02/18] intel/isl: Add surface state clear value information

This will be used to load and store clear values from surface state objects. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 + src/intel/isl/isl.h | 4 2 files changed, 13 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 12ffe3bb51..cad736dd56

[Mesa-dev] [PATCH v4 07/18] anv/cmd_buffer: Restrict fast clears in the GENERAL layout

v2: Remove ::first_subpass_layout assertion (Jason Ekstrand). v3: Allow some fast clears in the GENERAL layout. v4: Remove extra '||' and adjust line break (Jason Ekstrand). Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 22 ++ src/in

[Mesa-dev] [PATCH v4 05/18] anv/cmd_buffer: Initialize the clear values buffer

v2: Rewrite functions. v3 (Jason Ekstrand): - Don't set ResourceMinLOD. - Fix clamp of level_count. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/src/intel/v

[Mesa-dev] [PATCH v4 08/18] anv/gpu_memcpy: Add a lighter-weight GPU memcpy function

irect drawing register as TEMP_REG (Jason Ekstrand). Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_genX.h| 5 + src/intel/vulkan/genX_gpu_memcpy.c | 40 ++ 2 files changed, 45 insertions(+) diff --git a/src/intel/vulkan/anv_genX.h b/src/intel/v

[Mesa-dev] [PATCH v4 12/18] anv/cmd_buffer: Move aux_usage assignment up

For readability, bring the assignment of CCS closer to the assignment of NONE and MCS. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 62 ++ 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/src/intel/vulkan

[Mesa-dev] [PATCH v4 13/18] anv/cmd_buffer: Warn about not enabling CCS_E

Use the performance warning infrastructure to provide helpful information when testing applications. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src

[Mesa-dev] [PATCH v4 09/18] anv/cmd_buffer: Ensure fast-clear values are current

v2: Rewrite functions, change location of synchronization. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 114 + 1 file changed, 114 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH v4 15/18] anv: Stop resolving CCS implicitly

With an earlier patch from this series, resolves are additionally performed on layout transitions. Remove the now unnecessary implicit resolves within render passes. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 150 ++--- src/intel/vulkan

[Mesa-dev] [PATCH v4 10/18] anv/cmd_buffer: Disable CCS on gen7 color attachments upfront

The next patch enables the use of CCS_D even when the color attachment will not be fast-cleared. Catch the gen7 case early to simplify the changes required. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions

[Mesa-dev] [PATCH v4 11/18] anv/cmd_buffer: Always enable CCS_D in render passes

The lifespan of the fast-clear data will surpass the render pass scope. We need CCS_D to be enabled in order to invalidate blocks previously marked as cleared and to sample cleared data correctly. v2: Avoid refactoring. v3: Allow CCS_D for subpass resolves. Signed-off-by: Nanley Chery --- src

[Mesa-dev] [PATCH v4 16/18] anv/cmd_buffer: Skip some input attachment transitions

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 7b2a3551b6..611e77bddb 100644 --- a/src/intel

[Mesa-dev] [PATCH v4 14/18] anv: Transition more color buffer layouts

v2: Expound on comment for the pipe controls (Jason Ekstrand). v3: - Cast base_layer to uint64_t to avoid overflow. - Remove "seems" from the pipe control comment. - Fix clamp of layer_count (Jason Ekstrand). Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 4 +-

[Mesa-dev] [PATCH v4 17/18] intel/blorp: Allow BLORP calls to be predicated

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 3 +++ src/intel/blorp/blorp_genX_exec.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index d5226c2248..1e96fb42b0 100644 --- a/src/intel/blorp/blorp.h +++ b/src/intel

[Mesa-dev] [PATCH v4 18/18] anv: Predicate fast-clear resolves

function (Jason Ekstrand). - Enable easy retrieval of fast clear state fields. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 3 +- src/intel/vulkan/anv_private.h | 13 ++-- src/intel/vulkan/genX_cmd_buffer.c | 120 + 3 files changed

Re: [Mesa-dev] [PATCH v4 00/18] anv: Do CCS resolves at layout transitions

On Wed, Jul 19, 2017 at 02:21:52PM -0700, Nanley Chery wrote: > In this revision: > * review feedback is incorporated. > * a couple of bugs caught by a new dEQP version are fixed: > - image data could be lost if CCS_D wasn't enabled in render passes > before we started d

Re: [Mesa-dev] [PATCH v4 11/18] anv/cmd_buffer: Always enable CCS_D in render passes

On Fri, Jul 21, 2017 at 03:43:20PM -0700, Jason Ekstrand wrote: > On Wed, Jul 19, 2017 at 2:22 PM, Nanley Chery wrote: > > > The lifespan of the fast-clear data will surpass the render pass scope. > > We need CCS_D to be enabled in order to invalidate blocks previously > &g

Re: [Mesa-dev] [PATCH v4 18/18] anv: Predicate fast-clear resolves

On Fri, Jul 21, 2017 at 03:56:05PM -0700, Jason Ekstrand wrote: > On Wed, Jul 19, 2017 at 2:22 PM, Nanley Chery wrote: > > > Image layouts only let us know that an image *may* be fast-cleared. For > > this reason we can end up with redundant resolves. Testing has shown > >

Re: [Mesa-dev] [PATCH v4 01/18] anv: Transition MCS buffers from the undefined layout

On Fri, Jul 28, 2017 at 09:28:45AM +0100, Lionel Landwerlin wrote: > On 19/07/17 22:21, Nanley Chery wrote: > > Cc: > > Suggested-by: Jason Ekstrand > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_blorp.c | 8 > >

Re: [Mesa-dev] [PATCH v4 01/18] anv: Transition MCS buffers from the undefined layout

On Fri, Jul 28, 2017 at 05:33:53PM +0100, Lionel Landwerlin wrote: > On 28/07/17 17:21, Nanley Chery wrote: > > On Fri, Jul 28, 2017 at 09:28:45AM +0100, Lionel Landwerlin wrote: > > > On 19/07/17 22:21, Nanley Chery wrote: > > > > Cc: > > > > Suggested

Re: [Mesa-dev] [PATCH] intel/isl: Tighten up restrictions for CCS on gen7

On Sat, Jul 22, 2017 at 04:54:24PM -0700, Jason Ekstrand wrote: > It may technically be possible to enable some sort of fast-clear support > for at least the base slice of a 2D array texture on gen7. However, > it's not documented to work, we've never tried to do it in GL, and we > have no idea wh

Re: [Mesa-dev] [PATCH] intel/isl: Tighten up restrictions for CCS on gen7

On Mon, Jul 31, 2017 at 01:03:38PM -0700, Jason Ekstrand wrote: > On Mon, Jul 31, 2017 at 12:11 PM, Nanley Chery > wrote: > > > On Sat, Jul 22, 2017 at 04:54:24PM -0700, Jason Ekstrand wrote: > > > It may technically be possible to enable some sort of fast-clear suppor

[Mesa-dev] [PATCH 00/22] anv: Move CCS resolves to layout transitions

run three times at 1080p in release mode. Six tests in dEQP-VK.geometry.layered.3d.* now fail, but I've attributed the failures to a test bug and filed a bug report. Cc: Jason Ekstrand Nanley Chery (22): intel/isl: Limit CCS to one subresource on gen7 intel/isl: Only create

[Mesa-dev] [PATCH 02/22] intel/isl: Only create a CCS buffer if the image supports rendering

This prevents assertion failures when initializing the clear value buffer on images with the E5B9G9R9 format. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index ce5b35c47c

[Mesa-dev] [PATCH 06/22] anv/image: Remove incorrect assertion in anv_BindImage

According to the Linux kernel sources, the ioctl in anv_gem_mmap() will not fail if the size isn't a multiple of 4KB. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/

[Mesa-dev] [PATCH 01/22] intel/isl: Limit CCS to one subresource on gen7

Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index f89f351c15..ce5b35c47c 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1610,14 +1610,19

[Mesa-dev] [PATCH 04/22] anv: Add color auxiliary buffer helpers

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index dbe1e0475e..ac71537e88 100644 --- a/src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH 05/22] anv/image: Append CCS/MCS with a clear value buffer

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 67 1 file changed, 67 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index cf34dbe3b0..8d946e8e93 100644 --- a/src/intel/vulkan/anv_image.c +++ b

[Mesa-dev] [PATCH 13/22] blorp/clear: Add a binding-table-based CCS resolve function

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 9 ++ src/intel/blorp/blorp_clear.c | 64 --- 2 files changed, 57 insertions(+), 16 deletions(-) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index eab75d70ab

[Mesa-dev] [PATCH 17/22] anv: Add anv_get_sliceCount()

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 667176270a..819fbea567 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH 10/22] anv/cmd_buffer: Disable fast clears in the GENERAL layout

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 22 ++ src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/genX_cmd_buffer.c | 20 ++-- 3 files changed, 37 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b

[Mesa-dev] [PATCH 11/22] anv/cmd_buffer: Ensure the fast clear values are correct

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index e3b1687121..4698270abb 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 14/22] anv/blorp: Add a surface-state-based CCS resolve function

This will be used in conjunction with the buffer of clear values. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 41 + src/intel/vulkan/anv_private.h | 6 ++ 2 files changed, 47 insertions(+) diff --git a/src/intel/vulkan

[Mesa-dev] [PATCH 16/22] anv/cmd_buffer: Add transition_color_buffer()

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 93 ++ 1 file changed, 93 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index d5cc358aec..1ae0c3256e 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 12/22] anv/gpu_memcpy: Add a lighter-weight memcpy path

We're now performing a GPU memcpy in more places to copy small amounts of data. Add a path to thrash less state. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_gpu_memcpy.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/intel/v

[Mesa-dev] [PATCH 15/22] anv/cmd_buffer: Adjust the image view reloc function

Make the function take in an image instead of an image view. This enables us to record relocations for surfaces states created outside of the anv_CreateImageView path. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 45 +- 1 file changed

[Mesa-dev] [PATCH 08/22] anv/cmd_buffer: Always enable CCS_D in render passes

The lifespan of the fast-clear data will surpass the render pass scope. We need CCS_D to be enabled in order to invalidate blocks previously marked as cleared and to sample cleared data correctly. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 15 ++ src/intel/vulkan

[Mesa-dev] [PATCH 03/22] intel/isl: Add surface state clear value information

This will be used to load and store clear values from surface state objects. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 + src/intel/isl/isl.h | 4 2 files changed, 13 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index ff3e2fb86d..a3e91b2688

[Mesa-dev] [PATCH 21/22] intel/blorp: Allow BLORP calls to be predicated

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 3 +++ src/intel/blorp/blorp_genX_exec.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index 8b8227bb1c..36acbb8222 100644 --- a/src/intel/blorp/blorp.h +++ b/src/intel

[Mesa-dev] [PATCH 19/22] anv/blorp: Stop resolving CCS implicitly

With the previous patch, resolves are additionally performed on layout transitions. Remove the now unnecessary implicit resolves within render passes. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 139 --- 1 file changed, 139 deletions

[Mesa-dev] [PATCH 18/22] anv/cmd_buffer: Perform color buffer layout transitions

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 65 ++ 1 file changed, 52 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 1ae0c3256e..95729ec8a8 100644 --- a/src

[Mesa-dev] [PATCH 09/22] anv/cmd_buffer: Don't partially fast-clear image layers

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 0ea378fde2..a981b00f67 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 20/22] anv/pass: Get rid of anv_subpass_usage

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 14 -- src/intel/vulkan/anv_private.h | 10 -- 2 files changed, 24 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 02b8f03fa5..de279d9d64 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 22/22] anv: Predicate fast-clear resolves

There's no image layout to represent a full-RT-cleared color attachment. That's one reason we can end up with redundant resolves. Testing has shown that such resolves can measurably hurt performance and that predicating them can avoid the penalty. Signed-off-by: Nanley Chery ---

[Mesa-dev] [PATCH 07/22] anv/image: Initialize the clear values buffer

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 75 +++--- src/intel/vulkan/anv_private.h | 5 +++ 2 files changed, 69 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 9f3eb52a37

Re: [Mesa-dev] [PATCH 02/21] anv/cmd_buffer: Use the device allocator for QueueSubmit

On Fri, Apr 14, 2017 at 10:37:49AM -0700, Jason Ekstrand wrote: > The command is really operating on a Queue not a command buffer and the > nearest object to that with an allocator is VkDevice. > > Cc: "17.0" Should this have been Cc'ed to mesa-stable instead of mesa-dev? ___

Re: [Mesa-dev] [PATCH 18/22] anv/cmd_buffer: Perform color buffer layout transitions

On Thu, Apr 27, 2017 at 11:32:17AM -0700, Nanley Chery wrote: > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/genX_cmd_buffer.c | 65 > ++ > 1 file changed, 52 insertions(+), 13 deletions(-) > > diff --git a/src/intel/vulkan/genX_

Re: [Mesa-dev] [PATCH 08/22] anv/cmd_buffer: Always enable CCS_D in render passes

On Tue, May 02, 2017 at 04:15:42PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > The lifespan of the fast-clear data will surpass the render pass scope. > > We need CCS_D to be enabled in order to invalidate blocks previously

Re: [Mesa-dev] [PATCH 09/22] anv/cmd_buffer: Don't partially fast-clear image layers

On Tue, May 02, 2017 at 04:25:42PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 18 +++--- > > 1 file changed, 15 insertion

Re: [Mesa-dev] [PATCH 10/22] anv/cmd_buffer: Disable fast clears in the GENERAL layout

On Tue, May 02, 2017 at 04:44:49PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_pass.c| 22 ++ > > src/intel/vulkan/anv_pr

Re: [Mesa-dev] [PATCH 11/22] anv/cmd_buffer: Ensure the fast clear values are correct

On Tue, May 02, 2017 at 04:54:55PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 76 ++ > > &

Re: [Mesa-dev] [PATCH 13/22] blorp/clear: Add a binding-table-based CCS resolve function

On Tue, May 02, 2017 at 05:01:23PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/blorp/blorp.h | 9 ++ > > s

Re: [Mesa-dev] [PATCH 15/22] anv/cmd_buffer: Adjust the image view reloc function

On Tue, May 02, 2017 at 05:15:46PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Make the function take in an image instead of an image view. This > > enables us to record relocations for surfaces states creat

Re: [Mesa-dev] [PATCH 16/22] anv/cmd_buffer: Add transition_color_buffer()

On Wed, May 03, 2017 at 02:24:19PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 93 ++ > > &

Re: [Mesa-dev] [PATCH 16/22] anv/cmd_buffer: Add transition_color_buffer()

On Wed, May 10, 2017 at 12:38:50PM -0700, Jason Ekstrand wrote: > On Wed, May 10, 2017 at 11:30 AM, Nanley Chery > wrote: > > > On Wed, May 03, 2017 at 02:24:19PM -0700, Jason Ekstrand wrote: > > > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > > > wrote: &g

Re: [Mesa-dev] [RFC] intel/isl: Rewrite gen7_choose_image_alignment_el

On Wed, May 10, 2017 at 09:14:06PM +0300, Pohjolainen, Topi wrote: > On Tue, May 09, 2017 at 10:00:34AM -0700, Jason Ekstrand wrote: > > The Ivy Bridge PRM provides a nice table that handles most of the > > alignment cases in one place. For standard color buffers we have a > > little freedom of ch

Re: [Mesa-dev] [PATCH 16/22] anv/cmd_buffer: Add transition_color_buffer()

On Wed, May 10, 2017 at 02:00:19PM -0700, Jason Ekstrand wrote: > On Wed, May 10, 2017 at 1:35 PM, Nanley Chery wrote: > > > On Wed, May 10, 2017 at 12:38:50PM -0700, Jason Ekstrand wrote: > > > On Wed, May 10, 2017 at 11:30 AM, Nanley Chery > > > wrote: > >

Re: [Mesa-dev] [PATCH 14/22] anv/blorp: Add a surface-state-based CCS resolve function

On Tue, May 02, 2017 at 05:04:05PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > This will be used in conjunction with the buffer of clear values. > > > > Signed-off-by: Nanley Chery > > --- > &g

Re: [Mesa-dev] [PATCH 22/22] anv: Predicate fast-clear resolves

On Wed, May 03, 2017 at 03:39:51PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > There's no image layout to represent a full-RT-cleared color attachment. > > That's one reason we can end up with redundant resolves.

Re: [Mesa-dev] [PATCH 12/22] anv/gpu_memcpy: Add a lighter-weight memcpy path

On Tue, May 02, 2017 at 04:58:15PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > We're now performing a GPU memcpy in more places to copy small amounts > > of data. Add a path to thrash less state. > >

Re: [Mesa-dev] [PATCH 09/22] anv/cmd_buffer: Don't partially fast-clear image layers

On Tue, May 02, 2017 at 05:23:49PM -0700, Jason Ekstrand wrote: > On Tue, May 2, 2017 at 4:37 PM, Nanley Chery wrote: > > > On Tue, May 02, 2017 at 04:25:42PM -0700, Jason Ekstrand wrote: > > > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > > > wrote: > > &

Re: [Mesa-dev] [PATCH 04/22] anv: Add color auxiliary buffer helpers

On Tue, May 02, 2017 at 02:54:07PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_private.h | 42 ++ > > &

Re: [Mesa-dev] [PATCH 01/22] intel/isl: Limit CCS to one subresource on gen7

On Tue, May 02, 2017 at 02:48:09PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/isl/isl.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) &

Re: [Mesa-dev] [PATCH 07/22] anv/image: Initialize the clear values buffer

On Tue, May 02, 2017 at 04:03:36PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_image.c | 75 ++ > > +--- > &g

Re: [Mesa-dev] [PATCH 09/22] anv/cmd_buffer: Don't partially fast-clear image layers

On Thu, May 11, 2017 at 11:17:20AM -0700, Jason Ekstrand wrote: > On Thu, May 11, 2017 at 10:13 AM, Nanley Chery > wrote: > > > On Tue, May 02, 2017 at 05:23:49PM -0700, Jason Ekstrand wrote: > > > On Tue, May 2, 2017 at 4:37 PM, Nanley Chery > > wrote: > >

[Mesa-dev] [PATCH 01/24] intel/blorp: Assert on subresource in surface_info_init

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp.c b/src/intel/blorp/blorp.c index 9834275529..e972f721d0 100644 --- a/src/intel/blorp/blorp.c +++ b/src/intel/blorp/blorp.c @@ -66,6 +66,8

[Mesa-dev] [PATCH 03/24] intel/isl: Limit CCS to one subresource on gen7

Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index f89f351c15..ce5b35c47c 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1610,14 +1610,19

[Mesa-dev] [PATCH 02/24] intel/blorp: Assert on gen7 fast-cleared subresource

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp_clear.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index a9eb6b95e4..c72d3291c7 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src/intel/blorp/blorp_clear.c

[Mesa-dev] [PATCH 06/24] anv: Add color auxiliary buffer helpers

v2 (Jason Ekstrand): - Check for aux levels in layer helper Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 49 ++ 1 file changed, 49 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index

[Mesa-dev] [PATCH 04/24] intel/isl: Only create a CCS buffer if the image supports rendering

This prevents assertion failures when initializing the clear value buffer on images with the E5B9G9R9 format. Reviewed-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl

[Mesa-dev] [PATCH 07/24] anv/image: Append CCS/MCS with a clear value buffer

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 67 1 file changed, 67 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index d21e055f02..30cdfdb0e5 100644 --- a/src/intel/vulkan/anv_image.c +++ b

[Mesa-dev] [PATCH 08/24] anv/image: Remove incorrect assertion in anv_BindImage

According to the Linux kernel sources, the ioctl in anv_gem_mmap() will not fail if the size isn't a multiple of 4KB. Reviewed-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 11/24] anv/cmd_buffer: Don't partially fast-clear image layers

v2 (Jason Ekstrand): - Don't pass in the command buffer Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buf

[Mesa-dev] [PATCH 10/24] anv/cmd_buffer: Always enable CCS_D in render passes

The lifespan of the fast-clear data will surpass the render pass scope. We need CCS_D to be enabled in order to invalidate blocks previously marked as cleared and to sample cleared data correctly. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 15 ++ src/intel/vulkan

[Mesa-dev] [PATCH 12/24] anv/cmd_buffer: Disable fast clears in the GENERAL layout

v2 (Jason Ekstrand): - Initialize ::first_subpass_layout instead of asserting Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 22 ++ src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/genX_cmd_buffer.c | 10 -- 3 files changed, 31

[Mesa-dev] [PATCH 13/24] anv/gpu_memcpy: Rename the gpu_memcpy function

We'll be adding another memcpy function in the next commit. Provide more detail into how this one operates. Suggested-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_genX.h| 8 src/intel/vulkan/genX_cmd_buffer.c | 6 +++--- src/intel/v

[Mesa-dev] [PATCH 18/24] anv/cmd_buffer: Adjust the image view reloc function

Make the function take in an image instead of an image view. This enables us to record relocations for surfaces states created outside of the anv_CreateImageView path. v2 (Jason Ekstrand): - Use image->offset instead of surf_offset in aux_offset calculation. Signed-off-by: Nanley Chery ---

[Mesa-dev] [PATCH 09/24] anv/image: Initialize the clear values buffer

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 71 -- src/intel/vulkan/anv_private.h | 5 +++ 2 files changed, 67 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 6b6cc324b3

[Mesa-dev] [PATCH 23/24] intel/blorp: Allow BLORP calls to be predicated

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 3 +++ src/intel/blorp/blorp_genX_exec.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index 661e0380fd..de68fabc11 100644 --- a/src/intel/blorp/blorp.h +++ b/src/intel

[Mesa-dev] [PATCH 20/24] anv/cmd_buffer: Perform color buffer layout transitions

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 65 ++ 1 file changed, 52 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 5adf08b798..b49b80e6c9 100644 --- a/src

[Mesa-dev] [PATCH 14/24] anv/gpu_memcpy: Add a lighter-weight memcpy path

We'll be performing a GPU memcpy in more places to copy small amounts of data. Add a path that thrashes less state. v2: - Make a new function (Jason Ekstrand) - Move the #define into the function Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_genX.h| 5 + src/intel/v

[Mesa-dev] [PATCH 05/24] intel/isl: Add surface state clear value information

This will be used to load and store clear values from surface state objects. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 + src/intel/isl/isl.h | 4 2 files changed, 13 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index ff3e2fb86d..a3e91b2688

[Mesa-dev] [PATCH 19/24] anv/cmd_buffer: Add transition_color_buffer()

v2 (Jason Ekstrand): - Provide a more detailed comment for the CCS pipe controls Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 103 + 1 file changed, 103 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan

[Mesa-dev] [PATCH 17/24] anv/blorp: Add a surface-state-based CCS resolve function

This will be used in conjunction with the buffer of clear values. v2 (Jason Ekstrand): - Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 40 src/intel/vulkan/anv_private.h | 6 ++ 2 files

[Mesa-dev] [PATCH 24/24] anv: Predicate fast-clear resolves

There's no image layout to represent a full-RT-cleared color attachment. That's one reason we can end up with redundant resolves. Testing has shown that such resolves can measurably hurt performance and that predicating them can avoid the penalty. Signed-off-by: Nanley Chery ---

[Mesa-dev] [PATCH 15/24] anv/cmd_buffer: Ensure the fast clear values are correct

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 935cee34c1..6e993ed276 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 22/24] anv/pass: Get rid of anv_subpass_usage

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 14 -- src/intel/vulkan/anv_private.h | 10 -- 2 files changed, 24 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index bb7ee45098..597939ab66 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 16/24] blorp/clear: Add a binding-table-based CCS resolve function

v2 (Jason Ekstrand): - Replace "bt" suffix with "attachment." - Rename helper function to prepare_ccs_resolve. - Move blorp_params_init() into helper function. Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 9 +++ src/intel/blor

[Mesa-dev] [PATCH 21/24] anv/blorp: Stop resolving CCS implicitly

With the previous patch, resolves are additionally performed on layout transitions. Remove the now unnecessary implicit resolves within render passes. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 139 --- 1 file changed, 139 deletions

Re: [Mesa-dev] [PATCH 01/24] intel/blorp: Assert on subresource in surface_info_init

Forgot to add the V2 tag to this series. Sorry about that. -Nanley ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] i965/formats: Update the RGB_DXT1 mappings

The DXT1_RGB* format does not provide the correct behavior for OpenGL in the case where color_0 <= color_1. BC1_RGB_UNORM with a alpha set to 1 provides the behavior which matches the spec. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100925 Cc: Signed-off-by: Nanley Chery ---

[Mesa-dev] [PATCH 1/2] anv/formats: Update the BC1_RGB mappings

The DXT1_RGB* format does not provide the correct behavior for Vulkan in the case where color_0 <= color_1. BC1_RGB_UNORM with a alpha set to 1 provides the behavior which matches the spec. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100925 Cc: Signed-off-by: Nanley Chery ---

Re: [Mesa-dev] [PATCH 2/2] i965/formats: Update the RGB_DXT1 mappings

On Fri, May 12, 2017 at 08:39:40AM -0700, Kenneth Graunke wrote: > On Thursday, May 11, 2017 4:46:27 PM PDT Nanley Chery wrote: > > The DXT1_RGB* format does not provide the correct behavior for OpenGL in > > the case where color_0 <= color_1. BC1_RGB_UNORM with a alpha set to

[Mesa-dev] [PATCH v2 1/2] anv/formats: Update the three-channel BC1 mappings

set to 1 to provide the behavior required by the spec. v2 (Kenneth Graunke): - Provide a more detailed commit message. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100925 Cc: Reviewed-by: Kenneth Graunke (v1) Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_formats.c | 4 ++-- 1

[Mesa-dev] [PATCH v2 2/2] i965/formats: Update the three-channel DXT1 mappings

avior required by the spec. Note that the alpha is already set to 1 for RGB formats in brw_get_texture_swizzle(). v2 (Kenneth Graunke): - Provide a more detailed commit message. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100925 Cc: Acked-by: Tapani Pälli (v1) Reviewed-by: Kenneth Gra

Re: [Mesa-dev] [PATCH v2 2/2] i965/formats: Update the three-channel DXT1 mappings

On Fri, May 12, 2017 at 01:33:54PM -0700, Nanley Chery wrote: > The procedure for decompressing an opaque DXT1 OpenGL format is > dependant on the comparison of two colors stored in the first 32 bits of > the compressed block. Here's the specified OpenGL behavior for > reference

[Mesa-dev] [PATCH v3 1/2] anv/formats: Update the three-channel BC1 mappings

set to 1 to provide the behavior required by the spec. v2 (Kenneth Graunke): - Provide a more detailed commit message. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100925 Cc: Reviewed-by: Kenneth Graunke (v1) Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_formats.c | 4 ++-- 1

[Mesa-dev] [PATCH v3 2/2] i965/formats: Update the three-channel DXT1 mappings

Cc: Acked-by: Tapani Pälli (v1) Reviewed-by: Kenneth Graunke (v1) Signed-off-by: Nanley Chery --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 15 ++- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 4 +++- 2 files changed, 5 insertions(+), 14 deletions(-) diff -

Re: [Mesa-dev] [PATCH 11/43] intel/gensml: Suffix KSP0 fields on Iron Lake

The title says gensml instead of genxml. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/14] anv/cmd_buffer: Advance the address when initializing clear colors

On Mon, Nov 13, 2017 at 08:12:41AM -0800, Jason Ekstrand wrote: > Found by inspection > Good catch. > Cc: mesa-sta...@lists.freedesktop.org > --- > src/intel/vulkan/genX_cmd_buffer.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buf

<    3   4   5   6   7   8   9   10   11   12   >