[Mesa-dev] Fwd: [PATCH] Fixed memory leak.

2013-11-26 Thread Mario Rugiero
Sorry, I accidentally sent my mail to Alex instead of the list. -- Forwarded message -- From: Mario Rugiero Date: 2013/11/26 Subject: Re: [Mesa-dev] [PATCH] Fixed memory leak. To: Alex Deucher Hi, I'm an outsider (for everyone who might have not noticed), I started foll

Re: [Mesa-dev] [PATCH] radeonsi: Remove some stale XXX / FIXME comments

2013-12-04 Thread Mario Rugiero
May I ask if those fixmes are actually fixed? Otherwise, wouldn't it be wiser to keep them pointing out this problems? 2013/12/4 Alex Deucher > On Tue, Dec 3, 2013 at 11:38 PM, Michel Dänzer wrote: > > From: Michel Dänzer > > > > Signed-off-by: Michel Dänzer > > Reviewed-by: Alex Deucher >

Re: [Mesa-dev] [PATCH] radeonsi: Remove some stale XXX / FIXME comments

2013-12-04 Thread Mario Rugiero
Oh, OK then. I thought they maybe were there for a reason other than having used the other driver as a base. 2013/12/4 Alex Deucher > On Wed, Dec 4, 2013 at 11:20 AM, Mario Rugiero wrote: > > May I ask if those fixmes are actually fixed? Otherwise, wouldn't it be > >

Re: [Mesa-dev] [PATCH 6/9] glsl: implement mid3 built-in function

2013-12-10 Thread Mario Rugiero
Why not computing the max3(min(x,y),min(x,z),min(y,z))? For the six possible cases: x < y < z --> max(x, x, y) -> y ==> works x < z < y --> max(x, z, z) -> z ==> works y < x < z --> max(y, x, y) -> x ==> works y < z < x --> max(y, z, y) -> z ==> works z < x < y --> max(x, z, z) -> x ==> works z <