This flag is typically used to request pinned host memory, to avoid
any copies between GPU and CPU.
This improves throughput with an older OpenCL app which I unfortunately
can't publish due to its licensing.
---
src/gallium/state_trackers/clover/core/resource.cpp | 4
1 file changed, 4 inser
On 23.05.2015 15:53, Francisco Jerez wrote:
>> diff --git a/src/gallium/state_trackers/clover/core/resource.cpp
>> b/src/gallium/state_trackers/clover/core/resource.cpp
>> index 8ed4c42..8e51b3c 100644
>> --- a/src/gallium/state_trackers/clover/core/resource.cpp
>> +++ b/src/gallium/state_trackers
same issues as SI? We should really
try to figure out what's wrong with tiled DMA copies.
Anyway,
Reviewed-by: Grigori Goronzy
> Signed-off-by: Michel Dänzer
> ---
> src/gallium/drivers/radeonsi/Makefile.sources | 1 +
> src/gallium/drivers/radeonsi/cik_sdma.c | 364
Wrap MapBuffer and MapImage as hard_event actions, like other
operations. This enables correct profiling. Also make sure to wait
for events to finish when blocking is requested by the caller.
---
src/gallium/state_trackers/clover/api/transfer.cpp | 50 --
1 file changed, 46 ins
Mapping can fail, and this should be handled. Return the proper error
code and abort the associated event in this case.
---
src/gallium/state_trackers/clover/api/transfer.cpp | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api
Work-group size should always be aligned to subgroup size; this is a
basic requirement, otherwise some work-items will be no-operation.
It might make sense to refine the value according to a kernel's
resource usage, but that's a possible optimization for the future.
---
src/gallium/state_trackers
We need this to implement OpenCL's
CL_KERNEL_PREFERRED_WORK_GROUP_SIZE_MULTIPLE.
---
src/gallium/docs/source/screen.rst | 2 ++
src/gallium/drivers/ilo/ilo_screen.c | 8
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4
src/gallium/drivers/radeon/r600_pipe_
On 28.05.2015 13:04, Grigori Goronzy wrote:
> We need this to implement OpenCL's
> CL_KERNEL_PREFERRED_WORK_GROUP_SIZE_MULTIPLE.
> ---
Ping?
> src/gallium/docs/source/screen.rst | 2 ++
> src/gallium/drivers/ilo/ilo_screen.c | 8
> src/
On 28.05.2015 10:10, Grigori Goronzy wrote:
> Wrap MapBuffer and MapImage as hard_event actions, like other
> operations. This enables correct profiling. Also make sure to wait
> for events to finish when blocking is requested by the caller.
> ---
Ping?
> src/gallium/state_trac
On 30.09.2014 05:58, Michel Dänzer wrote:
> diff --git a/src/gallium/drivers/radeonsi/si_dma.c
> b/src/gallium/drivers/radeonsi/si_dma.c
> index ff64722..643ce3f 100644
> --- a/src/gallium/drivers/radeonsi/si_dma.c
> +++ b/src/gallium/drivers/radeonsi/si_dma.c
> @@ -251,7 +251,9 @@ void si_dma_cop
Reviewed-by: Grigori Goronzy
I've been using a similar patch to fix stability issues on my machine
for quite a while. Still, it's a pity we have to go that far to get
everything stable again.
On 13.11.2014 07:52, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Using the asyn
On 2016-02-24 12:47, Marek Olšák wrote:
On Wed, Feb 24, 2016 at 12:22 PM, Grigori Goronzy
wrote:
S_00B32C_SCRATCH_EN(shader->config.scratch_bytes_per_wave > 0));
+
+ /* Prefer RE_Z if the shader is complex enough. */
+ if (info->num_memory_instructions >= 2 ||
+
On 2016-02-23 17:45, Marek Olšák wrote:
From: Marek Olšák
This can increase perf for shaders that kill pixels (kill, alpha-test,
alpha-to-coverage).
---
src/gallium/drivers/radeonsi/si_shader.h| 1 +
src/gallium/drivers/radeonsi/si_state.c | 6 +++---
src/gallium/drivers/rade
On 2016-05-27 15:16, Emil Velikov wrote:
The odd things is that VLC uses/used to? check that information before
feeding the video to the decoder, while others implementations (like
the original one in mplayer done by the Nvidia devs) do/did? not
bother.
Many files either have an incorrect leve
On 2016-06-28 11:25, Nayan Deshmukh wrote:
This is a shader based bicubic interpolater which uses cubic
Hermite spline algorithm.
v2: set dst_area and dst_clip during scaling (Christian)
v3: clear the render target before rendering
v4: intialize offsets while initializing shaders
use a const
Passes all piglit tests.
v2: rebased
---
src/gallium/drivers/radeonsi/si_state.c | 20
1 file changed, 20 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index 6e9a60a..4f7adea 100644
--- a/src/gallium/drivers/rad
On 04.07.2014 01:24, Andy Furniss wrote:
> Maybe not 1/frame but anyway the first couple of a run have numbers
> rather than s
>
> [27977.386795] radeon :01:00.0: GPU fault detected: 146 0x0c035014
> [27977.386800] radeon :01:00.0: VM_CONTEXT1_PROTECTION_FAULT_ADDR
> 0x15E0
> [
On 29.08.2014 10:19, Christian König wrote:
>
> That sounds like something doesn't work correctly.
>
> The resources are created with the subsamled formats R8G8_R8B8 or
> G8R8_B8R8, but since this can't be accessed by the CB we need to use
> R8G8B8A8 as surface format for writing to them.
>
> If
On 29.08.2014 12:31, Andy Furniss wrote:
>> As for that 4:2:2 "doesn't work", AFAICT it absolutely does, but
>> there is no linear interpolation for chroma, so quality isn't ideal.
>> This seems to be a hardware restriction, unfortunately.
>
> Hmm, we may have to disagree on the definition of work
On 08.09.2014 14:50, Axel Davy wrote:
> Hi,
>
> When reading si_dma.c code, it looks like the requested width of the
> copy is ignored except for PIPE_BUFFER.
> Perhaps that explains the bugs observed ?
>
It isn't ignored. Partial DMA copies (i.e. operations that do not copy
whole lines) are simp
On 08.09.2014 21:07, Axel Davy wrote:
> On 08/09/2014 20:21, Grigori Goronzy wrote :
>> On 08.09.2014 14:50, Axel Davy wrote:
>>> Hi,
>>>
>>> When reading si_dma.c code, it looks like the requested width of the
>>> copy is ignored except for PIPE_BUFFER
LGTM, but I have a comments below.
Grigori
On 10.09.2014 10:54, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Signed-off-by: Michel Dänzer
> ---
>
> This might help for investigating DMA related bugs.
>
> src/gallium/drivers/radeonsi/si_dma.c | 103
> ++
>
This was broken by commit 1ad24faa.
---
src/mesa/main/marshal.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/marshal.h b/src/mesa/main/marshal.h
index f2dc842..63e0295 100644
--- a/src/mesa/main/marshal.h
+++ b/src/mesa/main/marshal.h
@@ -257,7 +257,7 @@
On 2017-07-14 23:30, Kenneth Graunke wrote:
This accidentally set __DRI_CTX_FLAG_NO_ERROR whenever any flags were
present. Just needs extra parenthesis.
Fixes: 4909519a6655 (egl: Add EGL_KHR_create_context_no_error support)
Reviewed-by: Grigori Goronzy
Sorry for breaking so much stuff
classic drivers all have code to explicitly balk at unknown flags. We
need to let it through or they'll fail to create a no_error context.
I can't test it, but LGTM, so:
Reviewed-by: Grigori Goronzy
---
src/mesa/drivers/dri/i915/intel_screen.c | 2 +-
src/mesa/driver
On 2017-07-17 19:21, Emil Velikov wrote:
On 13 July 2017 at 12:09, Grigori Goronzy wrote:
On 2017-07-12 15:15, Emil Velikov wrote:
As mentioned in earlier commit no_error should be device agnostic.
Hence removing the st/dri bits and adding a DRI_CONF_MESA_NO_ERROR()
line next to
On 2017-07-18 20:25, Ian Romanick wrote:
On 07/14/2017 04:10 PM, Kenneth Graunke wrote:
Grigori recently added EGL_KHR_create_context_no_error support,
which causes EGL to pass a new __DRI_CTX_FLAG_NO_ERROR flag to
drivers when requesting an appropriate context mode.
driContextSetFlags() will a
The check is too aggressive and might also fail if context flags
appear after the no-error attribute in the context attribute list.
Delay the check to after attribute parsing to fix this.
---
This was found by the piglit test I just sent to the piglit ML. I promise,
next time I'll write tests befo
On 2017-07-18 20:25, Ian Romanick wrote:
On 07/14/2017 04:10 PM, Kenneth Graunke wrote:
Grigori recently added EGL_KHR_create_context_no_error support,
which causes EGL to pass a new __DRI_CTX_FLAG_NO_ERROR flag to
drivers when requesting an appropriate context mode.
driContextSetFlags() will a
On 2017-07-19 23:51, Grigori Goronzy wrote:
The check is too aggressive and might also fail if context flags
appear after the no-error attribute in the context attribute list.
Delay the check to after attribute parsing to fix this.
---
This was found by the piglit test I just sent to the piglit
---
src/glx/dri2_glx.c | 12
src/glx/dri3_glx.c | 8
src/glx/dri_common.c| 52 -
src/glx/dri_common.h| 5 +
src/glx/drisw_glx.c | 3 +++
src/glx/glxclient.h | 6 ++
src/glx/glxextensions.c |
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 55 ---
src/gallium/state_trackers/glx/xlib/xm_api.c | 6 ++-
src/gallium/state_trackers/glx/xlib/xm_api.h | 4 +-
3 files changed, 57 insertions(+), 8 deletions(-)
diff --git a/src/gallium/state_trackers/glx/xlib/glx
Hi,
there also is a patch needed to make this work for Xorg on the
xorg-devel list as well as preliminary piglit test to verify the
functionality on the piglit list.
Grigori
On 2017-08-03 20:07, Grigori Goronzy wrote:
---
src/glx/dri2_glx.c | 12
src/glx/dri3_glx.c
On 2017-08-03 22:26, Alex Deucher wrote:
IIRC, user_ptrs require page alignment.
Alex
I didn't follow the whole discussion (sorry if I'm saying something
redundant), but AMD's older OpenCL Optimization Guide [1] has some notes
regarding the implementation of the USE_HOST_PTR flag.
It initi
On 2017-06-23 13:48, Andy Furniss wrote:
Marek Olšák wrote:
From: Marek Olšák
The kernel sort of does the same thing with fences.
v2: do emit partial flushes on SI
Bugzilla seems to be down currently so replying here.
On R9 285 with current agd5f 4.13-wip kernel I get some slight
artifacts
These entry points are used by Alien Isolation and caused
synchronization with glthread. The async marshalling implementation
is similar to glBuffer(Sub)Data.
Results in an approximately 6x drop in glthread synchronizations and a
~30% FPS jump in Alien Isolation (Medium preset, Athlon 860K, RX 480
ow much. It wouldn't surprise me if it is in the
40-50% region with both, though.
Best regards
Grigori
[1]
https://lists.freedesktop.org/archives/mesa-dev/2017-June/160329.html
On 25/06/17 02:59, Grigori Goronzy wrote:
These entry points are used by Alien Isolation and caused
synchroni
On 2017-06-22 17:10, Marek Olšák wrote:
From: Marek Olšák
+2.3% better score on Fiji. It might be better without HBM.
Is this really useful? Superposition is a benchmark. It would make more
sense if this also targeted some actual games.
Optimizations specific to only benchmarks are considere
don't really get it, by the way. Isn't the SVGA driver for Linux
guests?
Best regards
Grigori
> Best regards
> Grigori
>
>> [1]
>> https://lists.freedesktop.org/archives/mesa-dev/2017-June/160329.html
>>
>> On 25/06/17 02:59, Grigori Goronzy wrot
Use function pointers to identify the unmarshalling function, which
is simpler and gets rid of a lot generated code.
This removes an indirection and possibly results in a slight speedup
as well.
---
src/mapi/glapi/gen/Makefile.am | 4 --
src/mapi/glapi/gen/gl_marshal.py | 36 ++
On 2017-06-30 15:27, Nicolai Hähnle wrote:
On 30.06.2017 02:29, Grigori Goronzy wrote:
Use function pointers to identify the unmarshalling function, which
is simpler and gets rid of a lot generated code.
This removes an indirection and possibly results in a slight speedup
as well.
The fact
turns the switch/case block into an
efficient jump table with the ID method, so an array for function lookup
instead of that doesn't improve anything.
I didn't see any measurable benefit of the function pointer method
either.
Best regards
Grigori
On Fri, Jun 30, 2017 at 7:14 PM,
Extract clear buffer helper functions in preparation for adding
marshal/unmarshal functions for the various glClearBuffer variants.
---
src/mesa/main/marshal.c | 74 +++--
src/mesa/main/marshal.h | 5 ++--
2 files changed, 50 insertions(+), 29 deletions
Add async marshalling/unmarshalling for all glClearBuffer variants.
These entry points are commonly used in general and Alien Isolation
specifically uses glClearBufferiv. Slightly reduces the number of
thread synchronizations with glthread in that game.
---
src/mapi/glapi/gen/GL3x.xml | 6 +-
sr
On 2017-07-09 18:52, Matt Turner wrote:
+static inline size_t buffer_to_size(GLenum buffer)
+{
+ switch (buffer) {
+ case GL_COLOR:
+ return 4;
+ case GL_DEPTH_STENCIL:
+ return 2;
+ case GL_STENCIL:
+ case GL_DEPTH:
+ return 1;
+ default:
+ return 0;
+ }
+}
+
+s
On 2017-06-26 15:51, Marc Dietrich wrote:
Am Montag, 26. Juni 2017, 15:35:15 CEST schrieb Grigori Goronzy:
On 2017-06-26 15:11, Marc Dietrich wrote:
> unfortunately, this change broke vmware/vmplayer here (bisected).
> Windows
> guest on linux host. Sig 11 in SVGA driver. Al
The semantics are similar to glBufferData. Fixes a crash with VMWare
Player.
Signed-off-by: Grigori Goronzy
---
src/mesa/main/marshal.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/mesa/main/marshal.c b/src/mesa/main/marshal.c
index 8db4531..b801bdc
Hi,
this series implements support for the EGL_KHR_context_create_no
error extension and the associated plumbing through the different
layers of Mesa - EGL, DRI, Gallium state tracker, Mesa frontend. It
took me a while to figure out how everything is connected together
and still it's somewhat conf
Add a new context flag and plumb it through the various layers of the
context creation code to set up dispatch tables for the no-error mode.
---
src/gallium/include/state_tracker/st_api.h | 1 +
src/gallium/state_trackers/dri/dri_context.c | 3 +++
src/mesa/state_tracker/st_context.c
Allows applications to be whitelisted.
---
src/gallium/state_trackers/dri/dri_context.c| 3 +++
src/gallium/state_trackers/dri/dri_screen.c | 1 +
src/mesa/drivers/dri/common/dri_util.c | 3 +++
src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 +
4 files changed, 12 inserti
This basic extension allows usage of the __DRI_CTX_FLAG_NO_ERROR flag.
This includes support code for classic Mesa drivers to switch on the
no-error mode if the flag is set.
---
include/GL/internal/dri_interface.h | 19 +++
src/gallium/state_trackers/dri/dri2.c| 6
This only adds the EGL side, needs to be plumbed into Mesa frontend.
---
src/egl/drivers/dri2/egl_dri2.c | 20 ++--
src/egl/drivers/dri2/egl_dri2.h | 1 +
src/egl/main/eglapi.c | 1 +
src/egl/main/eglcontext.c | 30 ++
src/egl/main/eglc
On 2017-07-12 12:33, Eric Engestrom wrote:
+ case EGL_CONTEXT_OPENGL_NO_ERROR_KHR:
+ if (dpy->Version < 14) {
+err = EGL_BAD_ATTRIBUTE;
+break;
+ }
+
+ /* The KHR_no_error spec only applies against OpenGL 2.0+
and
+ * OpenGL ES 2.0+
On 2017-07-12 15:16, Emil Velikov wrote:
On 11 July 2017 at 23:26, Grigori Goronzy wrote:
Hi,
this series implements support for the EGL_KHR_context_create_no
error extension and the associated plumbing through the different
layers of Mesa - EGL, DRI, Gallium state tracker, Mesa frontend. It
On 2017-07-12 15:08, Emil Velikov wrote:
On 11 July 2017 at 23:26, Grigori Goronzy wrote:
Add a new context flag and plumb it through the various layers of the
context creation code to set up dispatch tables for the no-error mode.
---
src/gallium/include/state_tracker/st_api.h | 1 +
src
On 2017-07-12 15:15, Emil Velikov wrote:
As mentioned in earlier commit no_error should be device agnostic.
Hence removing the st/dri bits and adding a DRI_CONF_MESA_NO_ERROR()
line next to DRI_CONF_VBLANK_MODE seems like the better solution.
Hm, driconf overrides are typically set per screen
Allows applications to be whitelisted.
v2: Remove misguided DRI common part.
---
src/gallium/state_trackers/dri/dri_context.c| 3 +++
src/gallium/state_trackers/dri/dri_screen.c | 1 +
src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 +
3 files changed, 9 insertions(+)
diff --git
This basic extension allows usage of the __DRI_CTX_FLAG_NO_ERROR flag.
This includes support code for classic Mesa drivers to switch on the
no-error mode if the flag is set.
v2: Move to common DRI code.
---
include/GL/internal/dri_interface.h | 19 +++
src/gallium/state_
This only adds the EGL side, needs to be plumbed into Mesa frontend.
v2: Add check for extension availability.
---
src/egl/drivers/dri2/egl_dri2.c | 20 ++--
src/egl/drivers/dri2/egl_dri2.h | 1 +
src/egl/main/eglapi.c | 1 +
src/egl/main/eglcontext.c | 31 ++
Add a new context flag and plumb it through the various layers of the
context creation code to set up dispatch tables for the no-error mode.
---
src/gallium/include/state_tracker/st_api.h | 1 +
src/gallium/state_trackers/dri/dri_context.c | 3 +++
src/mesa/state_tracker/st_context.c
n the end,
BEST_SPEED might be a better compromise, particularly for systems with a
slow CPU.
Apart from that, consider the series
Reviewed-by: Grigori Goronzy
Best regards
Grigori
Am Donnerstag, 2. März 2017, 03:20:05 CET schrieb Matt Turner:
On Wed, Mar 1, 2017 at 2:19 PM, Timothy Arceri
wrot
101 - 161 of 161 matches
Mail list logo
