[Mesa-dev] [PATCH 3/3] radv/meta: remove an unused variable

2017-06-06 Thread Grazvydas Ignotas
Trivial. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_meta_clear.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index f4cb787..d7e7c5b 100644 --- a/src/amd/vulkan/radv_meta_clear.c +++ b/src/amd/vulkan

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

2017-06-09 Thread Grazvydas Ignotas
Ping. Boring patch, should be easy to review or NAK. On Wed, Jun 7, 2017 at 2:25 AM, Grazvydas Ignotas wrote: > This will allow to constify other things. > > Signed-off-by: Grazvydas Ignotas > --- > src/compiler/nir/nir.h | 25 + >

[Mesa-dev] [PATCH 1/2] radv: assert on CP_DMA_USE_L2 for SI

2017-06-10 Thread Grazvydas Ignotas
The register header (and radeonsi comment) states V_411_SRC_ADDR_TC_L2 is for CIK+ only, so let's assert on earlier ASICs. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/si_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/v

[Mesa-dev] [PATCH 2/2] radv: don't even attempt to prefetch on SI

2017-06-10 Thread Grazvydas Ignotas
esktop.org/show_bug.cgi?id=101334 Fixes: bcae327469 "radv: realign cp dma code with radeonsi" Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_cmd_buffer.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffe

[Mesa-dev] [PATCH] radv: fix trace dumping for !use_ib_bos

2017-06-11 Thread Grazvydas Ignotas
Fixes trace dumping crash for SI or when RADV_DEBUG=noibs is set. Fixes: 97dfff5410 "radv: Dump command buffer on hang." Signed-off-by: Grazvydas Ignotas --- Not sure if chained buffer dumping can be done for !use_ib_bos, returning NULL in _get_cpu_addr() just skips that. src/amd/vul

Re: [Mesa-dev] [PATCH] mesa/util: add a hash table wrapper which support 64-bit keys

2017-06-13 Thread Grazvydas Ignotas
On Tue, Jun 13, 2017 at 10:58 AM, Samuel Pitoiset wrote: > Needed for bindless handles which are represented using > 64-bit unsigned integers. All hash table implementations should > be uniformized later on. > > Signed-off-by: Samuel Pitoiset > --- > src/util/hash_table.c | 149 > ++

Re: [Mesa-dev] [PATCH 5/7] u_queue: add a futex-based implementation of fences

2017-10-23 Thread Grazvydas Ignotas
On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fences are now 4 bytes instead of 96 bytes (on my 64-bit system). > > Signaling a fence is a single atomic operation in the fast case plus a > syscall in the slow case. > > Testing if a fence is signaled is the same

Re: [Mesa-dev] [PATCH 7/7] radeonsi: reduce the scope of sel->mutex in si_shader_select_with_key

2017-10-23 Thread Grazvydas Ignotas
On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > We only need the lock to guard changes in the variant linked list. The > actual compilation can happen outside the lock, since we use the ready > fence as a guard. > --- > src/gallium/drivers/radeonsi/si_state_shad

Re: [Mesa-dev] [PATCH 5/7] u_queue: add a futex-based implementation of fences

2017-10-23 Thread Grazvydas Ignotas
On Mon, Oct 23, 2017 at 4:04 PM, Nicolai Hähnle wrote: > On 23.10.2017 13:50, Grazvydas Ignotas wrote: >> >> On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle >> wrote: >>> >>> From: Nicolai Hähnle >>> >>> Fences are now 4 bytes instead of

Re: [Mesa-dev] [PATCH v3 32/34] disk_cache: Fix issue reading GLSL metadata

2017-10-31 Thread Grazvydas Ignotas
On Tue, Oct 31, 2017 at 12:54 AM, Kenneth Graunke wrote: > On Sunday, October 22, 2017 1:01:40 PM PDT Jordan Justen wrote: >> This would cause the read of the metadata content to fail, which would >> prevent the linking from being skipped. >> >> Seen on Rocket League with i965 shader cache. >> >>

Re: [Mesa-dev] [PATCH 8/9] anv: don't use strcpy for copying strings

2017-07-14 Thread Grazvydas Ignotas
On Thu, Jul 13, 2017 at 8:09 PM, Lionel Landwerlin wrote: > CID: 1358935 > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/anv_device.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 39c90

Re: [Mesa-dev] [PATCH v2] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

2017-07-20 Thread Grazvydas Ignotas
For whatever reason this patch is breaking DOOM. Gražvydas On Wed, Jul 12, 2017 at 12:29 PM, Alex Smith wrote: > If a cube image has VK_IMAGE_USAGE_STORAGE_BIT set, the type in an image > view's descriptor was set to a 2D array (and a few other fields adjusted > accordingly). This is correct whe

Re: [Mesa-dev] [PATCH v2] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

2017-07-21 Thread Grazvydas Ignotas
On Fri, Jul 21, 2017 at 11:21 AM, Alex Smith wrote: > > I don't have Doom available to test. How's it broken? After the menu loads, it gets stuck flipping between some 2 (?) arbitrary frames than are no longer updating. > Could you see if removing the usage flags condition on the second call to

Re: [Mesa-dev] [PATCH 1/3] gallium/util: fix unused variable warning

2017-07-25 Thread Grazvydas Ignotas
FWIW: Reviewed-by: Grazvydas Ignotas for all 3. On Thu, Jul 20, 2017 at 3:07 AM, Timothy Arceri wrote: > --- > src/gallium/auxiliary/util/u_threaded_context.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_threaded

Re: [Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-11 Thread Grazvydas Ignotas
On Fri, Aug 11, 2017 at 8:52 AM, Kenneth Graunke wrote: > This should hopefully fix build issues on 32-bit Android-x86. > > Cc: Mauro Rossi > Cc: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050 > --- > src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 ++ > 1 fil

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-14 Thread Grazvydas Ignotas
On Mon, Aug 14, 2017 at 11:13 PM, Andy Furniss wrote: > Michel Dänzer wrote: >> >> On 11/08/17 01:45 AM, Emil Velikov wrote: >> >> Thanks, pushed. > > > Don't know if this is expected or not, but llvm built like - > > cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release > -DLLVM_TARGETS_TO

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-14 Thread Grazvydas Ignotas
On Tue, Aug 15, 2017 at 1:55 AM, Grazvydas Ignotas wrote: > > Also, llvm-config --version says "6.0.0git-f49c401", which means I had > to manually hack configure.ac every time to "6.0.0svn" to get mesa > building too :( Nevermind about this one, -DLLVM_APPEND_VC_R

Re: [Mesa-dev] [PATCH] radv: Use the correct pipeline for dispatches.

2017-04-22 Thread Grazvydas Ignotas
Fixes: ec15e0d30 "radv: optimise compute shader grid size emission." Tested-by: Grazvydas Ignotas On Sat, Apr 22, 2017 at 7:42 PM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- > 1 file changed, 3 inse

Re: [Mesa-dev] [PATCH] anv: Don't place scratch buffers above the 32-bit boundary

2017-04-22 Thread Grazvydas Ignotas
Fixes: 651ec926fc1 "anv: Add support for 48-bit addresses" Tested-by: Grazvydas Ignotas On Sun, Apr 23, 2017 at 1:55 AM, Jason Ekstrand wrote: > This fixes rendering corruptions in DOOM. Hopefully, it will also make > Jenkins a bit more stable as we've been seeing som

Re: [Mesa-dev] [PATCH 2/2] disk_cache: use block size rather than file size

2017-04-27 Thread Grazvydas Ignotas
On Thu, Apr 27, 2017 at 4:15 AM, Timothy Arceri wrote: > The majority of cache files are less than 1kb this resulted in us > greatly miscalculating the amount of disk space used by the cache. > > Using the number of blocks allocated to the file is more > conservative and less likely to cause issu

Re: [Mesa-dev] [PATCH 2/2] disk_cache: use block size rather than file size

2017-04-27 Thread Grazvydas Ignotas
On Thu, Apr 27, 2017 at 1:26 PM, Grazvydas Ignotas wrote: > On Thu, Apr 27, 2017 at 4:15 AM, Timothy Arceri > wrote: > >> diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c >> index 9fd7b96..2764017 100644 >> --- a/src/util/disk_cache.c >> +++ b/sr

Re: [Mesa-dev] [PATCH 2/2] radv: Use correct stage for ready bit.

2017-05-01 Thread Grazvydas Ignotas
Haven't noticed any difference in DOOM graphs, but that's not a bad thing I guess. Tested-by: Grazvydas Ignotas On Sun, Apr 30, 2017 at 7:40 PM, Bas Nieuwenhuizen wrote: > Set the bit in the same stage as the timestamp, instead always at top of > pipe. > > Signed-off

Re: [Mesa-dev] [PATCH 2/4] gallium: Enable ARM NEON CPU detection.

2017-05-01 Thread Grazvydas Ignotas
gt; > Ping on review of this one. Clearly several people have looked at it, > so if I don't hear something soon I'll probably push. > Yeah I commented on earlier version of this. FWIW: Reviewed-by: Grazvydas Ignotas ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] anv: don't leak DRM devices

2017-05-02 Thread Grazvydas Ignotas
After successful drmGetDevices2() call, drmFreeDevices() needs to be called. Fixes: b1fb6e8d "anv: do not open random render node(s)" Signed-off-by: Grazvydas Ignotas --- src/intel/vulkan/anv_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_device.c b

[Mesa-dev] [PATCH] anv: fix possible stack corruption

2017-05-02 Thread Grazvydas Ignotas
drmGetDevices2 takes count and not size. Probably hasn't caused problems yet in practice and was missed as setups with more than 8 DRM devices are not very common. Fixes: b1fb6e8d "anv: do not open random render node(s)" Signed-off-by: Grazvydas Ignotas --- src/intel/vulkan/a

[Mesa-dev] [PATCH] radv: don't leak DRM devices

2017-05-02 Thread Grazvydas Ignotas
After successful drmGetDevices2() call, drmFreeDevices() needs to be called. Fixes: 743315f2 "radv: do not open random render node(s)" Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/

[Mesa-dev] [PATCH] radv: fix possible stack corruption

2017-05-02 Thread Grazvydas Ignotas
drmGetDevices2 takes count and not size. Probably hasn't caused problems yet in practice and was missed as setups with more than 8 DRM devices are not very common. Fixes: 743315f2 "radv: do not open random render node(s)" Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/ra

[Mesa-dev] [PATCH 1/2] anv: only init locale once

2017-05-02 Thread Grazvydas Ignotas
This follows the same pattern as in _mesa_initialize_context(), but uses pthread_once instead of a mutex. The goal is to avoid problems with multiple instances. Signed-off-by: Grazvydas Ignotas --- src/intel/vulkan/anv_device.c | 19 --- 1 file changed, 16 insertions(+), 3

[Mesa-dev] [PATCH 2/2] anv: release spirv_to_nir glsl_type allocations

2017-05-02 Thread Grazvydas Ignotas
Add a spirv_to_nir_fini() helper to clean up glsl_type allocations resulting from spirv_to_nir() calls and call it on exit. This resolves many reports from valgrind and should be helpful for application developers that use valgrind. Signed-off-by: Grazvydas Ignotas --- src/compiler/spirv

[Mesa-dev] [PATCH] glsl: destroy function and subroutine hash tables

2017-05-02 Thread Grazvydas Ignotas
Just like other type hash tables are destroyed in _mesa_glsl_release_types(), also destroy the ones for function and subroutine types. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl_types.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/glsl_types.cpp b

Re: [Mesa-dev] [PATCH 1/2] draw: fix max_index initializer in draw_pipeline_run()

2017-05-02 Thread Grazvydas Ignotas
On Tue, May 2, 2017 at 10:21 PM, Brian Paul wrote: > Note, this is just some debug code. > --- > src/gallium/auxiliary/draw/draw_pipe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/draw/draw_pipe.c > b/src/gallium/auxiliary/draw/draw_pipe.c > ind

[Mesa-dev] [PATCH] radv: always free nir shaders from modules on stack

2017-05-02 Thread Grazvydas Ignotas
valgrind reports them as leaked, and I could not find anything making a copy of the nir pointer. Also, radv_device_init_meta_blit_color() is already freeing them unconditionally like this. Signed-off-by: Grazvydas Ignotas --- src/amd/vulkan/radv_meta_blit.c | 6 ++ src/amd/vulkan

Re: [Mesa-dev] [PATCH] anv: fix possible stack corruption

2017-05-04 Thread Grazvydas Ignotas
ping Emil: the code this fixes is yours. Gražvydas On Tue, May 2, 2017 at 8:17 PM, Grazvydas Ignotas wrote: > drmGetDevices2 takes count and not size. Probably hasn't caused problems > yet in practice and was missed as setups with more than 8 DRM devices > are not very com

Re: [Mesa-dev] [PATCH 02/13] mesa/dri: always link against shared glapi

2017-05-06 Thread Grazvydas Ignotas
This causes a strange build failure for me: make[7]: Entering directory '/home/notaz/src/radeon/mesa/src/mesa/drivers/dri' make[7]: Nothing to be done for 'install-exec-am'. /bin/mkdir -p '/opt/xorg/lib/dri/' /bin/bash ../../../../libtool --mode=install /usr/bin/install -c mesa_dri_drivers.la

Re: [Mesa-dev] [PATCH 02/13] mesa/dri: always link against shared glapi

2017-05-08 Thread Grazvydas Ignotas
? > > I had '--prefix=/usr/local' and '--with-dri-driverdir=/usr/local/dri', and > removing the --with-dri-driverdir fixed my build. > > --Aaron > > On Sat, May 6, 2017 at 7:48 PM, Grazvydas Ignotas wrote: >> >> This causes a strange build failur

Re: [Mesa-dev] [PATCH] anv: Canonicalize known offsets

2017-05-11 Thread Grazvydas Ignotas
On Thu, May 11, 2017 at 11:09 AM, Chris Wilson wrote: > When we add the reloc, we write the value of the relocation target using > non-canonical form. If we later patch up the address prior to command > submission, we will rewrite it using canonical form. We should always > write the address in ca

Re: [Mesa-dev] [PATCH 1/2] Clang doesn't have 64bit __atomic* builtins on i386

2017-05-14 Thread Grazvydas Ignotas
Gražvydas On Sat, May 13, 2017 at 12:20 PM, Jan Beich wrote: > glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In function > `disk_cache_remove': > disk_cache.c:(.text+0x763): undefined reference to `__atomic_fetch_add_8' > glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In fu

Re: [Mesa-dev] [PATCH 3/3] RFC: vulkan/wsi: Rework the way prime support works

2017-11-16 Thread Grazvydas Ignotas
On Thu, Nov 16, 2017 at 12:33 AM, Dave Airlie wrote: > On 15 November 2017 at 04:40, Jason Ekstrand wrote: >> This commit significantly reworks the way prime support works and lets >> us pull it even further into radv. The old mechanism required the >> specific WSI layer to be aware of the linea

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-17 Thread Grazvydas Ignotas
I've tested this branch (rx470 + hd530) and it's only partially working: - display on amd, radv: always fails with "offscreen: wsi/wsi_common.c:172: select_memory_type: Assertion `!"No memory type found"' failed." - display on amd, anv: misrenders. For SaschaWillems, only multisampling, subpasses a

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-18 Thread Grazvydas Ignotas
On Sat, Nov 18, 2017 at 3:06 AM, Jason Ekstrand wrote: > On Fri, Nov 17, 2017 at 2:18 PM, Grazvydas Ignotas > wrote: >> >> I've tested this branch (rx470 + hd530) and it's only partially working: >> - display on amd, radv: always fails with "offscreen: >

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-19 Thread Grazvydas Ignotas
On Sun, Nov 19, 2017 at 1:51 AM, Jason Ekstrand wrote: > On Sat, Nov 18, 2017 at 9:02 AM, Grazvydas Ignotas > wrote: >> >> On Sat, Nov 18, 2017 at 3:06 AM, Jason Ekstrand >> wrote: >> > On Fri, Nov 17, 2017 at 2:18 PM, Grazvydas Ignotas >> > wrote:

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-21 Thread Grazvydas Ignotas
On Mon, Nov 20, 2017 at 6:08 PM, Jason Ekstrand wrote: > On Sun, Nov 19, 2017 at 5:07 AM, Grazvydas Ignotas > wrote: >> >> On Sun, Nov 19, 2017 at 1:51 AM, Jason Ekstrand >> wrote: >> > >> > I force-pushed the branch again with an added commit: &q

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-22 Thread Grazvydas Ignotas
On Wed, Nov 22, 2017 at 7:54 AM, Jason Ekstrand wrote: > On Tue, Nov 21, 2017 at 1:21 PM, Grazvydas Ignotas > wrote: >> >> On Mon, Nov 20, 2017 at 6:08 PM, Jason Ekstrand >> wrote: >> > On Sun, Nov 19, 2017 at 5:07 AM, Grazvydas Ignotas >> > wrote: &

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

2017-06-15 Thread Grazvydas Ignotas
s possible. > > Reported-by: Grazvydas Ignotas Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100877 > Signed-off-by: Eric Engestrom It seems this has stalled. With the commit message updated (as detailed in my previous mail, bad things can happen even with matching thread results

Re: [Mesa-dev] [PATCH mesa v2 1/2] egl/display: only detect the platform once

2017-06-16 Thread Grazvydas Ignotas
t; Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101252 > Fixes: 7adb9b094894a512c019 ("egl/display: remove unnecessary code and > make it easier to read") > Signed-off-by: Eric Engestrom > Reviewed-by: Grazvydas Ignotas > Ack-by:

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

2017-06-20 Thread Grazvydas Ignotas
et another > application so I think we're stuck working around it. Hopefully, we can > delete this code one day. > > Cc: Dave Airlie Yes please, would be one less patch to carry. I'd even vote for it to go to stable. Tested-by: Grazvydas Ignota

Re: [Mesa-dev] radeonsi: ppc64 glamor backtrace

2017-06-21 Thread Grazvydas Ignotas
Looks like nobody tested radeonsi on BE for 5 months at least. You can try the attached patch, but I suspect there will be other places like this... Gražvydas On Wed, Jun 21, 2017 at 3:26 PM, Jack Mitchell wrote: > Hi, > > I'm trying to run a VERDE based AMD card in a big endian powerpc64. I > c

Re: [Mesa-dev] [PATCH 2/2] ac/nir: Make intrinsic_name buffer long enough

2017-06-21 Thread Grazvydas Ignotas
printf(intrinsic_name, ... assert(ret < sizeof(intrinsic_name)); In either case Reviewed-by: Grazvydas Ignotas > --- > src/amd/common/ac_nir_to_llvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_t

Re: [Mesa-dev] [PATCH 07/10] util/u_queue: add an option to resize the queue when it's full

2017-07-11 Thread Grazvydas Ignotas
On Tue, Jul 11, 2017 at 12:21 AM, Marek Olšák wrote: > From: Marek Olšák > > Consider the following situation: > mtx_lock(mutex); > do_something(); > util_queue_add_job(...); > mtx_unlock(mutex); > > If the queue is full, util_queue_add_job will wait for a free slot. > If the job which is

[Mesa-dev] [PATCH 1/3] android,configure,meson: define HAVE_ZLIB

2017-12-28 Thread Grazvydas Ignotas
The next change wants to use some optional zlib functionality, however not all platforms currently use zlib. Based on earlier Jordan Justen's patches and their review feedback. Signed-off-by: Grazvydas Ignotas --- Android.common.mk | 1 + configure.ac | 1 + meson.build | 1

[Mesa-dev] [PATCH 2/3] util/crc32: don't drop the const qualifier

2017-12-28 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- src/util/crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/crc32.c b/src/util/crc32.c index 44d637c..f2e01c6 100644 --- a/src/util/crc32.c +++ b/src/util/crc32.c @@ -109,11 +109,11 @@ util_crc32_table[256] = { * @sa http

[Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

2017-12-28 Thread Grazvydas Ignotas
d-off-by: Grazvydas Ignotas --- src/util/crc32.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/util/crc32.c b/src/util/crc32.c index f2e01c6..0cffa49 100644 --- a/src/util/crc32.c +++ b/src/util/crc32.c @@ -31,12 +31,20 @@ * * @author Jose Fonseca */ +#ifdef HAVE

Re: [Mesa-dev] [PATCH 3/8] spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory

2017-12-30 Thread Grazvydas Ignotas
Hi, I don't know if it's the game's fault, but it appears this change broke DOOM. here is the offending spirv binary: https://people.freedesktop.org/~notaz/doom_compute_spirv Gražvydas On Thu, Dec 7, 2017 at 6:12 PM, Jason Ekstrand wrote: > --- > src/compiler/spirv/vtn_variables.c | 18 ++

Re: [Mesa-dev] [PATCH 1/3] spirv: Add a mechanism for dumping failing shaders

2018-01-02 Thread Grazvydas Ignotas
On Tue, Jan 2, 2018 at 6:30 PM, Jason Ekstrand wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 29 + > src/compiler/spirv/vtn_private.h | 1 + > 2 files changed, 30 insertions(+) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spirv/spirv_to_n

Re: [Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

2018-01-02 Thread Grazvydas Ignotas
On Tue, Jan 2, 2018 at 11:38 PM, Ian Romanick wrote: > On 12/28/2017 05:56 PM, Grazvydas Ignotas wrote: >> zlib provides a faster slice-by-4 CRC32 implementation than the >> traditional single byte lookup one used by mesa. As most supported >> platforms now link zlib un

Re: [Mesa-dev] [PATCH 3/3] util: use zlib's CRC32 implementaion for larger buffers

2018-01-02 Thread Grazvydas Ignotas
On Wed, Jan 3, 2018 at 3:09 AM, Ian Romanick wrote: > On 01/02/2018 04:52 PM, Grazvydas Ignotas wrote: >> On Tue, Jan 2, 2018 at 11:38 PM, Ian Romanick wrote: >>> On 12/28/2017 05:56 PM, Grazvydas Ignotas wrote: >>>> zlib provides a faster slice-by-4

[Mesa-dev] [PATCH v2 1/3] util/crc32: don't drop the const qualifier

2018-01-09 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- src/util/crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/crc32.c b/src/util/crc32.c index 44d637c..f2e01c6 100644 --- a/src/util/crc32.c +++ b/src/util/crc32.c @@ -109,11 +109,11 @@ util_crc32_table[256] = { * @sa http

[Mesa-dev] [PATCH v2 2/3] android, configure, meson: define HAVE_ZLIB

2018-01-09 Thread Grazvydas Ignotas
The next change wants to use some optional zlib functionality, however not all platforms currently use it. Based on earlier Jordan Justen's patches and their review feedback. Signed-off-by: Grazvydas Ignotas --- Android.common.mk | 1 + configure.ac | 1 + meson.build | 1 + 3

[Mesa-dev] [PATCH v2 3/3] util: use faster zlib's CRC32 implementaion

2018-01-09 Thread Grazvydas Ignotas
mesa zlibmesa zlib 443 1443 225% +/- 2.1% 403 1175 191% +/- 0.9% It has been verified the calculation results stay the same after this change. Signed-off-by: Grazvydas Ignotas --- v2: drop the size threshold check because size is unlikely to be that low of things mesa is

Re: [Mesa-dev] [PATCH 1/2] amd/common: import get_{load, store}_intr_attribs() from RadeonSI

2018-01-10 Thread Grazvydas Ignotas
On Wed, Jan 10, 2018 at 1:57 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c| 12 ++- > src/amd/common/ac_llvm_util.c | 18 > src/amd/common/ac_llvm_util.h | 6

[Mesa-dev] [PATCH] radeon: remove unneeded semicolons

2018-01-14 Thread Grazvydas Ignotas
Trivial. Found by Coccinelle. --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 6 +++--- src/mesa/drivers/dri/radeon/radeon_debug.c | 2 +- src/mesa/drivers/dri/radeon/radeon_state_init.c | 2 +- src/mesa/drivers/dri/radeon/radeon_swtcl.c | 2 +- 4 files changed, 6 insertions(+), 6

[Mesa-dev] [PATCH] mesa: remove unneeded semicolons

2018-01-14 Thread Grazvydas Ignotas
Trivial. Found by Coccinelle. --- src/gbm/backends/dri/gbm_dri.c | 2 +- src/mesa/main/dlist.c| 2 +- src/mesa/main/program_resource.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index b2121cb.

[Mesa-dev] [PATCH] osmesa: don't check SmoothFlag twice

2018-01-14 Thread Grazvydas Ignotas
Trivial. Found by Coccinelle. --- src/mesa/drivers/osmesa/osmesa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c index 1df3da4..e0f87b8 100644 --- a/src/mesa/drivers/osmesa/osmesa.c +++ b/src/mesa/drivers/osmesa/osmesa.c @@ -

[Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-15 Thread Grazvydas Ignotas
: Grazvydas Ignotas --- src/gallium/state_trackers/va/config.c | 4 +++- src/gallium/state_trackers/va/image.c | 4 +++- src/gallium/state_trackers/va/picture.c | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/va/config.c b/src/gallium/state_trackers

[Mesa-dev] [PATCH 2/2] st/vdpau: release held lock in error path

2018-01-15 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- src/gallium/state_trackers/vdpau/surface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/surface.c b/src/gallium/state_trackers/vdpau/surface.c index c678eb7..012d303 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Grazvydas Ignotas
On Tue, Jan 16, 2018 at 10:15 AM, Christian König wrote: > Reviewed-by: Christian König > > Do you have commit right by now or should Leo or I commit that for you? Yes I do. > > Thanks for the help, > Christian. > > > Am 15.01.2018 um 23:03 schrieb Grazvydas Ignotas

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: release held lock in error path

2018-01-18 Thread Grazvydas Ignotas
Anyone cares about vdpau? Gražvydas On Tue, Jan 16, 2018 at 12:03 AM, Grazvydas Ignotas wrote: > Signed-off-by: Grazvydas Ignotas > --- > src/gallium/state_trackers/vdpau/surface.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/st

[Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

2017-09-18 Thread Grazvydas Ignotas
;util: use GCC atomic intrinsics with explicit memory model" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102573 Signed-off-by: Grazvydas Ignotas --- configure.ac | 13 + src/util/Makefile.am | 3 ++- 2 files changed, 15 insertions(+), 1 deletion(-) di

[Mesa-dev] [PATCH 2/2] util/u_atomic: remove unnecessaty __atomic functions

2017-09-18 Thread Grazvydas Ignotas
They are now provided by -latomic, which should be linked as needed since previous commit. Signed-off-by: Grazvydas Ignotas --- src/util/u_atomic.c | 12 1 file changed, 12 deletions(-) diff --git a/src/util/u_atomic.c b/src/util/u_atomic.c index b32527f..e4bffa8 100644 --- a/src

Re: [Mesa-dev] [PATCH] r600: fork and import gallium/radeon

2017-09-18 Thread Grazvydas Ignotas
Has anyone ran full piglit on these with r600? Copy-paste bugs are very easy to introduce. Gražvydas On Mon, Sep 18, 2017 at 7:32 PM, Marek Olšák wrote: > Latest version with an updated commit message: > https://cgit.freedesktop.org/~mareko/mesa/commit/?h=master&id=8671613ed19586ac1eceda48eb067a

Re: [Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

2017-09-19 Thread Grazvydas Ignotas
On Mon, Sep 18, 2017 at 11:30 PM, Matt Turner wrote: > On Mon, Sep 18, 2017 at 12:28 PM, Grazvydas Ignotas wrote: >> On some platforms, gcc generates library calls when __atomic_* functions >> are used, but does not link the required library automatically. Detect >> this and

Re: [Mesa-dev] [PATCH 1/2] configure: check if -latomic is needed for __atomic_*

2017-09-19 Thread Grazvydas Ignotas
On Tue, Sep 19, 2017 at 2:04 PM, Emil Velikov wrote: > On 19 September 2017 at 10:12, Grazvydas Ignotas wrote: >> On Mon, Sep 18, 2017 at 11:30 PM, Matt Turner wrote: >>> On Mon, Sep 18, 2017 at 12:28 PM, Grazvydas Ignotas >>> wrote: >>>> On some plat

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-08 Thread Grazvydas Ignotas
Some spelling suggestions, since you seem to be doing another version of these patches: On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: > glcpp's printing is an obvious low hanging fruit: > > 1. It unnecessarily uses formatted printing to print output of >preprocessing. To print just

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-08 Thread Grazvydas Ignotas
On Sun, Jan 8, 2017 at 4:05 PM, Grazvydas Ignotas wrote: > On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: >> +* >> +* Check for INT_MAX for the only reason that utility > > "... only for the only reason that ..." sounds b

Re: [Mesa-dev] [PATCH 11/12] glcpp: Create fast path hand-written scanner

2017-01-08 Thread Grazvydas Ignotas
On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: > @@ -582,6 +609,333 @@ HEXADECIMAL_INTEGER 0[xX][0-9a-fA-F]+[uU]? > > %% > > +static void > +glcpp_fast_skip_singleline_comment (glcpp_parser_t *parser, char **input) > +{ > + /* Skip // */ > + char *buf = *input + 2; > + > + wh

Re: [Mesa-dev] [PATCH 11/12] glcpp: Create fast path hand-written scanner

2017-01-08 Thread Grazvydas Ignotas
On Sun, Jan 8, 2017 at 4:11 PM, Grazvydas Ignotas wrote: > On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: >> @@ -582,6 +609,333 @@ HEXADECIMAL_INTEGER 0[xX][0-9a-fA-F]+[uU]? >> >> %% >> >> +static void >> +glcpp_fast_skip_singleline_commen

[Mesa-dev] [PATCH] mapi: update the asm code to support x32

2017-01-08 Thread Grazvydas Ignotas
Fixes crashes when both glx-tls and asm are enabled on x32. Cc: mesa-sta...@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94512 Signed-off-by: Grazvydas Ignotas --- no commit access, please push src/mapi/entry_x86-64_tls.h | 31 --- 1

Re: [Mesa-dev] [PATCH 06/10] amd/common: unify cube map coordinate handling between radeonsi and radv

2017-01-10 Thread Grazvydas Ignotas
Unfortunately this one breaks at least (surprise!) texturecubemap SaschaWillemsVulkan demo. I recommend you try it yourself, there are even precompiled binaries available (see README.md): https://github.com/SaschaWillems/Vulkan Gražvydas On Tue, Jan 10, 2017 at 5:12 PM, Nicolai Hähnle wrote: > F

[Mesa-dev] [PATCH] radv: remove some unused macros and functions

2017-01-10 Thread Grazvydas Ignotas
These seem unlikely to be used. Also remove irrelevant comment about SKL. Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/vulkan/radv_private.h | 15 +-- src/amd/vulkan/radv_util.c| 19 --- 2 files changed, 1 insertion(+), 33 deletions(-) diff

[Mesa-dev] [PATCH v2] radv: remove some unused macros and functions

2017-01-10 Thread Grazvydas Ignotas
These seem unlikely to be used. Also remove irrelevant comment about SKL. v2: forgot to rebase on master Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/vulkan/radv_private.h | 15 +-- src/amd/vulkan/radv_util.c| 19 --- 2 files changed, 1

Re: [Mesa-dev] [PATCH] radeonsi: handle big number of immediates dynamically

2017-01-11 Thread Grazvydas Ignotas
On Tue, Jan 10, 2017 at 7:33 PM, Samuel Pitoiset wrote: > diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > b/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > index 3e0f7c4f76..3cd87f2f66 100644 > --- a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > +++ b/src/gallium/

[Mesa-dev] [PATCH] ac/debug: move .gitignore for sid_tables.h too

2017-01-11 Thread Grazvydas Ignotas
b838f642 "ac/debug: Move sid_tables.h generation to common code." moved sid_tables.h but forgot the corresponding .gitignore. Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/common/.gitignore | 1 + src/gallium/drivers/radeonsi/.gitignore | 1 - 2 files

Re: [Mesa-dev] [PATCH] mapi: update the asm code to support x32

2017-01-12 Thread Grazvydas Ignotas
As the branchpoint is near, can someone push it, please? Gražvydas On Sun, Jan 8, 2017 at 11:22 PM, Matt Turner wrote: > On Sun, Jan 8, 2017 at 9:38 AM, Grazvydas Ignotas wrote: >> Fixes crashes when both glx-tls and asm are enabled on x32. >> >> Cc: mesa-sta...@

Re: [Mesa-dev] [PATCH] ac/debug: move .gitignore for sid_tables.h too

2017-01-12 Thread Grazvydas Ignotas
On Thu, Jan 12, 2017 at 12:26 PM, Nicolai Hähnle wrote: > On 12.01.2017 00:58, Grazvydas Ignotas wrote: >> >> b838f642 "ac/debug: Move sid_tables.h generation to common code." moved >> sid_tables.h but forgot the corresponding .gitignore. >> >> Sig

Re: [Mesa-dev] [PATCH] gallium: add Tegra renderonly support

2017-01-13 Thread Grazvydas Ignotas
Hi, just out of the interest, can this be used on Tegra X1 right now? If so, what would I need to get it to work (kernel, firmware, something else)? I'd be interested to run mesa on the Shield TV. Gražvydas On Fri, Jan 13, 2017 at 9:47 AM, Alexandre Courbot wrote: > From: Christian Gmeiner > >

[Mesa-dev] [PATCH] anv: remove some unused macros and functions

2017-01-13 Thread Grazvydas Ignotas
VK_ICD_WSI_PLATFORM_MAX is used, but a duplicate from wsi_common.h . Signed-off-by: Grazvydas Ignotas --- no commit access requested by Emil: https://lists.freedesktop.org/archives/mesa-dev/2017-January/140733.html src/intel/vulkan/anv_private.h | 15 --- src/intel/vulkan

[Mesa-dev] [PATCH] radv: don't resubmit the same cs over and over while tracing

2017-01-23 Thread Grazvydas Ignotas
Fixes: 97dfff54 ("radv: Dump command buffer on hang.") Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/vulkan/radv_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index d27a66

[Mesa-dev] [PATCH] tests/cache_test: mark arguments const

2017-03-24 Thread Grazvydas Ignotas
While at it, also fix up a failure message to not reference timestamp and gpu dirs as those are no longer being made. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl/tests/cache_test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/tests

[Mesa-dev] [PATCH] util/disk_cache: avoid making mesa subdir when cache dir is specified

2017-03-24 Thread Grazvydas Ignotas
When MESA_GLSL_CACHE_DIR is specified, we currently add a /mesa subdir even though the documentation and nearby comment in the code make no mention of it. Doesn't look useful too, remove. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl/tests/cache_test.c | 2 +- src/util/disk_ca

[Mesa-dev] [PATCH] util/disk_cache: don't deadlock on premature EOF

2017-03-24 Thread Grazvydas Ignotas
0 '{}' \; $ glxgears # deadlock Signed-off-by: Grazvydas Ignotas --- src/util/disk_cache.c | 43 ++- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 4f66aa9..9677f93 100644 ---

[Mesa-dev] [PATCH] glsl/shader_cache: restore evicted shader keys

2017-03-26 Thread Grazvydas Ignotas
returns to normal after 1 run. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl/shader_cache.cpp | 17 + 1 file changed, 17 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index dd8c6c0..274bb8c 100644 --- a/src/compiler

[Mesa-dev] [PATCH] glsl, st/shader_cache: check the whole sha1 for zero

2017-03-26 Thread Grazvydas Ignotas
The checks were only looking at the first byte, while the intention seems to be to check if the whole sha1 is zero. This prevented all shaders with first byte zero in their sha1 from being saved. This shaves around a second from Deus Ex load time on a hot cache. Signed-off-by: Grazvydas Ignotas

Re: [Mesa-dev] [PATCH] glsl, st/shader_cache: check the whole sha1 for zero

2017-03-26 Thread Grazvydas Ignotas
On Sun, Mar 26, 2017 at 11:45 PM, Timothy Arceri wrote: > > > On 27/03/17 03:30, Grazvydas Ignotas wrote: >> >> The checks were only looking at the first byte, while the intention >> seems to be to check if the whole sha1 is zero. This prevented all >> shaders w

Re: [Mesa-dev] [PATCH 1/3] glsl: delay optimisations on individual shaders when cache is available

2017-03-27 Thread Grazvydas Ignotas
On Mon, Mar 27, 2017 at 6:14 AM, Timothy Arceri wrote: > Due to a max limit of 65,536 entries on the index table that we use to > decide if we can skip compiling individual shaders, it is very likely > we will have collisions. > > To avoid doing too much work when the linked program may be in the

Re: [Mesa-dev] [PATCH 2/3] glsl: disable cache if MESA_EXTENSION_OVERRIDE is set

2017-03-27 Thread Grazvydas Ignotas
On Mon, Mar 27, 2017 at 6:14 AM, Timothy Arceri wrote: > In the following patch we will stop pre-processing shaders before > hashing them, so we just disable the cache if MESA_EXTENSION_OVERRIDE > is set. That's because the extension substitution is done by the preprocessor I assume? It's not rea

Re: [Mesa-dev] [PATCH 1/3] glsl: delay optimisations on individual shaders when cache is available

2017-03-27 Thread Grazvydas Ignotas
On Mon, Mar 27, 2017 at 12:43 PM, Timothy Arceri wrote: > > > On 27/03/17 20:30, Grazvydas Ignotas wrote: >> >> On Mon, Mar 27, 2017 at 6:14 AM, Timothy Arceri >> wrote: >>> >>> Due to a max limit of 65,536 entries on the index table that we use to &

[Mesa-dev] [PATCH] util/u_atomic: provide 64bit atomics where they're missing

2017-03-29 Thread Grazvydas Ignotas
his allows us to provide our implementation, which is marked weak to prefer a better implementation, should one exist. Cc: Matt Turner Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93089 Signed-off-by: Grazvydas Ignotas --- configure.ac | 12 src/util/Makefile.so

[Mesa-dev] [PATCH v2] util/u_atomic: provide 64bit atomics where they're missing

2017-03-30 Thread Grazvydas Ignotas
his allows us to provide our own implementation, which is marked weak to prefer a better implementation, should one exist. v2: changed copyright, some style adjustments Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93089 Signed-off-by: Grazvydas Ignotas Reviewed-by: Matt Turner ---

Re: [Mesa-dev] [PATCH] i965/fs: Gracefully handle TXS on multisampled textures with no LOD

2017-04-01 Thread Grazvydas Ignotas
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100391 > Cc: "13.0 17.0" > --- > Tested-by: Grazvydas Ignotas ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radeonsi: use unreachable to fix a warning

2017-04-02 Thread Grazvydas Ignotas
si_state.c: In function ‘si_make_texture_descriptor’: si_state.c:3240:25: warning: ‘num_format’ may be used uninitialized si_state.c:3240:12: warning: ‘data_format’ may be used uninitialized Signed-off-by: Grazvydas Ignotas --- no commit access (currently pending) src/gallium/drivers/radeonsi

<    1   2   3   4   >