Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

2015-10-29 Thread Grazvydas Ignotas
Hi, On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov wrote: > On 29 October 2015 at 15:22, Emmanuel Gil Peyrot > wrote: >> This was causing compilation issues when one of its providers wasn’t >> already included before gbm.h. > Cc: "11.0" > Reviewed-by: Emil Velikov > > I'll push this later on to

Re: [Mesa-dev] [PATCH] util/disk_cache: stop using ralloc_asprintf() unnecessarily

2017-02-09 Thread Grazvydas Ignotas
On Thu, Feb 9, 2017 at 12:06 AM, Timothy Arceri wrote: > --- > src/util/disk_cache.c | 25 - > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c > index 7691621..edfff73 100644 > --- a/src/util/disk_cache.c > +

[Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-10 Thread Grazvydas Ignotas
They cause regressions on little endian. Fixes: 172bfdaa9e ("r300g: add support for PIPE_FORMAT_x8R8G8B8_*") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98869 Signed-off-by: Grazvydas Ignotas --- no commit access src/gallium/drivers/r300/r300_texture.c | 5 + 1 file

Re: [Mesa-dev] [PATCH 3/4] gallium/radeon: add a HUD query for monitoring the CS thread activity

2017-02-11 Thread Grazvydas Ignotas
On Sat, Feb 11, 2017 at 9:58 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_query.c | 25 > ++- > src/gallium/drivers/radeon/r600_query.h | 1 + > src/gallium/drivers/radeon/radeon_winsys.h| 1 + > src/galli

Re: [Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-13 Thread Grazvydas Ignotas
On Mon, Feb 13, 2017 at 10:22 AM, Michel Dänzer wrote: > On 13/02/17 05:17 PM, Michel Dänzer wrote: >> On 11/02/17 08:01 AM, Grazvydas Ignotas wrote: >>> They cause regressions on little endian. >>> >>> Fixes: 172bfdaa9e ("r300g: add support for PIP

Re: [Mesa-dev] Query with respect to support of x32

2017-02-14 Thread Grazvydas Ignotas
On Tue, Feb 14, 2017 at 3:12 PM, Haridasan, Sujith wrote: > I am using mesa 12.0.1 from yocto project > (http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-graphics/mesa/mesa_12.0.1.bb?h=morty). > While building core-image-sato ( which is the graphical image ), I found > that Qt5 exa

Re: [Mesa-dev] [PATCH 1/2] util: Add helpers for iterating over Vulkan extension structs

2017-02-15 Thread Grazvydas Ignotas
On Wed, Feb 15, 2017 at 2:03 AM, Jason Ekstrand wrote: > --- > src/util/Makefile.sources | 3 ++- > src/util/vk_util.h| 43 +++ > 2 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 src/util/vk_util.h > > diff --git a/src/util/Ma

Re: [Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-20 Thread Grazvydas Ignotas
So, as there are no better solutions in sight, can somebody please push this patch? Gražvydas On Wed, Feb 15, 2017 at 5:33 AM, Alex Deucher wrote: > On Tue, Feb 14, 2017 at 10:27 PM, Michel Dänzer wrote: >> On 14/02/17 08:25 PM, Marek Olšák wrote: >>> I've changed my mind. The patch can be merg

Re: [Mesa-dev] [PATCH 1/8] util/disk_cache: fix bug with deleting old cache dirs

2017-02-22 Thread Grazvydas Ignotas
On Wed, Feb 22, 2017 at 5:45 AM, Timothy Arceri wrote: > If there was more than a single directory in the .cache/mesa dir > then it would only remove one (or none) of the directories. > > Apparently Valgrind was also reporting: > Conditional jump or move depends on uninitialised value uninitialis

[Mesa-dev] [PATCH 2/2] gallium/u_queue: set num_threads correctly if not all threads start

2017-02-25 Thread Grazvydas Ignotas
If i-th thread could not be created it means we have i threads, not i+1, because we start from 0. Fixes: 404d0d5 "gallium/u_queue: add an option to have multiple worker threads" Signed-off-by: Grazvydas Ignotas --- no commit access src/gallium/auxiliary/util/u_queue.c | 2 +- 1 file

[Mesa-dev] [PATCH 1/2] gallium/u_queue: fix a crash with atexit handlers

2017-02-25 Thread Grazvydas Ignotas
ns. Fixes: 4aea8fe "gallium/u_queue: fix random crashes when the app calls exit()" Signed-off-by: Grazvydas Ignotas --- no commit access src/gallium/auxiliary/util/u_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/util/u_queue.c b/src/gallium/auxi

[Mesa-dev] [PATCH 3/4] r600g: don't mark unused atom dirty

2015-08-09 Thread Grazvydas Ignotas
On evergreen config_state is not used, so don't mark it dirty. --- src/gallium/drivers/r600/r600_hw_context.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_hw_context.c b/src/gallium/drivers/r600/r600_hw_context.c index d67fdfd..c048a71 10064

[Mesa-dev] [PATCH 2/4] r600g: use a helper to add an initialized atom

2015-08-09 Thread Grazvydas Ignotas
Instead of writing to rctx->atoms directly use a helper to take advantage of assert checks. --- src/gallium/drivers/r600/evergreen_state.c | 4 ++-- src/gallium/drivers/r600/r600_pipe.h | 1 + src/gallium/drivers/r600/r600_state.c| 4 ++-- src/gallium/drivers/r600/r600_state_c

[Mesa-dev] [PATCH 4/4] r600g: use a bitfield to track dirty atoms

2015-08-09 Thread Grazvydas Ignotas
r600 currently has 73 atoms and looping through their dirty flags has become costly because checking each flag requires a pointer dereference before the read. To avoid having to do that add additional bitfield which can be checked really quickly thanks to tzcnt instruction. id field was added to s

[Mesa-dev] [PATCH 1/4] gallium/radeon: use helper functions to mark atoms dirty

2015-08-09 Thread Grazvydas Ignotas
This is analogous to r300_mark_atom_dirty() used by r300, and will be used by later patches. For common radeon code, appropriate helper is called through a function pointer. No functional changes. --- src/gallium/drivers/r600/evergreen_compute.c| 2 +- src/gallium/drivers/r600/evergreen_stat

Re: [Mesa-dev] [PATCH 4/4] r600g: use a bitfield to track dirty atoms

2015-08-10 Thread Grazvydas Ignotas
to be his code) Gražvydas > > Patches 1-3: > Reviewed-by: Marek Olšák > > Marek > > On Sun, Aug 9, 2015 at 11:42 PM, Grazvydas Ignotas wrote: >> r600 currently has 73 atoms and looping through their dirty flags has >> become costly because checking each fla

[Mesa-dev] [PATCH] radeon/uvd: remove unused variables

2015-08-17 Thread Grazvydas Ignotas
Recent commits introduced new unused variable warnings, fix them. --- src/gallium/drivers/radeon/radeon_uvd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c index 16ee541..81f3f45 100644 ---

[Mesa-dev] [PATCH] radeonsi: mark unreachable paths to avoid warnings

2015-08-17 Thread Grazvydas Ignotas
Otherwise we get: warning: 'num_user_sgprs' may be used uninitialized in this function ... --- src/gallium/drivers/radeonsi/si_shader.c| 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH] radeon/uvd: remove unused variables

2015-08-18 Thread Grazvydas Ignotas
On Tue, Aug 18, 2015 at 11:30 AM, Christian König wrote: > On 18.08.2015 01:51, Grazvydas Ignotas wrote: >> >> Recent commits introduced new unused variable warnings, fix them. > > > Reviewed-by: Christian König > > Do you have commit access? No, it's on

[Mesa-dev] [PATCH 2/4] r600g: make all viewport states use single atom

2015-08-23 Thread Grazvydas Ignotas
Similarly to scissor states, we can use single atom to track all viewport states. This will allow to simplify dirty atom handling later. --- src/gallium/drivers/r600/evergreen_state.c | 7 ++--- src/gallium/drivers/r600/r600_blit.c | 2 +- src/gallium/drivers/r600/r600_hw_context.c |

[Mesa-dev] [PATCH 3/4] r600g: start numbering atoms from 1

2015-08-23 Thread Grazvydas Ignotas
There doesn't seem any reason to start from 4. Start from 1 instead (0 is left reserved to catch uninitialized atoms). --- src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_pipe.h | 2 +- src/gallium/drivers/r600/r600_state.c | 2 +- 3 files changed, 3 ins

[Mesa-dev] [PATCH 1/4] r600g: make all scissor states use single atom

2015-08-23 Thread Grazvydas Ignotas
As suggested by Marek Olšák, we can use single atom to track all scissor states. This will allow to simplify dirty atom handling later. --- src/gallium/drivers/r600/evergreen_state.c | 33 ++--- src/gallium/drivers/r600/r600_blit.c | 2 +- src/gallium/drivers/r600/r600_h

[Mesa-dev] [PATCH 4/4] r600g: simplify dirty atom tracking

2015-08-23 Thread Grazvydas Ignotas
Now that R600_NUM_ATOMS is below 64, dirty atom tracking can be simplified. --- src/gallium/drivers/r600/r600_pipe.h | 41 ++-- 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.h b/src/gallium/drivers/r600/r600_pipe

Re: [Mesa-dev] [PATCH 1/4] r600g: make all scissor states use single atom

2015-08-25 Thread Grazvydas Ignotas
> to all scissors, not just 0. That is, if scissor.enable is changed, > all scissors must be marked as dirty. > > Marek > > On Mon, Aug 24, 2015 at 2:24 AM, Grazvydas Ignotas wrote: >> As suggested by Marek Olšák, we can use single atom to track all scissor >> states.

Re: [Mesa-dev] [PATCH 00/42] RadeonSI cleaning up states

2015-08-30 Thread Grazvydas Ignotas
Hi, On Sun, Aug 30, 2015 at 10:11 PM, Marek Olšák wrote: > The viewport and scissor states are optimized. The main thing is that setting > non-zero viewports and scissors is delayed until a shader that writes > VIEWPORT_INDEX appears (which is typically never). ... > > Radeonsi no longer coun

Re: [Mesa-dev] [PATCH 13/42] radeonsi: use a bitmask for tracking dirty atoms

2015-08-30 Thread Grazvydas Ignotas
On Sun, Aug 30, 2015 at 10:11 PM, Marek Olšák wrote: ... > diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c > b/src/gallium/drivers/radeonsi/si_state_draw.c > index 2ff58d1..81575b5 100644 > --- a/src/gallium/drivers/radeonsi/si_state_draw.c > +++ b/src/gallium/drivers/radeonsi/si_state_

Re: [Mesa-dev] [PATCH 40/42] winsys/radeon: add a flag telling how gfx IBs should be padded

2015-08-30 Thread Grazvydas Ignotas
On Sun, Aug 30, 2015 at 10:12 PM, Marek Olšák wrote: > From: Marek Olšák > > This is always false on amdgpu (set by calloc). > --- > src/gallium/drivers/radeon/radeon_winsys.h| 1 + > src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 4 +--- > src/gallium/winsys/radeon/drm/radeon_drm_w

Re: [Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-04 Thread Grazvydas Ignotas
On Tue, Oct 4, 2016 at 3:15 AM, Timothy Arceri wrote: > This fixes an unused variable warning on release builds. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 1/4] amd/common: add nir->llvm translation.

2016-10-04 Thread Grazvydas Ignotas
On Tue, Oct 4, 2016 at 1:09 PM, Nicolai Hähnle wrote: > On 04.10.2016 03:48, Dave Airlie wrote: > > [snip] >> >> diff --git a/src/amd/common/ac_llvm_helper.cpp >> b/src/amd/common/ac_llvm_helper.cpp >> new file mode 100644 >> index 000..feafdaf >> --- /dev/null >> +++ b/src/amd/common/ac_llvm_

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

2016-10-11 Thread Grazvydas Ignotas
On Mon, Oct 10, 2016 at 2:25 PM, Marek Olšák wrote: > From: Marek Olšák > > The kernel patch has been sent to amd-gfx. > --- > src/gallium/drivers/radeonsi/si_compute.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_compute.c > b/s

Re: [Mesa-dev] [PATCH] radv: Suffix the intel_icd file with the host CPU

2016-11-09 Thread Grazvydas Ignotas
On Wed, Nov 9, 2016 at 8:11 PM, Emil Velikov wrote: > From: Emil Velikov > > Port of the anv commit d96345de989 ("anv: Suffix the intel_icd file with > the host CPU"). I guess the subject of this patch should say radeon_icd instead of intel_icd. Gražvydas ___

[Mesa-dev] [PATCH 1/3] radv: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Just mark with MAYBE_UNUSED. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/vulkan/radv_cmd_buffer.c | 34 ++ src/amd/vulkan/radv_query.c | 6 +++--- 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 2/3] radv/meta: use VK_NULL_HANDLE for handles

2016-12-10 Thread Grazvydas Ignotas
Otherwise we get 32bit warnings because handle is plain uint64_t there and NULL is not suited to initialize that. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/vulkan/radv_meta_blit2d.c | 2 +- src/amd/vulkan/radv_meta_bufimage.c | 2 +- src/amd

[Mesa-dev] [PATCH] radeonsi: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/gallium/drivers/radeonsi/si_blit.c | 2 +- src/gallium/drivers/radeonsi/si_state.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium

[Mesa-dev] [PATCH 3/3] radv/ac: some fix maybe-uninitialized warnings

2016-12-10 Thread Grazvydas Ignotas
Mark some paths unreachable so that compiler knows variables are initialized in all valid paths. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/common

[Mesa-dev] [PATCH] anv: fix release build unused variable warnings

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/intel/vulkan/anv_blorp.c | 3 ++- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index

[Mesa-dev] [PATCH] intel/aubinator: fix 32bit shift overflow warning

2016-12-10 Thread Grazvydas Ignotas
Doesn't look like this can work on 32bit, just rids of annoying warning. Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/intel/tools/aubinator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/

[Mesa-dev] [PATCH] i965: fix release build unused variable warning

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- src/mesa/drivers/dri/i965/brw_blorp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 4c1d858..8b5750c 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] softpipe: fix release build unused variable warning

2016-12-10 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- no commit access, somebody please push src/gallium/drivers/softpipe/sp_state_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_state_shader.c b/src/gallium/drivers/softpipe/sp_state_shader.c index

[Mesa-dev] [PATCH 1/2] vulkan: deduplicate the util code

2016-12-11 Thread Grazvydas Ignotas
anv_util.c and radv_util.c are essentially duplicates, so create a new vk_util.c to be shared by both vulkan drivers. Some other content from anv_private.h and radv_private.h was moved to vk_util.h too. Signed-off-by: Grazvydas Ignotas --- no commit access configure.ac

[Mesa-dev] [PATCH 2/2] vulkan: fix 'statement with no effect' warning

2016-12-11 Thread Grazvydas Ignotas
Emitted on release build in case vk_error() return is not used. Signed-off-by: Grazvydas Ignotas --- no commit access src/vulkan/vk_util.c | 4 src/vulkan/vk_util.h | 13 - 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/vulkan/vk_util.c b/src/vulkan

[Mesa-dev] [PATCH v2] i965: fix release build unused variable warning

2016-12-11 Thread Grazvydas Ignotas
Signed-off-by: Grazvydas Ignotas --- v2: take Eduardo Lima's suggestion further - remove the variable completely no commit access src/mesa/drivers/dri/i965/brw_blorp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src

Re: [Mesa-dev] [PATCH v2] nir/algebraic: Add optimizations for "a == a && a CMP b"

2016-12-23 Thread Grazvydas Ignotas
On Thu, Dec 22, 2016 at 11:54 PM, Jason Ekstrand wrote: > This sequence shows up The Talos Principal, at least under Vulkan, Not really important, except maybe when looking for patches affecting the game, but I've noticed you keep calling it "Principal", while the game is "The Talos Principle".

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-06-29 Thread Grazvydas Ignotas
On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri wrote: > On Wed, 2016-06-29 at 03:47 +0300, Grazvydas Ignotas wrote: >> On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri >> wrote: >> > On Mon, 2016-06-27 at 00:46 +1000, Timothy Arceri wrote: >> > > On Sun,

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-07-09 Thread Grazvydas Ignotas
On Sat, Jul 9, 2016 at 10:02 AM, Timothy Arceri wrote: > On Fri, 2016-07-01 at 14:12 +1000, Timothy Arceri wrote: >> On Thu, 2016-06-30 at 00:59 +0300, Grazvydas Ignotas wrote: >> > On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri >> > wrote: >> > > On We

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

2016-07-09 Thread Grazvydas Ignotas
On Sat, Jul 9, 2016 at 6:49 PM, Marek Olšák wrote: > On Fri, Jul 8, 2016 at 3:20 AM, Timothy Arceri > wrote: >> On Wed, 2016-06-29 at 18:32 +0200, Marek Olšák wrote: >>> Hi, >>> >>> This series implements basic multithreaded LLVM shader compilation >>> in a minimally invasive way. (+51 lines of c

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add a workaround for a compute VGPR-usage LLVM bug

2016-07-13 Thread Grazvydas Ignotas
On Tue, Jul 12, 2016 at 11:52 PM, Marek Olšák wrote: > From: Marek Olšák > > This patch may be dropped depending on feedback. > > Cc: 12.0 > --- > src/gallium/drivers/radeonsi/si_shader.c | 33 > > 1 file changed, 33 insertions(+) > > diff --git a/src/gallium/d

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-07-13 Thread Grazvydas Ignotas
On Wed, Jul 13, 2016 at 2:56 AM, Timothy Arceri wrote: > On Sat, 2016-07-09 at 20:21 +0300, Grazvydas Ignotas wrote: >> >> I think I still have some more: >> - running 32bit program after 64bit version of the same thing (or >> vice >> versa) leads to segfaults and

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

2016-07-16 Thread Grazvydas Ignotas
On Sat, Jul 16, 2016 at 2:00 AM, Marek Olšák wrote: > On Wed, Jul 13, 2016 at 10:50 AM, Vedran Miletić wrote: >> On 07/13/2016 05:19 AM, Timothy Arceri wrote: >>> >>> So I finally got around to setting up my new polaris card on fedora. I >>> was curious to see how Talos performed compared to i965

Re: [Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps

2016-07-18 Thread Grazvydas Ignotas
On Mon, Jul 18, 2016 at 3:14 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/os/os_time.c | 15 +-- > src/gallium/auxiliary/os/os_time.h | 4 > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/src/gallium/auxiliary/os/os_time.c > b/

Re: [Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

2016-07-30 Thread Grazvydas Ignotas
On Sat, Jul 30, 2016 at 6:22 PM, Marek Olšák wrote: > From: Marek Olšák > > for debugging > --- > src/gallium/auxiliary/os/os_process.c | 37 > +++ > src/gallium/auxiliary/os/os_process.h | 2 ++ > 2 files changed, 39 insertions(+) > > diff --git a/src/gallium/a

[Mesa-dev] [PATCH 2/6] r600g: apply disable workaround on all scissors

2015-09-02 Thread Grazvydas Ignotas
During review of the "r600g: make all scissor states use single atom" patch Marek Olšák noticed that scissor disable workaround should be applied on all scissor states and not just first one, so let's do so. --- src/gallium/drivers/r600/r600_state.c| 22 +- src/gallium/

[Mesa-dev] [PATCH 5/6] r600g: simplify dirty atom tracking

2015-09-02 Thread Grazvydas Ignotas
Now that R600_NUM_ATOMS is below 64, dirty atom tracking can be simplified. --- src/gallium/drivers/r600/r600_hw_context.c | 9 +++--- src/gallium/drivers/r600/r600_pipe.h | 45 src/gallium/drivers/r600/r600_state_common.c | 9 +++--- 3 files changed, 14 in

[Mesa-dev] [PATCHv2 3/6] r600g: make all viewport states use single atom

2015-09-02 Thread Grazvydas Ignotas
Similarly to scissor states, we can use single atom to track all viewport states. This will allow to simplify dirty atom handling later. --- v2: rebased, moved dirty_mask set out of the loop src/gallium/drivers/r600/evergreen_state.c | 7 ++--- src/gallium/drivers/r600/r600_blit.c | 2

[Mesa-dev] [PATCH 6/6] gallium/radeon: remove 'dirty' member from r600_atom

2015-09-02 Thread Grazvydas Ignotas
It's no longer used by both r600 and radeonsi now. --- src/gallium/drivers/r600/r600_pipe.h | 2 -- src/gallium/drivers/r600/r600_state_common.c | 1 - src/gallium/drivers/radeon/r600_pipe_common.h | 3 +-- src/gallium/drivers/radeonsi/si_state.c | 1 - 4 files changed, 1 insertion

[Mesa-dev] [PATCH 4/6] r600g: start numbering atoms from 1

2015-09-02 Thread Grazvydas Ignotas
There doesn't seem any reason to start from 4. Start from 1 instead (0 is left reserved to catch uninitialized atoms). --- src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_pipe.h | 2 +- src/gallium/drivers/r600/r600_state.c | 2 +- 3 files changed, 3 ins

[Mesa-dev] [PATCHv2 1/6] r600g: make all scissor states use single atom

2015-09-02 Thread Grazvydas Ignotas
As suggested by Marek Olšák, we can use single atom to track all scissor states. This will allow to simplify dirty atom handling later. --- v2: rebased, moved dirty_mask set out of the loop src/gallium/drivers/r600/evergreen_state.c | 36 ++ src/gallium/drivers/r600/r600_bli

[Mesa-dev] [PATCH] r600g: update num_dw in scissor_enable workaround

2015-09-09 Thread Grazvydas Ignotas
"r600g: apply disable workaround on all scissors" forgot to update num_dw, fix it. Fixes: fbb423b433 "r600g: apply disable workaround on all scissors" Reported-and-tested-by: Markus Trippelsdorf Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91921 --- src/gallium/drivers/r600/r600_state_

Re: [Mesa-dev] [PATCH] r600g: update num_dw in scissor_enable workaround

2015-09-10 Thread Grazvydas Ignotas
On Thu, Sep 10, 2015 at 5:35 AM, Michel Dänzer wrote: > On 10.09.2015 01:33, Grazvydas Ignotas wrote: >> "r600g: apply disable workaround on all scissors" forgot to update >> num_dw, fix it. >> >> Fixes: fbb423b433 "r600g: apply disable workaround

[Mesa-dev] [PATCH resend] r600g: update num_dw in scissor_enable workaround

2015-09-22 Thread Grazvydas Ignotas
"r600g: apply disable workaround on all scissors" forgot to update num_dw, fix it. Fixes: fbb423b433 "r600g: apply disable workaround on all scissors" Reported-and-tested-by: Markus Trippelsdorf Signed-off-by: Grazvydas Ignotas --- resending with s-o-b src/

[Mesa-dev] [PATCH] r600g: don't leak driver const buffers

2016-01-20 Thread Grazvydas Ignotas
The buffers are referenced from r600_update_driver_const_buffers() -> r600_set_constant_buffer() -> u_upload_data(), but nothing ever releases the reference. Similar case with driver_consts. Found using valgrind. Signed-off-by: Grazvydas Ignotas --- No commit access, if the patch is ok s

Re: [Mesa-dev] Merging the Vulkan driver

2016-04-07 Thread Grazvydas Ignotas
Hi, On Tue, Apr 5, 2016 at 10:30 PM, Jason Ekstrand wrote: > I know we don't usually do merges in this project, but > the Vulkan driver is big and has a lot of history that we would like to > preserve. If you're strongly opposed to doing a merge, please speak up now! I fear issues like the one

Re: [Mesa-dev] [PATCH] st/nine: correctly fold guards around define WINAPI

2016-04-15 Thread Grazvydas Ignotas
On Fri, Apr 15, 2016 at 6:06 PM, Emil Velikov wrote: > From: Emil Velikov > > The __i386__ and __x86-64__ macros are gcc/clang specific, thus one does > not need the __GNUC__ at the top. > > Additionally, having _M_IX86 and _M_X64 in the same block (and even use > __attribute__(foo)) is wrong as

Re: [Mesa-dev] [PATCH] st/nine: correctly fold guards around define WINAPI

2016-04-15 Thread Grazvydas Ignotas
On Fri, Apr 15, 2016 at 9:46 PM, Christian Schmidbauer wrote: > On 15/04/16 17:06, Emil Velikov wrote: >> From: Emil Velikov >> >> The __i386__ and __x86-64__ macros are gcc/clang specific, thus one does >> not need the __GNUC__ at the top. >> >> Additionally, having _M_IX86 and _M_X64 in the sam

[Mesa-dev] [PATCH] mesa: add tags file to gitignore

2016-04-15 Thread Grazvydas Ignotas
For ctags users like me. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index b4f88f7..7db5639 100644 --- a/.gitignore +++ b/.gitignore @@ -34,6 +34,7

[Mesa-dev] [PATCH 5/7] isl: fix warnings in release build

2016-04-15 Thread Grazvydas Ignotas
Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings in release build. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/intel/isl/isl.c | 2 +- src/intel/isl/isl_gen7.c | 2 +- 2 files changed, 2 insertions(+), 2

[Mesa-dev] [PATCH 0/7] release build warning fixes

2016-04-15 Thread Grazvydas Ignotas
I guess almost everyone here builds mesa with asserts enabled, but many forget asserts are off by default, so ordinary users get thrown at quite a lot of warnings. This tries to improve the situation somewhat. Grazvydas Ignotas (7): util: add MAYBE_UNUSED for config dependent variables glsl

[Mesa-dev] [PATCH 4/7] spirv: fix warning in release build

2016-04-15 Thread Grazvydas Ignotas
Mark variable MAYBE_UNUSED to avoid unused-but-set-variable warning in release build. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/compiler/spirv/vtn_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

[Mesa-dev] [PATCH 2/7] glsl: fix warning in release build

2016-04-15 Thread Grazvydas Ignotas
Mark variable MAYBE_UNUSED to avoid unused-but-set-variable warning in release build. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/compiler/glsl/lower_buffer_access.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 7/7] gallium: use unreachable instead of asserts

2016-04-15 Thread Grazvydas Ignotas
Avoids warnings in release builds. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/gallium/auxiliary/gallivm/lp_bld_intr.c | 2 +- src/gallium/drivers/radeon/radeon_llvm_emit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[Mesa-dev] [PATCH 3/7] gallium: fix warnings in release build

2016-04-15 Thread Grazvydas Ignotas
Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings in release build. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c | 2 +- src/gallium/auxiliary/util/u_surface.c

[Mesa-dev] [PATCH 6/7] anv: fix warnings in release build

2016-04-15 Thread Grazvydas Ignotas
Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings in release build. Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/intel/vulkan/anv_dump.c | 2 +- src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-15 Thread Grazvydas Ignotas
on both GCC 4.2 (oldest supported by mesa) and clang 3.0 (just some random old version, nut sure what's the minimum for mesa). Signed-off-by: Grazvydas Ignotas --- I have no commit access, if this patch is ok, please someone push. src/util/macros.h | 2 ++ 1 file changed, 2 insertions(+)

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

2016-04-17 Thread Grazvydas Ignotas
On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov wrote: > On 16 April 2016 at 02:00, Grazvydas Ignotas wrote: >> This is mostly for variables that are only used in asserts and cause >> unused-but-set-variable warnings in release builds. Could just use >> UNUSED directly, but M

Re: [Mesa-dev] [PATCH] [v2] i965/skl: Add two missing device IDs

2016-02-16 Thread Grazvydas Ignotas
On Wed, Feb 17, 2016 at 1:45 AM, Ben Widawsky wrote: > The Iris part is left unbranded because we did not have these with original > SKL. > > v2: 0x192d is gt3, not gt4 The name and description still don't agree. > > Cc: "11.0 11.1" Signed-off-by: Ben Widawsky > --- > include/pci_ids/i965_pc

Re: [Mesa-dev] [PATCH 2/3] st/mesa: set TGSI property NEXT_SHADER

2016-03-11 Thread Grazvydas Ignotas
On Thu, Mar 10, 2016 at 7:36 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 35 > ++ > 1 file changed, 35 insertions(+) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > b/src/mesa/state_tracker/st_glsl_

Re: [Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

2016-03-11 Thread Grazvydas Ignotas
On Fri, Mar 11, 2016 at 7:48 PM, Marek Olšák wrote: > Can you paste the build failures please? In file included from compute_memory_pool.c:42:0: evergreen_compute_internal.h:43:2: error: unknown type name ‘LLVMContextRef’ LLVMContextRef llvm_ctx; ^ evergreen_compute.c: In function ‘evergreen_

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

2016-05-30 Thread Grazvydas Ignotas
On Mon, May 30, 2016 at 3:46 PM, Emil Velikov wrote: > From: Emil Velikov > > As we'll need the file in the release tarball, rework the rule so that > the file is regenerated _only_ if we're in a git repository. > > With this in place we can build vulkan (anv) from a release tarball. After this

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
I've tried it on AMD JUNIPER (DRM 2.43.0 / 4.6.0) and it does not pass the kernel CS validator with [drm:evergreen_packet3_check.isra.14 [radeon]] *ERROR* Packet3 opcode 42 not supported printed many times. I guess it needs some kernel patch? I haven't found anything relevant in Alex's kernel git.

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
nch is based on, don't know if it has any effect. Should I attempt to bisect? Gražvydas On Tue, May 31, 2016 at 1:30 AM, Marek Olšák wrote: > On Tue, May 31, 2016 at 12:17 AM, Grazvydas Ignotas wrote: >> I've tried it on AMD JUNIPER (DRM 2.43.0 / 4.6.0) and it does not pa

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

2016-05-30 Thread Grazvydas Ignotas
On Tue, May 31, 2016 at 2:58 AM, Grazvydas Ignotas wrote: > I've patched the CS validator and there seem to be some regressions: > > arb_map_buffer_range 11/11 5/11 > copybuffersubdata decrement-offset > copybuffersubdata increment-offset > copybuffersubdata offset=0 >

Re: [Mesa-dev] [PATCH 2/2] automake: bring back the .PHONY git_sha1.h.tmp rule

2016-05-31 Thread Grazvydas Ignotas
ed to ensure that the header is regenerated when on each > make invocation, while the latter helps us avoid the unneeded rebuild(s) > when the SHA1 hasn't changed. > > Cc: Grazvydas Ignotas > Reported-by: Grazvydas Ignotas > Signed-off-by: Emil Velikov > --- > And the br

Re: [Mesa-dev] [PATCH 2/2] i965: Add norbc debug option

2016-05-31 Thread Grazvydas Ignotas
On Tue, May 31, 2016 at 5:16 PM, Topi Pohjolainen wrote: > This INTEL_DEBUG option disables lossless compression (also known > as render buffer compression). > > Suggested-by: Eero Tamminen > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_debug.c | 1 + > src/mesa

Re: [Mesa-dev] [PATCH 00/10] R600: Cache flush fixes and cleanup v2

2016-06-01 Thread Grazvydas Ignotas
On Wed, Jun 1, 2016 at 9:57 PM, Marek Olšák wrote: > Hi, > > This is version 2 of the previous series. This time it's been tested!! > > Tested cards: > - RV670 > - RV730 > - EG/REDWOOD > - CAYMAN All good on JUNIPER now (piglit and a few random games). Tested-by:

Re: [Mesa-dev] [PATCH 7/9] anv/pipeline: Silently pass tests if depth or stencil is missing

2016-06-02 Thread Grazvydas Ignotas
On Thu, Jun 2, 2016 at 12:44 AM, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Cc: "12.0" > Cc: Ian Romanick > --- > src/intel/vulkan/gen7_pipeline.c | 12 ++-- > src/intel/vulkan/gen8_pipeline.c | 12 ++-- > src/intel/vulkan/genX_pipeline_util.h | 30 ++

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-06-26 Thread Grazvydas Ignotas
Tried this while playing with apitrace and am getting segfaults when running any trace with a cached (second) run. Not sure if it's "wrong" traces I've chosen or what, you can take one example from this bug: https://bugs.freedesktop.org/show_bug.cgi?id=96425 It would also be good idea to hide the

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

2016-06-26 Thread Grazvydas Ignotas
On Sat, Jun 25, 2016 at 4:54 PM, Alejandro Piñeiro wrote: > In theory they don't overdrawn. The test has a square formed by N > non-overlapping triangles. With just one call to glDrawRangeElements, > this always works. But if we split it in M subsets, so M calls to > glDrawRangeElements with N/M t

[Mesa-dev] [PATCH] doc: improve INTEL_DEBUG documentation

2016-06-27 Thread Grazvydas Ignotas
Remove 'reg' option that does not actually exist, elaborate more about 'sync' and add the missing options. Signed-off-by: Grazvydas Ignotas --- no commit access, if this is ok please somebody push docs/envvars.html | 12 ++-- 1 file changed, 10 insertions(+),

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-06-28 Thread Grazvydas Ignotas
On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri wrote: > On Mon, 2016-06-27 at 00:46 +1000, Timothy Arceri wrote: >> On Sun, 2016-06-26 at 16:15 +0300, Grazvydas Ignotas wrote: >> > Tried this while playing with apitrace and am getting segfaults >> > when >>

Re: [Mesa-dev] r600 tess branches updated

2015-12-06 Thread Grazvydas Ignotas
Hi, On Fri, Dec 4, 2015 at 6:19 AM, Dave Airlie wrote: > Hey all, > > I've pushed an updated version of the r600g tess support to my > r600g-tess-submit branch. FWIW: Tested-by: Grazvydas Ignotas on JUNIPER XT with heaven and piglit, no issues no

[Mesa-dev] [PATCH] r600: fix constant buffer size programming

2015-12-21 Thread Grazvydas Ignotas
i?id=92229 Signed-off-by: Grazvydas Ignotas --- Only tested on Juniper, but I guess others will need this too. src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_state.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/dr

Re: [Mesa-dev] [PATCH] r600: fix constant buffer size programming

2015-12-22 Thread Grazvydas Ignotas
On Tue, Dec 22, 2015 at 5:37 PM, Nicolai Hähnle wrote: > On 21.12.2015 21:12, Grazvydas Ignotas wrote: >> >> When buffer size is less than 16, zero ends up being programmed as >> size, which prevents the hardware from fetching the correct values. >> Fix it by combining

Re: [Mesa-dev] [PATCH 1/9] util: Add a string buffer implementation

2017-05-21 Thread Grazvydas Ignotas
On Sun, May 21, 2017 at 11:49 PM, Thomas Helland wrote: > Based on Vladislav Egorov's work on the preprocessor, but split > out to a util functionality that should be universal. Setup, teardown, > memory handling and general layout is modeled around the hash_table > and the set, to make it familia

[Mesa-dev] [PATCH] Revert "egl/display: remove unnecessary code and make it easier to read"

2017-05-31 Thread Grazvydas Ignotas
;native_platform' as soon as it's not _EGL_INVALID_PLATFORM, it should not cause problems in practice. Cc: Eric Engestrom Fixes: 7adb9b0948 "egl/display: remove unnecessary code and make it easier to read" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101252 Signed-off-

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

2017-06-01 Thread Grazvydas Ignotas
s possible. > > Reported-by: Grazvydas Ignotas Not really, see https://bugs.freedesktop.org/show_bug.cgi?id=101252 > Signed-off-by: Eric Engestrom > --- > > This is unnecessary in my opinion, but doesn't hurt :) It is necessary, without it things will work most of the time

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

2017-06-01 Thread Grazvydas Ignotas
On Thu, Jun 1, 2017 at 4:23 PM, Emil Velikov wrote: > Hi guys, > > On 1 June 2017 at 12:56, Grazvydas Ignotas wrote: >> On Thu, Jun 1, 2017 at 2:15 PM, Eric Engestrom >> wrote: >>> If the detections methods ever become able to return different results >>&

Re: [Mesa-dev] [PATCH 03/11] radeonsi: decrease the number of compiler threads to num CPUs - 1

2017-06-02 Thread Grazvydas Ignotas
With the "core wars" starting (16core/32thread "consumer" CPUs announced), maybe it's time to add an upper limit? Waking up a core from low power state has it's latency, it's sometimes faster to just do several jobs on an active core than to wake another one (which will also cause more lock content

[Mesa-dev] [PATCH] nir: make various getters take const pointers

2017-06-06 Thread Grazvydas Ignotas
This will allow to constify other things. Signed-off-by: Grazvydas Ignotas --- src/compiler/nir/nir.h | 25 + src/compiler/nir/nir_lower_io.c | 2 +- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir

[Mesa-dev] [PATCH 1/3] ac/nir: mark some arguments const

2017-06-06 Thread Grazvydas Ignotas
Most functions are only inspecting nir, so nir related arguments can be marked const. Some more can be done if/when some nir changes are accepted. Signed-off-by: Grazvydas Ignotas --- does *not* depend on the nir patch src/amd/common/ac_nir_to_llvm.c | 61

[Mesa-dev] [PATCH 2/3] ac/nir: convert several ifs to a switch

2017-06-06 Thread Grazvydas Ignotas
Also solve "outinfo may be used uninitialized" warning by putting in an unreachable(). Signed-off-by: Grazvydas Ignotas --- src/amd/common/ac_nir_to_llvm.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/

  1   2   3   4   >