+1` includes the final
'\0' in the move to terminate the string.
What's happening is that since we start the move at `end+1`, the length
becomes off by one.
With that fixed, this is:
Reviewed-by: Eric Engestrom
That said, a better fix IMO would be:
- memmove(str_start,
On Wednesday, 2017-02-01 11:24:39 -0500, Robert Foss wrote:
> Add assert checking that num_sources is never larger than 3.
>
> This prevents Coverity from concluding that the unhandled
> cases of num_sources not being 0-3 are relevant.
>
> Coverity-Id: 1399480-1399489
> Signed-off-by: Robert Foss
the spec says, the code looks good and the enum are in
Mesa's private range, so patches #2 & #3 are:
Reviewed-by: Eric Engestrom
>
> On 26.01.2017 12:50, Nicolai Hähnle wrote:
> > Hi all,
> >
> > this is mostly motivated by the need to support more screen depths t
This page was severely out of date... essentially everything was wrong
by now :P
Eric Engestrom (4):
docs: add a note about the new version scheme
docs: remove dead 'beta' link
docs: fix unpacking instructions
docs: update package contents
docs/download
Release candidates haven't been in a 'beta' subdir in a long time, so let's
replace the dead link with an explanation instead.
Signed-off-by: Eric Engestrom
---
docs/download.html | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/download.html b/docs
Signed-off-by: Eric Engestrom
---
Do we want to list all the modules under src/ ?
The current list seems a bit arbitrary:
src/- source code for libraries
src/mesa- sources for the main Mesa library and device drivers
src/gallium - sources for Gallium and Gallium drivers
Signed-off-by: Eric Engestrom
---
docs/download.html | 8
1 file changed, 8 insertions(+)
diff --git a/docs/download.html b/docs/download.html
index e90c1bbbf2..1cbfded575 100644
--- a/docs/download.html
+++ b/docs/download.html
@@ -24,6 +24,14 @@
+Starting with the first release
File names were wrong, file formats were wrong, bunzip command was
wrong...
I also removed all but the simplest example; people who use pipes already
know how to untar, so let's simplify and remove potential confusion for
non-tech-savvy users.
Signed-off-by: Eric Engestrom
---
Thanks Brian!
I would've used https for the links, but I'll just fix that later.
Series is:
Reviewed-by: Eric Engestrom
And pushed :)
On Wednesday, 2017-02-08 12:31:44 -0700, Brian Paul wrote:
> ---
> docs/intro.html | 42 +++---
>
CID: 1400129
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/etnaviv/etnaviv_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_context.c
b/src/gallium/drivers/etnaviv/etnaviv_context.c
index d767cd1f38..f5fa5c53ae 100644
CID: 1400128
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c
b/src/gallium/drivers/etnaviv/etnaviv_screen.c
index 8f2882f573..e398629a42 100644
--- a
Signed-off-by: Eric Engestrom
---
docs/relnotes/7.5.1.html | 2 +-
docs/relnotes/7.5.2.html | 2 +-
docs/relnotes/7.5.html | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/relnotes/7.5.1.html b/docs/relnotes/7.5.1.html
index cf5a5691de..5afd5c0abc 100644
--- a/docs
Signed-off-by: Eric Engestrom
---
docs/thanks.html | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/docs/thanks.html b/docs/thanks.html
index 685cb31e64..bca4b3424f 100644
--- a/docs/thanks.html
+++ b/docs/thanks.html
@@ -40,14 +40,9 @@
The
-http
Most of them already redirected to https anyway, so we might as well
avoid the redirection and the security implications by linking directly
to the right protocol.
Signed-off-by: Eric Engestrom
---
docs/README.WIN32 | 2 +-
docs/application-issues.html | 2 +-
docs
->base;
With this, you can also drop the `pctx = NULL` a couple lines above.
Series is:
Reviewed-by: Eric Engestrom
Cheers,
Eric
> + pctx->priv = ctx;
> + pctx->screen = pscreen;
> +
> screen = etna_screen(pscreen);
> ctx->stream = etna_cmd_strea
Signed-off-by: Eric Engestrom
---
docs/egl.html | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/egl.html b/docs/egl.html
index 6868448bc4..c22aa4a338 100644
--- a/docs/egl.html
+++ b/docs/egl.html
@@ -83,9 +83,9 @@
List the platforms (window systems) to support
Reviewed-by: Eric Engestrom
On Thursday, 2017-02-09 22:42:51 +1100, Timothy Arceri wrote:
> ---
> src/util/disk_cache.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c
> index edfff73..22a8
ng ")
These are posix headers, so I'm assuming *BSD systems won't be affected?
Reviewed-by: Eric Engestrom
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99701
> v2: [Emil: handle stdlib.h add commit message]
> Signed-off-by: Emil Velikov
> ---
> Vinson, Nico
On Friday, 2017-02-10 09:27:51 +0100, Volker Vogelhuber wrote:
> Hi,
> I'm currently try to stream video data to an OpenGL texture.
> While using the EGL_DRM_BUFFER_USE_SCANOUT_MESA flag
> when creating the memory for the texture makes it at least
> a bit easier (only X-tiling instead of Y-tiling o
tioned
> games not working.
>
> Fixes: 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and indices")
> Cc: "13.0"
> Cc: "17.0"
> Cc: Adam Jackson
> Signed-off-by: Hans de Goede
Reviewed-by: Eric Engestrom
> ---
> src/glx/g_glxg
On Monday, 2017-02-13 13:42:19 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Print only the information needed. Namely:
> *info: the DRI module picked and the vendor/renderer strings
> *gears: everything but the "...configuration file..." line(s)
>
> Signed-off-by: Emil Velikov
> ---
> d
On Monday, 2017-02-13 13:42:20 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Things are automated via git hooks.
>
> Cc: Brian Paul
> Cc: Eric Engestrom
> Signed-off-by: Emil Velikov
> ---
> Guys, let me know when things are in place.
This is *not* in plac
On Monday, 2017-02-13 13:42:21 +, Emil Velikov wrote:
> From: Emil Velikov
>
I just noticed xlibdriver.html and versions.html are also missing from
contents.html, if you want to add them as well :)
> Signed-off-by: Emil Velikov
> ---
> docs/contents.html | 1 +
> 1 file changed, 1 inserti
That link has been dead for 15 years...
We could link to Archive.org [1] to get the last time this page existed,
but I feel like Wikipedia is a better choice.
[1]
http://web.archive.org/web/20021211151318/http://www.inforamp.net/~poynton/notes/colour_and_gamma/GammaFAQ.html
Signed-off-by: Eric
Signed-off-by: Eric Engestrom
---
docs/sourcedocs.html | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/sourcedocs.html b/docs/sourcedocs.html
index 454ea7d677..660dcb2ef0 100644
--- a/docs/sourcedocs.html
+++ b/docs/sourcedocs.html
@@ -41,6 +41,11 @@
here
+
+Gallium is also
From: Eric Engestrom
The memset on the line before already takes care of this.
Signed-off-by: Eric Engestrom
---
src/egl/main/eglimage.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/egl/main/eglimage.c b/src/egl/main/eglimage.c
index 818b5975cd..d062cbfe01 100644
--- a/src/egl
From: Eric Engestrom
That link has been dead for 15 years...
We could link to Archive.org [1] to get the last time this page existed,
but I feel like Wikipedia is a better choice.
[1]
http://web.archive.org/web/20021211151318/http://www.inforamp.net/~poynton/notes/colour_and_gamma
On Wednesday, 2017-02-15 15:36:00 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Drop the extra handling and assert() if things change in the future.
>
> Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
> ---
> src/egl/main/eglarray.c | 27 +---
Reviewed-by: Eric Engestrom
On Wednesday, 2017-02-15 09:30:01 -0800, Jason Ekstrand wrote:
> ---
> src/util/Makefile.sources | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/util/Makefile.sources b/src/util/Makefile.sources
> index eec0311..aecb
From: Brendan King
This is a DRI3 version of a change made for DRI2
(4d6d4f939e0af4252e0b, "egl/dri2: implement query surface hook"),
that fixed failures in dEQP-EGL.functional.resize.surface_size.grow
and dEQP-EGL.functional.resize.surface_size.shrink.
Cc: Tapani Pälli
Cc: Mark Janes
Cc: Chad
Hey all,
I (finally) set up the git hook, which means that the website [1] is now
automagically updated whenever a change in docs/* on master is pushed.
There might be bugs, and I'll be doing some other git hook related
changes later on; if you see anything weird when pushing or if the
website's
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index cab05c2301..251855cc3b 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 251855cc3b..e149c0f8d1 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
This will allow us to make sure the list is always sorted in the next
commit.
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 78 +-
src/egl/main/eglentrypoint.def | 77 +
2 files changed, 78
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 31 ---
1 file changed, 24 insertions(+), 7 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index e149c0f8d1..e44375a106 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
Tested with dEQP-EGL.functional.get_proc_address.*
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 1038916cd2..b6a5b1c978
Starting with the next commit, badly sorting this list will break the
eglGetProcAddress().
Signed-off-by: Eric Engestrom
---
src/egl/Makefile.am | 3 ++-
src/egl/egl-entrypoint-check | 4
2 files changed, 6 insertions(+), 1 deletion(-)
create mode 100755 src/egl/egl-entrypoint
Let's make that comment true.
If will also be necessary in a couple commits (using bsearch).
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 74 +--
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/src/egl/main/eglap
As of the last 3 commits, there's a function for each entrypoint.
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 149 +-
1 file changed, 75 insertions(+), 74 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
out, but honestly I just thought this looked cleaner.
Also, I think the debug extension would print the wrong function names
before these patches? Not tested though, maybe it somehow worked.
>
> On Sun, Feb 19, 2017 at 6:23 PM, Eric Engestrom wrote:
> > Signed-off-by: Eric Engestrom
&
On Sunday, 2017-02-19 15:38:05 -0800, Matt Turner wrote:
> On Sun, Feb 19, 2017 at 3:23 PM, Eric Engestrom wrote:
> > Tested with dEQP-EGL.functional.get_proc_address.*
> >
> > Signed-off-by: Eric Engestrom
> > ---
> > src/egl/main/eglapi.c | 37
On Sunday, 2017-02-19 18:54:51 -0500, Ilia Mirkin wrote:
> On Sun, Feb 19, 2017 at 6:51 PM, Eric Engestrom wrote:
> > On Sunday, 2017-02-19 18:33:16 -0500, Ilia Mirkin wrote:
> >> Why are patches 1-3 necessary?
> >
> > They allow patch #4, which makes use o
On Tuesday, 2017-02-21 09:41:18 +0100, Nicolai Hähnle wrote:
> On 20.02.2017 20:27, Emil Velikov wrote:
> > From: Emil Velikov
> >
> > Suggested-by: Eric Engestrom
> > Signed-off-by: Emil Velikov
> > ---
> > docs/releasing.html | 6 +++---
> >
src/gallium/docs/source/tgsi.rst:3488: WARNING: Title underline too
short.
Signed-off-by: Eric Engestrom
---
src/gallium/docs/source/tgsi.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst
Signed-off-by: Eric Engestrom
---
src/gallium/docs/source/tgsi.rst | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst
index c296447b5c..b9b9d6ca34 100644
--- a/src/gallium/docs/source/tgsi.rst
+++ b/src/gallium/docs/source
src/gallium/docs/source/context.rst:95: ERROR: Unexpected indentation.
Sub lists need to be surrounded by a blank line.
Signed-off-by: Eric Engestrom
---
src/gallium/docs/source/context.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/docs/source/context.rst
b/src
Without these, mathjax considers these as the continuation of the
previous line.
Signed-off-by: Eric Engestrom
---
src/gallium/docs/source/tgsi.rst | 33 +
1 file changed, 33 insertions(+)
diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source
't feel right.
Cc: Rob Clark
Eric Engestrom (5):
gallium/docs: fix sublist formatting
gallium/docs: add missing math formatting
gallium/docs: add missing newlines
gallium/docs: fix section title formatting
gallium/docs: use imgmath instead of pngmath
src/gallium/docs/source/conf.py
WARNING: sphinx.ext.pngmath has been deprecated. Please use
sphinx.ext.imgmath instead.
Signed-off-by: Eric Engestrom
---
src/gallium/docs/source/conf.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/docs/source/conf.py b/src/gallium/docs/source
Signed-off-by: Eric Engestrom
---
src/glx/tests/Makefile.am | 2 +-
src/glx/tests/dispatch-index-check | 24
2 files changed, 25 insertions(+), 1 deletion(-)
create mode 100755 src/glx/tests/dispatch-index-check
diff --git a/src/glx/tests/Makefile.am b/src
On Monday, 2017-02-20 19:49:59 +, Emil Velikov wrote:
> On 19 February 2017 at 23:23, Eric Engestrom wrote:
> > Starting with the next commit, badly sorting this list will break the
> > eglGetProcAddress().
> >
> > Signed-off-by: Eric Engestrom
> > ---
>
This will allow us to make sure the list is always sorted in the next
commit.
Signed-off-by: Eric Engestrom
---
v2: use .h extension for the new file, and track it in LIBEGL_C_FILES (Emil)
---
src/egl/Makefile.sources | 1 +
src/egl/main/eglapi.c| 78
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 251855cc3b..e149c0f8d1 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 31 ---
1 file changed, 24 insertions(+), 7 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index e149c0f8d1..e44375a106 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
Signed-off-by: Eric Engestrom
---
Note for Ilia: I'm not opposed to removing the first 3 patches and
adding a macro for the special cases, but I'll wait until someone else
wants it too.
And if the request comes after this lands, these 3 patches are easy
enough to revert (just ignore the
Starting with the next commit, badly sorting this list will break the
eglGetProcAddress().
Signed-off-by: Eric Engestrom
---
v2: use sh instead of bash (Emil)
---
src/egl/Makefile.am | 3 ++-
src/egl/egl-entrypoint-check | 5 +
2 files changed, 7 insertions(+), 1 deletion
Let's make that comment true.
If will also be necessary in a couple commits (using bsearch).
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 74 +--
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/src/egl/main/eglap
Signed-off-by: Eric Engestrom
---
src/egl/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am
index bd8903f666..d36a786ab4 100644
--- a/src/egl/Makefile.am
+++ b/src/egl/Makefile.am
@@ -129,7 +129,7 @@ egl_HEADERS = \
TESTS
As of the last 3 commits, there's a function for each entrypoint.
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 149 +-
1 file changed, 75 insertions(+), 74 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
Tested with dEQP-EGL.functional.get_proc_address.*
Signed-off-by: Eric Engestrom
---
src/egl/main/eglapi.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 77ec5426ec..5694b5a4ca
Signed-off-by: Eric Engestrom
---
v2: make sure the list is in the order C's strcmp uses (Ilia)
Ilia: I used LC_ALL instead of LANG, as it takes precedence
(ie. LANG=C in this script would be overridden by
LC_ALL=en_US in the environment).
---
src/glx/tests/Makefi
On Thursday, 2017-02-23 10:46:19 -0800, Dylan Baker wrote:
> This produces an identical file except for whitespace.
>
> Signed-off-by: Dylan Baker
> ---
> src/intel/vulkan/anv_entrypoints_gen.py | 75 ++
> 1 file changed, 41 insertions(+), 34 deletions(-)
>
> diff --git
On Thursday, 2017-02-23 10:46:21 -0800, Dylan Baker wrote:
> This changes the python generator to write the files itself, rather than
> piping them out. This has a couple of advantages: first, it encapsulates
> the encoding. Second, it ensures that the header file and code file are
> generated at t
On Thursday, 2017-02-23 16:07:36 +, Emil Velikov wrote:
> You're a star Eric, thank you !
>
> On 22 February 2017 at 11:24, Eric Engestrom
> wrote:
> > Signed-off-by: Eric Engestrom
> > ---
> > v2: make sure the list is in the order C's strcmp
On Thursday, 2017-02-23 16:43:07 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Otherwise we'll fail when invoking the script outside of "make check"
>
> Signed-off-by: Emil Velikov
> ---
> src/compiler/glsl/tests/optimization-test | 10 ++
> 1 file changed, 10 insertions(+)
>
>
On Thursday, 2017-02-23 16:43:08 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Bail out early if the script is not where we expect it to be.
>
> Signed-off-by: Emil Velikov
> ---
> src/compiler/glsl/tests/optimization-test | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/sr
; +if [ "x$?" = x0 ]; then
if $PYTHON2 create_test_cases.py; then
...
With or without these nit-pick, patches 1-3 are:
Reviewed-by: Eric Engestrom
> +has_tests=1
> +fi
> +cd ..
> fi
> echo "$dir"
> done
On Thursday, 2017-02-23 16:43:10 +, Emil Velikov wrote:
> From: Emil Velikov
>
> At the moment things are completely bonkers (as can be seen from last
> commit). Regardless if we run the test as part of "make check" or
> standalone the most of the paths are wrong.
>
> Untangle things by issu
On Friday, 2017-02-24 16:46:36 +, Emil Velikov wrote:
> On 24 February 2017 at 14:58, Eric Engestrom
> wrote:
> > On Thursday, 2017-02-23 16:07:36 +, Emil Velikov wrote:
> >> You're a star Eric, thank you !
> >>
> >> On 22 Februar
On Friday, 2017-02-24 22:03:36 -0600, Aaron Watry wrote:
> Using <<< for variable redirection is bash-specific behavior.
> Ubuntu redirects sh -> dash, so this was erroring out.
>
> Also, the initial error that led me to this was that srcdir is null when
> running make check
> so I just copied so
Noticed a couple, found the rest using vimspell.
Signed-off-by: Eric Engestrom
---
docs/autoconf.html | 4 ++--
docs/codingstyle.html | 2 +-
docs/egl.html | 2 +-
docs/envvars.html | 2 +-
docs/install.html | 2 +-
docs/llvmpipe.html
On Monday, 2017-02-27 14:22:55 +, Elie Tournier wrote:
> Some1 to review this patch?
Reviewed and pushed, thanks :)
>
> On 21/02/17 16:15, Elie Tournier wrote:
> > nir_const_value is not needed in get_iteration
> Oops typo:
> nir_alu_instr is not needed in get_iteration
... and I only just
R_GEN)
> - $(PYTHON_GEN) $(srcdir)/util/gen_enum_to_str.py
> + $(PYTHON_GEN) $(srcdir)/util/gen_enum_to_str.py -o
> $(top_builddir)/src/vulkan/util
Just like the other Makefile patch a few days ago, this rule will run
the python script twice, script which writes both files.
Not performa
On Tuesday, 2017-02-28 14:04:15 +0100, Zhiguang Liu wrote:
> Hi,
>
> I try to build vmwgfx on Ubuntu 12.04 with gcc-4.8.1, make 3.8.1. I clone
> the source files using the following command:
>
> git clone git://anongit.freedesktop.org/git/mesa/vmwgfx
>
> However, when I use 'make' command to bui
On Tuesday, 2017-02-28 14:06:14 +, Emil Velikov wrote:
> On 28 February 2017 at 11:58, Eric Engestrom
> wrote:
> > On Tuesday, 2017-02-28 01:31:01 +0100, Mauro Rossi wrote:
> >> Thanks a lot for your feedbacks.
> >> Here follows final vers
ror 1
> make[1]: *** [_module_/home/zg/vmware/vmwgfx] Error 2
> make[1]: Leaving directory `/usr/src/linux-headers-3.13.0-108-generic'
> make: *** [modules] Error 2
>
> ===
Looks like there are more issues than I thought.
I
From: Brendan King
The Wayland Scanner pkg-config file is called wayland-scanner.pc.
Fixes: 153539bd9d4445b50411 ("configure: rework wayland_scanner
handling (fix make distcheck)")
CC: Emil Velikov
Reviewed-by: Eric Engestrom
Tested-by: Eric Engestrom
Signed-off-by: Br
e7c8c85785b3a8f29e3f ("gbm: Removed unused function.") forgot to remove
the global array used only by that function.
Signed-off-by: Eric Engestrom
---
src/gbm/main/gbm.c | 12
1 file changed, 12 deletions(-)
diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c
ind
On Thu, Sep 08, 2016 at 03:12:42PM +0300, Martina Kollarova wrote:
> A possible error (-1) was being lost because it was first converted to an
> unsigned int and only then checked.
>
> Reviewed-by: Nicolai Hähnle
> Signed-off-by: Martina Kollarova
Good cleanup :)
Reviewed-by:
handle
> i915_texture_get_handle
> u_resource_get_handle_vtbl
> dri2_query_image
> gbm_dri_bo_get_fd
> gbm_bo_get_fd
>
> Signed-off-by: Nicholas Bishop
Looks good to me
Reviewed-by: Eric Engestrom
> ---
> src/gallium/state_trackers/dri/dri2.c | 11 +++
&g
From: Eero Tamminen
Signed-off-by: Eero Tamminen
Reviewed-by: Eric Engestrom
---
Eero, this is the format a patch should have when sent to mesa-dev.
You can find more info on our website [1], but the gist of it is:
- Use `git send-email`, don't attach patches to emails
- Describe the c
On Wed, Sep 14, 2016 at 02:06:18PM -0400, Adam Jackson wrote:
> Signed-off-by: Adam Jackson
The series is:
Reviewed-by: Eric Engestrom
BTW, I feel like these should be CC'ed to stable? I never know when
a fix is stable-worthy.
Cheers,
Eric
> ---
> src/glx/glxglvnd.c | 3
On Thu, Sep 22, 2016 at 09:38:06AM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> In order to avoid the current, somewhat fragile detection in
> eglplatform.h introduce explicit platform selection.
>
> The approach is based on the one used in Vulkan and allows one to
> explicitly "request"
, id++,
> - surface_type, config_attrs, rgba_masks);
> +dri2_conf = dri2_add_config(disp, config, count + 1,
> surface_type,
> +config_attrs, rgba_masks);
> +if (dri2_conf)
Nit: I would've
easier for humans to spot this
kind of mistakes.
Signed-off-by: Eric Engestrom
---
src/mapi/glapi/gen/static_data.py | 168 +++---
1 file changed, 84 insertions(+), 84 deletions(-)
diff --git a/src/mapi/glapi/gen/static_data.py
b/src/mapi/glapi/gen/static_data.py
uniqueness of the `functions` list, and the uniqueness and compactness of the
`offsets` dictionary.
[1] https://lists.freedesktop.org/archives/mesa-dev/2016-September/129525.html
Signed-off-by: Eric Engestrom
---
If people don't like enforcing the order, I'm happy to drop the previous
On Thu, Aug 25, 2016 at 05:18:32PM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Duplicate a few lines at the expense of making the code-flow clearer
> while adding a few extra comments ;-)
>
> Signed-off-by: Emil Velikov
> ---
>
> It makes things clearer the way on this end, but if peop
nt32_t capabilities;
> #endif
>
> int is_render_node;
> - int is_different_gpu;
> + int is_different_gpu;
> };
>
> struct dri2_egl_context
> @@ -262,7 +262,7 @@ struct dri2_egl_surface
fers;
> }
>
> +static const __DRIdri2LoaderExtension droid_dri2_loader_extension = {
> + .base = { __DRI_DRI2_LOADER, 3 },
> +
> + .getBuffers= NULL,
> + .flushFrontBuffer = droid_flush_front_buffer,
> + .getBuffersWithFormat = droid_get_buffers_with_
x11).
>
> Note: in the future as other platforms (android, surfaceless) support
> the extension they can reuse the helper.
>
> v2: Rebase, check for device_name.
> Signed-off-by: Emil Velikov
Patches 13-21 + 23-26 + 30 (v2 for 16, 20, 23, 25 & 30) are:
Reviewed-by: Eric Enge
On Thu, Aug 25, 2016 at 05:18:50PM +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Signed-off-by: Emil Velikov
Oops, forgot this one, which is also:
Reviewed-by: Eric Engestrom
> ---
> src/egl/drivers/dri2/platform_x11_dri3.c | 2 +-
> src/glx/dri3_glx.c
On Sat, Sep 24, 2016 at 10:27:52PM -0400, Ilia Mirkin wrote:
> On Sat, Sep 24, 2016 at 10:17 PM, Eric Engestrom wrote:
> > Dylan Baker recently added functions to that list and had to try a couple
> > times
> > to avoid duplicates. He said [1] he ended up testing it using
uniqueness of the `functions` list, and the uniqueness and compactness of the
`offsets` dictionary.
[1] https://lists.freedesktop.org/archives/mesa-dev/2016-September/129525.html
Signed-off-by: Eric Engestrom
---
v2: making a set out of a dict doesn't need to use `.keys()` (Ilia)
If p
ing order (but I hadn't thought about it until just now).
I guess the best thing is to drop patch #1 and drop the last assert from
patch #2? I'll do that tomorrow then.
Cheers,
Eric
>
> On Sep 24, 2016 10:27 PM, "Ilia Mirkin" wrote:
>
> > On Sat, Sep 24,
Signed-off-by: Eric Engestrom
---
src/compiler/spirv/spirv2nir.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/spirv2nir.c b/src/compiler/spirv/spirv2nir.c
index d151c2c..a725228 100644
--- a/src/compiler/spirv/spirv2nir.c
+++ b/src/compiler
Signed-off-by: Eric Engestrom
---
src/compiler/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/.gitignore b/src/compiler/.gitignore
index c0e6299..c4f17be 100644
--- a/src/compiler/.gitignore
+++ b/src/compiler/.gitignore
@@ -3,3 +3,4 @@ subtest-cr
subtest-cr-lf
Signed-off-by: Eric Engestrom
---
src/compiler/spirv/spirv2nir.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/compiler/spirv/spirv2nir.c b/src/compiler/spirv/spirv2nir.c
index a725228..063e451 100644
--- a/src/compiler/spirv/spirv2nir.c
+++ b/src/compiler
CovID: 1373369
Signed-off-by: Eric Engestrom
---
src/compiler/spirv/spirv2nir.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/compiler/spirv/spirv2nir.c b/src/compiler/spirv/spirv2nir.c
index c837186..d151c2c 100644
--- a/src/compiler/spirv/spirv2nir.c
+++ b/src/compiler/spirv
we might as well
print real error messages, esp. since asserts are gone in release builds
(but who would use spirv2nir in a release build? ^^)
> Series is
>
> Reviewed-by: Jason Ekstrand
Thanks! Can you push it for me?
Cheers,
Eric
>
> On Sep 25, 2016 6:50 PM, "Eric Enges
On Tue, Sep 27, 2016 at 12:03:40PM +1000, Timothy Arceri wrote:
> ---
Whitespace-only change, and the result is cleaner than before :)
Reviewed-by: Eric Engestrom
> src/compiler/glsl/glsl_parser_extras.h | 60
> +-
> 1 file changed, 30 inser
1 - 100 of 2154 matches
Mail list logo
