On gen8+ fractional translation of viewport moved it by a whole integer.
The behaviour in this case isn't defined anywhere but some apps like
Wine may depend on viewport's width and height being ceiled.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106526
Signed-off-by: Danyl
We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS
should reflect this.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105975
Signed-off-by: Danylo Piliaiev
---
src/mesa/drivers/dri/i965/brw_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
d=106976
Signed-off-by: Danylo Piliaiev
---
configure.ac | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/configure.ac b/configure.ac
index 0652410..ab59e06 100644
--- a/configure.ac
+++ b/configure.ac
@@ -97,6 +97,7 @@ XCBDRI2_REQU
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106986
Signed-off-by: Danylo Piliaiev
---
src/mesa/main/queryobj.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
index 7ee820a..7547fa1 100644
--- a/src/mesa/main/queryobj.c
+++ b
Hello Keith,
I am not able to build Mesa after this patch:
wsi/wsi_common_display.c:991:4: error: unknown field ‘sequence_handler’
specified in initializer
.sequence_handler = wsi_display_sequence_handler,
^
wsi/wsi_common_display.c:991:24: warning: initialization from
incompatible po
Thanks, then should this dependency be expressed in autoconf and meson?
- Danil
On 25.06.18 17:32, Keith Packard wrote:
Danylo Piliaiev writes:
Hello Keith,
I am not able to build Mesa after this patch:
wsi/wsi_common_display.c:991:4: error: unknown field ‘sequence_handler’
specified in
dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
When I checked it appeared only version 1.13 has required functionality.
On 25.06.18 18:13, Keith Packard wrote:
Danylo Piliaiev writes:
Thanks, then should this dependency be expressed in autoconf and
mes
caused the workaround to become useless.
This commit allows compatibility profiles as high as 4.0 thus fixes
Worms W.M.D, Crookz - The Big Heist and Tropico 5.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107052
Signed-off-by: Danylo Piliaiev
---
src/mesa/drivers/dri/i965
abled.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107088
Signed-off-by: Danylo Piliaiev
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
b/src/mesa/driver
On 8/20/18 4:28 PM, Lionel Landwerlin wrote:
Reviewed-by: Lionel Landwerlin
Thanks!
Do you need me to push it?
Yes
Thanks,
-
Lionel
On 08/08/18 16:03, Danylo Piliaiev wrote:
Hi,
Since the exact value is not important for users, Roland offered
compelling explanation
and the value
The patch seems to be safe, so yes, thanks.
On 8/21/18 1:17 AM, Andres Gomez wrote:
Danylo, should we also include this in the stable queues ?
On Mon, 2018-06-18 at 15:50 +0300, Danylo Piliaiev wrote:
We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS
should reflect this
cannot have "invariant" qualifier.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100316
Signed-off-by: Danylo Piliaiev
---
My assumption is that variable being read_only means that it either
loads a value from an external source or is initialized from constant value.
From wha
this variable will be required to have
invariant qualifier in the next stage even though user never marked it
as such anywhere. And when the invariance will actually matter we will
check both implicit and explicit one. What do you think about such solution?
- Danil.
On Wed, Aug 22, 2018 at 7:
c detail.
Thus new flag is added to ir_variable_data which indicates 'invariant'
qualifier being explicitly set in the shader.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100316
Signed-off-by: Danylo Piliaiev
---
I'll send additional piglit test to test fixed case with inv
7;t remove invariant qualifier
from uniforms.
- Danil
On 8/23/18 2:49 PM, Danylo Piliaiev wrote:
Hi Jason,
On 8/22/18 7:07 PM, Jason Ekstrand wrote:
I think this would be correct to do and would fix the bug at hand but
there may be other bugs lurking deeper. In particular, if you have
mult
shader."
From Section 4.6.1 ("The Invariant Qualifier") GLSL ES 3.00 spec:
"Only variables output from a shader can be candidates for invariance."
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107842
Signed-off-by: Danylo Piliaiev
---
src/compiler/glsl/
Signed-off-by: Danylo Piliaiev
---
src/mesa/main/fbobject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 51e137dce9..edb86438e3 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -2080,7 +2080,7
ned-off-by: Danylo Piliaiev
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
index 42af41aca3..6adf4a5836 100644
---
On 9/7/18 5:48 PM, Ilia Mirkin wrote:
On Fri, Sep 7, 2018 at 10:41 AM, Danylo Piliaiev
wrote:
Comment for array_len field states:
"Indicates the number of array elements starting at
Base Array Layer."
And most usages of array_len expect it to be equal or less than
total lay
: 5a8c8903
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856
Signed-off-by: Danylo Piliaiev
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
b/src/mesa/driver
cia wrote:
On Fri, Sep 7, 2018 at 4:42 PM Danylo Piliaiev
wrote:
@@ -1546,8 +1548,8 @@ update_image_surface(struct brw_context *brw,
.format = format,
.base_level = obj->MinLevel + u->Level,
.levels = 1,
-.base_array_layer = obj->M
lia Mirkin)
- Rewrote patch by taking st_convert_image as a reference
- Removed now unused get_image_num_layers function
- Changed commit message
Fixes: 5a8c8903
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856
Signed-off-by: Danylo Piliaiev
---
.../drivers/dri/i
Hello everyone,
I would like to try to implement one of the Vulkan extensions -
VK_KHR_draw_indirect_count for anv,
unless someone is already working on it.
It's a relatively minor extension and I saw that the same functionality
is already implemented
for ARB_indirect_parameters in i965.
Al
scarry e-mail, I recommend starting with method 1 to get your feet wet
and then we can look into method 2 once you have that working.
I'll follow your recommendation and will start from the first method.
- Danil
--Jason
On Wed, Sep 12, 2018 at 6:36 AM Danylo Piliaiev
mailto:danylo.pilia.
reedesktop.org/patch/244676/
On 15/8/18 10:46 pm, Danylo Piliaiev wrote:
do_assignment validated assigment but when rhs type was not compatible
it proceeded without issues and returned error_emitted = false.
On the other hand process_initializer expected do_assignment to always
return compatible
GL/mesa/commit/9d1c7ae0db618c6f7281d5f667c96612ff0bb2c2
- Danil
On 9/12/18 6:30 PM, Danylo Piliaiev wrote:
Hi,
Thank you for the directions!
On 9/12/18 6:13 PM, Jason Ekstrand wrote:
Danylo,
You're free to implement anything not already implemented. Here are
some other (probably simple
On 9/17/18 5:34 PM, Jason Ekstrand wrote:
On Mon, Sep 17, 2018 at 8:34 AM Danylo Piliaiev
mailto:danylo.pilia...@gmail.com>> wrote:
Hi Jason,
I have implemented the extension and it works, however before
sending the patch I decided to see how it can interact with
On 9/17/18 7:03 PM, Jason Ekstrand wrote:
On Mon, Sep 17, 2018 at 10:08 AM Danylo Piliaiev
mailto:danylo.pilia...@gmail.com>> wrote:
On 9/17/18 5:34 PM, Jason Ekstrand wrote:
On Mon, Sep 17, 2018 at 8:34 AM Danylo Piliaiev
mailto:danylo.pilia...@gmail.com>> wrote:
On 9/18/18 1:08 PM, Jason Ekstrand wrote:
On Tue, Sep 18, 2018 at 4:08 AM Danylo Piliaiev
mailto:danylo.pilia...@gmail.com>> wrote:
On 9/17/18 7:03 PM, Jason Ekstrand wrote:
On Mon, Sep 17, 2018 at 10:08 AM Danylo Piliaiev
mailto:danylo.pilia...@gmail.com>> wrote:
On 9/18/18 1:46 PM, Danylo Piliaiev wrote:
On 9/18/18 1:08 PM, Jason Ekstrand wrote:
On Tue, Sep 18, 2018 at 4:08 AM Danylo Piliaiev
mailto:danylo.pilia...@gmail.com>> wrote:
On 9/17/18 7:03 PM, Jason Ekstrand wrote:
On Mon, Sep 17, 2018 at 10:08 AM Danylo Pi
Thanks! Looks much better than my attempt.
Series overall work as expected and eliminate the loop from the
bug: https://bugs.freedesktop.org/show_bug.cgi?id=32211
Also found two typos:
On 11/28/18 5:25 AM, Timothy Arceri wrote:
From: Danylo Piliaiev
Removing the last continue can allow more
accessing conditional buffer
(The issue was found by Samuel Iglesias)
Signed-off-by: Danylo Piliaiev
---
I'm not sure whether VK_ACCESS_CONDITIONAL_RENDERING_READ_BIT_EXT
should be handled in anv_pipe_invalidate_bits_for_access_flags or not.
It would be good if someone could clarify this matter f
ests.
And yes, I also was quite slow with my patches.
On 1/8/19 11:13 AM, Erik Faye-Lund wrote:
On Wed, 2018-10-17 at 14:58 +0300, Danylo Piliaiev wrote:
This series implement VK_KHR_draw_indirect_count and
VK_EXT_conditional_rendering extensions.
They are implemented together because
My small thoughts/questions:
- First of all discussions are really much more convenient.
- Several (mine) merge requests were "Closed" and merged (not just
merged, they are under "Closed" category), am I missing something?
- Is there a way to grant rights to creator of merge request to
add/chan
ure how to test the
implementation
of VK_EXT_conditional_rendering with my tests on CI. Could anyone help me with
this?
Also the one thing I'm uncertain of is described in the last patch.
Many thanks to Jason Ekstrand for the help with the extensions.
Danylo Piliaiev (3):
Signed-off-by: Danylo Piliaiev
---
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/genX_cmd_buffer.c | 155 +
2 files changed, 156 insertions(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index d4915c9501
Without MI_MATH we are forced to load MI_PREDICATE_SRC0
from memory on every predicate emission.
Signed-off-by: Danylo Piliaiev
---
src/intel/vulkan/anv_extensions.py | 2 +-
src/intel/vulkan/genX_cmd_buffer.c | 12 ++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a
alternative is to restore MI_PREDICATE_RESULT in all affected
functions at their beginning.
Signed-off-by: Danylo Piliaiev
---
src/intel/vulkan/anv_blorp.c | 7 +-
src/intel/vulkan/anv_device.c | 12 ++
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_private.h
Signed-off-by: Danylo Piliaiev
---
src/intel/tools/intel_sanitize_gpu.c | 38 +++-
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/src/intel/tools/intel_sanitize_gpu.c
b/src/intel/tools/intel_sanitize_gpu.c
index 9b49b0bbf2..36c4725a2f 100644
--- a/src
On Wed, Oct 17, 2018 at 6:47 PM Rafael Antognolli <
rafael.antogno...@intel.com> wrote:
> On Wed, Oct 17, 2018 at 06:08:34PM +0300, Danylo Piliaiev wrote:
> > Signed-off-by: Danylo Piliaiev
> > ---
> > src/intel/tools/intel_sanitize_gpu.c | 38 +++--
I have made a Piglit test that exercises the issue:
https://patchwork.freedesktop.org/patch/258180/
- Danil
On 9/10/18 6:21 PM, Danylo Piliaiev wrote:
Handle all cases in calculation of layers count for isl_view
taking into account texture view and image unit.
st_convert_image was taken as a
On 11/6/18 12:39 AM, Jason Ekstrand wrote:
On Wed, Oct 17, 2018 at 6:59 AM Danylo Piliaiev
wrote:
Signed-off-by: Danylo Piliaiev
---
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/genX_cmd_buffer.c | 155 +
2 files changed, 156 insertions
On 11/6/18 1:05 AM, Jason Ekstrand wrote:
On Wed, Oct 17, 2018 at 6:59 AM Danylo Piliaiev
wrote:
Conditional rendering affects next functions:
- vkCmdDraw, vkCmdDrawIndexed, vkCmdDrawIndirect, vkCmdDrawIndexedIndirect
- vkCmdDrawIndirectCountKHR, vkCmdDrawIndexedIndirectCountKHR
are not required for VK_KHR_draw_indirect_count
two patches collapsed into one with new title.
Danylo Piliaiev (2):
anv: Implement VK_KHR_draw_indirect_count for gen 7+
anv: Implement VK_EXT_conditional_rendering for gen 7.5+
src/intel/vulkan/anv_blorp.c | 7 +-
src/intel/vulkan
v2: by Jason Ekstrand
- Move out of the draw loop population of registers
which aren't changed in it
- Remove dependency on ALU registers
- Clarify usage of PIPE_CONTROL
- Without usage of ALU registers patch works for gen7+
Signed-off-by: Danylo Piliaiev
---
I'm uncer
alternative is to restore MI_PREDICATE_RESULT in all affected
functions at their beginning.
v2: by Jason Ekstrand
- Use vk_find_struct_const instead of manually looping
- Move draw count loading to prepare function
- Zero the top 32-bits of MI_ALU_REG15
Signed-off-by: Danylo Piliaiev
---
src
Hello,
Could anyone look at the patch?
Thanks!
On 10/24/18 2:22 PM, Danylo Piliaiev wrote:
I have made a Piglit test that exercises the issue:
https://patchwork.freedesktop.org/patch/258180/
- Danil
On 9/10/18 6:21 PM, Danylo Piliaiev wrote:
Handle all cases in calculation of layers count
e
conditions,
which will look slightly misleading and induce questions of why we
don't subtract them from array_len.
What do you think?
Thanks!
On 11/14/18 12:01 AM, Ilia Mirkin wrote:
On Tue, Nov 13, 2018 at 4:53 PM Jason Ekstrand wrote:
On Mon, Sep 10, 2018 at 10:21 AM Danylo Piliaiev
w
lia Mirkin)
- Rewrote patch by taking st_convert_image as a reference
- Removed now unused get_image_num_layers function
- Changed commit message
v4: (Jason Ekstrand)
- Added assert
Fixes: 5a8c8903
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107856
Signed-off-by: Dan
Thanks!
On 11/16/18 7:09 AM, Jason Ekstrand wrote:
Pushed.
On Thu, Nov 15, 2018 at 8:15 PM Jason Ekstrand wrote:
Thanks. I'm going to push it once it gets done running through CI.
On Thu, Nov 15, 2018 at 4:03 AM Danylo Piliaiev
wrote:
Handle all cases in calculation of layers coun
Lionel
On 20/06/18 14:25, Danylo Piliaiev wrote:
VK_USE_PLATFORM_XLIB_XRANDR_EXT requires xlib leasing which requires
xcb-randr >= 1.13. Also xrandr header is required for this extension.
The extension should not be automatically enabled if these dependencies
aren't satisfied.
Bugzilla:
onfigure.ac) and bumping
the revision in meson.build should be enough.
Thanks,
-
Lionel
On 09/07/18 10:16, Danylo Piliaiev wrote:
Hi Lionel,
Yes meson probably also has the issue since it checks for xcb-randr
1.12 and not 1.13 . I didn't send further patches since vulkan build
got broken once
ether this change is desirable and should it
be hidden behind environment variable (if yes suggestions about its name
are welcomed).
Also I wasn't able to test the change in st_link_nir and will welcome
some help with this.
Danylo Piliaiev (3):
i965: Sweep NIR after linking phase to free h
issue is 32bit game running under Wine.
The cost of the optimization is around ~3-5% of compilation speed
with complex shaders.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103274
Signed-off-by: Danylo Piliaiev
---
src/mesa/drivers/dri/i965/brw_link.cpp | 9 +
1 file changed, 9
issue is 32bit game running under Wine.
The cost of the optimization is around ~3-5% of compilation speed
with complex shaders.
Signed-off-by: Danylo Piliaiev
---
src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp
The function recursively calculates memory held by context's children.
It is aimed to easier debugging of excessive memory usage with ralloc.
It will work only if malloc_usable_size is available.
Signed-off-by: Danylo Piliaiev
---
src/util/ralloc.c | 30 ++
src
about
memory and assume nir_sweep gets called. Hanging on to linked shaders
with all that garbage floating around is a bad plan.
On Tue, Jul 10, 2018 at 1:53 AM Danylo Piliaiev
mailto:danylo.pilia...@gmail.com>> wrote:
After optimization passes and many trasfromations most of memory
id=107170
https://bugs.freedesktop.org/show_bug.cgi?id=106972
https://bugs.freedesktop.org/show_bug.cgi?id=107176
Signed-off-by: Danylo Piliaiev
---
configure.ac | 29 +-
meson.build| 11 +-
src/a
issue is 32bit game running under Wine.
The cost of the optimization is around ~3-5% of compilation speed
with complex shaders.
V2: by Jason Ekstrand
- Move nir_sweep up, right after the last change of NIR
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103274
Signed-off-by: Danylo
On 11.07.18 20:43, Dylan Baker wrote:
Quoting Danylo Piliaiev (2018-07-11 04:26:03)
diff --git a/meson.build b/meson.build
index 7d12af3d51..2683060827 100644
--- a/meson.build
+++ b/meson.build
@@ -1088,6 +1088,8 @@ _drm_freedreno_ver = '2.4.92'
_drm_intel_ver = '2.4
control in vk.xml
- Add support for 'protect' attribute to anv_entrypoints_gen
(copied from radv_entrypoints_gen)
- Turn #if into #ifdef
- Remove unnecessary pkg-config call from meson build (Dylan Baker)
Signed-off-by: Danylo Piliaiev
---
Other vulkan extensions are ga
On 12.07.18 21:49, Dylan Baker wrote:
Quoting Danylo Piliaiev (2018-07-12 06:09:57)
Make xlease automatically enabled only if xcb-randr >= 1.13,
check its version if manually enabled.
Enable VK_EXT_display_control only when libdrm >= 2.4.89
Check for DRM_EVENT_CONTEXT_VERSION >=
rom the external
source.
Signed-off-by: Danylo Piliaiev
---
configure.ac | 29 +-
meson.build| 10 -
src/amd/vulkan/radv_extensions.py | 9 +++-
src/amd/vulkan/radv_wsi_display.c | 5 ++
Could it be pushed? The commit is independent from other in series.
- Danil
On 12.07.18 00:27, Jason Ekstrand wrote:
Reviewed-by: Jason Ekstrand <mailto:ja...@jlekstrand.net>>
On Wed, Jul 11, 2018 at 5:29 AM Danylo Piliaiev
mailto:danylo.pilia...@gmail.com>> wrote:
Aft
Signed-off-by: Danylo Piliaiev
---
src/amd/vulkan/radv_shader.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
index 1399005998..aac5b8a21a 100644
--- a/src/amd/vulkan/radv_shader.c
+++ b/src/amd/vulkan
Signed-off-by: Danylo Piliaiev
---
src/compiler/glsl/ast_to_hir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index dd60a2a87f..8a4cc56511 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src
Signed-off-by: Danylo Piliaiev
---
src/mesa/main/context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
index 4243e03c5c..0ef8fe32a6 100644
--- a/src/mesa/main/context.c
+++ b/src/mesa/main/context.c
@@ -742,7 +742,7
Hi,
I was running cppcheck on Mesa and found the issue mentioned here:
This can't possibly work. The function immediately dereferences
fragcoord, so it can't legally be NULL. Which then begs the question,
how on earth did it work before? It would just read a non-existent
variable out of the
On 19.07.18 11:47, Timothy Arceri wrote:
On 19/07/18 08:31, Eric Anholt wrote:
Danylo Piliaiev writes:
After optimization passes and many trasfromations most of memory
"transformations"
NIR holds is a garbage which was being freed only after shader
deletion.
"is garbag
On 19.07.18 12:30, Timothy Arceri wrote:
On 19.07.18 11:47, Timothy Arceri wrote:
On 19/07/18 08:31, Eric Anholt wrote:
Danylo Piliaiev writes:
After optimization passes and many trasfromations most of memory
"transformations"
NIR holds is a garbage which was being freed
On 19.07.18 21:41, Ian Romanick wrote:
On 07/18/2018 01:53 AM, Danylo Piliaiev wrote:
Signed-off-by: Danylo Piliaiev
---
src/compiler/glsl/ast_to_hir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
Signed-off-by: Danylo Piliaiev
---
Also there is a similar patch which fixes the same issue
for OpenGL https://patchwork.freedesktop.org/patch/235939
src/intel/vulkan/genX_pipeline.c | 43
1 file changed, 32 insertions(+), 11 deletions(-)
diff --git a/s
Hi Emil,
On 24.07.18 17:10, Emil Velikov wrote:
Hi Danylo,
On 13 July 2018 at 14:57, Danylo Piliaiev wrote:
Make xlease automatically enabled only if xcb-randr >= 1.13,
check its version if manually enabled.
Enable VK_EXT_display_control only when libdrm >= 2.4.89
Che
Hi Eric,
On 24.07.18 18:43, Eric Engestrom wrote:
On Friday, 2018-07-13 16:57:34 +0300, Danylo Piliaiev wrote:
Make xlease automatically enabled only if xcb-randr >= 1.13,
check its version if manually enabled.
Enable VK_EXT_display_control only when libdrm >= 2.4.89
Che
Hi Emil,
On 24.07.18 19:23, Emil Velikov wrote:
Hi Danylo,
Having a closer look inspired by Eric's comments
On 24 July 2018 at 15:37, Danylo Piliaiev wrote:
Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler.
As you bump the libdrm version:
- drop the
bump. I can add test to Crucible if it will help.
On 20.07.18 12:54, Danylo Piliaiev wrote:
Dual source blending behaviour is undefined when shader doesn't
have second color output.
"If SRC1 is included in a src/dst blend factor and
a DualSource RT Write message is not use
being
direct before calling GetGLXDRIDrawable. This patch adds checks
where they were missed.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42699
Signed-off-by: Danylo Piliaiev
---
src/glx/glx_pbuffer.c | 12 ++--
src/glx/glxcmds.c | 3 +++
2 files changed, 13 insertions(+), 2
On 01.08.18 19:42, Adam Jackson wrote:
On Wed, 2018-08-01 at 17:15 +0300, Danylo Piliaiev wrote:
If indirect context is explicitly created by application and not
with LIBGL_ALWAYS_INDIRECT=1 then dri may be initialized in
__glXInitialize which allows Mesa to take invalid code paths
due to
ision.
We use 32bits floats in the packets sent to the hardware.
Quoting the spec :
"If the implementation truely has floating point viewport bounds, it
may report a sufficiently high value to indicate this. "
Maybe we should use something a bit bigger than 8?
Cheers,
-
Lionel
On 18/06/18
Accessing scalar constant as an array in function call or
initializer list triggered assert in get_array_element.
Examples:
func(0[0]);
vec2 t = { 0[0], 0 };
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107550
Signed-off-by: Danylo Piliaiev
---
src/compiler/glsl
Hi,
On 08/14/2018 10:53 AM, Tapani Pälli wrote:
Hi;
On 08/13/2018 06:57 PM, Danylo Piliaiev wrote:
Accessing scalar constant as an array in function call or
initializer list triggered assert in get_array_element.
Examples:
func(0[0]);
vec2 t = { 0[0], 0 };
Bugzilla: https
Hi,
On 08/14/2018 10:43 AM, Tapani Pälli wrote:
On 08/13/2018 08:54 PM, Ian Romanick wrote:
On 08/13/2018 08:57 AM, Danylo Piliaiev wrote:
Accessing scalar constant as an array in function call or
initializer list triggered assert in get_array_element.
Examples:
func(0[0]);
vec2 t
h. Example:
uniform struct {float field;} data;
...
vec4 tmp = data;
tmp.x -= 1.0;
After the patch there is only error line without a crash:
initializer of type #anon_struct cannot be assigned to variable of
type vec4
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107547
Signed-off-
Signed-off-by: Danylo Piliaiev
---
src/compiler/glsl/ir_clone.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/glsl/ir_clone.cpp b/src/compiler/glsl/ir_clone.cpp
index 69441fae7d..e1f4f3b290 100644
--- a/src/compiler/glsl/ir_clone.cpp
+++ b/src/compiler/glsl/ir_clone.cpp
On 08/16/2018 07:47 AM, Tapani Pälli wrote:
On 08/16/2018 02:21 AM, Andres Gomez wrote:
Danylo, should we also include this in the stable queues ?
Yep makes sense, it's simple and fixes a crasher.
I agree.
On Mon, 2018-08-13 at 18:57 +0300, Danylo Piliaiev wrote:
Accessing s
"spirv: Implement OpCopyObject and OpCopyLogical as blind copies" was reverted
yesterday
due to the failures in several dEQP-VK tests, see:
https://gitlab.freedesktop.org/mesa/mesa/-/commit/68f325b256d96dca923f6c7d84bc6faf43911245
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4375
t Phillips (1):
util/sparse_array: don't stomp head's counter on pop operations
Daniel Stone (1):
EGL: Add eglSetDamageRegionKHR to GLVND dispatch list
Danylo Piliaiev (1):
st/mesa: Update shader info of ffvp/ARB_vp after translation to NIR
Dave Airlie (2):
e in a row with clear regression crept in. I believe
that we can use this to improve the process and
safeguard against such regressions in the future.
P.S. I'm preparing and will test a final fix which will be sent soon.
Danylo
On 23.04.20 07:40, Dylan Baker wrote:
Quoting Ilia Mirkin
On 23.04.20 19:56, Dylan Baker wrote:
Quoting Michel Dänzer (2020-04-23 09:24:45)
On 2020-04-23 6:19 p.m., Mark Janes wrote:
Michel Dänzer writes:
On 2020-04-23 5:14 p.m., Mark Janes wrote:
Does anyone have recommendations for how to use Gitlab to verify that
there are no identified-but-un
original
offending patch is an option either.
Dylan
Quoting Danylo Piliaiev (2020-04-22 15:38:59)
My commit "st/mesa: Update shader info of ffvp/ARB_vp after translation to NIR"
did
introduce regression and its fix, which was merged (but isn't in this release
even though
there is
90 matches
Mail list logo
