[Mesa-dev] [PATCH] st/dri: Don't expose sRGB formats to clients

2018-08-31 Thread Daniel Stone
faces, preventing us from tripping over an assert. Signed-off-by: Daniel Stone Reported-by: Michel Dänzer Fixes: 8c1b9882b2e0 ("egl/dri2: Guard against invalid fourcc formats") Cc: Jason Ekstrand --- src/gallium/state_trackers/dri/dri2.c | 6 ++ 1 file changed, 6 insertions(+) diff --gi

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Daniel Stone
Hi, On Mon, 17 Sep 2018 at 22:31, Marek Olšák wrote: > Is there any documentation for configure options? Or do I have to do > "grep get_option meson.build" to get the list at least? Most of these questions can be answered by running: meson configure $builddir More documentation is available a

Re: [Mesa-dev] Lets talk about autotools

2018-09-20 Thread Daniel Stone
Hi Emil, On Thu, 20 Sep 2018 at 15:36, Emil Velikov wrote: > Mildly related: when using meson, make that you have patchelf or similar tool. > It nukes the RPATH, removing the need to relink the binaries [as it > happens on make install]. > > Perhaps meson should error out when that's missing? Th

Re: [Mesa-dev] [PATCH mesa 0/6] Let's get rid of 99% of warnings :)

2018-09-21 Thread Daniel Stone
On Fri, 21 Sep 2018 at 19:48, Jason Ekstrand wrote: > You should try building with clang. 😜 > If only there was some way we could do both, in some kind of automated fashion! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedes

Re: [Mesa-dev] [PATCH v2 0/5] Use GitLab CI to build Mesa

2018-09-21 Thread Daniel Stone
Hi Juan, On Wed, 29 Aug 2018 at 11:13, Juan A. Suarez Romero wrote: > This is a first part, version 2, of a more complete proposal to use GitLab CI > to > build and test Mesa. This first part just adds the required pieces to build > Mesa, using the different supported tools (meson, autotools, an

Re: [Mesa-dev] [PATCH v2 0/5] Use GitLab CI to build Mesa

2018-09-28 Thread Daniel Stone
Hi all, On Fri, 21 Sep 2018 at 20:59, Daniel Stone wrote: > On Wed, 29 Aug 2018 at 11:13, Juan A. Suarez Romero > wrote: > > This is a first part, version 2, of a more complete proposal to use GitLab > > CI to > > build and test Mesa. This first part just adds the

Re: [Mesa-dev] [PATCH 4/5] vulkan/wsi: Use the interface from the real modifiers extension

2018-10-03 Thread Daniel Stone
Hi, On Mon, 1 Oct 2018 at 22:25, Jason Ekstrand wrote: > index 70594d6c053..2850349a619 100644 > --- a/src/intel/vulkan/anv_image.c > +++ b/src/intel/vulkan/anv_image.c > @@ -109,6 +109,8 @@ choose_isl_tiling_flags(const struct > anv_image_create_info *anv_info, > case VK_IMAGE_TILING_LINEAR

Re: [Mesa-dev] [PATCH mesa 3/6] vulkan/wsi/display: pass the plane's modifiers to the image

2018-10-03 Thread Daniel Stone
d this patch is: Reviewed-by: Daniel Stone I didn't have time to properly look at the others yet, but most of what you said there makes sense to me, so I'll hang on for a v2. Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedes

Re: [Mesa-dev] [PATCH] docs: Document optional GitLab code review process

2018-11-30 Thread Daniel Stone
Hi all, Thanks for the CC. I'm on a sabbatical until mid-January; I'll be around but not following the lists/etc as actively as before. Please feel free to liberally CC me (on this address, not work) or poke me on IRC if there's something I should see or could contribute to. I'll have limited time

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-07 Thread Daniel Stone
Hi, On Sat, 8 Dec 2018 at 05:15, Eric Engestrom wrote: > On Friday, 2018-12-07 10:19:23 +0100, Erik Faye-Lund wrote: > > Automated emails (and perhaps IRC bot) would be really nice. > > Agreed. Email would be great to help with the transition. > There's work currently being done on GitLab to allo

Re: [Mesa-dev] [PATCH 0/6] i965: Fix TFP for CCS modifiers

2018-02-21 Thread Daniel Stone
The only new patch is 6 which is required because patch 3 starts making the > intel_texture_object contain the GL format for texture views and not the > hacked up format we used to use. We have to do the format hacks for depth > and ETC2 in texture upload now. This series is:

Re: [Mesa-dev] [PATCH 0/6] i965: Fix TFP for CCS modifiers

2018-02-21 Thread Daniel Stone
On 21 February 2018 at 10:49, Daniel Stone wrote: > On 24 January 2018 at 23:46, Jason Ekstrand wrote: >> This patch series provides fixes for the texture_from_pixmap path when >> modifiers are used. All but the first and last patches are reviewed. I >> haven't p

[Mesa-dev] [PATCH v11 01/15] vulkan/wsi: Add multiple planes to wsi_image

2018-02-21 Thread Daniel Stone
Not currently used. Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/vulkan/wsi/wsi_common.c | 20 src/vulkan/wsi/wsi_common_private.h | 9 + src/vulkan/wsi/wsi_common_wayland.c | 11 +++ src/vulkan/wsi/wsi_common_x11.c | 11

[Mesa-dev] [PATCH v11 13/15] x11/dri3: Store raw present completion mode

2018-02-21 Thread Daniel Stone
The DRI3 drawable info struct currently stores a boolean for whether the last completed operation was a flip or not. As we need to track the full completion mode for handling suboptimal returns, change the 'flipping' field to the raw present completion mode from the server. Signed-off-

[Mesa-dev] [PATCH v11 15/15] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-21 Thread Daniel Stone
Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/egl_dri2.c | 2 ++ src/egl/drivers/dri2/egl_dri2.h | 2 ++ src/egl/drivers/dri2/platform_x11_dri3.c | 3 +++ src/glx/dri3_glx.c | 4 ++- src/loader/loader_dri3_helper.c

[Mesa-dev] [PATCH v11 06/15] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-21 Thread Daniel Stone
zwp_linux_dmabuf_v1 lets us use multi-planar images and buffer modifiers. Signed-off-by: Daniel Stone --- src/vulkan/Makefile.am | 10 +++ src/vulkan/Makefile.sources | 4 +- src/vulkan/wsi/meson.build | 2 + src/vulkan/wsi/wsi_common_wayland.c | 141

[Mesa-dev] [PATCH v11 08/15] vulkan/wsi/x11: Consistently update swapchain status

2018-02-21 Thread Daniel Stone
Use a helper function for updating the swapchain status. This will be used later to handle VK_SUBOPTIMAL_KHR, where we need to make a non-error status stick to the swapchain until recreation. Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 90

[Mesa-dev] [PATCH v11 07/15] vulkan/wsi/x11: Expand set of swapchain statuses

2018-02-21 Thread Daniel Stone
Instead of direct comparisons to VK_SUCCESS, test for negative numbers meaning an error status, and positive numbers indicating non-error statuses. Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH v11 02/15] vulkan/wsi: Add drm_modifier member to wsi_image

2018-02-21 Thread Daniel Stone
Not yet used anywhere. Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/vulkan/Makefile.am | 1 + src/vulkan/wsi/meson.build | 2 +- src/vulkan/wsi/wsi_common.c | 3 +++ src/vulkan/wsi/wsi_common_private.h | 1 + 4 files changed, 6 insertions(+), 1

[Mesa-dev] [PATCH v11 14/15] egl/x11: Support DRI3 v1.1

2018-02-21 Thread Daniel Stone
-Francis Ratté-Boulianne Reviewed-by: Eric Engestrom Reviewed-by: Emil Velikov Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/egl_dri2.c | 7 + src/egl/drivers/dri2/egl_dri2.h | 3 + src/egl/drivers/dri2/platform_x11_dri3.c | 105

[Mesa-dev] [PATCH v11 10/15] vulkan/wsi/x11: Add support for DRI3 v1.1

2018-02-21 Thread Daniel Stone
Adds support for multiple planes and buffer modifiers. v4: Rename "has_dri3_v1_1" to "has_dri3_modifiers" Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 185 1 file changed, 168 insertions(+), 17 deletions(-) dif

[Mesa-dev] [PATCH v11 03/15] vulkan/wsi: Add modifiers support to wsi_create_native_image

2018-02-21 Thread Daniel Stone
ition all of the structs used in wsi_common to the real extension structs. Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common.c | 164 src/vulkan/wsi/wsi_common.h | 23 + src/vulkan/wsi/wsi_common_private.h

[Mesa-dev] [PATCH v11 11/15] vulkan/wsi/x11: Return VK_SUBOPTIMAL_KHR for X11

2018-02-21 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne When it is detected that a window could have been flipped but has been copied because of suboptimal format/modifier. The Vulkan client should then re-create the swapchain. Signed-off-by: Louis-Francis Ratté-Boulianne Reviewed-by: Daniel Stone Signed-off-by

[Mesa-dev] [PATCH v11 04/15] anv/image: Separate modifiers from legacy scanout

2018-02-21 Thread Daniel Stone
#x27;s clear in the driver when we're using modifiers and when we're using legacy paths. v2 (Jason Ekstrand): - Rename legacy_scanout to needs_set_tiling Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_device.c | 22 ++ src/intel/

[Mesa-dev] [PATCH v11 05/15] anv/image: Add support for modifiers for WSI

2018-02-21 Thread Daniel Stone
From: Jason Ekstrand This adds support for the modifiers portion of the WSI "extension". Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_formats.c | 38 ++ src/intel/vulkan/anv_imag

[Mesa-dev] [PATCH v11 00/15] Modifiers for X11 EGL/Vulkan, WL/VK

2018-02-21 Thread Daniel Stone
Hi, This series adds support for buffer modifiers through ANV and the common WSI infrastructure (AMD has no defined modifiers), as well as specifically for X11 and Wayland. It also adds support for the X11 DRI3 v1.1 and Present v1.2 protocols to EGL and GLX, which does not require changes to the DR

[Mesa-dev] [PATCH v11 09/15] vulkan/wsi/x11: Cleanly handle shutdowns in FIFO thread

2018-02-21 Thread Daniel Stone
The FIFO thread signals shutdown by pushing UINT32_MAX into the acquire queue, and shutdown is signaled to it by pushing UINT32_MAX into the present queue. Explicitly catch a push of UINT32_MAX in either direction and treat this as error. Signed-off-by: Daniel Stone --- src/vulkan/wsi

[Mesa-dev] [PATCH v11 12/15] x11/dri3: Don't open-code ARRAY_SIZE

2018-02-21 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/loader/loader_dri3_helper.c | 5 +++-- src/loader/meson.build | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 30ea133f7e5..cb947c58728 100644 --- a/src

Re: [Mesa-dev] [PATCH v11 07/15] vulkan/wsi/x11: Expand set of swapchain statuses

2018-02-21 Thread Daniel Stone
On 21 February 2018 at 14:05, Daniel Stone wrote: > @@ -781,7 +781,7 @@ x11_acquire_next_image_from_queue(struct x11_swapchain > *chain, > uint32_t image_index; > VkResult result = wsi_queue_pull(&chain->acquire_queue, >

Re: [Mesa-dev] [PATCH v11 09/15] vulkan/wsi/x11: Cleanly handle shutdowns in FIFO thread

2018-02-21 Thread Daniel Stone
Hi, On 21 February 2018 at 20:50, Jason Ekstrand wrote: > On Wed, Feb 21, 2018 at 6:05 AM, Daniel Stone wrote: >> @@ -832,7 +832,7 @@ x11_acquire_next_image_from_queue(struct x11_swapchain >> *chain, >> VkResult result = wsi_queue_pull(

Re: [Mesa-dev] [PATCH v11 10/15] vulkan/wsi/x11: Add support for DRI3 v1.1

2018-02-21 Thread Daniel Stone
Hi, On 21 February 2018 at 21:24, Jason Ekstrand wrote: > On Wed, Feb 21, 2018 at 1:22 PM, Jason Ekstrand > wrote: >>> + uint32_t n = 0; >>> + uint32_t counts[2]; >>> + uint64_t *modifiers[2]; >>> + >>> + if (mod_reply->num_drawable_modifiers) { >>> + counts[n] = mod_reply->num_draw

Re: [Mesa-dev] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-22 Thread Daniel Stone
Hi Dieter, 2018-02-22 0:57 GMT+00:00 Dieter Nützel : > Making all in vulkan > make[3]: Verzeichnis „/opt/mesa/src/vulkan“ wird betreten > make[3]: *** Keine Regel vorhanden, um das Ziel > „/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml“, > benötigt von „wsi/linux-dmabuf-unstable-v1-protocol

[Mesa-dev] [PATCH 2/3] build: Move wayland-protocols check into platform

2018-02-23 Thread Daniel Stone
In line with wayland-client and wayland-server, move the check for wayland-protocols into the wayland platform branch. Signed-off-by: Daniel Stone Fixes: bfa22266cd4d ("vulkan/wsi/wayland: Add support for zwp_dmabuf") Cc: Emil Velikov Reported-by: Dieter Nützel Bugzi

[Mesa-dev] [PATCH 1/3] vulkan/wsi/wayland: Move Wayland protocol from BUILT_SOURCES

2018-02-23 Thread Daniel Stone
same thing as EGL and manually encode the dependencies in the Makefile. Signed-off-by: Daniel Stone Fixes: bfa22266cd4d ("vulkan/wsi/wayland: Add support for zwp_dmabuf") Cc: Emil Velikov Reported-by: Dieter Nützel Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105211 ---

[Mesa-dev] [PATCH 3/3] build: Move wayland-scanner check into platform

2018-02-23 Thread Daniel Stone
Also only check for wayland-scanner if building for the Wayland platform. Signed-off-by: Daniel Stone Fixes: bfa22266cd4d ("vulkan/wsi/wayland: Add support for zwp_dmabuf") Cc: Emil Velikov Reported-by: Dieter Nützel Bugzilla: https://bugs.freedesktop.org/show_bug.cgi

Re: [Mesa-dev] [PATCH] meson: Fix GL and EGL pkg-config files with glvnd

2018-02-23 Thread Daniel Stone
Hi Dylan, On 20 February 2018 at 18:36, Dylan Baker wrote: > Currently meson will generate a pkg-config that links to EGL_mesa (or > GLX_mesa), but this isn't correct, it should always link to EGL or GL. > Probably the "right" solution is to have glvnd itself provide the pkg > config files for GL

Re: [Mesa-dev] [ANNOUNCE] mesa-demos 8.4.0

2018-02-23 Thread Daniel Stone
Hi Marc, On 23 February 2018 at 12:58, Marc Dietrich wrote: > my system has problems with linking xdemos: > ... > CCLD glsync > /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: > glsync.o: undefined reference to symbol 'glXQueryExtensionsString' > /usr/lib64/libGL.

Re: [Mesa-dev] [PATCH] meson: Fix GL and EGL pkg-config files withglvnd

2018-02-23 Thread Daniel Stone
Hi Marc, On 23 February 2018 at 15:42, Marc Dietrich wrote: > Am Freitag, 23. Februar 2018, 14:31:30 CET schrieb Daniel Stone: >> On 20 February 2018 at 18:36, Dylan Baker wrote: >> > Currently meson will generate a pkg-config that links to EGL_mesa (or >> > GLX_me

Re: [Mesa-dev] [PATCH] gbm: Fix the alpha masks in the GBM format table.

2018-02-23 Thread Daniel Stone
Reviewed-by: Daniel Stone You can probably tell I only tested XRGB. Sorry!___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-02-25 Thread Daniel Stone
Hi, On 24 February 2018 at 00:43, Jason Ekstrand wrote: > On Tue, Feb 13, 2018 at 4:31 PM, Keith Packard wrote: >> + image->chain = chain; >> + image->state = wsi_image_idle; >> + image->fb_id = 0; >> + >> + /* XXX extract depth and bpp from image somehow */ > > You have the format in cr

[Mesa-dev] [PATCH] meson: Add default DRI drivers for ARM/AArch64

2018-02-27 Thread Daniel Stone
On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as 'aarch64'), only build swrast for DRI drivers. The only classic drivers which could be used are r200 and NV20 cards, which seems unlikely enough that it shouldn't be the default. Signed-off-by:

Re: [Mesa-dev] [PATCH] meson: Add default DRI drivers for ARM/AArch64

2018-02-27 Thread Daniel Stone
Hi Dylan, On Tue, 2018-02-27 at 09:13 -0800, Dylan Baker wrote: > Quoting Daniel Stone (2018-02-27 02:08:29) > > --- a/meson.build > > +++ b/meson.build > > @@ -100,6 +100,8 @@ if _drivers == 'auto' > > # TODO: PPC, Sparc > > if ['

[Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

2018-02-27 Thread Daniel Stone
On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as 'aarch64'), only build swrast for DRI drivers. The only classic drivers which could be used are r200 and NV20 cards, which seems unlikely enough that it shouldn't be the default. Signed-off-by:

[Mesa-dev] [PATCH v2 2/2] meson: Don't build svga on ARM/AArch64

2018-02-27 Thread Daniel Stone
VMware has no (published) support for Arm-architecture guests. Signed-off-by: Daniel Stone Cc: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c349e9e5f85..92200a3d64a 100644 --- a/meson.build +++ b/meson.build

Re: [Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

2018-02-28 Thread Daniel Stone
Hi, On 28 February 2018 at 09:33, Eric Engestrom wrote: > On Tuesday, 2018-02-27 18:01:11 +0000, Daniel Stone wrote: >> On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as >> 'aarch64'), only build swrast for DRI drivers. > > The commit

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-02 Thread Daniel Stone
Hi, On 2 March 2018 at 12:06, Thierry Reding wrote: > On Thu, Mar 01, 2018 at 09:37:28AM -0500, Ilia Mirkin wrote: >> > +static void >> > +nvc0_query_dmabuf_modifiers(struct pipe_screen *screen, >> > +enum pipe_format format, int max, >> >> Maybe change this to "unsign

Re: [Mesa-dev] [PATCH mesa] gbm: give a name to rgba fields

2018-03-05 Thread Daniel Stone
On 5 March 2018 at 14:40, Eric Engestrom wrote: > Note: `gbm_dri_visuals_table` doesn't need any modification, as the > channel order doesn't change, so `rgba_mask = { r, g, b, a }` still > works. Yeah, this is a very definite and obvious improvement. Thanks Eric! Review

Re: [Mesa-dev] nouveau 30bpp / deep color status

2018-03-08 Thread Daniel Stone
Hi, On 8 March 2018 at 17:08, Ilia Mirkin wrote: > On Thu, Mar 8, 2018 at 11:57 AM, Mario Kleiner > wrote: >> Under EGL there is matching of channel masks, so only X11+GLX is >> problematic. Not sure if anything special would need to be done for >> XWayland, haven't looked at that at all so far.

[Mesa-dev] [PATCH 2/2] gbm: Add support for 10bpp BGR formats

2018-03-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010 formats. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index df20db40218..b3d6ceb15a3 100644 --- a/src/gbm

[Mesa-dev] [PATCH 1/2] egl/wayland: Add 10bpc BGR configs

2018-03-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010. Signed-off-by: Daniel Stone Cc: Ilia Mirkin --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index

Re: [Mesa-dev] [PATCH] travis: bump libxcb version to 1.13

2018-03-10 Thread Daniel Stone
On 10 March 2018 at 14:53, Christian Gmeiner wrote: > Fixes following dependency problem: > Native dependency xcb-dri3 found: NO found '1.11' but need: '>= 1.13' Oh, oops! Thanks for the catch Christian. Reviewed-by: Daniel Stone Fixes: c80c08e22603 ("vu

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Daniel Stone
Hi Juan, On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> Ilia Mirkin writes: >> - CI Automation immediately builds/tests the proposed stable branch >>whenever it changes. Release managers verify the results. >> > > This is k

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Daniel Stone
Hi Juan, On 12 March 2018 at 12:10, Juan A. Suarez Romero wrote: > On Mon, 2018-03-12 at 11:49 +0000, Daniel Stone wrote: >> On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: >> > We are improving this by moving to use Gitlab CI (still wip), which allows >> >

Re: [Mesa-dev] [PATCH 1/3] wayland-drm: Expose server-side xbgr2101010 and abgr2101010 formats.

2018-03-13 Thread Daniel Stone
Hi Mario, On 12 March 2018 at 20:45, Mario Kleiner wrote: > This way the wayland server can signal support for these formats > to wayland EGL clients. This is currently used by nouveau for 10 > bpc support. > > Tested with glmark2-wayland and glmark2-es2-wayland under weston > to now expose 10 bp

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: correct DRI3 version in comment

2018-03-13 Thread Daniel Stone
Hi Emil, On 13 March 2018 at 11:40, Emil Velikov wrote: > During development the version was bumped, yet the comment did not get > an update. > > Cc: Daniel Stone > Fixes: c80c08e2260 ("vulkan/wsi/x11: Add support for DRI3 v1.2") > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 1/2] autotools+dri3: allow building against older xcb (v4)

2018-03-14 Thread Daniel Stone
Hi, On 14 March 2018 at 13:04, Rob Clark wrote: > I'm not sure everyone wants to be updating their dri3 in a forced > march setting, this allows a nicer approach, esp when you want > to build on distro that aren't brand new. I don't have that much of an opinion on whether the dependency should b

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

2018-03-16 Thread Daniel Stone
Hi Juan, On 16 March 2018 at 11:42, Juan A. Suarez Romero wrote: > Trivial merge conflicts > --- > > [...] > > commit 5fd11359b66c8138d2c7ee29bd9740280b02d1e2 > Author: Daniel Stone > > egl/wayland: Fix ARGB/XRGB transposition in config map

Re: [Mesa-dev] [PATCH 0/3] Meson patches for FreeBSD

2018-03-16 Thread Daniel Stone
Hi, On 16 March 2018 at 15:23, Matt Turner wrote: > On Fri, Mar 16, 2018 at 8:07 AM, Emil Velikov > wrote: >> On 16 March 2018 at 02:39, Matt Turner wrote: >>> All of your messages are going to spam on gmail: >>> >> Setting up a filter for 'list:"mesa-dev.lists.freedesktop.org"' will help >>

Re: [Mesa-dev] Patchwork has 'Server Error (500)'

2018-03-18 Thread Daniel Stone
Hi Dieter, On 18 March 2018 at 00:48, Dieter Nützel wrote: > @ least, here fromm Germany. > > https://patchwork.freedesktop.org/ > Server Error (500) This is fixed now, and I think that particular problem shouldn't happen again. Cheers, Daniel ___ mes

[Mesa-dev] [PATCH] autotools: Don't redefine EXTRA_DIST for freedreno

2018-01-25 Thread Daniel Stone
The EXTRA_DIST of meson.build accidentally stomps another Freedreno file which should be disted. Change = to +=. Signed-off-by: Daniel Stone Fixes: 436ed65d38d4 ("autotools: include meson build files in tarball") Cc: Dylan Baker Cc: Eric Engestrom Cc: Emil Velikov --- src/galli

Re: [Mesa-dev] [PATCH] autotools: Don't redefine EXTRA_DIST for freedreno

2018-01-25 Thread Daniel Stone
Hi Emil, On 25 January 2018 at 11:14, Emil Velikov wrote: > I've got slightly different version [1], any objections if we opt for that? > Seems like I git branched a second too soon, omitting the fixes from > master and 'detaching' 18.0-branchpoint. Sure, that one is: R

Re: [Mesa-dev] [PATCH] configure.ac: correct driglx-direct help text

2018-01-25 Thread Daniel Stone
On 20 December 2017 at 17:34, Emil Velikov wrote: > The default was toggled a while back, but the text wasn't updated. Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/

Re: [Mesa-dev] [PATCH] renderonly: fix dumb BO allocation for non 32bpp formats

2018-01-31 Thread Daniel Stone
ksizebits()? getblocksize() internally just divides getblocksizebits by 8, so this is redundant. WIth that: Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] mesa: add xbgr support adjacent to xrgb

2018-02-05 Thread Daniel Stone
Hi Ilia, On 4 February 2018 at 19:09, Ilia Mirkin wrote: > One might have split this up into multiple patches, but it's just very > repetitive and similar code. You probably want to add this into gbm_to_dri_image_formats[] inside src/gbm/backends/dri/gbm_dri.c, so Wayland compositors running on

Re: [Mesa-dev] [PATCH kmscube] formats: use weston's egl config matching logic, move format defines up

2018-02-08 Thread Daniel Stone
et = drmModeAddFB2(drm_fd, width, height, > DRM_FORMAT_XRGB, > + ret = drmModeAddFB2(drm_fd, width, height, DRM_FORMAT, Nitpick: use gbm_bo_get_format(bo) for both of these. With that: Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mai

[Mesa-dev] [PATCH 10/18] egl/wayland: Add bpp to visual map

2018-02-08 Thread Daniel Stone
Both the DRI2 GetBuffersWithFormat interface, and SHM buffer allocation, had their own format -> bpp lookup tables. Replace these with a lookup into the visual map. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 36 +++-- 1 file changed,

[Mesa-dev] [PATCH 07/18] egl/wayland: Use visual map for buffer_from_image

2018-02-08 Thread Daniel Stone
When creating a wl_buffer on an upstream Wayland display from an existing EGLImage, use the dri2_wl_visual map rather than another hardcoded list of formats. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 38 - 1 file changed, 18

[Mesa-dev] [PATCH 06/18] egl/wayland: Use visual map for config->format lookup

2018-02-08 Thread Daniel Stone
Having hoisted the format -> config map into common code, we now use it for config -> format lookups. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 61 +++-- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/src/egl/d

[Mesa-dev] [PATCH 03/18] egl/wayland: Widen channel masks to bpp

2018-02-08 Thread Daniel Stone
Widen the channel masks given in the visual table to the full width of the pixel format, i.e. as many leading zeros as required. No functional change. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 25 - 1 file changed, 20 insertions(+), 5

[Mesa-dev] [PATCH 13/18] gbm/dri: Add RGBA masks to GBM format table

2018-02-08 Thread Daniel Stone
Eventually, we can replace the visuals list inside GBM EGL driver with this one. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 46 +- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src

[Mesa-dev] [PATCH 18/18] gbm: Add support for 10bpp BGR formats

2018-02-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010 formats. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index ed64ad61bf0..b7da65be27b 100644 --- a/src/gbm

[Mesa-dev] [PATCH 11/18] egl/wayland: Remove has_format enum

2018-02-08 Thread Daniel Stone
Instead of the has_format enum, use an index into the visual array. This makes adding new formats less typing. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/src/egl

[Mesa-dev] [PATCH 14/18] gbm/dri: Expose visuals table through gbm_dri_device

2018-02-08 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c| 21 ++--- src/gbm/backends/dri/gbm_driint.h | 9 + 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 65f612e68b4

[Mesa-dev] [PATCH 05/18] egl/wayland: Add format enums to visual map

2018-02-08 Thread Daniel Stone
eliminate a bunch of open-coded conversions. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index fac66c8c2e2..d08664e87af

[Mesa-dev] [PATCH 16/18] egl/gbm: Ensure EGLConfigs match GBM surface format

2018-02-08 Thread Daniel Stone
this commit, please look at its EGLConfig selection (e.g. through eglChooseConfigs), and add an EGL_NATIVE_VISUAL_ID == gbm_surface format match to the attribs for config selection. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_drm.c | 52 ++--- 1

[Mesa-dev] [PATCH 15/18] egl/gbm: Remove duplicate format table

2018-02-08 Thread Daniel Stone
ind a suitable config. Without doing this, an XRGB EGLConfig would match on an R8 format. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_drm.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/src/egl/drivers/dri2/platform_

[Mesa-dev] [PATCH 02/18] egl/wayland: Hoist format <-> EGLConfig definition up

2018-02-08 Thread Daniel Stone
Pull the mapping between Wayland formats and EGLConfigs up to the top level, so we can reuse it elsewhere. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/egl

[Mesa-dev] [PATCH 12/18] egl/wayland: Use an array for modifiers

2018-02-08 Thread Daniel Stone
Each Wayland EGLDisplay currently contains a struct with one vector of modifiers per format, hardcoded in the header. To allow easier support for more formats, turn this into an array of u_vectors which is opaque outside of platform_wayland.c. Signed-off-by: Daniel Stone --- src/egl/drivers

[Mesa-dev] [PATCH 09/18] egl/wayland: Use visual map for DRIImage<->FourCC map

2018-02-08 Thread Daniel Stone
When trying to translate between DRIImage format enums and FourCC codes, use our visual map rather than an open-coded subset. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a

[Mesa-dev] [PATCH 08/18] egl/wayland: Use visual map for format advertisement

2018-02-08 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 75 - 1 file changed, 36 insertions(+), 39 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 0839f5e85a7..b5659b1 100644

[Mesa-dev] [PATCH 04/18] egl/wayland: Use proper enum type in visual definition

2018-02-08 Thread Daniel Stone
No semantic change. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index a9f8b51d986..fac66c8c2e2 100644 --- a/src/egl

[Mesa-dev] [PATCH 00/18] Wayland/GBM format cleanups and 10bpc BGR

2018-02-08 Thread Daniel Stone
Hi, When Ilia asked for suggestions on where to look to add 10bpc BGR support to the GBM and Wayland EGL backends, I had a quick look; the number of places the formats were duplicated and lossily/inconsistently translated between rapidly annoyed me enough to just type this series up. This gives bo

[Mesa-dev] [PATCH 03/18] egl/wayland: Widen channel masks to bpp

2018-02-08 Thread Daniel Stone
Widen the channel masks given in the visual table to the full width of the pixel format, i.e. as many leading zeros as required. No functional change. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 25 - 1 file changed, 20 insertions(+), 5

[Mesa-dev] [PATCH 04/18] egl/wayland: Use proper enum type in visual definition

2018-02-08 Thread Daniel Stone
No semantic change. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index a9f8b51d986..fac66c8c2e2 100644 --- a/src/egl

[Mesa-dev] [PATCH 02/18] egl/wayland: Hoist format <-> EGLConfig definition up

2018-02-08 Thread Daniel Stone
Pull the mapping between Wayland formats and EGLConfigs up to the top level, so we can reuse it elsewhere. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/egl

[Mesa-dev] [PATCH 17/18] egl/wayland: Add 10bpc BGR configs

2018-02-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010. Signed-off-by: Daniel Stone Cc: Ilia Mirkin --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index

[Mesa-dev] [PATCH 13/18] gbm/dri: Add RGBA masks to GBM format table

2018-02-08 Thread Daniel Stone
Eventually, we can replace the visuals list inside GBM EGL driver with this one. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 46 +- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src

[Mesa-dev] [PATCH 10/18] egl/wayland: Add bpp to visual map

2018-02-08 Thread Daniel Stone
Both the DRI2 GetBuffersWithFormat interface, and SHM buffer allocation, had their own format -> bpp lookup tables. Replace these with a lookup into the visual map. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 36 +++-- 1 file changed,

[Mesa-dev] [PATCH 08/18] egl/wayland: Use visual map for format advertisement

2018-02-08 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 75 - 1 file changed, 36 insertions(+), 39 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 0839f5e85a7..b5659b1 100644

[Mesa-dev] [PATCH 07/18] egl/wayland: Use visual map for buffer_from_image

2018-02-08 Thread Daniel Stone
When creating a wl_buffer on an upstream Wayland display from an existing EGLImage, use the dri2_wl_visual map rather than another hardcoded list of formats. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 38 - 1 file changed, 18

[Mesa-dev] [PATCH 11/18] egl/wayland: Remove has_format enum

2018-02-08 Thread Daniel Stone
Instead of the has_format enum, use an index into the visual array. This makes adding new formats less typing. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/src/egl

[Mesa-dev] [PATCH 01/18] egl/wayland: Fix ARGB/XRGB transposition in config map

2018-02-08 Thread Daniel Stone
When 0b2b7191214eb moved from an if tree to a struct to map between wl_drm formats and EGLConfigs, it transposed the mapping between XRGB and ARGB. Luckily, everyone exposes both formats, so this is harmless. Signed-off-by: Daniel Stone Fixes: 0b2b7191214eb ("egl/wayland: intr

[Mesa-dev] [PATCH 12/18] egl/wayland: Use an array for modifiers

2018-02-08 Thread Daniel Stone
Each Wayland EGLDisplay currently contains a struct with one vector of modifiers per format, hardcoded in the header. To allow easier support for more formats, turn this into an array of u_vectors which is opaque outside of platform_wayland.c. Signed-off-by: Daniel Stone --- src/egl/drivers

[Mesa-dev] [PATCH 05/18] egl/wayland: Add format enums to visual map

2018-02-08 Thread Daniel Stone
eliminate a bunch of open-coded conversions. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index fac66c8c2e2..d08664e87af

[Mesa-dev] [PATCH 06/18] egl/wayland: Use visual map for config->format lookup

2018-02-08 Thread Daniel Stone
Having hoisted the format -> config map into common code, we now use it for config -> format lookups. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 61 +++-- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/src/egl/d

[Mesa-dev] [PATCH 16/18] egl/gbm: Ensure EGLConfigs match GBM surface format

2018-02-08 Thread Daniel Stone
this commit, please look at its EGLConfig selection (e.g. through eglChooseConfigs), and add an EGL_NATIVE_VISUAL_ID == gbm_surface format match to the attribs for config selection. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_drm.c | 52 ++--- 1

[Mesa-dev] [PATCH 15/18] egl/gbm: Remove duplicate format table

2018-02-08 Thread Daniel Stone
ind a suitable config. Without doing this, an XRGB EGLConfig would match on an R8 format. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_drm.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/src/egl/drivers/dri2/platform_

[Mesa-dev] [PATCH 17/18] egl/wayland: Add 10bpc BGR configs

2018-02-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010. Signed-off-by: Daniel Stone Cc: Ilia Mirkin --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index

[Mesa-dev] [PATCH 09/18] egl/wayland: Use visual map for DRIImage<->FourCC map

2018-02-08 Thread Daniel Stone
When trying to translate between DRIImage format enums and FourCC codes, use our visual map rather than an open-coded subset. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a

[Mesa-dev] [PATCH 14/18] gbm/dri: Expose visuals table through gbm_dri_device

2018-02-08 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c| 21 ++--- src/gbm/backends/dri/gbm_driint.h | 9 + 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 65f612e68b4

<    1   2   3   4   5   6   7   8   9   >