[Mesa-dev] [PATCH] i965: add XRGB to fast texture upload

2013-10-11 Thread Courtney Goeltzenleuchter
MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_sub

[Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-11 Thread Courtney Goeltzenleuchter
Support all levels of a supported texture format. --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c index 4aec05d..5e

Re: [Mesa-dev] [PATCH] i965: add XRGB to fast texture upload

2013-10-13 Thread Courtney Goeltzenleuchter
On Sun, Oct 13, 2013 at 1:41 PM, Ian Romanick wrote: > On 10/11/2013 10:16 AM, Courtney Goeltzenleuchter wrote: > > MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms > > of storage on the device, so okay to use this optimized copy routine. > > --- > >

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-13 Thread Courtney Goeltzenleuchter
On Sun, Oct 13, 2013 at 2:50 PM, Frank Henigman wrote: > On Fri, Oct 11, 2013 at 10:00 PM, Chad Versace > wrote: > > On 10/11/2013 10:17 AM, Courtney Goeltzenleuchter wrote: > >> > >> Support all levels of a supported texture format. > >> --- > >>

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-13 Thread Courtney Goeltzenleuchter
On Sun, Oct 13, 2013 at 4:39 PM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > > On Sun, Oct 13, 2013 at 2:50 PM, Frank Henigman wrote: > >> On Fri, Oct 11, 2013 at 10:00 PM, Chad Versace >> wrote: >> > On 10/11/2013 10:17 AM, Courtney Goeltzenleu

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Courtney Goeltzenleuchter
hanks, Courtney On Mon, Oct 14, 2013 at 8:32 AM, Chad Versace wrote: > On 10/13/2013 08:33 PM, Ian Romanick wrote: > >> On 10/13/2013 01:50 PM, Frank Henigman wrote: >> >>> On Fri, Oct 11, 2013 at 10:00 PM, Chad Versace >>> wrote: >>> >>&g

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Courtney Goeltzenleuchter
On Mon, Oct 14, 2013 at 12:43 PM, Chad Versace wrote: > On 10/14/2013 10:54 AM, Eric Anholt wrote: > >> Courtney Goeltzenleuchter writes: >> >> Does anyone know of a test that measures frame 0 time? Or texture upload >>> speed? >>> >>> For Sm

[Mesa-dev] Core Profile and extension strings question

2013-10-22 Thread Courtney Goeltzenleuchter
cific appendices to later versions of the specification. This says to me that the Mesa driver should be listing GL_ARB_texture_cube_map in it's extension string. So, why isn't it there? What am I missing? What should the piglit test do? Is this going to be a compatibility issue for applicatio

Re: [Mesa-dev] Core Profile and extension strings question

2013-10-22 Thread Courtney Goeltzenleuchter
On Tue, Oct 22, 2013 at 11:01 AM, Ian Romanick wrote: > On 10/22/2013 09:00 AM, Courtney Goeltzenleuchter wrote: > > I'm curious about what the proper behavior should be for extensions that > > have been integrated into core. In particular I'm looking at > > ARB_t

[Mesa-dev] [PATCH] i965: Update MESA_INFO to eliminate error

2013-10-23 Thread Courtney Goeltzenleuchter
If a user set MESA_INFO and the OpenGL application uses a 3.0 or later context then the MESA_INFO debug output will have an error when it queries for extensions using the deprecated enum GL_EXTENSIONS. Passing context argument allows code to return extension list directly regardless of profile. ---

Re: [Mesa-dev] [PATCH] i965: Update MESA_INFO to eliminate error

2013-10-23 Thread Courtney Goeltzenleuchter
erent than what glxinfo was reporting. Other than that I'm not sure of it's usefulness. Courtney On Wed, Oct 23, 2013 at 3:05 PM, Matt Turner wrote: > On Wed, Oct 23, 2013 at 12:41 PM, Courtney Goeltzenleuchter > wrote: > > If a user set MESA_INFO and the OpenGL applicat

[Mesa-dev] [PATCH] mesa: Update MESA_INFO to eliminate error

2013-10-24 Thread Courtney Goeltzenleuchter
If a user set MESA_INFO and the OpenGL application uses a 3.0 or later context then the MESA_INFO debug output will have an error when it queries for extensions using the deprecated enum GL_EXTENSIONS. Passing context argument allows code to return extension list directly regardless of profile. Com

[Mesa-dev] [PATCH] i965: Fix compiler warning.

2013-10-30 Thread Courtney Goeltzenleuchter
fix: intel_screen.c:1320:4: warning: initialization from incompatible pointer type [enabled by default] --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_c

[Mesa-dev] [PATCH 0/1]: Preparing for ARB_viewport_array

2013-10-31 Thread Courtney Goeltzenleuchter
The following patch will begin the process of adding ARB_viewport_array to Mesa. Next will be to extend the gl_context Scissor and Viewport attributes to hold multiple viewport, scissor and scissor enables. Then the DI side of ARB_viewport_array. ___ mes

[Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-10-31 Thread Courtney Goeltzenleuchter
Add the index parameter to the Scissor, Viewport and DepthRange driver methods. Update i965 and Gallium to the change. Index always 0. --- src/mesa/drivers/common/driverfuncs.c | 2 +- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/d

[Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-01 Thread Courtney Goeltzenleuchter
Start setting the stage for ARB_viewport_array extension support. Add the index parameter to the Scissor, Viewport and DepthRange driver methods. Update i965 and Gallium to match. Include change for i915, nouveau and radeon per feedback from mesa-dev. piglit quick.tests passes --- src/mesa/driver

[Mesa-dev] [PATCH] mesa: Add ARB_texture_view to Mesa core

2013-11-01 Thread Courtney Goeltzenleuchter
* copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-01 Thread Courtney Goeltzenleuchter
On Fri, Nov 1, 2013 at 1:51 PM, Ian Romanick wrote: > On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote: > > Add the index parameter to the Scissor, Viewport and > > DepthRange driver methods. Update i965 and Gallium > > to the change. Index always 0. > > I j

Re: [Mesa-dev] [PATCH] mesa: Add ARB_texture_view to Mesa core

2013-11-05 Thread Courtney Goeltzenleuchter
d internalformat, so it can't be used with TexStorage? > Chris is correct. GL_LUMINANCE is unsized and is not an allowed format for glTexStorage. -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http:

Re: [Mesa-dev] [PATCH] mesa: Add ARB_texture_view to Mesa core

2013-11-05 Thread Courtney Goeltzenleuchter
On Tue, Nov 5, 2013 at 9:40 AM, Ian Romanick wrote: > On 11/04/2013 03:34 PM, Courtney Goeltzenleuchter wrote: > > > > On Fri, Nov 1, 2013 at 1:42 PM, Ian Romanick > <mailto:i...@freedesktop.org>> wrote: > > > > On 11/01/2013 09:54 AM, Courtney Goeltz

Re: [Mesa-dev] [PATCH] mesa: Add ARB_texture_view to Mesa core

2013-11-05 Thread Courtney Goeltzenleuchter
translate the target internalFormat passed to glTextureView into a VIEW_CLASS. GL_LUMINANCE8 does not have a valid VIEW_CLASS and could not match the internal format of the source texture. That makes me wonder, should I be trying to map the target internalformat into a driver int

[Mesa-dev] [PATCH] mesa: Add API debug logging to TexStorage

2013-11-05 Thread Courtney Goeltzenleuchter
Give glTexStorage* equivalent debug logging to glTexImage*. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/texstorage.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 7bd8652..84b8f82 100644 --- a/src/mesa

[Mesa-dev] [PATCH 0/7] Add ARB_texture_view

2013-11-05 Thread Courtney Goeltzenleuchter
enums that have been added as queriable texture parameters. Adds one new driver entry point for the driver to map the view specified onto the origtexture given. Passes non-rendering ARB_texture_view piglit tests (recently added). Courtney Goeltzenleuchter (7): mesa: Add API definitions for

[Mesa-dev] [PATCH 7/7] mesa: Fill out ARB_texture_view entry points

2013-11-05 Thread Courtney Goeltzenleuchter
Add Mesa TextureView logic. Incorporate feedback on ARB_texture_view --- src/mesa/main/texstorage.c | 3 +- src/mesa/main/textureview.c | 558 +++- 2 files changed, 558 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main

[Mesa-dev] [PATCH 6/7] mesa: Add driver entry point for ARB_texture_view

2013-11-05 Thread Courtney Goeltzenleuchter
--- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/dd.h| 5 + 2 files changed, 8 insertions(+) diff --git a/src/mesa/drivers/common/driverfuncs.c b/src/mesa/drivers/common/driverfuncs.c index 5faa98a..f185688 100644 --- a/src/mesa/drivers/common/driverfuncs.

[Mesa-dev] [PATCH 1/7] mesa: Add API definitions for ARB_texture_view

2013-11-05 Thread Courtney Goeltzenleuchter
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Authors: + *Courtney Goeltzenleuc

[Mesa-dev] [PATCH 2/7] mesa: Tracking for ARB_texture_view extension

2013-11-05 Thread Courtney Goeltzenleuchter
--- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 48c4e9f..75591b0 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -156,6 +156,7 @@ static

[Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

2013-11-05 Thread Courtney Goeltzenleuchter
TexStorage now updates texture object state needed by ARB_texture_view extension. Set appropriate TextureView state in texture object. --- src/mesa/main/texstorage.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/t

[Mesa-dev] [PATCH 4/7] mesa: ARB_texture_view get parameters

2013-11-05 Thread Courtney Goeltzenleuchter
Add support for ARB_texture_view get parameters: GL_TEXTURE_VIEW_MIN_LEVEL GL_TEXTURE_VIEW_NUM_LEVELS GL_TEXTURE_VIEW_MIN_LAYER GL_TEXTURE_VIEW_NUM_LAYERS Incorporate feedback regarding when to allow query of GL_TEXTURE_IMMUTABLE_LEVELS. --- src/mesa/main/texparam.c | 60 +

[Mesa-dev] [PATCH 3/7] mesa: update texture object for ARB_texture_view

2013-11-05 Thread Courtney Goeltzenleuchter
Add state needed by glTextureView to the gl_texture_object. --- src/mesa/main/mtypes.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index a35e9d9..2c5343c 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -1192,6 +1192,1

[Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

2013-11-06 Thread Courtney Goeltzenleuchter
TexStorage and TexStorageMultisample updates texture object state needed by ARB_texture_view extension. Set appropriate TextureView state in texture object. mesa: Add ARB_texture_view Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/teximage.c | 38

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

2013-11-06 Thread Courtney Goeltzenleuchter
LE and GL_TEXTURE_2D_MULTISAMPLE_ARRAY. > > On Thu, Nov 7, 2013 at 8:55 AM, Courtney Goeltzenleuchter > wrote: > > TexStorage and TexStorageMultisample updates texture object > > state needed by ARB_texture_view extension. > > > > Set appropriate TextureView state in texture obj

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

2013-11-06 Thread Courtney Goeltzenleuchter
t will never get reached -- but spurious. > > It might be worth pulling both blocks out into a shared helper. > > > > > On Thu, Nov 7, 2013 at 9:32 AM, Courtney Goeltzenleuchter < > court...@lunarg.com> wrote: > >> Correct and I check_multisample_target check

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

2013-11-06 Thread Courtney Goeltzenleuchter
Okay, making that change, the commit's flow better if patches 5,6,7 become new 5,6,7,8. What's the recommended process for superseding the previous patches for these new ones? Courtney On Wed, Nov 6, 2013 at 2:04 PM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: >

[Mesa-dev] Contributing to Mesa Demos?

2013-11-07 Thread Courtney Goeltzenleuchter
What's the process of contributing a test to the Mesa demos repository? Thanks, Courtney -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Contributing to Mesa Demos?

2013-11-07 Thread Courtney Goeltzenleuchter
Courtney Goeltzenleuchter writes: > > > What's the process of contributing a test to the Mesa demos repository? > > Tests should be made automated and put in piglit, instead of in the Mesa > demos repository. > -- Courtney Goeltzenleuchter LunarG __

[Mesa-dev] [PATCH demos 1/3] Perf: Add command line capabilities to perf framework

2013-11-07 Thread Courtney Goeltzenleuchter
These were entirely interactive. Adding ability to pass in command line arguments allows future tests to include automated test capabilities. Signed-off-by: Courtney Goeltzenleuchter --- src/perf/copytex.c | 2 +- src/perf/drawoverhead.c | 2 +- src/perf/fbobind.c | 2

[Mesa-dev] [PATCH demos 0/3] Customizable texture upload benchmark

2013-11-07 Thread Courtney Goeltzenleuchter
patch adds command line argument passing to the perf infrastructure. Then adding a simple version of the test. And finally adding the full command line configurability. Courtney Goeltzenleuchter (3): Perf: Add command line capabilities to perf framework Perf: Add test to measure texture

[Mesa-dev] [PATCH demos 3/3] Perf: teximage_enh Add command line options

2013-11-07 Thread Courtney Goeltzenleuchter
-off-by: Courtney Goeltzenleuchter --- src/perf/teximage_enh.c | 366 +--- 1 file changed, 287 insertions(+), 79 deletions(-) diff --git a/src/perf/teximage_enh.c b/src/perf/teximage_enh.c index 9bb3944..0f5d2f7 100644 --- a/src/perf/teximage_enh.c +++ b

[Mesa-dev] [PATCH demos 2/3] Perf: Add test to measure texture upload

2013-11-07 Thread Courtney Goeltzenleuchter
: Courtney Goeltzenleuchter --- src/perf/CMakeLists.txt| 1 + src/perf/Makefile.am | 1 + src/perf/bench_glTexImage2D.sh | 13 ++ src/perf/teximage_enh.README | 10 ++ src/perf/teximage_enh.c| 391 + 5 files changed, 416

[Mesa-dev] [PATCH 1/2] i965: add XRGB to tiled_memcpy

2013-11-07 Thread Courtney Goeltzenleuchter
MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-07 Thread Courtney Goeltzenleuchter
Support all levels of a supported texture format. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri

[Mesa-dev] [PATCH 0/2v2] i965: Extend fast texture upload

2013-11-07 Thread Courtney Goeltzenleuchter
456.35 611.53 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Courtney Goeltzenleuchter (2): i965: add XRGB to tiled_memcpy i965: Enhance tiled_memcpy to support all levels src/mesa/drivers/dri/i965/intel_tex_subim

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-07 Thread Courtney Goeltzenleuchter
patch. Any results to share? > > On Thu, Nov 7, 2013 at 1:22 PM, Courtney Goeltzenleuchter > wrote: > > Support all levels of a supported texture format. > > > > Signed-off-by: Courtney Goeltzenleuchter > > --- > > src/mesa/drivers/dri/i965/intel_tex_subi

[Mesa-dev] [PATCH 1/2 v3] i965: add XRGB to tiled_memcpy

2013-11-07 Thread Courtney Goeltzenleuchter
440.62 611.28 256x256 GL_RGBA 489.08 487.80 587.42 GL_RGB 229.03 376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Courtney Goeltzenleuchter

[Mesa-dev] [PATCH 2/2 v3] i965: Enhance tiled_memcpy to support all levels

2013-11-07 Thread Courtney Goeltzenleuchter
376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Courtney Goeltzenleuchter (2): i965: add XRGB to tiled_memcpy i965: Enhance tiled_memcpy to support all levels src/mesa/drivers/dri/i965/intel_tex_subimage.

Re: [Mesa-dev] [PATCH 0/2v2] i965: Extend fast texture upload

2013-11-07 Thread Courtney Goeltzenleuchter
Re-posted patches with updated commit messages. Thanks, Courtney On Thu, Nov 7, 2013 at 2:34 PM, Matt Turner wrote: > On Thu, Nov 7, 2013 at 1:22 PM, Courtney Goeltzenleuchter > wrote: > > This series builds on work from Frank Henigman to optimize the > > process of uplo

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-08 Thread Courtney Goeltzenleuchter
376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh Courtney Goeltzenleuchter (2): i965: add XRGB to tiled_memcpy i965: Enhance tiled_memcpy to support all levels src/mesa/drivers/dri/i965/intel_tex_subimage.

Re: [Mesa-dev] [PATCH demos 3/3] Perf: teximage_enh Add command line options

2013-11-08 Thread Courtney Goeltzenleuchter
Hi Brian, Oops, I meant to get rid of that. Is unnecessary now that the perf framework has command line arguments. Courtney On Thu, Nov 7, 2013 at 5:49 PM, Brian Paul wrote: > On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: > >> texture_enh allows the user to sp

Re: [Mesa-dev] [PATCH demos 2/3] Perf: Add test to measure texture upload

2013-11-08 Thread Courtney Goeltzenleuchter
enh = enhanced Suggestions on something more descriptive? teximage2? bench_teximage? teximage_perf? Thanks for the feedback. On Thu, Nov 7, 2013 at 5:49 PM, Brian Paul wrote: > On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: > >> Needed test to measure texture upload s

Re: [Mesa-dev] [PATCH] mesa: Add ARB_texture_view to Mesa core

2013-11-11 Thread Courtney Goeltzenleuchter
On Mon, Nov 11, 2013 at 11:15 AM, Ian Romanick wrote: > On 11/05/2013 11:36 AM, Courtney Goeltzenleuchter wrote: > > On Tue, Nov 5, 2013 at 12:22 PM, Ian Romanick > <mailto:i...@freedesktop.org>> wrote: > > > > On 11/05/2013 09:44 AM, Chris Forbes wrote

[Mesa-dev] [PATCH demos v2 0/3] Customizable texture upload benchmark

2013-11-11 Thread Courtney Goeltzenleuchter
first patch adds command line argument passing to the perf infrastructure. One big commit to update teximage. Would have been similar commit using other route (new test eventually replacing teximage.) Add bash script to benchmark all the modes tested previously. Courtney Goeltzenleuchter (3):

[Mesa-dev] [PATCH demos v2 3/3] perf: Add script to run collection of texture formats

2013-11-11 Thread Courtney Goeltzenleuchter
bench_teximage.sh runs all the same formats that teximage ran. Also passes the command line arguments of the script to the benchmark to allow tester to set --csvstyle to full or data for output more easily parsed by scripts and such. Signed-off-by: Courtney Goeltzenleuchter --- src/perf

[Mesa-dev] [PATCH demos v2 1/3] Perf: Add command line capabilities to perf framework

2013-11-11 Thread Courtney Goeltzenleuchter
These were entirely interactive. Adding ability to pass in command line arguments allows future tests to include automated test capabilities. Signed-off-by: Courtney Goeltzenleuchter --- src/perf/copytex.c | 2 +- src/perf/drawoverhead.c | 2 +- src/perf/fbobind.c | 2

[Mesa-dev] [PATCH demos v2 2/3] perf: Update teximage to measure more formats

2013-11-11 Thread Courtney Goeltzenleuchter
feedback. This provides a quick way to get feedback on texture upload related performance tuning. Texture image data is initialized and aligned to 64 byte bounary. Uses Mesa demos Perf library to do the measurements. Signed-off-by: Courtney Goeltzenleuchter --- src/perf/teximage.c | 720

Re: [Mesa-dev] [PATCH 1/2 v3] i965: add XRGB to tiled_memcpy

2013-11-12 Thread Courtney Goeltzenleuchter
: > > On 11/07/2013 01:59 PM, Courtney Goeltzenleuchter wrote: > >> > >> MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms > >> of storage on the device, so okay to use this optimized copy routine. > >> > >> This series buil

[Mesa-dev] [v3 1/8] mesa: Add API definitions for ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
Stub in glTextureView API call to go with the glTextureView API xml definition. Includes dispatch test for glTextureView Signed-off-by: Courtney Goeltzenleuchter --- src/mapi/glapi/gen/ARB_texture_view.xml | 23 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen

[Mesa-dev] [v3 7/8] mesa: add texture_view helper function for TexStorage

2013-11-19 Thread Courtney Goeltzenleuchter
Add helper function to set texture_view state from TexStorage calls. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/textureview.c | 59 + src/mesa/main/textureview.h | 4 +++ 2 files changed, 63 insertions(+) diff --git a/src/mesa/main

[Mesa-dev] [v3 3/8] mesa: update texture object for ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
Add state needed by glTextureView to the gl_texture_object. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/mtypes.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f6ce6d0..82fcd61 100644 --- a/src/mesa/main/mtypes.h

[Mesa-dev] [v3 4/8] mesa: ARB_texture_view get parameters

2013-11-19 Thread Courtney Goeltzenleuchter
Add support for ARB_texture_view get parameters: GL_TEXTURE_VIEW_MIN_LEVEL GL_TEXTURE_VIEW_NUM_LEVELS GL_TEXTURE_VIEW_MIN_LAYER GL_TEXTURE_VIEW_NUM_LAYERS Incorporate feedback regarding when to allow query of GL_TEXTURE_IMMUTABLE_LEVELS. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa

[Mesa-dev] [v3 0/8] Add ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
enums that have been added as queriable texture parameters. Adds one new driver entry point for the driver to map the view specified onto the origtexture given. Includes review feedback and a bug fix in compatible_format. Passes non-rendering ARB_texture_view piglit tests. Courtney

[Mesa-dev] [v3 5/8] mesa: Add driver entry point for ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/dd.h| 5 + 2 files changed, 8 insertions(+) diff --git a/src/mesa/drivers/common/driverfuncs.c b/src/mesa/drivers/common/driverfuncs.c index 5faa98a..f185688

[Mesa-dev] [v3 6/8] mesa: Fill out ARB_texture_view entry points

2013-11-19 Thread Courtney Goeltzenleuchter
Add Mesa TextureView logic. Incorporate feedback on ARB_texture_view Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/textureview.c | 562 +++- 1 file changed, 561 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/textureview.c b/src/mesa

[Mesa-dev] [v3 2/8] mesa: Tracking for ARB_texture_view extension

2013-11-19 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 104618c..b7da884 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa

[Mesa-dev] [v3 8/8] mesa: Update TexStorage to support ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
Call TextureView helper function to set TextureView state appropriately for the TexStorage calls. Misc updates from review feedback. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/teximage.c | 6 ++ src/mesa/main/texstorage.c | 5 +++-- 2 files changed, 9 insertions(+), 2

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-19 Thread Courtney Goeltzenleuchter
13 at 12:31 PM, Brian Paul wrote: > On 11/04/2013 11:43 AM, Ian Romanick wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 11/01/2013 04:12 PM, Francisco Jerez wrote: >> >>> Ian Romanick writes: >&

[Mesa-dev] [PATCH 1/2] i965: add XRGB to tiled_memcpy

2013-11-19 Thread Courtney Goeltzenleuchter
GB (MB/sec) GL_RGBA 489.08 487.80 GL_RGB 229.03 376.63 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage -- 1.8.1.2 Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965/intel_tex_subi

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-19 Thread Courtney Goeltzenleuchter
611.28 256x256 GL_RGBA 487.80 587.42 GL_RGB 376.63 585.00 Test shows similar pattern for 512x512 and 256x256. Benchmark has been sent to mesa-dev list: teximage_enh -- 1.8.1.2 Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-19 Thread Courtney Goeltzenleuchter
My apologies, I was distracted by other maters - updated commit follows. On Mon, Nov 11, 2013 at 2:21 PM, Chad Versace wrote: > On 11/08/2013 08:13 AM, Courtney Goeltzenleuchter wrote: > >> Support all levels of a supported texture format. >> >> Using 1024x1024,

Re: [Mesa-dev] [PATCH 0/1]: Preparing for ARB_viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
to be array references to index 0. Shall I just post my changes for folks to poke at? Or is a fdo personal repository easier to work with? Courtney On Tue, Nov 19, 2013 at 5:54 PM, Ian Romanick wrote: > On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote: > > The following patch

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
it. If Driver::Viewport is about to removed, the code of st_viewport should > be moved somewhere else. > > Marek > > > > On Wed, Nov 20, 2013 at 12:53 AM, Courtney Goeltzenleuchter < > court...@lunarg.com> wrote: > >> The Gallium state tracker has a st_viewport t

[Mesa-dev] [PATCH 00/15] Add ARB_viewport_array extension

2013-11-20 Thread Courtney Goeltzenleuchter
t the right index value in place of 0. Courtney Goeltzenleuchter (18): mesa: Change scissor dd interface for viewport_array mesa: Update viewport dd interface for viewport_array mesa: Change DepthRange dd interface mesa: Update gl_scissor_attrib to support ARB_viewport_array mesa: Update vie

[Mesa-dev] [PATCH 02/18] mesa: Update viewport dd interface for viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/intel_context.c | 4 ++-- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c | 2 +- src/mesa/drivers/dri/radeon/radeon_common.c | 4 ++-- src/mesa/drivers/dri/radeon

[Mesa-dev] [PATCH 05/18] mesa: Update viewport driver args for ARB_viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
Change the Driver viewport method arguments to be floats instead of ints. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/intel_context.c | 7 --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c | 5 +++-- src/mesa

[Mesa-dev] [PATCH 01/18] mesa: Change scissor dd interface for viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 2 +- src/mesa/drivers/dri/i915/i830_state.c | 2 +- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_state.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c

[Mesa-dev] [PATCH 07/18] meta: Update meta driver to use API entry point

2013-11-20 Thread Courtney Goeltzenleuchter
Using Mesa's GL entry point allows the meta driver to ignore interface changes due to ARB_viewport_array Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/meta.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/common/m

[Mesa-dev] [PATCH 03/18] mesa: Change DepthRange dd interface

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/i830_state.c | 2 +- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_state.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c

[Mesa-dev] [PATCH 12/18] mesa: Add scissor entry points for viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/scissor.c | 113 src/mesa/main/scissor.h | 8 2 files changed, 121 insertions(+) diff --git a/src/mesa/main/scissor.c b/src/mesa/main/scissor.c index 3187ab1..580558e 100644 --- a

[Mesa-dev] [PATCH 14/18] mesa: Add gl_ViewportIndex variable to GLSL

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/glsl/builtin_variables.cpp | 2 ++ src/glsl/glsl_parser_extras.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 4d44104..862d255 100644 --- a/src/glsl

[Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

2013-11-20 Thread Courtney Goeltzenleuchter
Define API connections to extension entry points added in previous commits. Update entry points to use floating point arguments as required by the extension. Add get tokens for ARB_viewport_array state. Signed-off-by: Courtney Goeltzenleuchter --- src/mapi/glapi/gen/ARB_viewport_array.xml | 79

[Mesa-dev] [PATCH 08/18] mesa: Add indexed version of mesa_scissor

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/attrib.c | 17 ++--- src/mesa/main/context.c | 10 +- src/mesa/main/scissor.c | 46 ++ src/mesa/main/scissor.h | 2 +- 4 files changed, 50 insertions(+), 25 deletions

[Mesa-dev] [PATCH 10/18] mesa: Add custom get function for SCISSOR

2013-11-20 Thread Courtney Goeltzenleuchter
Now that the scissor enable state is a bitfield need a custom function to extract the correct value from gl_context. Modeled Scissor.EnableFlags after Color.BlendEnabled. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/enable.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH 13/18] mesa: Add ARB_viewport_array viewport entry points

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/context.c | 2 +- src/mesa/main/scissor.c | 2 +- src/mesa/main/viewport.c | 316 +++ src/mesa/main/viewport.h | 22 +++- 4 files changed, 287 insertions(+), 55 deletions(-) diff --git

[Mesa-dev] [PATCH 06/18] mesa: Update viewport state for viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
Include DepthRange as well since it's state is lumped together with viewport state. Updates all the drivers that reference Viewport state in gl_context. Have meta driver call _mesa_Viewport as that interface is not changing. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/c

[Mesa-dev] [PATCH 04/18] mesa: Update gl_scissor_attrib to support ARB_viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
bit 0 when communicating with a driver that does not support ARB_viewport_array. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 13 ++--- src/mesa/drivers/common/meta.c | 6 +++--- src/mesa/drivers/dri/i915/i830_vtbl.c | 4

[Mesa-dev] [PATCH 09/18] mesa: Add new get entrypoints for ARB_viewport_array

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/get.c | 189 src/mesa/main/get.h | 6 ++ 2 files changed, 195 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index b8929a5..9e5c04a 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 11/18] mesa: Add ARB_viewport_array state to gl_context

2013-11-20 Thread Courtney Goeltzenleuchter
Add ARB_viewport_array in extensions.c and a flag in gl_extensions. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/context.c| 3 +++ src/mesa/main/extensions.c | 1 + src/mesa/main/get.c| 1 + src/mesa/main/mtypes.h | 10 -- 4 files changed, 13 insertions

[Mesa-dev] [PATCH 11/18] mesa: Add custom get function for SCISSOR

2013-11-20 Thread Courtney Goeltzenleuchter
Now that the scissor enable state is a bitfield need a custom function to extract the correct value from gl_context. Modeled Scissor.EnableFlags after Color.BlendEnabled. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/context.c| 3 +++ src/mesa/main/extensions.c | 1 + src/mesa

[Mesa-dev] [PATCH 18/18] mesa: Remove unused arguments from driver->DepthRange

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/i830_state.c | 2 +- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_state.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c | 2 +- src/mesa/drivers/dri/r200/r200_state.c

[Mesa-dev] [PATCH 17/18] mesa: Remove unused arguments from driver->Viewport

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/dri/i915/intel_context.c | 14 ++ src/mesa/drivers/dri/i965/brw_context.c | 7 +-- src/mesa/drivers/dri/r200/r200_state.c | 9 + src/mesa/drivers/dri/radeon/radeon_common.c | 4 +--- src/mesa

[Mesa-dev] [PATCH 16/18] mesa: Remove unused arguments from driver->Scissor

2013-11-20 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 4 +--- src/mesa/drivers/dri/i915/i830_state.c | 24 ++-- src/mesa/drivers/dri/i915/i830_vtbl.c | 3 +-- src/mesa/drivers/dri/i915/i915_state.c | 24

Re: [Mesa-dev] [PATCH 00/15] Add ARB_viewport_array extension

2013-11-20 Thread Courtney Goeltzenleuchter
On Wed, Nov 20, 2013 at 5:06 PM, Ian Romanick wrote: > On 11/20/2013 02:59 PM, Courtney Goeltzenleuchter wrote: > > This series starts by updating the driver interface for > > scissor, viewport and DepthRange. This includes removing > > unused arguments from the Scissor, Vi

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

2013-11-21 Thread Courtney Goeltzenleuchter
tually -- that's weird. > > > On Fri, Nov 22, 2013 at 8:55 AM, Chris Forbes wrote: > >> I mean some of the values don't match the spec :) >> >> >> On Fri, Nov 22, 2013 at 7:52 AM, Courtney Goeltzenleuchter < >> court...@lunarg.com>

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

2013-11-21 Thread Courtney Goeltzenleuchter
t; These are bogus: > > > > + > > + > > + > > + > > + > What do you mean by "bogus"? I was emulating other extension xml files. Are these not needed because they are already defined in gl_ext.h? > > > > 0x8E4D > > > > + > >

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

2013-11-22 Thread Courtney Goeltzenleuchter
Hi Chris, I'm using this version of the spec: http://www.opengl.org/registry/specs/ARB/viewport_array.txt On Thu, Nov 21, 2013 at 4:41 PM, Chris Forbes wrote: > I was just comparing to the list in the ARB_viewport_array spec. > > > On Fri, Nov 22, 2013 at 11:33 AM, Courtney

Re: [Mesa-dev] [PATCH 15/18] mesa: Add ARB_viewport_array plumbing

2013-11-22 Thread Courtney Goeltzenleuchter
Got it. On Fri, Nov 22, 2013 at 2:55 PM, Chris Forbes wrote: > It's just that last block that were messed up -- rest was context. > > Sorry for any confusion. > > > On Sat, Nov 23, 2013 at 10:06 AM, Courtney Goeltzenleuchter < > court...@lunarg.com> wrote: >

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-10 Thread Courtney Goeltzenleuchter
oint.com/v1/url?u=http:/ >> /lists.freedesktop.org/mailman/listinfo/mesa-dev&k= >> oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ% >> 2BTLs8wadB%2BiIj9xpBY%3D%0A&m=BQB5tezP6JJarG3K6deQKB%2FgjK% >> 2FGhKQvd8LRF8usgCs%3D%0A&s=6d587c1f9718375e59390ea001cad3 >> ee836a3597c86c77596f02292c818b3051> >> >> >> >> >> >> -- >> Cody Northrop >> Graphics Software Engineer >> LunarG, Inc.- 3D Driver Innovations >> Email: c...@lunarg.com <mailto:c...@lunarg.com> >> Website: http://www.lunarg.com >> <https://urldefense.proofpoint.com/v1/url?u=http:/ >> /www.lunarg.com/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r= >> lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m= >> BQB5tezP6JJarG3K6deQKB%2FgjK%2FGhKQvd8LRF8usgCs%3D%0A&s= >> e4c25bb2e76d3a5cbff56061766e2be646a3106ae813979beea26ede2680e7ec> >> > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa: glx: Reduce error log level

2014-06-10 Thread Courtney Goeltzenleuchter
The code that parses LIBGL_DRIVERS_PATH was printing an error for every attempted dlopen. It's not an error to have to check multiple items in the path, only an error if no suitable library is found. Reduced the load error to a warning to match behavior of dynamic linker. Signed-off-by: Cou

Re: [Mesa-dev] [PATCH 12/15] mesa: Add a gles3 error condition for sized internalformat in glCopyTexImage*()

2014-06-11 Thread Courtney Goeltzenleuchter
Wed, Jun 11, 2014 at 10:28 AM, Courtney Goeltzenleuchter > > wrote: > >> > >> On Fri, Jun 6, 2014 at 5:57 PM, Anuj Phogat > wrote: > >>> > >>> Fixes many failures in gles3 Khronos CTS test: packed_pixels > >>>

Re: [Mesa-dev] [PATCH] i965: Make glGetTex to PBO path use blorp to handle swizzled formats

2014-06-26 Thread Courtney Goeltzenleuchter
ip, > - texImage->Width, texImage->Height, GL_COPY)) > - return false; > + 0, 0, texImage->Width, texImage->Height, > + 0, 0, texImage->Width, texImage->Height, > + GL_NEAREST, dst_flip, false); > > intel_miptree_release(&pbo_mt); > > -- > 1.8.1.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > Reviewed-by: Courtney Goeltzenleuchter -- Courtney Goeltzenleuchter LunarG ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

  1   2   >