Re: [Mesa-dev] [PATCH mesa] st/xvmc: fix a couple 'unused-but-set-variable' warnings

2016-07-13 Thread Christian König
Am 13.07.2016 um 00:41 schrieb Eric Engestrom: Signed-off-by: Eric Engestrom Reviewed-by: Christian König --- src/gallium/state_trackers/xvmc/surface.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/surface.c b/src/gallium

[Mesa-dev] [PATCH] st/mesa: fix reference counting bug in st_vdpau

2016-07-13 Thread Christian König
From: Christian König Otherwise we leak the resources created for the DMA-buf descriptors. Signed-off-by: Christian König Cc: 12.0 --- src/mesa/state_tracker/st_vdpau.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_vdpau.c b/src

[Mesa-dev] [PATCH] radeon/uvd: add session context buffer for polaris 10/11

2016-07-13 Thread Christian König
From: Christian König This way we have unlimited UVD sessions. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 20 src/gallium/drivers/radeon/radeon_uvd.h | 1 + 2 files changed, 21 insertions(+) diff --git a/src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: add a return value to cs_flush

2016-07-13 Thread Christian König
Am 13.07.2016 um 20:24 schrieb Marek Olšák: From: Marek Olšák Reviewed-by: Christian König for the whole series. Required by our UVD code. --- src/gallium/drivers/radeon/radeon_winsys.h| 8 +--- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 7 --- src/gallium/winsys

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-14 Thread Christian König
Am 05.07.2016 um 13:17 schrieb Christian König: Am 01.07.2016 um 18:18 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this

Re: [Mesa-dev] [PATCH 01/11] vl: add parameters for VAAPI encode

2016-07-14 Thread Christian König
Am 14.07.2016 um 00:51 schrieb Boyuan Zhang: Allow to specify more parameters in the encoding interface which previously just hardcoded in the encoder Signed-off-by: Boyuan Zhang I'm still not convinced what exactly this is_idr flag should do, but for now I've reviewed and push patch 1, 3 a

Re: [Mesa-dev] [PATCH 06/11] st/va: add copy function for yv12 image to nv12 surface

2016-07-14 Thread Christian König
Am 14.07.2016 um 00:51 schrieb Boyuan Zhang: Add function to copy from yv12 image to nv12 surface for VAAPI putimage call. Existing function only work for copying from yv12 surface to nv12 image. Signed-off-by: Boyuan Zhang Two nitpicks here, the subject should read "vl/util: ..." and the co

Re: [Mesa-dev] [PATCH 02/11] vl: add entry point

2016-07-14 Thread Christian König
Am 14.07.2016 um 00:51 schrieb Boyuan Zhang: Add entry point for encoding which previously hardcoded for decoding purpose only I still can't figure out why we would want this? The variable doesn't seem to be used in the whole patchset. Christian. Signed-off-by: Boyuan Zhang --- src/ga

Re: [Mesa-dev] [PATCH 02/11] vl: add entry point

2016-07-18 Thread Christian König
Am 16.07.2016 um 00:41 schrieb Boyuan Zhang: Add entrypoint to distinguish H.264 decode and encode. For example, in patch 5/11 when is calling "VaCreateContext", "pps" and "sps" shouldn't be allocated for H.264 encoding. So we need to use the entry_point to determine this is H.264 decode or H.2

Re: [Mesa-dev] [PATCH 05/11] st/va: add encode entrypoint

2016-07-18 Thread Christian König
Am 16.07.2016 um 00:41 schrieb Boyuan Zhang: VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We will save this encode entry point in config. config_id was used as profile previously. Now, config has both profile and entrypoint field, and config_id is used to get the

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

2016-07-18 Thread Christian König
Am 16.07.2016 um 00:41 schrieb Boyuan Zhang: Add function to copy from yv12 image to nv12 surface for VAAPI putimage call. We need this function in VaPutImage call where copying from yv12 image to nv12 surface for encoding. Existing function can't be used because it only work for copying from

Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint

2016-07-19 Thread Christian König
Am 19.07.2016 um 00:43 schrieb Boyuan Zhang: VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We will save this encode entry point in config. config_id was used as profile previously. Now, config has both profile and entrypoint field, and config_id is used to get the

Re: [Mesa-dev] [PATCH 11/12] st/va: add environmental variable to disable interlace

2016-07-19 Thread Christian König
Am 19.07.2016 um 00:43 schrieb Boyuan Zhang: Add environmental variable to disable interlace mode. At VAAPI decoding stage, driver can not distinguish b/w pure decoding case and transcoding case. And since interlace encoding is not supported, we have to disable interlace for transcoding case.

Re: [Mesa-dev] [PATCH 09/12] st/va: add functions for VAAPI encode

2016-07-19 Thread Christian König
Am 19.07.2016 um 00:43 schrieb Boyuan Zhang: Add necessary functions/changes for VAAPI encoding to buffer and picture. These changes will allow driver to handle all Vaapi encode related operations. This patch doesn't change the Vaapi decode behaviour. Signed-off-by: Boyuan Zhang --- src/gal

Re: [Mesa-dev] [PATCH 02/12] vl: add entry point

2016-07-19 Thread Christian König
Am 19.07.2016 um 00:43 schrieb Boyuan Zhang: Add entrypoint to distinguish H.264 decode and encode. For example, in patch 5/11 when is calling "VaCreateContext", "pps" and "sps" shouldn't be allocated for H.264 encoding. So we need to use the entry_point to determine this is H.264 decode or H.2

Re: [Mesa-dev] [PATCH mesa v2] vl: fix memory leak

2016-07-19 Thread Christian König
Reviewed-by: Nayan Deshmukh mailto:nayan26deshm...@gmail.com>> On Thu, Jul 14, 2016 at 3:20 AM, Eric Engestrom mailto:e...@engestrom.ch>> wrote: CovID: 1363008 Signed-off-by: Eric Engestrom mailto:e...@engestrom.ch>> --- v2: avoid using malloc(

Re: [Mesa-dev] introducing radv - proof of concept vulkan driver for AMD VI chipsets

2016-07-20 Thread Christian König
Nice :) Not sure if that is going to fly but it at least adds some more pressure on the issue of open sourcing AMDs internal vulkan implementation. Christian. Am 19.07.2016 um 21:59 schrieb Dave Airlie: I was waiting for an open source driver to appear when I realised I should really just writ

Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint

2016-07-20 Thread Christian König
ation), PPS (added by the application), Slice Header, SPS (added by the driver), PPS(added by the driver), Slice Header/Slice Data. That might work in some if not most cases, but is certainly not complaint to the VA-API specification. Christian. Regards, Boyuan ---

Re: [Mesa-dev] [PATCH 09/12] st/va: add functions for VAAPI encode

2016-07-20 Thread Christian König
together with the performance improvements. Regards, Christian. Regards, Boyuan ---- *From:* Christian König *Sent:* July 19, 2016 4:55:43 AM *To:* Zhang, Boyuan; mesa-dev@lists.freedesktop.org *Cc:* adf.li...@gmail.com *Subject:*

Re: [Mesa-dev] VAAPI egl interop on radeon

2016-07-21 Thread Christian König
Hi Jan, I don't think we have implemented EGL interop on VA-API to this extend. All that is supported is exporting the handle of RGBA images, not directly decoded YUV data. If you need decoding support with OpenGL/EGL interop on AMD hardware please use VDPAU instead. Regards, Christian. A

Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint

2016-07-21 Thread Christian König
Am 21.07.2016 um 00:13 schrieb Boyuan Zhang: VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We will save this encode entry point in config. config_id was used as profile previously. Now, config has both profile and entrypoint field, and config_id is used to get the

Re: [Mesa-dev] [PATCH] vl/dri3: fix a memory leak from front buffer

2016-07-21 Thread Christian König
for mpv and totem. Signed-off-by: Leo Liu Cc: "12.0" Looks like I never replied on this :( I simply have to much on my todo list. Patch is Reviewed-by: Christian König if you haven't already pushed it. Regards, Christian. --- src/gallium/auxiliary/vl/vl_winsys_dri3.c

Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint

2016-07-21 Thread Christian König
t some point. Picture encoding seems to be only used for JPEG as far as I can see. Anyway let's keep it like this for now and fix all the fallout we will run into later on. Regards, Christian. Regards, Boyuan *From:*Christian König [mailto:deathsim...@vodafone.de] *Sent:*

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

2016-07-21 Thread Christian König
gards, Christian. Am 20.07.2016 um 14:02 schrieb Nayan Deshmukh: Hi Christian, Thanks for the review. On Tue, Jul 19, 2016 at 4:58 PM, Christian König mailto:deathsim...@vodafone.de>> wrote: Am 18.07.2016 um 21:55 schrieb Nayan Deshmukh: v2: avoiding dividing by zero when

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

2016-07-21 Thread Christian König
.x - 0.5) + 0.5) / video_height In the fragment shader to get the correct coordinate. No need to actually mess with the destination sizes here. Regards, Christian. Regards, Nayan. On Thu, Jul 21, 2016 at 7:20 PM, Christian König mailto:deathsim...@vodafone.de>> wrote: This seems

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Christian König
that those libraries shouldn't do that with such a common name, but renaming the Mesa DEBUG define to something more library specific would still be a good idea to avoid such problems in the future. So general approach is Acked-by: Christian König Regards, Christian. BR, -R BR, -R Signed

[Mesa-dev] Final review VA-API encode support

2016-07-22 Thread Christian König
Hi guys, I would like to get this commit today. I just cleaned up patch #1 a bit, fixes some compiler warning in patch #3 and a build break in #4. Andy any more comments/testing on this or can I add your Tested-by: on it? Regards, Christian. ___ mesa-

[Mesa-dev] [PATCH 3/9] st/va: add conversion for yv12 to nv12in putimage v2

2016-07-22 Thread Christian König
yv12 format. v2 (chk): fix some compiler warnings and commit message Signed-off-by: Boyuan Zhang Signed-off-by: Christian König --- src/gallium/state_trackers/va/image.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH 4/9] st/va: get rate control method from configattrib v2

2016-07-22 Thread Christian König
mit message Signed-off-by: Boyuan Zhang Signed-off-by: Christian König --- src/gallium/state_trackers/va/config.c | 11 +++ src/gallium/state_trackers/va/context.c| 2 ++ src/gallium/state_trackers/va/va_private.h | 2 ++ 3 files changed, 15 insertions(+) diff --git a/src/gall

[Mesa-dev] [PATCH 2/9] vl/util: add copy func for yv12image to nv12surface

2016-07-22 Thread Christian König
From: Boyuan Zhang Add function to copy from yv12 image to nv12 surface for VAAPI putimage call. We need this function in VaPutImage call where copying from yv12 image to nv12 surface for encoding. Existing function can't be used because it only work for copying from yv12 surface to nv12 image

[Mesa-dev] [PATCH 8/9] st/va: add function to handle misc param type frame rate

2016-07-22 Thread Christian König
From: Boyuan Zhang Frame rate can be passed to driver either through VAEncSequenceParameterBufferType or VAEncMiscParameterTypeFrameRate. Previous code only implement the former one, which is used by Gstreamer-Vaapi. Now adding implementation for VAEncMiscParameterTypeFrameRate. Also adding de

[Mesa-dev] [PATCH 5/9] st/va: add functions for VAAPI encode

2016-07-22 Thread Christian König
From: Boyuan Zhang Add necessary functions/changes for VAAPI encoding to buffer and picture. These changes will allow driver to handle all Vaapi encode related operations. This patch doesn't change the Vaapi decode behaviour. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/buff

[Mesa-dev] [PATCH 6/9] st/va: add preset values for VAAPI encode

2016-07-22 Thread Christian König
From: Boyuan Zhang Add some hardcoded values hardware needs mainly for rate control purpose. With previously hardcoded values for OMX, the rate control result is not correct. This change fixed the rate control result by setting correct values for Vaapi. Signed-off-by: Boyuan Zhang --- src/ga

[Mesa-dev] [PATCH 9/9] st/va: enable h264 VAAPI encode

2016-07-22 Thread Christian König
From: Boyuan Zhang Enable H.264 VAAPI encoding through config. Currently only H.264 baseline is supported. Encode entrypoint is not accepted by driver. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/config.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 7/9] st/va: add enviromental variable to disable interlace

2016-07-22 Thread Christian König
From: Boyuan Zhang Add environmental variable to disable interlace mode. At VAAPI decoding stage, driver can not distinguish b/w pure decoding case and transcoding case. And since interlace encoding is not supported, we have to disable interlace for transcoding case. The temporary solution is

[Mesa-dev] [PATCH 1/9] st/va: add encode entrypoint v2

2016-07-22 Thread Christian König
tch instead of ifs, fix memory leaks in the error path, implement vlVaQueryConfigEntrypoints as well, drop VAEntrypointEncPicture (only used for JPEG). Signed-off-by: Boyuan Zhang Signed-off-by: Christian König --- src/gallium/state_trackers/va/config.c |

Re: [Mesa-dev] [PATCH 3/9] st/va: add conversion for yv12 to nv12in putimage v2

2016-07-25 Thread Christian König
Am 23.07.2016 um 01:51 schrieb Andy Furniss: Christian König wrote: From: Boyuan Zhang For putimage call, if image format is yv12 (or IYUV with U V field swap) This comment confuses me AIUI + checking on fourcc.org yv12 is YVU and IYUV/I420 is YUV and nv12 is UVUVUV... so compared to the

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-25 Thread Christian König
Am 22.07.2016 um 17:21 schrieb Emil Velikov: On 22 July 2016 at 09:42, Christian König wrote: Am 22.07.2016 um 03:37 schrieb Rob Clark: On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: LLVM and Mesa both define the DEBUG macro in

Re: [Mesa-dev] [PATCH 12/12] gallium/radeon/winsyses: decrease max_alloc_size to 1/3 of largest heap

2016-08-02 Thread Christian König
Am 02.08.2016 um 14:57 schrieb Alex Deucher: On Tue, Aug 2, 2016 at 4:55 AM, Marek Olšák wrote: On Tue, Aug 2, 2016 at 3:13 AM, Michel Dänzer wrote: On 01.08.2016 16:35, Michel Dänzer wrote: On 30.07.2016 06:42, Marek Olšák wrote: From: Marek Olšák This is controversial, but I don't see a

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-03 Thread Christian König
Sorry for the delay I've been on vacation for a week. Where you able to fix the problem Andy reported? I was able to rather easily reproduce that. Leave out level 8&9 is clearly a good idea and I'm rather eager to commit this set now if it doesn't show any more obvious problems. Regards, Ch

Re: [Mesa-dev] [PATCH 2/5] winsys/radeon: remove cs_queue_empty

2013-10-07 Thread Christian König
greport in a minute. Christian. Am 06.10.2013 18:06, schrieb Marek Olšák: This causes a deadlock and X freeze for some users. See the bug: https://bugs.freedesktop.org/show_bug.cgi?id=70123 Do you have any idea what's wrong there? Marek On Sat, Sep 21, 2013 at 4:41 PM, Christian Köni

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd, st/vdpau: fix video format reporting

2013-10-07 Thread Christian König
Am 01.10.2013 21:12, schrieb Ilia Mirkin: On Tue, Oct 1, 2013 at 3:06 PM, Grigori Goronzy wrote: UVD can only support NV12 in the case of hardware decoding, but we can still use all other formats for software decoding. Use the UNKNOWN entrypoint to signal that we're not interesting in hardware

Re: [Mesa-dev] [PATCH 2/2] st/vl: use MPEG-2 chroma cositing

2013-10-07 Thread Christian König
Am 01.10.2013 21:06, schrieb Grigori Goronzy: MPEG-2 and later video standards align the chroma sample position horizontally with the leftmost luma sample position. Add a half-texel offset to the chroma texture sampling coordinate to sample at the this position instead of sampling in the center b

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd, st/vdpau: fix video format reporting

2013-10-07 Thread Christian König
e going to fix that sooner or later anyway. Christian. Am 07.10.2013 11:37, schrieb Grigori Goronzy: On 07.10.2013 11:25, Christian König wrote: Am 01.10.2013 21:12, schrieb Ilia Mirkin: On Tue, Oct 1, 2013 at 3:06 PM, Grigori Goronzy wrote: UVD can only support NV12 in the case of har

Re: [Mesa-dev] [PATCH] st/vdpau: set correct timeout for fence_finish

2013-10-08 Thread Christian König
Am 08.10.2013 19:13, schrieb Marek Olšák: From: Marek Olšák The timeout of 0 is equivalent to calling fence_signalled, which is not very useful here. Grigori already attached the same fix to the bug https://bugs.freedesktop.org/show_bug.cgi?id=68792. He's probably already working on the re

Re: [Mesa-dev] [PATCH 2/2] r600g, radeonsi: use fences provided by the winsys

2013-10-09 Thread Christian König
Haven't looked in detail at the patch, but I'm pretty sure that this goes into the right direction. Christian. Am 08.10.2013 23:53, schrieb Marek Olšák: Sorry, I didn't realize this. You are right. My bad. Regardless of my comment, I still wonder what people's opinion on this patch is. Marek

Re: [Mesa-dev] [PATCH 1/6] radeon/uvd: fix video format reporting

2013-10-09 Thread Christian König
I reviewed and assumed that you don't have commit access so pushed the whole series. Thanks allot for the help, Christian. Am 09.10.2013 02:23, schrieb Grigori Goronzy: UVD can only support NV12 in the case of hardware decoding, but we can still use all other formats for software decoding. Use

Re: [Mesa-dev] [PATCH] R600/SI: fix MIMG writemask adjustement

2013-10-09 Thread Christian König
Are there any changes to the original patch you've send out? Anyway this version is: Reviewed-by: Christian König Am 09.10.2013 15:33, schrieb Marek Olšák: From: Marek Olšák This fixes piglit: - shaders/glsl-fs-texture2d-masked - shaders/glsl-fs-texture2d-masked-4 Signed-off-by:

[Mesa-dev] [PATCH] radeon/winsys: fix handling in radeon_drm_cs_flush v2

2013-10-09 Thread Christian König
From: Christian König Calling radeon_drm_cs_flush from multiple threads might cause deadlocks, fix this by immediately signaling the semaphore after waiting for it. This is a candidate for the stable branch(es). Partially fixes: https://bugs.freedesktop.org/show_bug.cgi?id=70123 v2: some

Re: [Mesa-dev] [PATCH 1/2] r600/uvd: fix mapping of UVD surfaces for readback

2013-10-10 Thread Christian König
Am 09.10.2013 22:19, schrieb Grigori Goronzy: R600_RESOURCE_FLAG_TRANSFER forces direct mapping, and reading from VRAM is simply too slow. VDPAU GetBitsYCbCr is unusuable. Change to the new PIPE_BIND_LINEAR and adjust r600_transfer_map so that it uses a staging texture. Looks good on the first

Re: [Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-10 Thread Christian König
Am 10.10.2013 18:02, schrieb Vadim Girlin: On 10/10/2013 02:11 PM, Michel Dänzer wrote: On Don, 2013-10-10 at 12:49 +0400, Vadim Girlin wrote: Currently it's hardcoded in the shader, so every change requires compilation of the shader variant, killing the performance in Serious Sam 3 and probabl

Re: [Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-11 Thread Christian König
Am 11.10.2013 01:15, schrieb Marek Olšák: On Thu, Oct 10, 2013 at 6:38 PM, Vadim Girlin wrote: On 10/10/2013 08:10 PM, Christian König wrote: Am 10.10.2013 18:02, schrieb Vadim Girlin: On 10/10/2013 02:11 PM, Michel Dänzer wrote: On Don, 2013-10-10 at 12:49 +0400, Vadim Girlin wrote

Re: [Mesa-dev] [PATCH 1/3] radeon/uvd: use PIPE_BIND_LINEAR for video surfaces

2013-10-13 Thread Christian König
Am 13.10.2013 18:08, schrieb Grigori Goronzy: This new bind flag forces linear storage, but does not have other side effects like R600_RESOURCE_FLAG_TRANSFER. Reviewed and committed the whole patch set. Thansk for the help, Christian. --- src/gallium/drivers/r600/r600_uvd.c | 6 +++

[Mesa-dev] Mesa drivers/GLX and fork

2013-10-15 Thread Christian König
Hi Marek, for the past few days I've been working on solving https://bugs.freedesktop.org/show_bug.cgi?id=70123. The basic problem is that compton forks itself into the background after initializing the X server connection and GLX context. What happens now is that only comptons main thread g

Re: [Mesa-dev] Mesa drivers/GLX and fork

2013-10-16 Thread Christian König
Am 15.10.2013 19:46, schrieb Ian Romanick: On 10/15/2013 03:45 AM, Christian König wrote: Hi Marek, for the past few days I've been working on solving https://bugs.freedesktop.org/show_bug.cgi?id=70123. The basic problem is that compton forks itself into the background after initializin

[Mesa-dev] [PATCH] winsys/radeon: cleanup CS offloading

2013-10-19 Thread Christian König
From: Christian König Using atomic function for ncs is superfluous since it is protected by a mutex anyway. Also lock the mutex only once while retrieving the next CS for submission. Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 31

[Mesa-dev] [PATCH 1/2] winsys/radeon: make radeon_drm_winsys_create public

2013-10-20 Thread Christian König
From: Christian König Otherwise OpenGL/VDPAU interop won't work as expected. Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c

[Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v6

2013-10-20 Thread Christian König
From: Christian König v2: Actually implement interop between the gallium state tracker and the VDPAU backend. v3: Make it also available in non legacy contexts, fix video buffer sharing. v4: deny interop if we don't have the same screen object v5: rebased on upstream change

[Mesa-dev] [PATCH 4/7] vl/vlc: add remove bits function

2013-10-24 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_vlc.h | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_vlc.h b/src/gallium/auxiliary/vl/vl_vlc.h index 0dc1df9..9f67ba9 100644 --- a/src/gallium/auxiliary/vl

[Mesa-dev] OpenMAX state tracker

2013-10-24 Thread Christian König
Hello list, the following patch set implements an initial OpenMAX state tracker. Supported are hardware accelerated decoding of both MPEG2 and H264 using UVD on modern radeon chips. In opposite to our VDPAU implementation the H264 decoder supports Hi10P as well, but on the other hand probably

[Mesa-dev] [PATCH 3/7] vl/h264: split fields into SPS/PPS

2013-10-24 Thread Christian König
From: Christian König Add alot of missing fields as well. Signed-off-by: Christian König --- .../drivers/nouveau/nouveau_vp3_video_bsp.c| 30 src/gallium/drivers/nouveau/nouveau_vp3_video_vp.c | 24 +++--- src/gallium/drivers/nouveau/nv50/nv84_video_bsp.c | 38

[Mesa-dev] [PATCH 2/7] radeon/uvd: fix H264 chroma format handling

2013-10-24 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c index 134ce4e..6d87841 100644

[Mesa-dev] [PATCH 5/7] vl/vlc: add function to limit the vlc size

2013-10-24 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_vlc.h | 53 ++- 1 file changed, 41 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_vlc.h b/src/gallium/auxiliary/vl/vl_vlc.h index 9f67ba9..ea4f93d

[Mesa-dev] [PATCH 1/7] vl: add 400 chroma format as well

2013-10-24 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/include/pipe/p_format.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_format.h b/src/gallium/include/pipe/p_format.h index b82f08f..461d38f 100644 --- a/src/gallium/include/pipe/p_format.h

[Mesa-dev] [PATCH 6/7] vl/rbsp: add H.264 RBSP implementation

2013-10-24 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_rbsp.h | 164 + 1 file changed, 164 insertions(+) create mode 100644 src/gallium/auxiliary/vl/vl_rbsp.h diff --git a/src/gallium/auxiliary/vl/vl_rbsp.h b/src/gallium

Re: [Mesa-dev] [PATCH 3/7] vl/h264: split fields into SPS/PPS

2013-10-24 Thread Christian König
Am 24.10.2013 19:18, schrieb Ilia Mirkin: On Thu, Oct 24, 2013 at 9:14 AM, Christian König wrote: From: Christian König Add alot of missing fields as well. Signed-off-by: Christian König --- .../drivers/nouveau/nouveau_vp3_video_bsp.c| 30 src/gallium/drivers/nouveau

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-10-26 Thread Christian König
Merged the fixes and pushed the result this morning. Thanks for the help, Christian. Am 26.10.2013 01:25, schrieb Marek Olšák: On Sun, Oct 20, 2013 at 11:57 AM, Christian König wrote: Hi Marek, I've just send out a v6 of the patch, please take a second look. Most things are fixed now

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-10-27 Thread Christian König
Am 26.10.2013 19:49, schrieb Paul Berry: On 26 October 2013 07:26, Christian König <mailto:deathsim...@vodafone.de>> wrote: Merged the fixes and pushed the result this morning. Did you by any chance run "make check"? I'm seeing the following failure: Nope, sor

Re: [Mesa-dev] [PATCH] R600/SI: add a workaround for a scalar-memory-read hw bug on CI

2013-10-30 Thread Christian König
Am 30.10.2013 14:23, schrieb Marek Olšák: From: Marek Olšák This also fixes scalar compare instructions which were always eliminated, because they didn't have a destination of SCC. Uff, that looks like quite a bit of overhead, isn't there a simpler approach? Like setting the the NumRecord to

Re: [Mesa-dev] [PATCH] R600/SI: add a workaround for a scalar-memory-read hw bug on CI

2013-10-30 Thread Christian König
ed by S_CBRANCH has less overhead than doing a memory read. If we used one of S_BUFFER_LOAD_DWORDX2,4,8,16, it wouldn't be so bad. I don't know. Marek On Wed, Oct 30, 2013 at 2:48 PM, Christian König wrote: Am 30.10.2013 14:23, schrieb Marek Olšák: From: Marek Olšák This also fixes

Re: [Mesa-dev] [PATCH] R600/SI: add a workaround for a scalar-memory-read hw bug on CI

2013-10-30 Thread Christian König
Marek Olšák: Yeah, it's unusual. What if S_BUFFER_LOAD is also used by something else, like texture buffers, or OpenCL? Will we have to fix that as well? Marek On Wed, Oct 30, 2013 at 3:32 PM, Christian König wrote: Mhm, I'm assumed that having NumRecord zero is actually something qui

Re: [Mesa-dev] [PATCH 0/6] Removal of useless Gallium targets

2013-11-02 Thread Christian König
buggy and will probably never be fixed. (there are 4 bugs about them on FDO) The video-accel softpipe targets also aren't useful anymore. For the whole series: Reviewed-by: Christian König Marek ___ mesa-dev mailing list mesa-dev@lists.freed

Re: [Mesa-dev] [PATCH 17/37] targets/vdpau: symlink vl_winsys_{dri, xsp}.c for each target

2013-11-02 Thread Christian König
Am 02.11.2013 20:00, schrieb Emil Velikov: Make automake's subdir-objects work. Signed-off-by: Emil Velikov You can drop this and patch 18, I have a patch in the pipeline to entirely remove vl_winsys_xsp.c. Just waiting for Mareks patchset to be committed. Christian. --- src/gallium/t

Re: [Mesa-dev] [PATCH] st/vdpau: resolve delayed rendering for GL interop

2013-11-06 Thread Christian König
We need to take/release the driver lock around this as well. I've fixed this and pushed the result upstream. Any idea when your deinterlacer is ready to hit the list as a patch? Thanks for the help, Christian. Am 06.11.2013 00:35, schrieb Grigori Goronzy: Otherwise OutputSurface interop has

[Mesa-dev] [PATCH] vl: use a separate context for shader based decode

2013-11-06 Thread Christian König
From: Christian König This makes VDPAU thread save again. Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_mpeg12_decoder.c | 180 ++- src/gallium/auxiliary/vl/vl_mpeg12_decoder.h | 1 + 2 files changed, 120 insertions(+), 61 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH] vl: use a separate context for shader based decode

2013-11-06 Thread Christian König
#x27;t see anywhere in vl_mpeg12_destroy that you are actually destroying the context that you create in vl_create_mpeg12_decoder. Would I be correct in assuming that this is leaked memory? --Aaron On Wed, Nov 6, 2013 at 8:13 AM, Christian König wrote: From: Christian König This makes VDPAU thread

[Mesa-dev] [PATCH] vl: use a separate context for shader based decode v2

2013-11-06 Thread Christian König
From: Christian König This makes VDPAU thread save again. v2: fix some memory leaks reported by Aaron Watry. Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_mpeg12_decoder.c | 184 ++- src/gallium/auxiliary/vl/vl_mpeg12_decoder.h | 1 + 2 files

Re: [Mesa-dev] [PATCH 2/2] targets/xvmc: export only necessary symbols

2013-11-17 Thread Christian König
. Haven't tested it, but it sounds like a good idea to me as well. Patch is: Reviewed-by: Christian König --- src/gallium/Automake.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/Automake.inc b/src/gallium/Automake.inc index b6b9b36..1e4a34f 100644 ---

[Mesa-dev] [PATCH] winsys/radeon: cleanup virtual memory nonsense

2013-11-19 Thread Christian König
From: Christian König The alignment of a virtual memory area must always be at least 4096 bytes. It only worked because size was aligned to 4096 outside of the function. Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 37 +-- src

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-19 Thread Christian König
For merging the patches for new hardware and/or features I agree on the process of merging things bottom up. (e.g kernel first, then libdrm, mesa last). But to give reasons for the merge into Linus tree it's usually better to have a "big picture" you can validate the code against. So I think t

Re: [Mesa-dev] [PATCH] winsys/radeon: cleanup virtual memory nonsense

2013-11-19 Thread Christian König
Am 19.11.2013 14:41, schrieb Marek Olšák: On Tue, Nov 19, 2013 at 11:05 AM, Christian König wrote: From: Christian König The alignment of a virtual memory area must always be at least 4096 bytes. It only worked because size was aligned to 4096 outside of the function. Signed-off-by

Re: [Mesa-dev] [PATCH] winsys/radeon: cleanup virtual memory nonsense

2013-11-19 Thread Christian König
Am 19.11.2013 16:19, schrieb Alex Deucher: On Tue, Nov 19, 2013 at 5:05 AM, Christian König wrote: From: Christian König The alignment of a virtual memory area must always be at least 4096 bytes. It only worked because size was aligned to 4096 outside of the function. Signed-off-by

Re: [Mesa-dev] [PATCH 1/4] vl: add more avc profiles

2014-06-04 Thread Christian König
Am 04.06.2014 16:20, schrieb Andy Furniss: Christian König wrote: Reviewed and pushed. Pushed where? Unfortunately to the wrong server instead of upstream, thanks for the notice. I guess they don't affect radeon uvd anyway, just when I saw 422 and 444, I was hopeful that uvd cards

Re: [Mesa-dev] [PATCH 3/3] radeon/uvd: disable VC-1 simple/main on UVD 2.x

2014-06-04 Thread Christian König
Am 04.06.2014 18:54, schrieb Grigori Goronzy: It's about as broken as on later UVD revisions. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66452 Cc: "10.1 10.2" Do you have commit rights? Patch is Reviewed-by: Christian König Thanks for the help, Christian. --

Re: [Mesa-dev] [PATCH] configure: correctly autodetect xvmc/vdpau/omx

2014-06-11 Thread Christian König
swrast was selected. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79907 Cc: "10.2" Signed-off-by: Emil Velikov I was already wondering what's going wrong there. Thanks for all the work maintaining the build system. Patch is Reviewed-by: Christian König --- c

Re: [Mesa-dev] [PATCH 5/5] radeon/vce: set number of cpbs based on level

2014-06-12 Thread Christian König
b_num = get_cpb_num(enc); Please add an error check here that we don't have zero CPBs, that can happen if the user specifies an invalid level for the given resolution. In this case a "goto error" should probably be sufficient. With that fixed the series is Reviewed-by: Christ

Re: [Mesa-dev] [PATCH] radeonsi: fixup sizes of shader resource and sampler arrays

2014-06-14 Thread Christian König
g and should be fixed. Patch is Reviewed-by: Christian König Regards, Christian. --- src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index a7

Re: [Mesa-dev] [PATCH 1/2] R600/SI: add Gather4 intrinsics (v2)

2014-06-17 Thread Christian König
Yeah, agree adding SDNodes for every intrinsic sounds odd. SDNodes should be the source of the selection process, not it's destination. Christian. Am 17.06.2014 03:51, schrieb Marek Olšák: Is there any specific reason for using SDNodes for everything? Using intrinsics directly in patterns see

Re: [Mesa-dev] [PATCHv2] targets/radeonsi/vdpau: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Hi Emil, This patch is Reviewed-by: Christian König But there is still something looking odd: if NEED_RADEON_DRM_WINSYS if !HAVE_GALLIUM_R300 -if !HAVE_GALLIUM_RADEONSI STATIC_TARGET_LIB_DEPS += \ $(top_builddir)/src/gallium/winsys/radeon/drm/libradeonwinsys.la endif endif

Re: [Mesa-dev] [PATCHv2] targets/r600/xvmc: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:02, schrieb Emil Velikov: The r600 equivalent of previous commit. v2: - Correctly include the radeon winsys/radeon_common. Cc: Christian König Signed-off-by: Emil Velikov Reviewed-by: Christian König --- configure.ac | 3 +- src

Re: [Mesa-dev] [PATCHv2] targets/r600/omx: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:04, schrieb Emil Velikov: The r600 counterpart of previous commit - now the libomx-r600 is built into the libomx-mesa library. Providing a single library per API. v2: - Include the radeon winsys only when there is a user for it. Cc: Leo Liu Cc: Christian König Signed-off

Re: [Mesa-dev] [PATCHv2] targets/radeonsi/omx: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:05, schrieb Emil Velikov: The radeonsi counterpart of previous commit - now libomx-radeonsi is built into the libomx-mesa library. Providing a single library per API. v2: - Include the radeon winsys only when there is a user for it. Cc: Leo Liu Cc: Christian König Signed-off

Re: [Mesa-dev] [PATCHv2] targets/r600/vdpau: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:06, schrieb Emil Velikov: Similar to previous commit, this allows us to minimise some of the duplication by compacting all vdpau targets into a single library. v2: - Include the radeon winsys only when there is a user for it. Cc: Christian König Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 05/23] targets/(r300|r600|radeonsi)/dri: Convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:38, schrieb Emil Velikov: Related to previous commit, merge the separate dri targets to a single one. This is essentially all the buildsystem mayhem required for megaradeon. Cc: Marek Olšák Cc: Michel Dänzer Cc: Christian König Signed-off-by: Emil Velikov I'm not

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-06-18 Thread Christian König
@Grigori: Should I push it or did you got your account in the meantime? Christian. Am 17.06.2014 22:26, schrieb Marek Olšák: This looks good to me. Reviewed-by: Marek Olšák Marek On Wed, Jun 4, 2014 at 6:54 PM, Grigori Goronzy wrote: This makes 4:2:2 video surfaces work in VDPAU. --- sr

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-06-18 Thread Christian König
Ok, pushed the patches. Account requests usually take a while to complete, that's nothing to worry about. Regards, Christian. Am 18.06.2014 13:14, schrieb Grigori Goronzy: On 18.06.2014 13:11, Christian König wrote: @Grigori: Should I push it or did you got your account in the mea

Re: [Mesa-dev] [PATCH 1/5] st/st/omx: fix switch-case indentation in vid_enc.c

2014-06-18 Thread Christian König
Am 12.06.2014 18:27, schrieb Leo Liu: Signed-off-by: Leo Liu I've pushed everything upstream. Thanks for the help, Christian. --- src/gallium/state_trackers/omx/vid_enc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/gallium/st

Re: [Mesa-dev] [PATCH] st/omx: keep the name, (name|role)_specific strings dynamically allocated

2014-06-27 Thread Christian König
Am 26.06.2014 18:45, schrieb Emil Velikov: ... as it's caller (the external program omxregister-bellagio) is the one who frees all of the allocated memory. Cc: Pedretti Fabio Reported-by: Pedretti Fabio Signed-off-by: Emil Velikov Reviewed-by: Christian König --- src/ga

[Mesa-dev] [PATCH] gallium/radeon: use PRIX64 instead of PRIu64

2014-07-06 Thread Christian König
From: Christian König We want hex values here, not decimals. Signed-off-by: Christian König --- src/gallium/drivers/radeon/r600_buffer_common.c | 2 +- src/gallium/drivers/radeon/r600_texture.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH] radeonsi: fix order of r600_need_dma_space and r600_context_bo_reloc

2014-07-09 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/si_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_dma.c b/src/gallium/drivers/radeonsi/si_dma.c index dc8c609..26f1e1b 100644 --- a/src/gallium

<    1   2   3   4   5   6   7   8   9   10   >