Re: [Mesa-dev] [PATCH mesa] swr: use ARRAY_SIZE macro

2017-09-13 Thread Cherniak, Bruce
Regardless of making it a v2, etc. :-) Sorry for the complication of not being able to just accept the original. Reviewed-by: Bruce Cherniak > On Sep 12, 2017, at 8:03 AM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > --- > src/gallium/drivers/swr/rasterizer/memory/StoreTile.h

Re: [Mesa-dev] [PATCH] swr/rast: fix intrinsic/function for LLVM 7 compatibility

2018-10-16 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 15, 2018, at 9:53 AM, Alok Hota wrote: > > Converted from x86 VFMADDPS intrinsic to generic LLVM intrinsic, and > removed createInstructionSimplifierPass, which were both removed in LLVM > 7.0.0 > > These changes combine patches we received from the communi

Re: [Mesa-dev] [PATCH 1/1] swr/rast: ignore CreateElementUnorderedAtomicMemCpy

2018-10-17 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 17, 2018, at 1:51 PM, Alok Hota wrote: > > This function's API changed between LLVM 5 and 6. Compile errors occur > when building with LLVM 6+ if LLVM 5 was used for a dist tarball > --- > .../drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 3 +

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

2018-07-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jul 27, 2018, at 1:45 PM, Denis Pauk wrote: > > Reuse Code from: > f69bc797e1 gallium/auxiliary: Add helper support for bptc format > compress/decompress > > Signed-off-by: Denis Pauk > CC: Marek Olšák > CC: Bruce Cherniak > CC: Tim Rowley > --- > src/gal

Re: [Mesa-dev] [PATCH] gallium/swr: Enable support bptc format.

2018-08-01 Thread Cherniak, Bruce
.com>> wrote: Hi Bruce, Thank you, could you please merge commits? (I don't have commit rights.) On Fri, Jul 27, 2018 at 11:02 PM Cherniak, Bruce mailto:bruce.chern...@intel.com>> wrote: Reviewed-by: Bruce Cherniak mailto:bruce.chern...@intel.com>> > On Jul 27, 2018

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 6.0

2018-08-09 Thread Cherniak, Bruce
res LLVM 5.0. >> >> Let's bump required LLVM to 6.0 in swr too. >> >> Fixes: fd1121e839 ("amd: remove support for LLVM 5.0") >> Cc: Tim Rowley >> Cc: Emil Velikov >> Cc: Dylan Baker >> Cc: Eric Engestrom > > CC: "Chern

Re: [Mesa-dev] [PATCH 0/6] update swr rasterizer

2016-04-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Apr 25, 2016, at 5:12 PM, Tim Rowley wrote: > > Couple of large backend refactorizations, some miscellaneous changes, > and warning cleanup. > > Tim Rowley (6): > swr: [rasterizer core] backend refactor > swr: [rasterizer jitter] add mSimdInt1Ty > swr: [rast

Re: [Mesa-dev] [PATCH] swr: s/Elements/ARRAY_SIZE/

2016-04-27 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Apr 27, 2016, at 10:13 AM, Tim Rowley wrote: > > --- > src/gallium/drivers/swr/swr_context.cpp| 4 ++-- > src/gallium/drivers/swr/swr_state.cpp | 6 +++--- > src/gallium/drivers/swr/swr_tex_sample.cpp | 4 ++-- > 3 files changed, 7 insertions(+), 7 deleti

Re: [Mesa-dev] [PATCH] swr: remove duplicated constant update code

2016-04-28 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Apr 28, 2016, at 11:18 AM, Tim Rowley wrote: > > --- > src/gallium/drivers/swr/swr_state.cpp | 91 ++- > 1 file changed, 47 insertions(+), 44 deletions(-) > > diff --git a/src/gallium/drivers/swr/swr_state.cpp > b/src/gallium/d

Re: [Mesa-dev] [PATCH 00/11] update swr rasterizer

2016-05-05 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On May 3, 2016, at 11:13 AM, Tim Rowley wrote: > > Smallish changes this time around, some changes that hopefully > start improving coverity's opinion of the rasterizer, and a small > performance tweak. > > Tim Rowley (11): > swr: [rasterizer] Whitespace cleanup

Re: [Mesa-dev] [PATCH] swr: PIPE_CAP_CULL_DISTANCE cap request response

2016-05-16 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On May 16, 2016, at 11:05 AM, Tim Rowley wrote: > > --- > src/gallium/drivers/swr/swr_screen.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/swr/swr_screen.cpp > b/src/gallium/drivers/swr/swr_screen.cpp > index 3d280e3..ce880ec 1

Re: [Mesa-dev] [PATCH v2] docs: add swr to GL3.txt

2016-05-19 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak On 5/17/16, 5:46 PM, "mesa-dev on behalf of Tim Rowley" wrote: >--- > docs/GL3.txt | 82 ++-- > 1 file changed, 41 insertions(+), 41 deletions(-) > >diff --git a/docs/GL3.txt b/docs/GL3.txt >index 921a529..7e

Re: [Mesa-dev] [PATCH v2 00/19] swr: update rasterizer

2016-05-19 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak On 5/17/16, 5:36 PM, "mesa-dev on behalf of Tim Rowley" wrote: >Mostly small cleanups this round. > >v2: > remove definition of offsetof > more descriptive commit messages > split threads.cpp cygwin/style changes into two commits > >Tim Rowley (19): > swr: [ra

Re: [Mesa-dev] [PATCH 0/6] update swr rasterizer

2016-05-20 Thread Cherniak, Bruce
Unfortunately, you're right. I'll need to come up with a more complete fix. Don't submit that knob change. On 5/20/16, 2:08 PM, "mesa-dev on behalf of Rowley, Timothy O" wrote: >Bruce, is cut-aware needed for primitive restart? > >> On May 20, 2016, at 11:58 AM, Rowley, Timothy O >> wro

Re: [Mesa-dev] [PATCH 0/6] update swr rasterizer

2016-05-24 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak minus the knob.h change to disable cut-aware primitive assembler. New change for that coming today. > On May 20, 2016, at 2:08 PM, Rowley, Timothy O > wrote: > > Bruce, is cut-aware needed for primitive restart? > >> On May 20, 2016, at 11:58 AM, Rowley, Timothy

<    1   2   3