Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
p.video.mesa3d.devel/66385 [3] http://thread.gmane.org/gmane.comp.video.mesa3d.devel/78175 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
On Thu, 3 Jul 2014 11:14:48 +0200 Giovanni Campagna wrote: > 2014-07-03 10:48 GMT+02:00 Boris BREZILLON > : > > Hello Giovanni, > > > > I have recently been working on a DRM/KMS driver which does not support > > OpenGL rendering (it only provides plane compos

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
On Thu, 3 Jul 2014 12:24:44 +0300 Pekka Paalanen wrote: > On Thu, 3 Jul 2014 10:48:26 +0200 > Boris BREZILLON wrote: > > > Hello Giovanni, > > > > I have recently been working on a DRM/KMS driver which does not support > > OpenGL rendering (it only provides

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
On Thu, 3 Jul 2014 13:49:06 +0300 Pekka Paalanen wrote: > On Thu, 3 Jul 2014 12:10:36 +0200 > Boris BREZILLON wrote: > > > On Thu, 3 Jul 2014 12:24:44 +0300 > > Pekka Paalanen wrote: > > > > > On Thu, 3 Jul 2014 10:48:26 +0200 > > > Boris BR

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-03 Thread Boris BREZILLON
On Thu, 3 Jul 2014 15:46:14 +0300 Pekka Paalanen wrote: > On Thu, 3 Jul 2014 14:15:34 +0200 > Boris BREZILLON wrote: > > > On Thu, 3 Jul 2014 13:49:06 +0300 > > Pekka Paalanen wrote: > > > > > On Thu, 3 Jul 2014 12:10:36 +0200 > > > Boris BREZIL

Re: [Mesa-dev] [PATCH v3 0/3] Software rendering in EGL-DRM

2014-07-10 Thread Boris BREZILLON
Hello Giovanni, On Thu, 3 Jul 2014 11:14:48 +0200 Giovanni Campagna wrote: > 2014-07-03 10:48 GMT+02:00 Boris BREZILLON > : > > Hello Giovanni, > > > > I have recently been working on a DRM/KMS driver which does not support > > OpenGL rendering (it o

Re: [Mesa-dev] [PATCH] meson: egl: correctly manage loader/xmlconfig

2019-02-15 Thread Boris Brezillon
> Cc: Alexander von Gluck IV > Cc: Dylan Baker > Cc: Boris Brezillon > Reported-by: Boris Brezillon > Fixes: 834d221512f ("meson: Add Haiku platform support v4") > Signed-off-by: Emil Velikov Tested-by: Boris Brezillon Thanks, Boris > --- > src/egl/meson.

[Mesa-dev] [RFC PATCH 1/2] etnaviv: add support for CPU-based super/multi tile tiling/untiling

2019-02-21 Thread Boris Brezillon
cases. Signed-off-by: Boris Brezillon --- src/gallium/drivers/etnaviv/etnaviv_tiling.c | 85 --- src/gallium/drivers/etnaviv/etnaviv_tiling.h | 10 ++- .../drivers/etnaviv/etnaviv_transfer.c| 16 ++-- 3 files changed, 84 insertions(+), 27 deletions(-) diff --git a/src

[Mesa-dev] [RFC PATCH 0/2] etnaviv: use CPU-based tiling/untiling for small regions

2019-02-21 Thread Boris Brezillon
ou don't like it, feel free to propose other solution that would be worth investigating. Thanks, Boris [1]https://gitlab.collabora.com/bbrezillon/mesa/commits/etna-texture-atlas-18.2.4 [2]https://github.com/laanwj/mesa/commit/6d575b3094f17e29246be72dce8fbb6fe048db2c Boris Brezillon (2):

[Mesa-dev] [RFC PATCH 2/2] etnaviv: try to use CPU to tile/untile when the region is small enough

2019-02-21 Thread Boris Brezillon
o make things more readable. Signed-off-by: Boris Brezillon --- .../drivers/etnaviv/etnaviv_transfer.c| 67 +-- 1 file changed, 61 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_transfer.c b/src/gallium/drivers/etnaviv/etnaviv_transfer.c

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-22 Thread Boris Brezillon
Christian, Marek, On Wed, 30 Jan 2019 05:28:14 +0100 Marek Vasut wrote: > From: Christian Gmeiner > > A pipe_resource can be shared by all the pipe_context's hanging off the > same pipe_screen. We seem to be impacted by the problem you're fixing here, but, while this patch definitely make thi

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-22 Thread Boris Brezillon
On Thu, 21 Feb 2019 23:29:53 +0100 Boris Brezillon wrote: > Christian, Marek, > > On Wed, 30 Jan 2019 05:28:14 +0100 > Marek Vasut wrote: > > > From: Christian Gmeiner > > > > A pipe_resource can be shared by all the pipe_context's hanging off the >

Re: [Mesa-dev] [PATCH] etnaviv: blt: mark used src resource as read from

2019-02-22 Thread Boris Brezillon
On Fri, 22 Feb 2019 11:10:29 +0100 Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Boris Brezillon > --- > src/gallium/drivers/etnaviv/etnaviv_blt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/etnaviv/etna

Re: [Mesa-dev] etnaviv: rs: mark used src resource as read from

2019-02-22 Thread Boris Brezillon
On Fri, 22 Feb 2019 11:02:34 +0100 Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Boris Brezillon > --- > src/gallium/drivers/etnaviv/etnaviv_rs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.

[Mesa-dev] [PATCH] gallium/util: Fix off-by-one in box intersection

2019-02-25 Thread Boris Brezillon
by being one pixel less greedy. Signed-off-by: Daniel Stone Signed-off-by: Boris Brezillon --- src/gallium/auxiliary/util/u_box.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/util/u_box.h b/src/gallium/auxiliary/util/u_box.h in

Re: [Mesa-dev] [PATCH v6] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-25 Thread Boris Brezillon
> Signed-off-by: Christian Gmeiner > Signed-off-by: Marek Vasut > Signed-off-by: Boris Brezillon Reviewed-by: Boris Brezillon Tested-by: Boris Brezillon This being said, I'm still unsure all races are fixed with this patch (see the part about RS-based tiling in my repl

Re: [Mesa-dev] [PATCH] gallium/util: Fix off-by-one in box intersection

2019-02-28 Thread Boris Brezillon
Hello Gurchetan, On Wed, 27 Feb 2019 10:34:26 -0800 Gurchetan Singh wrote: > On Mon, Feb 25, 2019 at 12:35 AM Boris Brezillon > wrote: > > > > From: Daniel Stone > > > > pipe_boxes are x/y + width/height, rather than x0/y0 -> x1/y1. This > > means th

[Mesa-dev] [PATCH 2/3] broadcom/vc4: Add support for extended CL submission

2017-12-07 Thread Boris Brezillon
an extra chunk. Signed-off-by: Boris Brezillon --- src/gallium/drivers/vc4/vc4_job.c| 23 +-- src/gallium/drivers/vc4/vc4_screen.c | 2 ++ src/gallium/drivers/vc4/vc4_screen.h | 1 + 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/vc4

[Mesa-dev] [PATCH 1/3] drm-uapi: Update vc4 header with CL chunks and perfmon related definitions

2017-12-07 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- include/drm-uapi/vc4_drm.h | 156 ++--- 1 file changed, 146 insertions(+), 10 deletions(-) diff --git a/include/drm-uapi/vc4_drm.h b/include/drm-uapi/vc4_drm.h index 3415a4b71884..ca0220257f05 100644 --- a/include/drm

[Mesa-dev] [PATCH 3/3] broadcom/vc4: Add support for HW perfmon

2017-12-07 Thread Boris Brezillon
The V3D engine provides several perf counters. Implement ->get_driver_query_[group_]info() so that these counters are exposed through the GL_AMD_performance_monitor extension. Signed-off-by: Boris Brezillon --- src/gallium/drivers/vc4/vc4_context.h | 13 +++ src/gallium/drivers/vc4/vc4_jo

[Mesa-dev] [PATCH 0/3] broadcom/v4: Expose VC4 HW perf counters

2017-12-07 Thread Boris Brezillon
Hello, This series makes use of the VC4 perfmon ioctls to expose HW perf counters through the GL_AMD_performance_monitor interface. This patches depends on their kernel counterparts and should not be applied until the kernel patches have reached the drm tree. Regards, Boris Boris Brezillon (3

[Mesa-dev] [PATCH v2 1/2] drm-uapi: Update vc4 header with perfmon related definitions

2018-01-11 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- include/drm-uapi/vc4_drm.h | 67 ++ 1 file changed, 67 insertions(+) diff --git a/include/drm-uapi/vc4_drm.h b/include/drm-uapi/vc4_drm.h index 3415a4b71884..3686f451d779 100644 --- a/include/drm-uapi/vc4_drm.h +++ b

[Mesa-dev] [PATCH v2 2/2] broadcom/vc4: Add support for HW perfmon

2018-01-11 Thread Boris Brezillon
The V3D engine provides several perf counters. Implement ->get_driver_query_[group_]info() so that these counters are exposed through the GL_AMD_performance_monitor extension. Signed-off-by: Boris Brezillon --- Changes in v2 (all reported by Eric): - Add missing "TLB-quads-passing-z-and

[Mesa-dev] [PATCH v2 0/2] broadcom/v4: Expose VC4 HW perf counters

2018-01-11 Thread Boris Brezillon
: - Drop the extended CL stuff - Fix bugs reported by Eric (see changelog in patch 2) Boris Brezillon (2): drm-uapi: Update vc4 header with perfmon related definitions broadcom/vc4: Add support for HW perfmon include/drm-uapi/vc4_drm.h| 67 ++ src/gallium/drivers/vc4

Re: [Mesa-dev] [PATCH v2 2/2] broadcom/vc4: Add support for HW perfmon

2018-01-12 Thread Boris Brezillon
On Thu, 11 Jan 2018 16:42:45 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > The V3D engine provides several perf counters. > > Implement ->get_driver_query_[group_]info() so that these counters are > > exposed through the GL_AMD_performance_monitor exten

[Mesa-dev] [PATCH] vc4: Fix infinite retry in vc4_bo_alloc()

2017-09-26 Thread Boris Brezillon
s and explicitly reset its content in the retry path. Signed-off-by: Boris Brezillon --- src/gallium/drivers/vc4/vc4_bufmgr.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_bufmgr.c b/src/gallium/drivers/vc4/vc4_bufmgr.c index 12af7f8

[Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

2017-09-27 Thread Boris Brezillon
This patch makes use of the DRM_IOCTL_VC4_GEM_MADVISE ioctl to mark all BOs placed in the mesa BO cache as purgeable so that the system can reclaim this memory under memory pressure. Signed-off-by: Boris Brezillon --- Hello, Note that this series depends on kernel code that has not been

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

2017-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2017 14:50:10 +0100 Chris Wilson wrote: > Quoting Boris Brezillon (2017-09-27 14:45:17) > > static struct vc4_bo * > > vc4_bo_from_cache(struct vc4_screen *screen, uint32_t size, const char > > *name) > > { > > @@ -111,6 +121,11 @@ vc4_bo_fro

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

2017-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2017 15:24:16 +0100 Chris Wilson wrote: > Quoting Boris Brezillon (2017-09-27 15:06:53) > > On Wed, 27 Sep 2017 14:50:10 +0100 > > Chris Wilson wrote: > > > > > Quoting Boris Brezillon (2017-09-27 14:45:17) > > > > static struct

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

2017-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2017 10:15:23 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > On Wed, 27 Sep 2017 15:24:16 +0100 > > Chris Wilson wrote: > > > >> Quoting Boris Brezillon (2017-09-27 15:06:53) > >> > On Wed, 27 Sep 2

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

2017-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2017 12:41:52 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > On Wed, 27 Sep 2017 10:15:23 -0700 > > Eric Anholt wrote: > > > >> Boris Brezillon writes: > >> > >> > On Wed, 27 Sep 2017 15:24:16 +0100 > &

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

2017-09-27 Thread Boris Brezillon
On Wed, 27 Sep 2017 22:03:15 +0200 Boris Brezillon wrote: > On Wed, 27 Sep 2017 12:41:52 -0700 > Eric Anholt wrote: > > > Boris Brezillon writes: > > > > > On Wed, 27 Sep 2017 10:15:23 -0700 > > > Eric Anholt wrote: > > > > > >&

Re: [Mesa-dev] [PATCH] vc4: Mark BOs as purgeable when they enter the BO cache

2017-09-28 Thread Boris Brezillon
On Wed, 27 Sep 2017 16:33:23 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > On Wed, 27 Sep 2017 12:41:52 -0700 > > Eric Anholt wrote: > > > >> Boris Brezillon writes: > >> > >> > On Wed, 27 Sep 2017 10:15:23 -0700 > &g

[Mesa-dev] [PATCH v2] vc4: Mark BOs as purgeable when they enter the BO cache

2017-10-04 Thread Boris Brezillon
This patch makes use of the DRM_IOCTL_VC4_GEM_MADVISE ioctl to mark all BOs placed in the mesa BO cache as purgeable so that the system can reclaim this memory under memory pressure. Signed-off-by: Boris Brezillon --- Hello, Note that this series depends on kernel code that has not been

Re: [Mesa-dev] [PATCH v2] vc4: Mark BOs as purgeable when they enter the BO cache

2017-10-06 Thread Boris Brezillon
On Thu, 05 Oct 2017 11:25:46 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > This patch makes use of the DRM_IOCTL_VC4_GEM_MADVISE ioctl to mark all > > BOs placed in the mesa BO cache as purgeable so that the system can > > reclaim this memory under memory

[Mesa-dev] [PATCH v4 2/5] dri_interface: add DRI2_BufferDamage interface

2019-06-25 Thread Boris Brezillon
of context, rewritten description Signed-off-by: Boris Brezillon --- include/GL/internal/dri_interface.h | 43 + 1 file changed, 43 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index af0ee9c56670..ada78c5d53d6

[Mesa-dev] [PATCH v4 5/5] panfrost: Add support for KHR_partial_update()

2019-06-25 Thread Boris Brezillon
the left/right/top/bottom regions surrounding the biggest damage rect). We also do not try to reduce the number of draws by passing all quad vertices to the blit request (would require extending u_blitter) Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_blit.c | 14 ++---

[Mesa-dev] [PATCH v4 0/5] EGL_KHR_partial_update support

2019-06-25 Thread Boris Brezillon
ons on how to do it better are welcome. Regards, Boris [1]https://gitlab.freedesktop.org/mesa/mesa/merge_requests/227 [2]https://patchwork.freedesktop.org/series/45915/#rev2 [3]https://gitlab.freedesktop.org/wayland/weston/merge_requests/106 Boris Brezillon (1): panfrost: Add support for KHR_

[Mesa-dev] [PATCH v4 1/5] egl/android: Delete set_damage_region from egl dri vtbl

2019-06-25 Thread Boris Brezillon
platfrom_*.c files. Then upcomming patches add a new dri2 interface for the drivers to implement Signed-off-by: Harish Krupo Reviewed-by: Daniel Stone Signed-off-by: Boris Brezillon --- src/egl/drivers/dri2/egl_dri2.c | 3 +- src/egl/drivers/dri2/egl_dri2.h | 4 -- src

[Mesa-dev] [PATCH v4 3/5] egl/dri: Use __DRI2_DAMAGE extension for KHR_partial_update

2019-06-25 Thread Boris Brezillon
From: Harish Krupo Use the DRI2 interface callback to pass the damage rects to the driver. Signed-off-by: Harish Krupo Signed-off-by: Boris Brezillon --- src/egl/drivers/dri2/egl_dri2.c | 55 ++--- src/egl/drivers/dri2/egl_dri2.h | 1 + 2 files changed, 51

[Mesa-dev] [PATCH v4 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-06-25 Thread Boris Brezillon
Signed-off-by: Daniel Stone Signed-off-by: Boris Brezillon --- src/gallium/include/pipe/p_screen.h | 7 +++ src/gallium/state_trackers/dri/dri2.c | 22 ++ 2 files changed, 29 insertions(+) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_

Re: [Mesa-dev] [PATCH v4 2/5] dri_interface: add DRI2_BufferDamage interface

2019-06-25 Thread Boris Brezillon
On Tue, 25 Jun 2019 18:37:46 +0200 Boris Brezillon wrote: > From: Daniel Stone > > Add a new DRI2_BufferDamage interface to support the > EGL_KHR_partial_update extension, informing the driver of an overriding > scissor region for a particular drawable. > > Based o

[Mesa-dev] [PATCH] panfrost: Remove unneeded check in panfrost_scissor_culls_everything()

2019-06-26 Thread Boris Brezillon
The ss local var is guaranteed to be != NULL. Get rid of this useless check. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers

Re: [Mesa-dev] [PATCH v4 5/5] panfrost: Add support for KHR_partial_update()

2019-06-26 Thread Boris Brezillon
On Wed, 26 Jun 2019 10:51:23 -0700 Alyssa Rosenzweig wrote: > Overall, I'm quite happy with how this turns out; I was fearful it would > be a lot more complicated, though there's always time for that ;) Same here. I thought it would be more complicated than that, but it turned out to be pretty s

Re: [Mesa-dev] [PATCH v4 5/5] panfrost: Add support for KHR_partial_update()

2019-06-26 Thread Boris Brezillon
On Wed, 26 Jun 2019 12:19:28 -0700 Alyssa Rosenzweig wrote: > > > > +/* We set the damage extent to the full resource size but keep > > > > the > > > > + * damage box empty so that the FB content is reloaded by > > > > default. > > > > + */ > > > > > > English,

Re: [Mesa-dev] [PATCH v4 5/5] panfrost: Add support for KHR_partial_update()

2019-06-26 Thread Boris Brezillon
On Wed, 26 Jun 2019 14:03:45 -0700 Alyssa Rosenzweig wrote: > > The symptom is, black areas around the damage rect when the rendering > > area (the area you define in mali_payload_fragment) is not > > 32x32-aligned. If you want to test it, remove the "* 2" in the code and > > run weston+desktop-s

Re: [Mesa-dev] [PATCH v4 3/5] egl/dri: Use __DRI2_DAMAGE extension for KHR_partial_update

2019-06-27 Thread Boris Brezillon
On Thu, 27 Jun 2019 13:29:38 +0530 Harish Krupo wrote: > Hi Boris, > > Thank you for resurrecting this series and taking it further. Just one > nitpick. > The commit summary should read: > "egl/dri: Use __DRI_BUFFER_DAMAGE extension for KHR_partial_update" > > While you are at it, could you ple

[Mesa-dev] [PATCH] panfrost: Add the sampled texture BO to the job

2019-07-01 Thread Boris Brezillon
Otherwise we get random use-after-{free,unmap} errors. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c index bf98d3853f16

Re: [Mesa-dev] [PATCH] panfrost: Add the sampled texture BO to the job

2019-07-01 Thread Boris Brezillon
On Mon, 1 Jul 2019 08:28:03 -0700 Alyssa Rosenzweig wrote: > > > > @@ -848,6 +850,7 @@ panfrost_upload_tex( > > for (unsigned l = first_level; l <= last_level; ++l) { > > for (unsigned f = first_layer; f <= last_layer; ++f) { > > > > +panfrost

[Mesa-dev] [PATCH v2] panfrost: Add the sampled texture BO to the job

2019-07-01 Thread Boris Brezillon
Otherwise we get random use-after-{free,unmap} errors. Signed-off-by: Boris Brezillon --- Changes in v2: - Move the panfrost_job_add_bo() call out of the loop --- src/gallium/drivers/panfrost/pan_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/panfrost

[Mesa-dev] [PATCH 03/10] panfrost: Get rid of the "free imported BO" logic

2019-07-02 Thread Boris Brezillon
gned-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c | 18 -- src/gallium/drivers/panfrost/pan_resource.c | 19 +++ src/gallium/drivers/panfrost/pan_resource.h | 3 --- src/gallium/drivers/panfrost/pan_screen.h | 3 --- 4 files changed, 7

[Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

2019-07-02 Thread Boris Brezillon
There's no point duplicating the code, and it will help us simplify the bo_handles[] filling logic in panfrost_drm_submit_job(). Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_allocate.c | 21 +++--- src/gallium/drivers/panfrost/pan_allocate.h | 22 -- src/ga

[Mesa-dev] [PATCH 07/10] panfrost: Move the mmap BO logic out of panfrost_drm_import_bo()

2019-07-02 Thread Boris Brezillon
So we can re-use it for the panfrost_drm_create_bo() function we are about to introduce. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c | 51 +++--- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/panfrost

[Mesa-dev] [PATCH 00/10] panfrost: Try to make BO handling more consistent

2019-07-02 Thread Boris Brezillon
be ready before being scheduled. I know there's a lot going on in the panfrost area right now, and some of what I'm proposing here might be irrelevant or might have to be ported on top of other changes (which is fine). Let me know if that's the case. Regards, Boris Boris Brezillo

[Mesa-dev] [PATCH 02/10] panfrost: Get rid of the panfrost_driver abstraction leftovers

2019-07-02 Thread Boris Brezillon
Commit 5f81669d880b ("panfrost: Remove the panfrost_driver abstraction") left a few things behind, remove them now. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c| 1 - src/gallium/drivers/panfrost/pan_drm.h| 32 --- src/galli

[Mesa-dev] [PATCH 01/10] panfrost: Move scanout res creation out of panfrost_resource_create()

2019-07-02 Thread Boris Brezillon
Which improves readability and help us avoid a memory leak. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_resource.c | 79 - 1 file changed, 44 insertions(+), 35 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_resource.c b/src/gallium

[Mesa-dev] [PATCH 05/10] panfrost: Move BO meta-data out of panfrost_bo

2019-07-02 Thread Boris Brezillon
cation and make BO allocation more consistent. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c | 12 +- src/gallium/drivers/panfrost/pan_fragment.c | 2 +- src/gallium/drivers/panfrost/pan_mfbd.c | 24 ++-- src/gallium/drivers/panfrost/pan_resour

[Mesa-dev] [PATCH 10/10] panfrost: Pass referenced BOs to the SUBMIT ioctls

2019-07-02 Thread Boris Brezillon
scheduler wait on referenced BO fences if needed. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c | 46 +++--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c

[Mesa-dev] [PATCH 06/10] panfrost: Avoid passing winsys handles to import/export BO funcs

2019-07-02 Thread Boris Brezillon
file. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c | 17 +++-- src/gallium/drivers/panfrost/pan_resource.c | 16 +++- src/gallium/drivers/panfrost/pan_screen.h | 6 ++ 3 files changed, 20 insertions(+), 19 deletions(-) diff --git

[Mesa-dev] [PATCH 08/10] panfrost: Add the panfrost_drm_{create, release}_bo() helpers

2019-07-02 Thread Boris Brezillon
To avoid the panfrost_memory <-> panfrost_bo dance done in panfrost_resource_create_bo() and panfrost_bo_unreference(). Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c | 62 + src/gallium/drivers/panfrost/pan_resource.c | 32 +-

[Mesa-dev] [PATCH 04/10] panfrost: Stop exposing internal panfrost_drm_*() functions

2019-07-02 Thread Boris Brezillon
panfrost_drm_submit_job() and panfrost_fence_create() are not used outside of pan_drm.c. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_drm.c| 4 ++-- src/gallium/drivers/panfrost/pan_screen.h | 5 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src

[Mesa-dev] [PATCH v5 3/5] egl/dri: Use __DRI2_BUFFER_DAMAGE extension for KHR_partial_update

2019-07-02 Thread Boris Brezillon
From: Harish Krupo Use the DRI2 interface callback to pass the damage rects to the driver. Signed-off-by: Harish Krupo Signed-off-by: Boris Brezillon Acked-by: Alyssa Rosenzweig --- Changes in v5: * Add Alyssa's a-b * Update Arish email address * s/__DRI2_DAMAGE/__DRI2_BUFFER_D

[Mesa-dev] [PATCH v5 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-02 Thread Boris Brezillon
Signed-off-by: Daniel Stone Signed-off-by: Boris Brezillon Reviewed-by: Alyssa Rosenzweig --- Changes in v5: * Add Alyssa's R-b --- src/gallium/include/pipe/p_screen.h | 7 +++ src/gallium/state_trackers/dri/dri2.c | 22 ++ 2 files changed, 29 insertions(+) dif

[Mesa-dev] [PATCH v5 2/5] dri_interface: add DRI2_BufferDamage interface

2019-07-02 Thread Boris Brezillon
of context, rewritten description Signed-off-by: Daniel Stone Signed-off-by: Boris Brezillon Acked-by: Alyssa Rosenzweig --- Changes in v5: * Add Alyssa's a-b * Add Daniel's SoB --- include/GL/internal/dri_interface.h | 43 + 1 file changed, 43 insertion

[Mesa-dev] [PATCH v5 1/5] egl/android: Delete set_damage_region from egl dri vtbl

2019-07-02 Thread Boris Brezillon
platfrom_*.c files. Then upcomming patches add a new dri2 interface for the drivers to implement Signed-off-by: Harish Krupo Reviewed-by: Daniel Stone Signed-off-by: Boris Brezillon Acked-by: Alyssa Rosenzweig --- Changes in v5: * Add Alyssa's a-b --- src/egl/drivers/dri2/egl_d

[Mesa-dev] [PATCH v5 0/5] EGL_KHR_partial_update support

2019-07-02 Thread Boris Brezillon
his v5 (collecting the R-b/A-b tags + addressing Alyssa's comments on patch 5). Regards, Boris [1]https://gitlab.freedesktop.org/mesa/mesa/merge_requests/227 [2]https://patchwork.freedesktop.org/series/45915/#rev2 [3]https://gitlab.freedesktop.org/wayland/weston/merge_requests/106 Boris Bre

[Mesa-dev] [PATCH v5 5/5] panfrost: Add support for KHR_partial_update()

2019-07-02 Thread Boris Brezillon
the left/right/top/bottom regions surrounding the biggest damage rect). We also do not try to reduce the number of draws by passing all quad vertices to the blit request (would require extending u_blitter) Signed-off-by: Boris Brezillon --- Changes in v5: - rename the second panfrost_blit_wallpa

Re: [Mesa-dev] [PATCH v5 1/5] egl/android: Delete set_damage_region from egl dri vtbl

2019-07-02 Thread Boris Brezillon
On Tue, 2 Jul 2019 15:49:58 +0200 Boris Brezillon wrote: > From: Harish Krupo Crap, forgot to update your email address here > > The intension of the KHR_partial_update was not to send the damage back > to the platform but to send the damage to the driver to ensure that the

Re: [Mesa-dev] [PATCH 06/10] panfrost: Avoid passing winsys handles to import/export BO funcs

2019-07-02 Thread Boris Brezillon
ced to memcpy() into a BO we create if given a user > pointer rather than a resource), but maybe not actually because of sync > requirements. > > On Tue, Jul 02, 2019 at 03:23:49PM +0200, Boris Brezillon wrote: > > Let's keep a clear split between ioctl wrappers and the rest of t

Re: [Mesa-dev] [PATCH 05/10] panfrost: Move BO meta-data out of panfrost_bo

2019-07-02 Thread Boris Brezillon
On Tue, 2 Jul 2019 06:53:56 -0700 Alyssa Rosenzweig wrote: > Oh, not controversial at all, I'm quite happy with this! > Just a question -- I remember some panfrost_resources didn't have a bo > but had a winsys thingy instead. How does that interact? Didn't notice any specific test for the !rsrc-

Re: [Mesa-dev] [PATCH 09/10] panfrost: Make SLAB pool creation rely on BO helpers

2019-07-02 Thread Boris Brezillon
On Tue, 2 Jul 2019 16:54:22 +0200 Tomeu Vizoso wrote: > On Tue, 2 Jul 2019 at 15:24, Boris Brezillon > wrote: > > > > There's no point duplicating the code, and it will help us simplify > > the bo_handles[] filling logic in panfrost_drm_submit_job(). >

Re: [Mesa-dev] [PATCH v5 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-02 Thread Boris Brezillon
On Tue, 2 Jul 2019 13:21:31 -0400 Marek Olšák wrote: > On Tue., Jul. 2, 2019, 09:50 Boris Brezillon, > wrote: > > > From: Daniel Stone > > > > Add a pipe_screen->set_damage_region() hook to propagate > > set-damage-region requests to the driver, it's

Re: [Mesa-dev] [PATCH v4 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-03 Thread Boris Brezillon
; > On Tue, Jun 25, 2019 at 06:37:48PM +0200, Boris Brezillon wrote: > > > From: Daniel Stone > > > > > > Add a pipe_screen->set_damage_region() hook to propagate > > > set-damage-region requests to the driver, it's then up to the > > >

[Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-03 Thread Boris Brezillon
/commit/drivers/gpu/drm/panfrost?id=583bbf46133c726bae277e8f4e32bfba2a528c7f Signed-off-by: Boris Brezillon Cc: Cc: Cc: Steven Price Cc: Rob Herring --- Cc-ing dri-devel is not a mistake, I really to have feedback from the DRM maintainers, since this started with a kernel-side change. --- src/etnaviv/drm/et

Re: [Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-03 Thread Boris Brezillon
On Wed, 3 Jul 2019 07:45:32 -0600 Rob Herring wrote: > On Wed, Jul 3, 2019 at 7:34 AM Boris Brezillon > wrote: > > > > Exported BOs might be imported back, then mmap()-ed to be written > > too. Most drivers handle that by mmap()-ing the GEM handle after it's > &g

Re: [Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-03 Thread Boris Brezillon
On Wed, 3 Jul 2019 15:13:25 +0100 Steven Price wrote: > On 03/07/2019 14:56, Boris Brezillon wrote: > > On Wed, 3 Jul 2019 07:45:32 -0600 > > Rob Herring wrote: > > > >> On Wed, Jul 3, 2019 at 7:34 AM Boris Brezillon > >> wrote: > >>> &

Re: [Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-03 Thread Boris Brezillon
On Wed, 3 Jul 2019 15:50:08 +0100 Steven Price wrote: > On 03/07/2019 15:33, Boris Brezillon wrote: > > On Wed, 3 Jul 2019 15:13:25 +0100 > > Steven Price wrote: > > > >> On 03/07/2019 14:56, Boris Brezillon wrote: > >>> On Wed, 3 Jul 20

Re: [Mesa-dev] [PATCH] panfrost: Take into account off-screen FBOs

2019-07-04 Thread Boris Brezillon
On Thu, 4 Jul 2019 10:02:54 +0200 Tomeu Vizoso wrote: > In that case, ctx->pipe_framebuffer.cbufs[0] can be NULL. > > Signed-off-by: Tomeu Vizoso > Cc: Boris Brezillon Reviewed-by: Boris Brezillon > Fixes: 5375d009be18 ("panfrost: Pass referenced BOs to the SUBMI

Re: [Mesa-dev] [PATCH 1/3] panfrost: Cache BO imports

2019-07-04 Thread Boris Brezillon
Hi Tomeu, On Thu, 4 Jul 2019 10:04:41 +0200 Tomeu Vizoso wrote: > If two jobs use the same GEM object at the same time, the job that > finishes first will (previous to this commit) close the GEM object, even > if there's a job still referencing it. > > To prevent this, have all jobs use the sa

Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-04 Thread Boris Brezillon
On Thu, 4 Jul 2019 10:04:42 +0200 Tomeu Vizoso wrote: > @@ -382,11 +362,14 @@ panfrost_resource_create_bo(struct panfrost_screen > *screen, struct panfrost_reso > > /* Tiling textures is almost always faster, unless we only use it > once */ > > +#define SCANOUT (PIPE_BIND_SCANOUT

[Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-04 Thread Boris Brezillon
Hello, Alyssa recently proposed that I push my own panfrost-related submissions once they received proper review and are considered ready to merged (meaning that received enough A-b/R-b tags). In order to do that, I'd need to obtain write permissions on the git repo. Note that I already have an a

Re: [Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-04 Thread Boris Brezillon
On Thu, 04 Jul 2019 20:49:32 -0700 Kenneth Graunke wrote: > On Thursday, July 4, 2019 5:23:44 AM PDT Boris Brezillon wrote: > > Hello, > > > > Alyssa recently proposed that I push my own panfrost-related > > submissions once they received proper review and are con

Re: [Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-05 Thread Boris Brezillon
On Fri, 05 Jul 2019 13:43:20 -0700 Kenneth Graunke wrote: > On Thursday, July 4, 2019 10:42:49 PM PDT Boris Brezillon wrote: > > On Thu, 04 Jul 2019 20:49:32 -0700 > > Kenneth Graunke wrote: > > > > > On Thursday, July 4, 2019 5:23:44 AM PDT Boris Br

Re: [Mesa-dev] [PATCH v5 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-15 Thread Boris Brezillon
Hello Marek, On Tue, 2 Jul 2019 20:09:23 +0200 Boris Brezillon wrote: > On Tue, 2 Jul 2019 13:21:31 -0400 > Marek Olšák wrote: > > > On Tue., Jul. 2, 2019, 09:50 Boris Brezillon, > > wrote: > > > > > From: Daniel Stone > > > > > > Ad

[Mesa-dev] [PATCH v6 3/5] egl/dri: Use __DRI2_BUFFER_DAMAGE extension for KHR_partial_update

2019-07-15 Thread Boris Brezillon
From: Harish Krupo Use the DRI2 interface callback to pass the damage rects to the driver. Signed-off-by: Harish Krupo Signed-off-by: Boris Brezillon Acked-by: Alyssa Rosenzweig Reviewed-by: Qiang Yu Tested-by: Qiang Yu --- Changes in v6: * None Changes in v5: * Add Alyssa's a-b * U

[Mesa-dev] [PATCH v6 0/5] EGL_KHR_partial_update support

2019-07-15 Thread Boris Brezillon
Marek concerns regarding the doc and the prototype of the gallium ->set_damage_region() hook. Regards, Boris [1]https://gitlab.freedesktop.org/mesa/mesa/merge_requests/227 [2]https://patchwork.freedesktop.org/series/45915/#rev2 Boris Brezillon (1): panfrost: Add support for KHR_parti

[Mesa-dev] [PATCH v6 5/5] panfrost: Add support for KHR_partial_update()

2019-07-15 Thread Boris Brezillon
the left/right/top/bottom regions surrounding the biggest damage rect). We also do not try to reduce the number of draws by passing all quad vertices to the blit request (would require extending u_blitter) Signed-off-by: Boris Brezillon Reviewed-by: Alyssa Rosenzweig --- Changes in v6: * Add Alyss

[Mesa-dev] [PATCH v6 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-15 Thread Boris Brezillon
Signed-off-by: Daniel Stone Signed-off-by: Boris Brezillon Reviewed-by: Alyssa Rosenzweig --- Hello Qiang, I intentionally dropped your R-b/T-b on this patch since the ->set_damage_region() prototype has changed. Feel free to add it back. Regards, Boris Changes in v6: * Pass pipe_box obje

[Mesa-dev] [PATCH v6 2/5] dri_interface: add DRI2_BufferDamage interface

2019-07-15 Thread Boris Brezillon
of context, rewritten description Signed-off-by: Daniel Stone Signed-off-by: Boris Brezillon Acked-by: Alyssa Rosenzweig Reviewed-by: Qiang Yu Tested-by: Qiang Yu --- Changes in v6: * Fix the doc Changes in v5: * Add Alyssa's a-b * Add Daniel's SoB --- include/GL/internal/dri_i

[Mesa-dev] [PATCH v6 1/5] egl/android: Delete set_damage_region from egl dri vtbl

2019-07-15 Thread Boris Brezillon
platfrom_*.c files. Then upcomming patches add a new dri2 interface for the drivers to implement Signed-off-by: Harish Krupo Reviewed-by: Daniel Stone Signed-off-by: Boris Brezillon Acked-by: Alyssa Rosenzweig Reviewed-by: Qiang Yu Tested-by: Qiang Yu --- Changes in v6: * Fix Harish's

Re: [Mesa-dev] [PATCH v5 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-15 Thread Boris Brezillon
On Mon, 15 Jul 2019 09:23:43 +0200 Boris Brezillon wrote: > Hello Marek, > > On Tue, 2 Jul 2019 20:09:23 +0200 > Boris Brezillon wrote: > > > On Tue, 2 Jul 2019 13:21:31 -0400 > > Marek Olšák wrote: > > > > > On Tue., Jul. 2,

Re: [Mesa-dev] [PATCH v6 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-07-22 Thread Boris Brezillon
Hi Qiang, On Sun, 21 Jul 2019 17:02:54 +0800 Qiang Yu wrote: > On Mon, Jul 15, 2019 at 8:50 PM Boris Brezillon > wrote: > > > > From: Daniel Stone > > > > Add a pipe_screen->set_damage_region() hook to propagate > > set-damage-region requests to th

Re: [Mesa-dev] [PATCH v6 4/5] st/dri2: Implement DRI2bufferDamageExtension

2019-08-01 Thread Boris Brezillon
+Marek (looks like I forgot to Cc you on this v6 :-/). On Mon, 22 Jul 2019 09:49:31 +0200 Boris Brezillon wrote: > Hi Qiang, > > On Sun, 21 Jul 2019 17:02:54 +0800 > Qiang Yu wrote: > > > On Mon, Jul 15, 2019 at 8:50 PM Boris Brezillon > > wrote: >

[Mesa-dev] [PATCH 0/9] panfrost: Allocate the polygon lists on-demand

2019-08-02 Thread Boris Brezillon
are needed to get patch 9 working (patch 2, 3, 4, 5, 6 and 8), others are just things I decided to get rid off along the way (patches 1 and 7). Regards, Boris Alyssa Rosenzweig (1): panfrost: Allocate polygon lists on-demand Boris Brezillon (8): panfrost: Get rid of ctx->job panfrost: Rem

[Mesa-dev] [PATCH 2/9] panfrost: Remove job from ctx->jobs at submission time

2019-08-02 Thread Boris Brezillon
This guarantees that new draws targetting the same framebuffer will get a new job instance. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_job.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers

[Mesa-dev] [PATCH 9/9] panfrost: Allocate polygon lists on-demand

2019-08-02 Thread Boris Brezillon
Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c| 8 ++- src/gallium/drivers/panfrost/pan_context.h| 1 - src/gallium/drivers/panfrost/pan_drm.c| 2 +- src/gallium/drivers/panfrost/pan_job.c| 24 +++ src/gallium/drivers/pan

[Mesa-dev] [PATCH 5/9] panfrost: Bail out early when doing a wallpaper blit

2019-08-02 Thread Boris Brezillon
py the new state into ctx->pipe_framebuffer and exit the function. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/dri

[Mesa-dev] [PATCH 3/9] panfrost: Delay FB descriptor allocation

2019-08-02 Thread Boris Brezillon
No need to emit SFBD/MFBD at frame invalidation. They can be emitted when the framebuffer is attached, which saves us a potential FB desc re-allocation if a new FB is bound after the swap. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c | 21

[Mesa-dev] [PATCH 7/9] panfrost: Get rid of the skippable param in attach_vt_framebuffer()

2019-08-02 Thread Boris Brezillon
The only user of this function always passes true. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c

[Mesa-dev] [PATCH 6/9] panfrost: Don't emit a new FB desc when setting a new FB state

2019-08-02 Thread Boris Brezillon
The FB desc will be emitted/attached on the first draw targetting this new FB. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers

  1   2   3   4   >