[Mesa-dev] [PATCH 7/7] st/nine: Protect dtors with mutex

2017-01-06 Thread Axel Davy
cause hang, since nine_csmt_process is not threadsafe. Fixes Hitman hang, and possibly others. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.c | 26 +++ src/gallium/state_trackers/nine/iunknown.h | 3 ++ src/gallium/state_trackers/nine/nine_lock.c

[Mesa-dev] [PATCH 3/7] st/nine: Rework CreatePipeSurface

2017-01-06 Thread Axel Davy
Create both surfaces in one call. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 49 ++ src/gallium/state_trackers/nine/surface9.h | 3 -- 2 files changed, 30 insertions(+), 22 deletions(-) diff --git a/src/gallium/state_trackers/nine

[Mesa-dev] [PATCH 4/7] st/nine: Flush pending commands if needed for surface9 changes

2017-01-06 Thread Axel Davy
nine_context uses NineSurface9 fields, thus we need to flush pending commands using the surface before changing the fields. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 28 src/gallium/state_trackers/nine/surface9.h | 17

[Mesa-dev] [PATCH 5/7] st/nine: Process pending commands on Reset

2017-01-06 Thread Axel Davy
Some nine_state_* and nine_context_* functions used for Reset() require all pending commands are flushed. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 1 + src/gallium/state_trackers/nine/device9ex.c | 1 + src/gallium/state_trackers/nine/nine_state.c | 3 +++ 3

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-07 Thread Axel Davy
I find ~/.drirc useful. You can add hacks missing in system drirc, or use device_id to set the card to use for the given game for dual gpu systems. Nine also has some drirc settings that are not hacks, but user options. I think it's driconf that should be fixed. It shouldn't copy the system

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-07 Thread Axel Davy
Expecting the user to use env vars it ok for power users, but not very user-friendly for newbies, or just people who don't like using the command line. And that's exactly these users who are likely to use something like driconf. Axel On 07/01/2017 14:23, Kai Wasserbäch wrote: Hey Marek, mayb

Re: [Mesa-dev] [PATCH] dri: don't load .drirc from $HOME

2017-01-07 Thread Axel Davy
after clicking on "Detect Future Running Apps" and before clicking again on "Stop"), and change device_id to affect on which card to run in the future. On 07/01/2017 14:01, Axel Davy wrote: I find ~/.drirc useful. You can add hacks missing in system drirc, or use device_id to

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Axel Davy
ported by all the desktop GPUs". Preventing NaN from being generated is not sufficient to fix the 0*inf = 0 issue. For example radeonsi does convert all NaN to zeros via a hardware setting. But 0*inf = 0 behaviour should be also in mad, and with the NaN to zero conversion, you get 0 * inf +

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Axel Davy
On 12/01/2017 23:09, Matteo Bruni wrote: 2017-01-12 22:54 GMT+01:00 Axel Davy : Preventing NaN from being generated is not sufficient to fix the 0*inf = 0 issue. For example radeonsi does convert all NaN to zeros via a hardware setting. But 0*inf = 0 behaviour should be also in mad, and with

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-13 Thread Axel Davy
On 13/01/2017 19:50, Matteo Bruni wrote: 2017-01-13 3:37 GMT+01:00 Ilia Mirkin : On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand wrote: Unless, of course, it's controlled by the same hardware bit... Clearly, we can can give you abs on rsq without denorm flushing (easy shader hacks) but not the

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-14 Thread Axel Davy
On 13/01/2017 19:06, Nicolai Hähnle wrote: On 13.01.2017 18:53, Jason Ekstrand wrote: On Fri, Jan 13, 2017 at 8:43 AM, Marek Olšák mailto:mar...@gmail.com>> wrote: On Fri, Jan 13, 2017 at 5:25 PM, Jason Ekstrand mailto:ja...@jlekstrand.net>> wrote: > On Fri, Jan 13, 2017 at 4:05 AM,

Re: [Mesa-dev] [PATCH] nv50, nvc0: disable depth offsets when there is no depth buffer

2017-01-15 Thread Axel Davy
Shouldn't this be fixed in wine, rather than in the driver ? Yours, Axel On 15/01/2017 21:57, Ilia Mirkin wrote: While I can find no support for this in the GL spec, this is apparently what D3D9 wants. Also appears to fix a very long-standing bug in Tomb Raider: Underworld and Deus Ex: Human

Re: [Mesa-dev] [PATCH v2 3/5] st/nine: set the MUL_ZERO_WINS flag when supported

2017-01-20 Thread Axel Davy
With this patch, there is one case where we hit the "undefined case" of the spec (mismatch between different shaders): With streamout we use a dummy pixel created by utils instead of nine_shader. As we use software renderers for the feature doing the streamout, I guess that's ok for now. Tha

Re: [Mesa-dev] [PATCH 1/2] r600g: use ieee variants of multiplication instructions

2017-01-24 Thread Axel Davy
ailman/listinfo/mesa-dev Bad apps that depend on the behaviour could be listed in drirc with a workaround to force them use the gl extension associated with the feature. Yours, Axel Davy ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

[Mesa-dev] [PATCH] st/nine: Fix support for ps 1.4 dw and dz modifiers

2017-03-26 Thread Axel Davy
RCP was used incorrectly to support NINED3DSPSM_DW and NINED3DSPSM_DZ. src.x as used as input instead of src.w or src.z. Fixes: https://github.com/iXit/Mesa-3D/issues/271 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Mesa-dev] [PATCH] st/nine: Fix support for ps 1.4 dw and dz modifiers

2017-03-28 Thread Axel Davy
This probably should be CC Mesa 17 stable. I'll add it before push. On 26/03/2017 23:00, Axel Davy wrote: RCP was used incorrectly to support NINED3DSPSM_DW and NINED3DSPSM_DZ. src.x as used as input instead of src.w or src.z. Fixes: https://github.com/iXit/Mesa-3D/issues/271 Signed-o

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

2018-05-01 Thread Axel Davy
PIPE_RESOURCE_FLAG_x */ /** * For planar images, ie. YUV EGLImage external, etc, pointer to the * next plane. */ struct pipe_resource *next; + struct pipe_screen *screen; /**< screen that this texture belongs to */ Out of curiosity, why moving this field ? Yours,

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

2018-05-16 Thread Axel Davy
Hi, Shouldn't this be fixed on the xserver or the ddx side, rather than in Mesa ? Yours, Axel Davy On 16/05/2018 11:10, Michel Dänzer wrote: From: Michel Dänzer Prevents spuriously bumping the upper 32 bits of the SBC, which results in hangs with the modesetting driver from xserver

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Axel Davy
mples used for coverage and enable EQAA/CSAA (in fact there is a similar way to advertise the feature for Nvidia and Amd). But maybe I misunderstood. Yours, Axel Davy On 18/05/2018 06:05, Marek Olšák wrote: From: Marek Olšák The interface only uses general MSAA terms, so it's "adv

Re: [Mesa-dev] [PATCH 00/13] Implement INTEL_shader_atomic_float_minmax

2018-08-21 Thread Axel Davy
/documentation/intel-gfx-prm-osrc-bdw-vol07-3d_media_gpgpu_3.pdf But there is no mention of it for Skylake. Maybe it was supported, but dropped ? Yours, Axel Davy ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/2] st/nine: do not double-close the fd on teardown

2018-08-29 Thread Axel Davy
Hi Emil, This patch and the nine part of the second patch look fine. Reviewed-by: Axel Davy for them. Yours, Axel On 29/08/2018 19:13, Emil Velikov wrote: From: Emil Velikov As the newly introduced comment says: The pipe loader takes ownership of the fd Thus, there's no need to

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Axel Davy
cally the pinned cores if load would be better shared among cores. Yours, Axel Davy On 9/6/18 6:02 AM, Marek Olšák wrote: Hi, When the Ryzen CPUs were launched, they didn't perform very well in games, and it took a while before games were patched. Guess what, Mesa drivers have suffered fro

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Axel Davy
ds to cores. It pins threads to one L3, which can have 4 or 8 cores. Marek On Thu, Sep 6, 2018 at 5:22 AM, Axel Davy wrote: Hi Marek, Shouldn't this core pinning be handled by the kernel ? Else all multithreaded games (or applications) need an update. I also see a risk in applications

[Mesa-dev] [PATCH 3/5] st/nine: Add parameter to start with bind

2018-09-09 Thread Axel Davy
Add a parameter to start new object with a bind instead of a refcount. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.c | 18 +++--- src/gallium/state_trackers/nine/iunknown.h | 1 + src/gallium/state_trackers/nine/nine_helpers.h | 2 ++ 3 files

[Mesa-dev] [PATCH 2/5] st/nine: Use perspective correction for ps depth fog

2018-09-09 Thread Axel Davy
b.com/iXit/Mesa-3D/issues/315 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_shader.c b/src/gallium/state_trackers/nine/nine_shader.c index

[Mesa-dev] [PATCH 4/5] st/nine: Add new helper for object creation with bind

2018-09-09 Thread Axel Davy
Add a new helper to create objects starting with a bind count instead of a ref count. Signed-off-by: Axel Davy --- .../state_trackers/nine/nine_helpers.h| 26 +++ 1 file changed, 26 insertions(+) diff --git a/src/gallium/state_trackers/nine/nine_helpers.h b/src/gallium

[Mesa-dev] [PATCH 5/5] st/nine: Avoid RefToBind calls in ff

2018-09-09 Thread Axel Davy
avoided by creating the shaders with a bind count directly. Fixes: https://github.com/iXit/Mesa-3D/issues/295 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 2 -- src/gallium/state_trackers/nine/pixelshader9.c | 6 +- src/gallium/state_trackers/nine

[Mesa-dev] [PATCH 1/5] st/nine: Clamp RCP when 0*inf!=0

2018-09-09 Thread Axel Davy
r versions where NV or AMD don't clamp. LOG and RSQ being already clamped, this patch only clamps RCP. Fixes: https://github.com/iXit/Mesa-3D/issues/316 Signed-off-by: Axel Davy CC: --- src/gallium/state_trackers/nine/nine_shader.c | 14 +- 1 file changed, 13 insertions

Re: [Mesa-dev] [PATCH 1/5] st/nine: Clamp RCP when 0*inf!=0

2018-09-09 Thread Axel Davy
On 9/9/18 9:35 PM, Ilia Mirkin wrote: On Sun, Sep 9, 2018 at 3:19 PM, Axel Davy wrote: For now clamp for all drivers. An ulterior optimization would be to avoid clamping for drivers with MUL_ZERO_WINS for the specific shader versions where NV or AMD don't clamp. Too bad. The whole poi

Re: [Mesa-dev] [PATCH 1/5] st/nine: Clamp RCP when 0*inf!=0

2018-09-09 Thread Axel Davy
On 9/9/18 9:40 PM, Ilia Mirkin wrote: On Sun, Sep 9, 2018 at 3:19 PM, Axel Davy wrote: Tests showed Intel on windows does always clamp RCP, RSQ and LOG (thus preventing inf/nan generation), for all shader versions (some vendor behaviours vary with shader versions). By the way, this happens

Re: [Mesa-dev] [PATCH 1/5] st/nine: Clamp RCP when 0*inf!=0

2018-09-11 Thread Axel Davy
On 9/11/18 11:28 PM, Roland Scheidegger wrote: Am 09.09.2018 um 21:19 schrieb Axel Davy: Tests done on several devices of all 3 vendors and of different generations showed that there are several ways of handling infs and NaN for d3d9. Tests showed Intel on windows does always clamp RCP, RSQ

Re: [Mesa-dev] [PATCH 1/5] st/nine: Clamp RCP when 0*inf!=0

2018-09-11 Thread Axel Davy
On 9/12/18 8:17 AM, Axel Davy wrote: The goal is to catch inf and -inf and replace them by FLT_MAX and -FLT_MAX. Without, the NaN would appear when doing mul or mad. Axel I small precision I want to add: This is not the only place clamping makes a difference. Indeed else MUL_ZERO_WINS

Re: [Mesa-dev] [PATCH 1/5] st/nine: Clamp RCP when 0*inf!=0

2018-09-12 Thread Axel Davy
On 9/9/18 9:40 PM, Ilia Mirkin wrote: On Sun, Sep 9, 2018 at 3:19 PM, Axel Davy wrote: Tests showed Intel on windows does always clamp RCP, RSQ and LOG (thus preventing inf/nan generation), for all shader versions (some vendor behaviours vary with shader versions). By the way, this happens

Re: [Mesa-dev] [PATCH 1/5] st/nine: Clamp RCP when 0*inf!=0

2018-09-12 Thread Axel Davy
On 9/12/18 11:44 PM, Roland Scheidegger wrote: Am 12.09.2018 um 23:43 schrieb Roland Scheidegger: I small precision I want to add: This is not the only place clamping makes a difference. Indeed else MUL_ZERO_WINS would be safe to use and remove all the clamping. The rasterizers can produce N

[Mesa-dev] [PATCH 05/22] st/nine: Fix aliased read in ff

2018-09-23 Thread Axel Davy
Fix aliasing of colorarg_b4 with colorarg_b5. Fixes: https://github.com/iXit/Mesa-3D/issues/302 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src

[Mesa-dev] [PATCH 03/22] st/nine: Clarify some ff assignments

2018-09-23 Thread Axel Davy
colorarg0, etc are 3 bits wide. Make the code more readable by adding an & 0x7 to further indicate we only remember the first 3 bits only. The 4th bit is always 0, and colorarg_b4, colorarg_b5, etc are used to store the 5th and 6th bits. Signed-off-by: Axel Davy --- src/gallium/state_trac

[Mesa-dev] [PATCH 07/22] st/nine: Remove clamping when mul_zero_wins

2018-09-23 Thread Axel Davy
Tests show the clamping can be removed when mul_zero_wins is supported. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c | 55 --- 1 file changed, 47 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_shader.c b/src

[Mesa-dev] [PATCH 04/22] st/nine: Fix ff assignment with aliasing

2018-09-23 Thread Axel Davy
"tex_stage[s][D3DTSS_COLORARG0] >> 4" could be a two bit number, thus colorarg_b4 was incorrectly set. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/sta

[Mesa-dev] [PATCH 02/22] st/nine: Print transform matrices in debug

2018-09-23 Thread Axel Davy
This is useful to see the matrices content in the log to debug. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index

[Mesa-dev] [PATCH 06/22] st/nine: Implement predicated instructions

2018-09-23 Thread Axel Davy
Most of the work was already there, just not implemented. Fixes: https://github.com/iXit/Mesa-3D/issues/318 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c | 62 --- 1 file changed, 55 insertions(+), 7 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 01/22] st/nine: Add ff key hash to help debug

2018-09-23 Thread Axel Davy
This is very useful to find in the log the ff shader shource of a given call. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index

[Mesa-dev] [PATCH 08/22] st/nine: Check if format is DS before retrieving flags

2018-09-23 Thread Axel Davy
support non depth stencil format, but we don't want the user to create depth buffers with d3d formats that can't be one, it's better to check if the format can be depth buffer with d3d. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 2 ++ 1 file changed, 2 inse

[Mesa-dev] [PATCH 11/22] st/nine: Avoid redundant SetCursorPos calls

2018-09-23 Thread Axel Davy
tests. Fixes irresponsive GUI for some applications. Fixes: https://github.com/iXit/Mesa-3D/issues/173 Signed-off-by: Axel Davy CC: --- src/gallium/state_trackers/nine/device9.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/ga

[Mesa-dev] [PATCH 09/22] st/nine: Initialize manually cursor structure

2018-09-23 Thread Axel Davy
Initialize manually the cursor structure fields for more clarity on its content. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c

[Mesa-dev] [PATCH 13/22] st/nine: Lock the entire buffer in some cases.

2018-09-23 Thread Axel Davy
(starting from the offset) for these (except for DYNAMIC buffers, which might hurt performance too much). Fixes: https://github.com/iXit/Mesa-3D/issues/301 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/buffer9.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium

[Mesa-dev] [PATCH 15/22] st/nine: Minor refactor of a few NINE_STATE_* flags

2018-09-23 Thread Axel Davy
Rename NINE_STATE_FOG_SHADER, NINE_STATE_POINTSIZE_SHADER and NINE_STATE_PS1X_SHADER into NINE_STATE_VS_PARAMS_MISC and NINE_STATE_PS_PARAMS_MISC. The behaviour is unchanged, except one minor change: D3DRS_FOGTABLEMODE doesn't need to affect VS. Signed-off-by: Axel Davy --- src/ga

[Mesa-dev] [PATCH 10/22] st/nine: Init cursor position at device creation

2018-09-23 Thread Axel Davy
This is only useful for software cursor, but at least now we won't start it at (0, 0). Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/ga

[Mesa-dev] [PATCH 17/22] st/nine: Add dummy ff shader state

2018-09-23 Thread Axel Davy
;t need it, replace by a dummy ff shader state (which is easier to understand for an external reader than just setting 0 and more future proof). Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 16 src/gallium/state_trackers/nine/nine_state.h | 4 2 fil

[Mesa-dev] [PATCH 16/22] st/nine: Mark pointsize states as ff states

2018-09-23 Thread Axel Davy
The pointsize states were missing the ff NINE_STATE_FF_OTHER flag, and thus might miss state updates when using ff. Fixes some wine tests. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 14/22] st/nine: Increase maximum number of temp registers

2018-09-23 Thread Axel Davy
With some test app I hit the limit. As we allocate on demand (up to the maximum), it is free to increase the limit. Signed-off-by: Axel Davy CC: --- src/gallium/state_trackers/nine/nine_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine

[Mesa-dev] [PATCH 19/22] st/nine: Do not mark both ff vs and ps updated

2018-09-23 Thread Axel Davy
. Fixes: https://github.com/iXit/Mesa-3D/issues/319 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index addea3dde1f

[Mesa-dev] [PATCH 12/22] st/nine: Don't call SetCursor until a cursor is set

2018-09-23 Thread Axel Davy
x27;t do. Add comment about not avoiding redundant ID3DPresent_SetCursor calls once a cursor has been set in d3d, as it has been tested to cause regressions. Fixes: https://github.com/iXit/Mesa-3D/issues/197 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 9 - 1

[Mesa-dev] [PATCH 18/22] st/nine: Split NINE_STATE_FF_OTHER

2018-09-23 Thread Axel Davy
NINE_STATE_FF_OTHER was mostly ff vs states. Rename it to NINE_STATE_FF_VS_OTHER and move common states with ps to NINE_STATE_FF_PS_CONSTS (renamed from NINE_STATE_FF_PSSTAGES). Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 4 +-- src/gallium/state_trackers/nine

[Mesa-dev] [PATCH 22/22] radeonsi: NaN should pass kill_if

2018-09-23 Thread Axel Davy
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=105333 Fixes: https://github.com/iXit/Mesa-3D/issues/314 For this application, NaN is passed to KILL_IF and is expected to pass. Signed-off-by: Axel Davy --- src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 20/22] st/nine: Capture also default matrices for D3DSBT_ALL

2018-09-23 Thread Axel Davy
We avoid allocating space for never unused matrices. However we must do as if we had captured them. Thus when a D3DSBT_ALL stateblock apply has fewer matrices than device state, allocate the default matrices for the stateblock before applying. Signed-off-by: Axel Davy --- src/gallium

[Mesa-dev] [PATCH 21/22] st/nine: Mark transform matrices dirty for D3DSBT_ALL

2018-09-23 Thread Axel Davy
D3DSBT_ALL stateblocks capture the transform matrices. Fixes some d3d test programs not displaying properly. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine

Re: [Mesa-dev] [PATCH 20/22] st/nine: Capture also default matrices for D3DSBT_ALL

2018-09-23 Thread Axel Davy
It should be last_index += D3DTS_WORLDMATRIX(0) - 10; I drop this patch from the serie and patch 21/22 as they need more testing. On 9/23/18 7:00 PM, Axel Davy wrote: We avoid allocating space for never unused matrices. However we must do as if we had captured them. Thus when a D3DSBT_ALL

[Mesa-dev] [PATCH 22/22 v2] radeonsi: NaN should pass kill_if

2018-09-23 Thread Axel Davy
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=105333 Fixes: https://github.com/iXit/Mesa-3D/issues/314 For this application, NaN is passed to KILL_IF and is expected to pass. v2: Explain in the code why UGE is used. Signed-off-by: Axel Davy Reviewed-by: Marek Olšák CC: --- src

Re: [Mesa-dev] [Mesa-stable] [PATCH 22/22 v2] radeonsi: NaN should pass kill_if

2018-10-01 Thread Axel Davy
structions"), which was not nominated. WDYT? Should both patches added to the 18.2 release, or just get them out of the release? J.A. Hi, As Marek is the maintainer for radeonsi, I let him choose. Yours, Axel Davy On Mon, Sep 24, 2018 at 2:29 AM, Axel Davy wrote

Re: [Mesa-dev] [PATCH] d3dadapter9: use snprintf(..., "%s", ...) instead of strncpy

2018-11-25 Thread Axel Davy
Reading https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/ I think the snprintf variant suffers from the same issue, and the compiler is just not yet able to detect it, and send the same warning (but it might do in later gcc versions). Probably a better fix wo

Re: [Mesa-dev] [PATCH] d3dadapter9: use snprintf(..., "%s", ...) instead of strncpy

2018-12-01 Thread Axel Davy
Well, OK, I guess these snprintf call are an acceptable solution then. Reviewed-by: Axel Davy On 26/11/2018 13:23, Andre Heider wrote: On 25/11/2018 17:23, Axel Davy wrote: Reading https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/ I think the snprintf

Re: [Mesa-dev] last call for autotools

2018-12-12 Thread Axel Davy
On 12/12/2018 23:06, Dylan Baker wrote: Quoting Marek Olšák (2018-12-12 13:07:10) On Wed, Dec 12, 2018 at 3:52 PM Rob Clark wrote: On Wed, Dec 12, 2018 at 3:45 PM Marek Olšák wrote: > > On Wed, Dec 12, 2018 at 3:37 PM Rob Clark wrote: >> >> On Wed, Dec 12, 2018 at 3:

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-13 Thread Axel Davy
On 13/12/2018 17:26, Jason Ekstrand wrote: On Thu, Dec 13, 2018 at 5:06 AM Eric Engestrom mailto:eric.engest...@intel.com>> wrote: On Wednesday, 2018-12-12 15:24:25 -0800, Dylan Baker wrote: > In the autotools discussion I've come to realize that we also need to talk about > the

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Axel Davy
On 13/12/2018 17:57, Mathias Fröhlich wrote: Hi, Initially it seemed to me that I am about the only one sticking with mailing lists. And I personally feel like a too small contributor to really try to influence your decisions too much. But these recent hand full of mails all tell me that I am

Re: [Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

2018-12-14 Thread Axel Davy
Hi Marek, That seems a good idea. Several 32bits games have virtual address space issues as well with both Nine and Wine (but Nine seems a bit more affected because more libs are loaded). Maybe the patch could go a little bit further by doing the same for buffers the first time they si_buffe

[Mesa-dev] [PATCH 4/6] st/nine: Bind src not dst in nine_context_box_upload

2018-12-16 Thread Axel Davy
nine_context_box_upload uploads a ram buffer (from src) to a pipe_resource (dst). We already have a refcount on the pipe_resource, what needs to be protected from release is the ram buffer, thus a reference to src. Signed-off-by: Axel Davy Cc: mesa-sta...@lists.freedesktop.org --- src/gallium

[Mesa-dev] [PATCH 5/6] st/nine: Add src reference to nine_context_range_upload

2018-12-16 Thread Axel Davy
Just like nine_context_box_upload, nine_context_range_upload should reference the src, which holds the ram source buffer. Fixes: https://github.com/iXit/Mesa-3D/issues/327 Signed-off-by: Axel Davy Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/nine/buffer9.h| 4

[Mesa-dev] [PATCH 2/6] st/nine: Switch to presentation buffer if resize is detected

2018-12-16 Thread Axel Davy
This enables to match the window size on resize on all cases, as it only works currently with presentation buffers. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/swapchain9.c | 37 +++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 1/6] st/nine: Use helper to release swapchain buffers later

2018-12-16 Thread Axel Davy
This patch introduces a structure to release the present_handles only when they are fully released by the server, thus making "DestroyD3DWindowBuffer" actually release the buffer right away when called. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/swapcha

[Mesa-dev] [PATCH 6/6] st/nine: Increase the limit of cached ff shaders

2018-12-16 Thread Axel Davy
100 is too small for some games, which triggers recompilations every frame. Increase to 1024. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium

[Mesa-dev] [PATCH 3/6] st/nine: Fix volumetexture dtor on ctor failure

2018-12-16 Thread Axel Davy
The dtor is called on allocation failure, thus we must check the volumes are allocated before trying to release them. Signed-off-by: Axel Davy Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/nine/volumetexture9.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] st/nine: Enable debug info if NDEBUG is not set

2018-12-20 Thread Axel Davy
We want to have debug info as well if using meson's debugoptimized when ndebug is off. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 6 +++--- src/gallium/state_trackers/nine/basetexture9.h | 2 +- src/gallium/state_trackers/nine/nine_debug.h

[Mesa-dev] [PATCH] st/nine: Ignore null sized windows

2019-01-03 Thread Axel Davy
xes: https://github.com/iXit/Mesa-3D/issues/332 Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Axel Davy --- It may not apply cleanly to mesa stable. I can do another patch for stable if needed. Basically it's the very same code except the part "/* Switch to using presentation buf

Re: [Mesa-dev] [PATCH] st/nine: Ignore null sized windows

2019-01-05 Thread Axel Davy
to our knowledge, but that may tie our hands. Anyone having opinion on whether I should push the workaround or consider the issue fixed if using an updated wine backend ? Axel On 03/01/2019 21:48, Axel Davy wrote: If for some reason the window size detected is null, just render at normal size. F

[Mesa-dev] [PATCH 1/4] st/nine: Fix bad tracking of bound vs textures

2018-03-13 Thread Axel Davy
An incorrect formula was used to compute bound_samplers_mask_vs. Since s is above always 8 for vs and the variable is encoded on 8 bits, it was always 0. This resulted in commiting the samplers every call when there was at least one texture read in the vs shader. Signed-off-by: Axel Davy

[Mesa-dev] [PATCH 3/4] st/nine: Fixes warning about implicit conversion

2018-03-13 Thread Axel Davy
Makes the conversion explicit. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=102542 Signed-off-by: Axel Davy CC: "17.3 18.0" --- src/gallium/state_trackers/nine/nine_ff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/ni

[Mesa-dev] [PATCH 2/4] st/nine: Fix bad tracking of vs textures for NINESBT_ALL

2018-03-13 Thread Axel Davy
Stateblocks with NINESBT_ALL should track all textures. For better performance they have a faster path which copies all the required. This path was only tracking ps textures. Fixes: https://github.com/iXit/Mesa-3D/issues/303 Signed-off-by: Axel Davy CC: "17.3 18.0" --- s

[Mesa-dev] [PATCH 4/4] st/nine: Fix non inversible matrix check

2018-03-13 Thread Axel Davy
There was a missing absolute value when checking if the determinant was big enough. Fixes: https://github.com/iXit/Mesa-3D/issues/292 Signed-off-by: Axel Davy CC: "17.3 18.0" --- src/gallium/state_trackers/nine/nine_ff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Mesa-dev] [PATCH 2/7] gallium: use PIPE_CAP_CONSTBUF0_FLAGS

2018-02-02 Thread Axel Davy
Hi Marek, Since the previous patch makes it mandatory to use the flags when required, I guess this patch should also add the neccessary changes to gallium nine. Yours, Axel Davy On 02/02/2018 21:48, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/util/u_inlines.h | 21

Re: [Mesa-dev] [PATCH 2/7] gallium: use PIPE_CAP_CONSTBUF0_FLAGS

2018-02-03 Thread Axel Davy
On 02/02/2018 23:41, Marek Olšák wrote: On Fri, Feb 2, 2018 at 10:44 PM, Axel Davy wrote: Hi Marek, Since the previous patch makes it mandatory to use the flags when required, I guess this patch should also add the neccessary changes to gallium nine. Nine uses user buffers and const_uploader

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-02-28 Thread Axel Davy
My understanding of the code is that the disk cache just depends on the sscreen->b.disk_shader_cache being initialized, and it looks like this is always initialized. Thus the disk cache is always enabled. Could you add a RADEON_DEBUG env var to disable it, please ? Thanks, Axel Davy On

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add support for an on-disk shader cache

2017-03-01 Thread Axel Davy
On 02/03/2017 00:27, Timothy Arceri wrote: On 01/03/17 18:36, Axel Davy wrote: My understanding of the code is that the disk cache just depends on the sscreen->b.disk_shader_cache being initialized, and it looks like this is always initialized. Thus the disk cache is always enabled. Co

Re: [Mesa-dev] [PATCH 1/2] util/disk_cache: support caches for multiple architectures

2017-03-02 Thread Axel Davy
On 02/03/2017 17:24, Marek Olšák wrote: On Thu, Mar 2, 2017 at 3:03 PM, Mike Lothian wrote: Is this because the 32bit and 64bit versions have slightly different time stamps used in the cache directory name? I was under the impression that the cache itself could be shared between 32bit & 64bit?

Re: [Mesa-dev] [PATCH 2/2] st/nine: pass NULL to ureg_get_tokens()

2017-03-08 Thread Axel Davy
Reviewed-by: Axel Davy On 03/03/2017 00:12, Timothy Arceri wrote: The number of tokens in never used and the pointer is NULL checked so just pass NULL. --- src/gallium/state_trackers/nine/nine_ff.c | 3 +-- src/gallium/state_trackers/nine/nine_shader.c | 3 +-- 2 files changed, 2

[Mesa-dev] [PATCH] st/nine: Fix user vertex data uploader with csmt

2017-03-15 Thread Axel Davy
Fix regression caused by abb1c645c476b5dd289ce3efae0594f8796f9cf8 The patch made csmt use context.pipe instead of secondary_pipe, leading to thread safety issues. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 15 +++ src/gallium/state_trackers/nine

[Mesa-dev] [PATCH 1/2] st/nine: Fix issue with surface and volume dtors and csmt

2017-03-15 Thread Axel Davy
Surfaces and Volumes can be freed in the worker thread. This fixes these dtor. Especially if they were freed by nine_context_box_upload, the counter was decremented after the destructions, which lead to deadlock. Fixes bugzilla 99246. CC: "17.0" Signed-off-by: Axel Davy --- s

[Mesa-dev] [PATCH 2/2] st/nine: Use atomics for available_texture_mem

2017-03-15 Thread Axel Davy
Resource dtor can be executed in the worker thread. Use atomic to avoid threading safety issues. CC: "17.0" Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/resource9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine

Re: [Mesa-dev] [PATCH 1/2] loader/dri3: Use client local back to front blit in copySubBuffer if available

2017-09-04 Thread Axel Davy
if loader_dri3_blit_image fails doesn't seem a good choice, because what the server sees is the linear copy of the buffers. You'd have to add a blit from the linear copy to the tiled buffer (which won't work if local blit is not available). Yours, Axel Davy

Re: [Mesa-dev] [PATCH 1/2] loader/dri3: Use client local back to front blit in copySubBuffer if available

2017-09-05 Thread Axel Davy
Hi, On 05/09/2017 08:37, Thomas Hellstrom wrote: Hi! On 09/05/2017 07:36 AM, Axel Davy wrote: On 04/09/2017 14:27, Thomas Hellstrom wrote: The copySubBuffer functionality always attempted a server side blit from back to fake front if a fake front was present, and we weren't displaying

Re: [Mesa-dev] [PATCH 1/2] radeonsi: enable out-of-order rasterization when possible on VI and GFX9 dGPUs

2017-09-06 Thread Axel Davy
+* +* - depth-only rendering: +* + depth must force ordering Why depth must force ordering in depth only rendering ? If the depth func is PIPE_FUNC_LESS, PIPE_FUNC_GREATER or similar, you get min or max behaviour, thus the order shouldn't matter. Yours, Axel

[Mesa-dev] [PATCH 01/12] st/nine: Remove commented nine_context_apply_stateblock

2018-10-24 Thread Axel Davy
At some point the project was to adapt the commented version to csmt. The csmt rework enabled to fix some state aliasing issues between stateblocks and internal state updates. The commented version needs a lot of work to work with that. Just drop it. Signed-off-by: Axel Davy --- src/gallium

[Mesa-dev] [PATCH 05/12] st/nine: Capture also default matrices for D3DSBT_ALL

2018-10-24 Thread Axel Davy
We avoid allocating space for never unused matrices. However we must do as if we had captured them. Thus when a D3DSBT_ALL stateblock apply has fewer matrices than device state, allocate the default matrices for the stateblock before applying. Signed-off-by: Axel Davy --- src/gallium

[Mesa-dev] [PATCH 06/12] st/nine: Never update device changed.* fields

2018-10-24 Thread Axel Davy
The device state changed.* field are never used. These fields are used only for stateblocks. Avoid setting them at all for clarity. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 4 +- src/gallium/state_trackers/nine/nine_state.c | 7 +- src/gallium

[Mesa-dev] [PATCH 03/12] st/nine: Don't update unused world matrices

2018-10-24 Thread Axel Davy
de to send the updated values for the unreachable matrices. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/state_trackers/nine/nine_state.c b/src/gallium/state_trackers/nine/nine_state.c index c99012

[Mesa-dev] [PATCH 02/12] st/nine: Remove two unused states.

2018-10-24 Thread Axel Davy
NINE_STATE_MATERIAL was used incorrectly at one location. Replace it with the correct state. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 2 +- src/gallium/state_trackers/nine/nine_state.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 09/12] st/nine: Enable shadow mapping for ps 1.X

2018-10-24 Thread Axel Davy
We didn't implement shadow textures for ps 1.X, assuming the case couldn't happen... Well it does. Fixes: https://github.com/iXit/Mesa-3D/issues/261 Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_shader.c | 8 +--- src/gallium/state_trackers/nine/pixelshad

[Mesa-dev] [PATCH 10/12] st/nine: Reduce MaxSimultaneousTextures to 8

2018-10-24 Thread Axel Davy
Windows drivers don't set this flag (which affects ff) to more than 8. Do the same in case some games check for 8. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers

[Mesa-dev] [PATCH 04/12] st/nine: Mark transform matrices dirty for D3DSBT_ALL

2018-10-24 Thread Axel Davy
D3DSBT_ALL stateblocks capture the transform matrices. Fixes some d3d test programs not displaying properly. Signed-off-by: Axel Davy --- Notice without the previous patch, D3DSBT_ALL stateblocks would send hundreds of identity matrices to the context every apply. src/gallium/state_trackers

[Mesa-dev] [PATCH 12/12] st/nine: Handle window resize when a presentation buffer is used

2018-10-24 Thread Axel Davy
. ID3DPresent_GetWindowInfo is a function available with D3DPresent v1.0, and thus we don't need to check if the function is available. The function had been introduced to implement this very feature. Signed-off-by: Axel Davy --- A presentation buffer is used when multisampling is used or

[Mesa-dev] [PATCH 11/12] d3dadapter: Fix wrong naming in header file

2018-10-24 Thread Axel Davy
GetWindowInfo used to be GetWindowSize before gallium nine was merged. A left-over remained... Signed-off-by: Axel Davy --- include/d3dadapter/present.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/d3dadapter/present.h b/include/d3dadapter/present.h index

<    5   6   7   8   9   10   11   >