[Mesa-dev] [PATCH] mesa: Be less casual about texture formats in st_finalize_texture

2013-05-06 Thread Adam Jackson
reeing about the format. Fix this by not ignoring the alpha channel in st_finalize_texture when considering whether two 32-bit formats are sufficiently compatible. Signed-off-by: Adam Jackson --- src/mesa/state_tracker/st_cb_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] st/mesa: handle texture_from_pixmap and other surface-based textures correctly

2013-05-14 Thread Adam Jackson
ace_format. > 2) Don't reallocate a surface-based texture in st_finalize_texture. > > Also don't use st_ChooseTextureFormat is st_context_teximage, because > the format is dictated by the caller. > > This fixes the glx-tfp piglit test. Reviewed-by: Adam Jackson - ajax _

[Mesa-dev] [PATCH 00/13] Fix llvmpipe on big-endian

2013-05-16 Thread Adam Jackson
This series introduces bytewise formats for framebuffers, and fixes the vector representation on big-endian. No damage to piglit on little-endian, but fixes a few thousand on big-endian, enough to make gnome-shell work correctly. I've tried to break it up into reviewable chunks, but it probably w

[Mesa-dev] [PATCH 01/13] gallivm: Remove all notion of byte-swapping

2013-05-16 Thread Adam Jackson
--- src/gallium/auxiliary/gallivm/lp_bld_conv.c| 76 -- src/gallium/auxiliary/gallivm/lp_bld_conv.h| 11 src/gallium/auxiliary/gallivm/lp_bld_format_aos.c | 9 --- .../auxiliary/gallivm/lp_bld_format_aos_array.c| 56 src/gallium/auxil

[Mesa-dev] [PATCH 02/13] draw: Add A8R8G8B8 to draw_print_arrays

2013-05-16 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson --- src/gallium/auxiliary/draw/draw_pt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/draw/draw_pt.c b/src/gallium/auxiliary/draw/draw_pt.c index 14dde67..bc300c0 100644 --- a/src/gallium/auxiliary/draw

[Mesa-dev] [PATCH 03/13] gallium: Introduce 32-bit bytewise format names

2013-05-16 Thread Adam Jackson
From: Richard Sandiford RGBA has R at byte 0 and A at byte 3, regardless of platform endianness. Reviewed-by: Adam Jackson --- src/gallium/include/pipe/p_format.h | 38 + 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/src/gallium/include

[Mesa-dev] [PATCH 04/13] tests: Convert to bytewise formats

2013-05-16 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson --- src/gallium/tests/graw/clear.c | 4 ++-- src/gallium/tests/graw/fs-test.c | 4 ++-- src/gallium/tests/graw/graw_util.h | 6 +++--- src/gallium/tests/graw/quad-sample.c | 4 ++-- src/gallium/tests/graw/shader-leak.c | 4

[Mesa-dev] [PATCH 05/13] gbm: Convert to bytewise formats

2013-05-16 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson --- src/gallium/state_trackers/gbm/gbm_drm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/gbm/gbm_drm.c b/src/gallium/state_trackers/gbm/gbm_drm.c index 8490480..4f76b0f 100644 --- a

[Mesa-dev] [PATCH 06/13] st/xlib: Convert to bytewise formats

2013-05-16 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson --- src/gallium/state_trackers/glx/xlib/xm_api.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/glx/xlib/xm_api.c b/src/gallium/state_trackers/glx/xlib/xm_api.c index e426192

[Mesa-dev] [PATCH 07/13] st/dri: Convert to bytewise formats

2013-05-16 Thread Adam Jackson
Reviewed-by: Adam Jackson --- src/gallium/state_trackers/dri/common/dri_screen.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/dri/common/dri_screen.c b/src/gallium/state_trackers/dri/common/dri_screen.c index e09fe1d..43cca30 100644

[Mesa-dev] [PATCH 08/13] format: Convert to bytewise formats

2013-05-16 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson --- src/mesa/state_tracker/st_format.c | 58 +++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index 56f3a4a..ae9e28e

[Mesa-dev] [PATCH 09/13] graw-xlib: Convert to bytewise formats

2013-05-16 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson --- src/gallium/targets/graw-xlib/graw_xlib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/targets/graw-xlib/graw_xlib.c b/src/gallium/targets/graw-xlib/graw_xlib.c index 2827747..ed112b9 100644 --- a/src

[Mesa-dev] [PATCH 10/13] util: Convert color pack to bytewise formats

2013-05-16 Thread Adam Jackson
From: Richard Sandiford This fixes them on big-endian. Reviewed-by: Adam Jackson --- src/gallium/auxiliary/util/u_pack_color.h | 36 +++ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util/u_pack_color.h b/src/gallium

[Mesa-dev] [PATCH 11/13] llvmpipe: Fix convert_to_blend_type on big-endian

2013-05-16 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson --- src/gallium/drivers/llvmpipe/lp_state_fs.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c b/src/gallium/drivers/llvmpipe/lp_state_fs.c index 6921210

[Mesa-dev] [PATCH 12/13] gallivm: Fix big-endian machines

2013-05-16 Thread Adam Jackson
From: Richard Sandiford This adds a bit-shift count to the format table, and adds the concept of vector or bitwise alignment on gathers. Reviewed-by: Adam Jackson --- src/gallium/auxiliary/gallivm/lp_bld_format_aos.c | 22 +++ src/gallium/auxiliary/gallivm/lp_bld_format_soa.c | 13

[Mesa-dev] [PATCH 13/13] gallivm: Fix lp_build_rgba8_to_fi32_soa for big endian

2013-05-16 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson --- src/gallium/auxiliary/gallivm/lp_bld_format_soa.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_format_soa.c index 2c62291..cf51b34 100644

Re: [Mesa-dev] [PATCH 00/13] Fix llvmpipe on big-endian

2013-05-16 Thread Adam Jackson
On Thu, 2013-05-16 at 16:28 +0200, Michel Dänzer wrote: > On Don, 2013-05-16 at 09:06 -0400, Adam Jackson wrote: > > This series introduces bytewise formats for framebuffers, and fixes the > > vector representation on big-endian. No damage to piglit on little-endian, > > but

[Mesa-dev] [PATCH] llvmpipe: Remove x/y from cmd_bin

2013-05-16 Thread Adam Jackson
These were mostly just a waste of memory and cache pressure, and were really only used for debugging. This change reduces instruction count (as measured by callgrind's Ir event) of gnome-shell-perf-tool on Ivybridge by 3.5% ± 0.015% (n=20). Signed-off-by: Adam Jackson --- src/gallium/dr

Re: [Mesa-dev] [PATCH] llvmpipe: Remove x/y from cmd_bin

2013-05-16 Thread Adam Jackson
On Thu, 2013-05-16 at 15:44 -0400, Adam Jackson wrote: > These were mostly just a waste of memory and cache pressure, and were > really only used for debugging. > > This change reduces instruction count (as measured by callgrind's Ir > event) of gnome-shell-perf-tool on Ivybr

[Mesa-dev] [PATCH] gallium: Document format name conventions

2013-06-03 Thread Adam Jackson
Other things to maybe add: - More detail on FOURCC formats, or at least a link - SSCALED/USCALED? Not sure what they're meant to be really Signed-off-by: Adam Jackson --- src/gallium/docs/format.rst | 39 +++ 1 file changed, 39 insertions(+) create

[Mesa-dev] [PATCH] gallium: Document format name conventions

2013-06-05 Thread Adam Jackson
v2: - Fix a channel name thinko (Michel Dänzer) - Elaborate on SCALED versus INT - Add links to DirectX and FOURCC docs Signed-off-by: Adam Jackson --- src/gallium/docs/format.rst | 54 + 1 file changed, 54 insertions(+) create mode 100644 src

Re: [Mesa-dev] [PATCH] llvmpipe: Use saturating add/sub for UNORM formats

2013-06-10 Thread Adam Jackson
On Fri, 2013-06-07 at 08:34 -0700, Jose Fonseca wrote: > Looks good to me. Pushed (along with some other fixes of Richard's that were still pending), thanks. - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/m

[Mesa-dev] [PATCH] llvmpipe: Stop calling util_format_get_blocksize on the hot path

2013-06-10 Thread Adam Jackson
Calling this two+ times per tile command is not especially fast. We already had a slot for this in the scene, but we were only filling it in for the z/s buffer. Fill it in consistently and use that instead of util_format_get_blocksize() when computing tile addresses. Signed-off-by: Adam Jackson

Re: [Mesa-dev] [PATCH 03/13] gallium: Introduce 32-bit bytewise format names

2013-06-17 Thread Adam Jackson
On Sun, 2013-06-16 at 10:22 -0700, Jose Fonseca wrote: > Ok. I think this patch series is sound from an implementation POV. I > see no point in delaying further. We can tweak things afterwards if > deemed necessary. > > Lets squash the commits, rename the XYZW formats to go from > low->high b

[Mesa-dev] [PATCH 00/14] Big-endian support in gallivm and llvmpipe

2013-06-18 Thread Adam Jackson
New in this series: - Includes gallium format name documentation - Defines packed formats as aliases into the existing enum - Changes packed format names to be lsb-to-msb Note that the existing hardware drivers will be "broken" by this series (on big-endian machines), but that they probably alrea

[Mesa-dev] [PATCH 01/14] gallivm: Remove all notion of byte-swapping

2013-06-18 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/gallium/auxiliary/gallivm/lp_bld_conv.c| 76 -- src/gallium/auxiliary/gallivm/lp_bld_conv.h| 11 src/gallium/auxiliary/gallivm/lp_bld_format_aos.c | 9 --- .../auxiliary/gallivm/lp_bld_format_aos_array.c| 56

[Mesa-dev] [PATCH 02/14] gallium: Document format name conventions

2013-06-18 Thread Adam Jackson
v2: - Fix a channel name thinko (Michel Dänzer) - Elaborate on SCALED versus INT - Add links to DirectX and FOURCC docs Signed-off-by: Adam Jackson --- src/gallium/docs/format.rst | 54 + 1 file changed, 54 insertions(+) create mode 100644 src

[Mesa-dev] [PATCH 03/14] gallium: Introduce 32-bit packed format names

2013-06-18 Thread Adam Jackson
rmat names. Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/include/pipe/p_format.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/gallium/include/pipe/p_format.h b/src/gallium/include/pipe/p_format.h index 098b25b..f181621 100644 --- a/

[Mesa-dev] [PATCH 04/14] gallium: Document packed formats

2013-06-18 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/gallium/docs/format.rst | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/docs/format.rst b/src/gallium/docs/format.rst index 2514656..e270d93 100644 --- a/src/gallium/docs/format.rst +++ b/src/gallium/docs/format.rst

[Mesa-dev] [PATCH 05/14] tests: Convert to packed formats

2013-06-18 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/tests/graw/clear.c | 4 ++-- src/gallium/tests/graw/fs-test.c | 4 ++-- src/gallium/tests/graw/graw_util.h | 6 +++--- src/gallium/tests/graw/quad-sample.c | 4 ++-- src

[Mesa-dev] [PATCH 06/14] gbm: Convert to packed formats

2013-06-18 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/state_trackers/gbm/gbm_drm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/gbm/gbm_drm.c b/src/gallium/state_trackers/gbm/gbm_drm.c

[Mesa-dev] [PATCH 07/14] st/xlib: Convert to packed formats

2013-06-18 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/state_trackers/glx/xlib/xm_api.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/glx/xlib/xm_api.c b/src/gallium/state_trackers/glx

[Mesa-dev] [PATCH 08/14] st/dri: Convert to packed formats

2013-06-18 Thread Adam Jackson
Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/state_trackers/dri/common/dri_screen.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/dri/common/dri_screen.c b/src/gallium/state_trackers/dri/common/dri_screen.c

[Mesa-dev] [PATCH 10/14] graw-xlib: Convert to packed formats

2013-06-18 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/targets/graw-xlib/graw_xlib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/targets/graw-xlib/graw_xlib.c b/src/gallium/targets/graw-xlib/graw_xlib.c index

[Mesa-dev] [PATCH 11/14] util: Convert color pack to packed formats

2013-06-18 Thread Adam Jackson
From: Richard Sandiford This fixes them on big-endian. Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/auxiliary/util/u_pack_color.h | 36 +++ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/gallium/auxiliary/util

[Mesa-dev] [PATCH 12/14] llvmpipe: Fix convert_to_blend_type on big-endian

2013-06-18 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/drivers/llvmpipe/lp_state_fs.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c b/src/gallium/drivers

[Mesa-dev] [PATCH 13/14] gallivm: Fix big-endian machines

2013-06-18 Thread Adam Jackson
From: Richard Sandiford This adds a bit-shift count to the format table, and adds the concept of vector or bitwise alignment on gathers. Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/auxiliary/gallivm/lp_bld_format_aos.c | 22 +++ src/gallium/auxiliary

[Mesa-dev] [PATCH 14/14] gallivm: Fix lp_build_rgba8_to_fi32_soa for big endian

2013-06-18 Thread Adam Jackson
From: Richard Sandiford Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/auxiliary/gallivm/lp_bld_format_soa.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_soa.c b/src/gallium/auxiliary/gallivm

[Mesa-dev] [PATCH] glx: Fix image size computation for EXT_texture_integer

2014-12-12 Thread Adam Jackson
tly reject the request without this patch. This is the client-side equivalent of: http://cgit.freedesktop.org/xorg/xserver/commit/?id=13d36923e0ddb077f4854e354c3d5c80590b5d9d Signed-off-by: Adam Jackson --- src/glx/compsize.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] glx: Fix image size computation for EXT_texture_integer

2014-12-15 Thread Adam Jackson
On Fri, 2014-12-12 at 13:25 -0800, Ian Romanick wrote: > Looking at src/glx/glxextensions.c (the known_glx_extensions array > specifically), I don't think we support GL_EXT_texture_integer on the > client side for indirect rendering. So... do we actually need this patch? Technically no? But pigl

[Mesa-dev] [PATCH] glxinfo: Add support for GLX_MESA_query_renderer

2015-01-12 Thread Adam Jackson
This just queries our context, it doesn't attempt to enumerate all the available renderers. Signed-off-by: Adam Jackson --- src/xdemos/glxinfo.c | 49 + 1 file changed, 49 insertions(+) diff --git a/src/xdemos/glxinfo.c b/src/xdemos/glxi

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

2019-01-14 Thread Adam Jackson
On Fri, 2019-01-11 at 15:01 +, Emil Velikov wrote: > > @@ -460,6 +464,14 @@ driGetConfigAttribIndex(const __DRIconfig *config, > > else > > *value = 0; > > break; > > +case __DRI_ATTRIB_RED_MASK_HI: > > +case __DRI_ATTRIB_GREEN_MASK_HI: > > +case __DRI_ATTRIB_BLUE_M

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

2019-01-16 Thread Adam Jackson
On Wed, 2019-01-16 at 04:41 +, Strasser, Kevin wrote: > Emil Velikov wrote: > > > > Please split this up a bit. I'm thinking of: > > - dri_interface > > - mesa > > - egl > > - gbm > > - glx - seems sparse on updates, guessting you're followed in laster > > patches? > > Sure, I can break

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

2019-01-16 Thread Adam Jackson
On Wed, 2019-01-16 at 17:58 +, Strasser, Kevin wrote: > Adam Jackson wrote: > > > Probably what I'd do is only define those masks to non-zero for <=32bpp > > formats, > > Not sure if I understood this statement. Do you mean if we keep the _HI and > _LO

Re: [Mesa-dev] [PATCH] meson: add toggle for TLS support in GLX

2019-01-28 Thread Adam Jackson
On Sat, 2019-01-26 at 13:56 +0100, Patrick Steinhardt wrote: > Unfortunately, I'm not aware of any easy way to do this. The > problem is not due to the compiler, as the program compiles and > links just fine with musl libc. Instead, this is a runtime issue > that happens when dlopen'ing shared obj

Re: [Mesa-dev] Fwd: Review for last remaining Mesa wayland-drm depth 30 bits?

2019-01-29 Thread Adam Jackson
bmission: > > https://patchwork.freedesktop.org/project/mesa/list/?submitter=14956 > > Would be good to get this into Mesa 19 before new color formats are > added. Should be useful for new formats as well. 4 and 5 are: Reviewed-by: Adam Jackson - ajax ___

Re: [Mesa-dev] Fwd: Review for last remaining Mesa wayland-drm depth 30 bits?

2019-01-29 Thread Adam Jackson
On Tue, 2019-01-29 at 17:51 +0100, Mario Kleiner wrote: > Thanks for the quick review! > > Patchwork didn't pick the r-b's up though. Do i need to do anything / > ping somebody to get those merged to master ideally before the close > 19.0 branchpoint and not overlooked? I've created a merge reque

Re: [Mesa-dev] [PATCH 11/13] gallium: Add buffer and configs handling or fp16 formats

2019-01-29 Thread Adam Jackson
On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote: > Expose configs when allow_fp16_configs has been enabled and > DRI_LOADER_CAP_FP16 is set in the loader. > > Also, make kms_swrast_dri respect format bpp, to allow for allocating > buffers wider than 32 bpp. Was this the only offender? -

Re: [Mesa-dev] [PATCH 04/13] egl: Convert configs to use shifts instead of masks

2019-01-29 Thread Adam Jackson
On Mon, 2019-01-28 at 10:42 -0800, Kevin Strasser wrote: > @@ -237,19 +268,35 @@ dri2_add_config(_EGLDisplay *disp, const __DRIconfig > *dri_config, int id, > break; > >case __DRI_ATTRIB_RED_MASK: > - dri_masks[0] = value; > + dri_shifts[0] = ffs(value) - 1; >

Re: [Mesa-dev] [PATCH 00/13] Enable fp16 visuals and fbconfigs

2019-01-29 Thread Adam Jackson
ers) to support EXT_gl_colorspace_scrgb / > EXT_gl_colorspace_scrgb_linear, used in places like Android wide color > gamut. This looks great! Comments on 4/ and 11/ are minor, and haven't built my way through testing this yet, but: Reviewed-by: Adam Jackson - ajax __

Re: [Mesa-dev] 10-bit fbconfigs break most video players using VAAPI+GLX

2019-02-06 Thread Adam Jackson
On Tue, 2019-02-05 at 17:30 -0500, Marek Olšák wrote: > If we expose 10-bit or 16-bit formats, a lot of software will be > broken. Any ideas how to get out of this rabbit hole? Use GLX_SGIX_visual_select_group to hide the depth-30 formats after the depth-24 ones. We're already doing this for simi

Re: [Mesa-dev] 10-bit fbconfigs break most video players using VAAPI+GLX

2019-02-06 Thread Adam Jackson
On Wed, 2019-02-06 at 10:33 -0500, Adam Jackson wrote: > On Tue, 2019-02-05 at 17:30 -0500, Marek Olšák wrote: > > > If we expose 10-bit or 16-bit formats, a lot of software will be > > broken. Any ideas how to get out of this rabbit hole? > > Use GLX_SGIX_visual_select

Re: [Mesa-dev] RFC - libglvnd and GLXVND vendor enumeration to facilitate GLX multi-vendor PRIME GPU offload

2019-02-08 Thread Adam Jackson
On Fri, 2019-02-08 at 10:19 -0800, Andy Ritger wrote: > (1) If configured for PRIME GPU offloading (environment variable or > application profile), client-side libglvnd could load the possible > libGLX_${vendor}.so libraries it finds, and call into each to > find which vendor (and poss

Re: [Mesa-dev] Should piglit drop bugzilla and move to using gitlab issues?

2019-03-06 Thread Adam Jackson
On Fri, 2019-03-01 at 17:35 -0800, Kenneth Graunke wrote: > On Friday, March 1, 2019 1:30:48 PM PST Dylan Baker wrote: > > Quoting Jordan Justen (2019-03-01 12:22:18) > > > I guess piglit makes very light usage of bugzilla. Would it be simpler > > > to just use gitlab issues in the piglit gitlab pr

Re: [Mesa-dev] [PATCH v3] glx: update to updated version of EXT_create_context_es2_profile

2016-02-03 Thread Adam Jackson
nt-side support > v2 -> v3: >  - fix error in computing mask Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH demos 1/4] eglinfo: Note when an EGLConfig is streams-compatible

2016-04-20 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index 1f79fef..ca22df2 100644 --- a/src/egl/opengl/eglinfo.c +++ b/src/egl/opengl/eglinfo.c @@ -93,6 +93,8 @@ PrintConfigs(EGLDisplay

[Mesa-dev] [PATCH demos 4/4] eglinfo: Add EXT_platform_* awareness

2016-04-20 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 41 +++-- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index 875e407..75d9fe5 100644 --- a/src/egl/opengl/eglinfo.c +++ b/src/egl

[Mesa-dev] [PATCH demos 3/4] eglinfo: Factor out a "probe one display" function

2016-04-20 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index b044eaa..875e407 100644 --- a/src/egl/opengl/eglinfo.c +++ b/src/egl/opengl

[Mesa-dev] [PATCH demos 2/4] eglinfo: Print client extensions first

2016-04-20 Thread Adam Jackson
These are independent of the display, and I want to iterate over those. Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index ca22df2..b044eaa 100644 --- a/src

[Mesa-dev] [PATCH 5/4] eglinfo: Restore eglTerminate

2016-04-20 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index 75d9fe5..f7da372 100644 --- a/src/egl/opengl/eglinfo.c +++ b/src/egl/opengl/eglinfo.c @@ -178,6 +178,7 @@ doOneDisplay(EGLDisplay

Re: [Mesa-dev] [PATCH 0/3] Support for Android RGBX/RGBA formats

2016-04-25 Thread Adam Jackson
On Mon, 2016-04-25 at 15:21 +0100, Emil Velikov wrote: > Last a I saw you guys were backporting all of mesa, correct ? > Are you OK with us deprecating compat. between DRI(2) modules and > loaders (GL/EGL/gbm) that are, say 3 years apart ? At this point that's probably fine. RHEL6 still includes

Re: [Mesa-dev] [PATCH 0/3] Support for Android RGBX/RGBA formats

2016-04-25 Thread Adam Jackson
On Mon, 2016-04-25 at 16:49 +0100, Emil Velikov wrote: > Was thinking of that one but forgot to explicitly mention it. What is > the "age gap" between the xserver and the dri modules that you ship ? > I'm thinking that the above 3 years "gap" + ~9months of deprecation > period should be fine with

[Mesa-dev] [PATCH] egl: Remove skeleton implementation of EGL_MESA_screen_surface

2015-05-01 Thread Adam Jackson
No backend wires this up to anything, and the extension spec has been marked obsolete for 4+ years. Signed-off-by: Adam Jackson --- include/EGL/eglmesaext.h | 46 -- src/egl/main/Makefile.sources | 4 - src/egl/main/eglapi.c | 278 src/egl

[Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2015-05-12 Thread Adam Jackson
t the testcase wants GL 3.0 and shaders, and that's not a thing classic has, so I figured making it work on softpipe was crime enough. Signed-off-by: Adam Jackson --- src/gallium/state_trackers/dri/drisw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/d

[Mesa-dev] [PATCH 0/9] Implement GLX_ARB_context_flush_control

2015-05-12 Thread Adam Jackson
This is a rebase of Neil's work through patch 5. 6 through 8 wire the extension through gallium and drisw. Adding it to the gallium hardware drivers would be similarly trivial. The last patch hides some grossness with the protocol, where xserver has to be taught about the new context attribute b

[Mesa-dev] [PATCH 7/9] gallium: Wire up flush control

2015-05-12 Thread Adam Jackson
This still doesn't do anything unless your driver exposes the flush control extension. Signed-off-by: Adam Jackson --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_context.c | 7 ++- src/mesa/state_tracker/st_manager.c | 3 +++ 3

[Mesa-dev] [PATCH 3/9] glx: Add the GLX_ARB_context_flush_control extension

2015-05-12 Thread Adam Jackson
From: Neil Roberts This adds the framework for the GLX flush control extension. It is advertised if the DRI driver implements the new __DRI2_FLUSH_CONTROL extension. The GLX attributes are converted to the appropriate DRI attributes. --- src/glx/dri2_glx.c | 19 +-- src/glx/

[Mesa-dev] [PATCH 5/9] i965: Implement the __DRI2_FLUSH_CONTROL extension

2015-05-12 Thread Adam Jackson
From: Neil Roberts Implementing the extension just involves copying the release behaviour value from the context config to the GL context's constants. The upper layers of Mesa handles the actual flushing. --- src/mesa/drivers/dri/i965/brw_context.c | 20 +++- src/mesa/drivers/dr

[Mesa-dev] [PATCH 6/9] glx: Implement ARB_context_flush_control in drisw too

2015-05-12 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/drisw_glx.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index a07feb9..c2f8c4b 100644 --- a/src/glx/drisw_glx.c +++ b/src/glx/drisw_glx.c @@ -410,7 +410,7

[Mesa-dev] [PATCH 1/9] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

2015-05-12 Thread Adam Jackson
From: Neil Roberts Previously the CreateContext method of __DriverApiRec took a set of arguments to describe the attribute values from the window system API's CreateContextAttribs function. As more attributes get added this could quickly get unworkable and every new attribute needs a modification

[Mesa-dev] [PATCH 2/9] dri: Add a flush control extension

2015-05-12 Thread Adam Jackson
From: Neil Roberts Adds a DRI extension which advertises that the driver can accept a new __DRI_CTX_ATTRIB_RELEASE_BEHAVIOR attribute in the createContextAttribs function. If the attribute is specified then it will be passed down to the CreateContext function in the release_behavior member of __D

[Mesa-dev] [PATCH 4/9] intel: Don't flush the old context in intelMakeCurrent

2015-05-12 Thread Adam Jackson
From: Neil Roberts It shouldn't be necessary to flush the context within the driver implementation because the old context is explicitly flushed in _mesa_make_current which is called a little further on. It is useful to only have a single place that flushes when switching contexts to make it easi

[Mesa-dev] [PATCH 9/9] hacks: Enable testing this series on slightly older userspace

2015-05-12 Thread Adam Jackson
This hides the flush control attribute from the CreateContextAttribs request. Older X servers don't know about it and will throw an error, and at least for purposes of testing it's not something that matters. Signed-off-by: Adam Jackson --- src/glx/create_cont

Re: [Mesa-dev] [PATCH 00/57] Finish enabling ARB_direct_state_access

2015-05-13 Thread Adam Jackson
ly is not the case. In any event, looks good to me. With or without the above addressed, these 20 are: Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl: remove remaining EGL_MESA_copy_context skeleton

2015-05-14 Thread Adam Jackson
xtension > was never implemented in mesa. > > Cc: Adam Jackson > Signed-off-by: Emil Velikov Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/20] glapi: Remove static dispatch for functions that didn't exist in NVIDIA

2015-05-19 Thread Adam Jackson
On Wed, 2015-05-13 at 12:44 -0700, Ian Romanick wrote: > From: Ian Romanick > > Comparing the output of > > nm -D libGL.so.349.16 | grep ' T gl[^X]' | sed 's/.* T //' > > between Catalyst NVIDIA 349.16 and this commit, the only change is a > bunch > of functions that NVIDIA exports that Me

Re: [Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2015-05-19 Thread Adam Jackson
On Tue, 2015-05-12 at 23:34 +0200, Roland Scheidegger wrote: > I like faster! > > I don't really understand though where the wins come from. > softpipe can't have much pending work in the first place (maybe tile > cache?), llvmpipe potentially has the rasterizer threads I guess but > I'm not quit

Re: [Mesa-dev] [PATCH 6/9] glx: Implement ARB_context_flush_control in drisw too

2015-05-19 Thread Adam Jackson
On Tue, 2015-05-12 at 11:54 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson This one is still unreviewed, if anyone's interested. It's almost certainly too late to land this series in 10.6, but 10.7 would be nice. - ajax > --- > src/glx/drisw_glx.c | 13

[Mesa-dev] [PATCH] dri: Add a way to query the driver for supported context flags

2015-05-19 Thread Adam Jackson
initialize the set in InitScreen, and check that set in the driver CreateContextAttribs hook instead of open-coding. Signed-off-by: Adam Jackson --- include/GL/internal/dri_interface.h | 20 ++-- src/gallium/state_trackers/dri/dri2.c| 6 ++ src/gallium/stat

Re: [Mesa-dev] [PATCH] RFC: drisw/glx: use XShm if possible

2015-06-08 Thread Adam Jackson
On Fri, 2015-06-05 at 19:14 +0200, Marc-André Lureau wrote: > XPutImage requires to copy the images around, and the request may be > split over several chunks. Using XShm may improve performance. Almost certainly will, the XPutImage implementation is fairly comic. > +static volatile int XErrorFla

Re: [Mesa-dev] [PATCH] RFC: drisw/glx: use XShm if possible

2015-06-08 Thread Adam Jackson
On Mon, 2015-06-08 at 20:19 +0200, Marc-André Lureau wrote: > This was based off similar code in xlib_sw_winsys.c You're right, that code's all wrong too. I'll send some patches to fix that up. - aja ___ mesa-dev mailing list mesa-dev@lists.freedeskto

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-09 Thread Adam Jackson
On Wed, 2016-03-09 at 11:15 -0700, Kyle Brenneman wrote: > The current implementation of libglvnd uses a new X extension called  > x11glvnd to look up a vendor name for each screen and to find a screen  > number for a GLXDrawable. > > But, Adam Jackson pointed out that a GLX ext

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-10 Thread Adam Jackson
On Thu, 2016-03-10 at 08:32 -0700, Kyle Brenneman wrote: > > That could work, although I would expect "vendor-specific info" to  > > mean "random, arbitrary, and probably not machine-parsable". I'd be  > > hesitant to try to impose a structure on something that's never had  > > any structure befor

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-10 Thread Adam Jackson
On Thu, 2016-03-10 at 10:53 -0700, Kyle Brenneman wrote: > On 03/10/2016 10:47 AM, Martin Peres wrote: > > > > That could be a hacky way of handling the case where multiple 3D  > > drivers could be used to drive the same GPU. This may be necessary in  > > the future if two mesa drivers support the

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-11 Thread Adam Jackson
On Fri, 2016-03-11 at 11:12 -0700, Kyle Brenneman wrote: > All right, here's an updated draft of the Issues section. How does it look? > > Issues >  1)  Should GLX_VENDOR_NAMES_EXT contain a single vendor name or a list of >  names? > >  UNRESOLVED: Allow a list of names. > >

[Mesa-dev] [PATCH 01/11] glx: Unbreak generating some of the xorg glx headers

2016-03-24 Thread Adam Jackson
Broken by: commit 9ace0b542241c77ae82a0835ac8a09e2a7510eaf Author: Dylan Baker Date: Wed May 20 15:49:11 2015 -0700 glapi: glX_proto_size.py: use argparse instead of getopt Which changed most, but not all, callers to use --header-tag instead of -h. Signed-off-by: Adam

[Mesa-dev] [PATCH 00/11] Generated GLX dispatch updates

2016-03-24 Thread Adam Jackson
Apologies for the stray duplicate copy of 01/11, neglected to say --compose and didn't hit ^C in time. This long-overdue series synchronizes the GLX dispatch scripts with the state of the world in xserver. We no longer use the CALL_* pattern instead emitting gl* calls directly (or thunking throug

[Mesa-dev] [PATCH 03/11] glapi/glx: skip that which is marked for skipping

2016-03-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/indirect_vertex_array.c | 39 src/glx/indirect_vertex_program.c | 202 -- src/glx/tests/indirect_api.cpp| 2 - src/mapi/glapi/gen/glX_XML.py | 6 +- 4 files changed, 4 insertions(+), 245 deletions

[Mesa-dev] [PATCH 07/11] glapi: Add the safe_{add, mul, pad} functions from xserver

2016-03-24 Thread Adam Jackson
We're about to update the generator scripts to use these, easier not to vary between client and server. Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_send.py | 24 1 file changed, 24 insertions(+) diff --git a/src/mapi/glapi/gen/glX_proto_send.py

[Mesa-dev] [PATCH 11/11] glapi/glx: Mark the indirect swapped dispatch functions _X_COLD

2016-03-24 Thread Adam Jackson
A modest size savings: textdata bss dec hex filename 264143 15608 232 279983 445af libglx.so.before 254303 15608 232 270143 41f3f libglx.so.after Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 6 +++--- 1 file changed, 3 insertions

[Mesa-dev] [PATCH 05/11] glapi/glx: Treat xserver generated targets as .PHONY

2016-03-24 Thread Adam Jackson
Meaning, always rebuild them when asked instead of bothering to look at timestamps (and then wondering why nothing happened when you said make). Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/glapi/gen/Makefile.am b

[Mesa-dev] [PATCH 09/11] glapi/glx: Sync some additional error checking from xserver

2016-03-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 4 1 file changed, 4 insertions(+) diff --git a/src/mapi/glapi/gen/glX_proto_recv.py b/src/mapi/glapi/gen/glX_proto_recv.py index 21b187c..a138adb 100644 --- a/src/mapi/glapi/gen/glX_proto_recv.py +++ b/src/mapi/glapi

[Mesa-dev] [PATCH 10/11] glapi/glx: Mark byteswap functions as _X_UNUSED

2016-03-24 Thread Adam Jackson
Squashes the one remaining warning in the xserver build. Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/glX_proto_recv.py b/src/mapi/glapi/gen/glX_proto_recv.py index a138adb..7eb19df

[Mesa-dev] [PATCH 04/11] glapi/glx: Thunk non-ABI calls through GetProcAddress

2016-03-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/glX_proto_recv.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/glX_proto_recv.py b/src/mapi/glapi/gen/glX_proto_recv.py index 916da94..1cfa8c5 100644 --- a/src/mapi/glapi/gen

[Mesa-dev] [PATCH 08/11] glapi: Harden GLX request size processing

2016-03-24 Thread Adam Jackson
--- src/mapi/glapi/gen/glX_XML.py| 2 +- src/mapi/glapi/gen/glX_proto_recv.py | 2 -- src/mapi/glapi/gen/glX_proto_send.py | 2 -- src/mapi/glapi/gen/glX_proto_size.py | 24 +++- src/mapi/glapi/gen/gl_XML.py | 2 +- 5 files changed, 13 insertions(+), 19 dele

[Mesa-dev] [PATCH 01/11] glx: Unbreak generating some of the xorg glx headers

2016-03-24 Thread Adam Jackson
Broken by: commit 9ace0b542241c77ae82a0835ac8a09e2a7510eaf Author: Dylan Baker Date: Wed May 20 15:49:11 2015 -0700 glapi: glX_proto_size.py: use argparse instead of getopt Which changed most, but not all, callers to use --header-tag instead of -h. Signed-off-by: Adam

[Mesa-dev] [PATCH 02/11] glapi/glx: Emit direct GL calls instead of dispatch lookup

2016-03-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/Makefile.am | 11 --- src/mapi/glapi/gen/glX_proto_recv.py | 33 ++--- 2 files changed, 10 insertions(+), 34 deletions(-) diff --git a/src/mapi/glapi/gen/Makefile.am b/src/mapi/glapi/gen/Makefile.am

[Mesa-dev] [PATCH 06/11] glapi: Fix whitespace droppings when printing the license header

2016-03-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/mapi/glapi/gen/gl_XML.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py index 2e7123e..e11f6fc 100644 --- a/src/mapi/glapi/gen/gl_XML.py +++ b/src/mapi/glapi/gen/gl_XML.py

Re: [Mesa-dev] [PATCH 07/11] glapi: Add the safe_{add, mul, pad} functions from xserver

2016-03-28 Thread Adam Jackson
On Mon, 2016-03-28 at 10:53 -0700, Ian Romanick wrote: > On 03/24/2016 11:10 AM, Adam Jackson wrote: > > +print 'if (a == 0 || b == 0) return 0;' > Is this check actually necessary? Yes because ... > > +print 'if (a > INT_MAX / b) retur

Re: [Mesa-dev] [PATCH 03/11] glapi/glx: skip that which is marked for skipping

2016-03-29 Thread Adam Jackson
On Mon, 2016-03-28 at 11:14 -0700, Ian Romanick wrote: > I am confused by this patch.  Mesa drivers doesn't support > GL_NV_vertex_program, but the library still supports the protocol for it > for compatibility with other server implementations. > src/glx/glxextensions.c still tries to advertise su

<    1   2   3   4   5   >