these load sequences by allowing
a number of rounds where no instruction is scheduled.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106163
Signed-off-by: Gert Wollny
---
src/gallium/drivers/r600/sb/sb_sched.cpp | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff
This patch doesn't apply, the "int i" was deleted already; I didn't
find the commit though.
Am Freitag, den 29.12.2017, 08:32 +0300 schrieb Konstantin Kharlamov:
> Signed-off-by: Konstantin Kharlamov
> ---
> src/gallium/drivers/r600/r600_state_common.c | 1 -
> 1 file changed, 1 deletion(-)
>
This gives me ~200 FPS more with a 200x200 glxgears window with both,
Barts and Ceder.
Reviewed-by: Gert Wollny
Am Montag, den 01.01.2018, 10:38 +0300 schrieb Konstantin Kharlamov:
> Ported from radeonsi. Improves windowed glxgears ran as
>
> vblank_mode=0 glxgears -info -geo
Patches 2-4 Reviewed-By: Gert Wollny
I can't push them though
I'd like to add that for the future it would be better to
- send the patches for st and r600 as separate series, this would
make it easier to find reviewers
- when fixing warning to add the specific warnings
Am Donnerstag, den 12.04.2018, 18:11 -0700 schrieb
gurchetansi...@chromium.org:
> This is the SSBO analogue to fe0647. User supplied data must
> be a multiple of GL_SHADER_STORAGE_BUFFER_OFFSET_ALIGNMENT.
>
> This fixes 44 GLES31 tests on airlied@'s GLES31 sketch branches with
> Nvidia hardware, b
Gert
> On Mon, Jun 4, 2018 at 6:03 AM Gert Wollny
> wrote:
> >
> > Am Donnerstag, den 12.04.2018, 18:11 -0700 schrieb
> > gurchetansi...@chromium.org:
> > > This is the SSBO analogue to fe0647. User supplied data must
> > > be a multiple of GL_SHADER_S
,
^~
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c
b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index 2c43785201..b37a92fa43 100644
--- a/src
unsigned
integer expressions [-Wsign-compare]
if (i < prop->Property.NrTokens - 2)
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c
b/src/gallium/auxi
rights
Gert Wollny (24):
configure.ac: Add CFLAG -Wno-missing-field-initializers
gallium/aux/cso_cache: Fix various warnings
gallium/aux/tgsi/tgsi_dump.c: Fix -Wsign-compare warnings
gallium/aux/tgsi/tgsi_parse.c: Fix two warnings
gallium/aux/tgsi_sanity.c: Fix -Wsign-compare warnings
anity.c:488:26: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
if (ctx->index_of_END == ~0) {
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_sanity.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary
)
^~~~
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c
b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index
.
Signed-off-by: Gert Wollny
---
configure.ac | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure.ac b/configure.ac
index 02dca4547c..7d71e0ee4e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -301,7 +301,9 @@ AX_CHECK_COMPILE_FLAG([-Wall],
[CFLAGS="$C
ARRAY_SIZE(coords));
^~
tgsi/tgsi_exec.c:2363:20: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
for (i = dim; i < ARRAY_SIZE(coords); i++) {
^
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_exec.c |
n signed and unsigned in
conditional expressions [-Wsign-compare]
dst->Register.Index == ts->color_out) {
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_aa_point.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_aa_po
ing: comparison between signed and unsigned
integer expressions [-Wsign-compare]
return ctx->Position >=
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_parse.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/t
delete_sampler_state(struct cso_context *ctx, void
*state)
^~~
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/cso_cache/cso_cache.c | 12 ++--
src/gallium/auxiliary/cso_cache/cso_context.c | 2 +-
2 files changed, 7 insertions(+), 7
remove "type" from "match_or_expand_immediate64", fixes:
tgsi/tgsi_ureg.c: In function 'match_or_expand_immediate64':
tgsi/tgsi_ureg.c:837:34: warning: unused parameter 'type' [-Wunused-
parameter]
int type,
Fixes warning:
tgsi/tgsi_exec.c: In Funktion »exec_kill«:
tgsi/tgsi_exec.c:2049:47: Warning: unused parameter »inst« [-Wunused-parameter]
const struct tgsi_full_instruction *inst)
^~~~
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary
Removing the unused prev_tocken from the function calls made this local
variable also unused.
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_build.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c
b/src/gallium
n 'test_texture_barrier':
util/u_tests.c:652:25: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
for (int i = 0; i < num_samples / 2; i++) {
^
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/util/u_cpu_
Only decorate function as noreturn when DEBUG is not defined, because
when compiled in DEBUG mode the function actually executes an int3 and
may return, fixes:
u_debug.c: In function '_debug_assert_fail':
u_debug.c:309:1: warning: 'noreturn' function does return
Signed
g.c: In function 'rename_color_inputs':
tgsi/tgsi_lowering.c:1311:28: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
if (src->Index == ctx->two_side_idx[j]) {
^~
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary
ons [-Wsign-compare]
for (i = 0; i < ARRAY_SIZE(ureg->properties); i++)
^
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_ureg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c
b/src/gallium/auxili
__LINE__, __FUNCTION__))
^~~~
os/os_process.c:140:7: note: in expansion of macro 'assert'
assert(n < size);
^~
gallium/aux/os/ squash
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/os/os_process.c | 28 ++--
1 file cha
1)
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/util/u_cpu_detect.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_cpu_detect.h
b/src/gallium/auxiliary/util/u_cpu_detect.h
index 4a34ac4d9a..7a63d55028 100644
--- a/src/gallium/auxi
atatype src_datatype)
^~~~
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c
b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index 7e44bfee85..d9ac0ff
~~
tgsi/tgsi_two_side.c: In function 'xform_inst':
tgsi/tgsi_two_side.c:184:45: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
if (inst->Src[i].Register.Index == ts-
>front_color_input[j]) {
gt;num_src) {
^
tgsi/tgsi_text.c: In function 'parse_immediate':
tgsi/tgsi_text.c:1660:24: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
for (type = 0; type < ARRAY_SIZE(tgsi_immediate_type_names); ++type)
{
g.c: In function 'rename_color_inputs':
tgsi/tgsi_lowering.c:1311:28: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
if (src->Index == ctx->two_side_idx[j]) {
^~
Signed-off-by: Gert Wollny
---
src/gallium/
^~
tgsi/tgsi_build.c: In function 'tgsi_build_texture_offset':
tgsi/tgsi_build.c:819:23: warning: unused parameter 'prev_token' [-
Wunused-parameter]
struct tgsi_token *prev_token,
^~
Signed-off-by: Gert Wollny
---
s
d.c: In function 'tgsi_build_full_property':
tgsi/tgsi_build.c:1393:18: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
for( i = 0; i < full_prop->Property.NrTokens - 1; i++ ) {
^
Signed-off-by: Gert Wollny
---
src/gallium/auxiliary/tgsi
omments are very
welcome.
Many thanks for reviews and comments,
Gert
PS: I have no commit rights.
Gert Wollny (15):
mesa/st/glsl_to_tgsi: Add method to collect some TGSI statistics
mesa/st/glsl_to_tgsi: Split arrays whose elements are only accessed
directly
mesa/st/glsl_to_tgsi: Pro
t;resource if it is an array element
(thanks: Benedikt Schemmer for testing the patches on radeonsi, which
revealed that I was missing tracking this)
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 113 -
1 file changed, 112 ins
On one hand "live range" is the term used in the literature, and on the
other hand a distinction is needed from the array live ranges.
v4: Fix indentions and white spaces
Reviewed-by: Nicolai Hähnle (v3)
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp
if (b)
t = ...
else
t = ...
x = t;
...
}
...
}
This patch adds a unit test for this case and corrects the minimal live range
estimation
accordingly.
v4: update comments
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_temprename.
collected. The file is
opened in append mode so that statistics from various runs will be
accumulated.
v4: Make accress to log file thread save (thanks for pointing this out Nicolai
Hähnle)
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 68
v4: - Update the code to use the new merge logic.
- Use a cleaner, class-based approach for the evaluation of merges.
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 383 -
.../state_tracker/st_glsl_to_tgsi_array_merge.h| 26 +-
2
commit message
Thanks Nicolai Hähnle for the pointers given.
Signed-off-by: Gert Wollny
---
src/mesa/Makefile.sources | 2 +
src/mesa/meson.build | 2 +
.../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 217
v4: - Remove logic for evaluation of swizzles and merges since this
was moved to array_live_range. This class now only handles the
actual remapping.
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 100 +
.../state_tracker
: Gert Wollny
---
src/mesa/state_tracker/tests/Makefile.am | 20 +-
src/mesa/state_tracker/tests/meson.build | 16 +-
src/mesa/state_tracker/tests/st_tests_common.h | 7 +-
.../tests/test_glsl_to_tgsi_array_merge.cpp| 751 +
4 files changed, 787
In preparartion of adding the tracking of the live range the classes that refer
to temporary registers are renamed.
Reviewed-by: Nicolai Hähnle
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_temprename.cpp | 61 +++---
.../state_tracker
of
adding more complexity to the already existing code for temporary life
range evaluation.
v4: Update commit message to make it clearer why this class is seperate from
the tracking of temporaries.
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_temprename.cpp | 102
In preparation of the array live range tracking the evaluation of the read
mask is moved out the register live range tracking to the enclosing call
of the generalized read access tracking.
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 15
'avg change %', 'worst'])
v4: - Correct typo and add bugs that are fixed by this series.
- Update stats and describe stats evaluation
Bugzilla:
https://bugs.freedesktop.org/show_bug.cgi?id=105371
https://bugs.freedesktop.org/show_bug.cgi?id=100
Signed-off-by: Gert Wollny
---
.../tests/test_glsl_to_tgsi_array_merge.cpp| 211 +
1 file changed, 211 insertions(+)
diff --git a/src/mesa/state_tracker/tests/test_glsl_to_tgsi_array_merge.cpp
b/src/mesa/state_tracker/tests/test_glsl_to_tgsi_array_merge.cpp
index
v4: Also track the register given in inst->resource. (thanks: Benedikt Schemmer
for testing the patches on radeonsi, which revealed that I was missing
tracking this)
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_temprename.cpp | 62 +-
1 f
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/tests/st_tests_common.cpp | 181 ---
src/mesa/state_tracker/tests/st_tests_common.h | 32 +++-
2 files changed, 186 insertions(+), 27 deletions(-)
diff --git a/src/mesa/state_tracker/tests/st_tests_common.cpp
b/src
From: Gert Wollny
This warning is misleading: When a struct is partially initialized without
assigning to the struture members by name, then the un-initialized fields
will be zeroed out, and this warning will be issued (if enabled). If, on the
other hand, the partial initialization is done by
From: Gert Wollny
This warning is misleading: When a struct is partially initialized without
assigning to the struture members by name, then the un-initialized fields
will be zeroed out, and this warning will be issued (if enabled). If, on the
other hand, the partial initialization is done by
Hello Benedikt,
Am Mittwoch, den 06.06.2018, 21:58 +0200 schrieb Benedikt Schemmer:
>
> The arrays-of-arrays piglit shaders I sent you still crash though
> Gert.
Can you post a backtrace?
>
>
> - if (get_temp_registers_required_live_ranges(
> reg_live_ranges, &this->instructions,
> +//
: Marek Olšák (v1)
Reviewed-by: Emil Velikov (v2)
Signed-off-by: Gert Wollny
---
configure.ac | 4
meson.build | 11 +++
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 75ee1a7c01..6a9e56f974 100644
--- a/configure.ac
+++ b/configure.ac
__LINE__, __FUNCTION__))
^~~~
os/os_process.c:140:7: note: in expansion of macro 'assert'
assert(n < size);
^~
gallium/aux/os/ squash
v2: - simplify patch (Emil Velikov)
- print error message only when compiled in debug mode
Signed-off-by: Ger
Am Freitag, den 08.06.2018, 16:28 +0100 schrieb Emil Velikov:
> On 8 June 2018 at 12:02, Gert Wollny wrote:
> > From: Gert Wollny
> >
> > This warning is misleading: When a struct is partially initialized
> > without
> > assigning to the struture members
Am Montag, den 11.06.2018, 11:05 +0100 schrieb Eric Engestrom:
> On Monday, 2018-06-11 11:33:20 +0200, Gert Wollny wrote:
> > This warning is misleading: When a struct is partially initialized
> > without
> > assigning to the structure members by name, then the remaining
&
add -Wno-missing-field-initializers to
c_args instead of no_override_init_args (Eric Engstrom)
Reviewed-by: Marek Olšák (v1)
Reviewed-by: Emil Velikov (v2)
Signed-off-by: Gert Wollny
---
configure.ac | 4
meson.build | 13 ++---
2 files changed, 14 insertions(+), 3
Hi Emil,
Am Freitag, den 08.06.2018, 16:28 +0100 schrieb Emil Velikov:
> On 8 June 2018 at 12:02, Gert Wollny wrote:
> > From: Gert Wollny
> >
[...]
> Out of curiosity: how many warnings are we walking about - is it
> something like 20-50 or it's in the 100+ re
add -Wno-missing-field-initializers to
c_args instead of no_override_init_args (Eric Engstrom)
v5: * configure.ac: Correct copy/paste error with CFLAGS/CXXFLAGS
Reviewed-by: Marek Olšák (v1)
Reviewed-by: Emil Velikov (v2)
Signed-off-by: Gert Wollny
---
configure.ac | 4
Hi Dylan & Eric,
are you fine with how the flag is added now in meson? If you don't have
any complaints I'm going to push the changes later today.
many thanks,
Gert
Am Dienstag, den 19.06.2018, 10:07 +0200 schrieb Gert Wollny:
> This warning is misleading: When a st
Looks good to me
Reviewed-By: Gert Wollny
Am Freitag, den 08.06.2018, 11:20 +1000 schrieb Dave Airlie:
> From: Dave Airlie
>
> ---
> docs/features.txt| 2 +-
> src/gallium/drivers/virgl/virgl_encode.c | 7 +--
> src/gallium/drivers/virgl/
Ping
Am Samstag, den 26.05.2018, 23:20 +0200 schrieb Gert Wollny:
> One must not assume that compiling swr on non-Windows platforms is
> always
> done for 64 bit archs. For instance in an Gentoo multiarch
> installation if
> swr is enabled, it will be build for all ar
For texture array lookup the slice index is evaluated according to
idx = floor(z + 0.5)
This patch implements the first part by adding 0.5 to the according
texture coordinate when appropriate.
Signed-off-by: Gert Wollny
---
src/gallium/drivers/r600/r600_shader.c | 64
these two patches correct the offets and the rounding modes for the
index evaluation when accessing texture arrays. The patches were tested
with the gles3 test suite where they fix a number of tests related to 2D
texture arrays and didn't show any regressions.
Best,
Gert
Gert Woll
d z-filter are
used.
Fixes:
dEQP-GLES3.functional.texture.shadow.2d_array.*
dEQP-GLES3.functional.texture.vertex.2d_array.*
dEQP-GLES3.functional.texture.filtering.2d_array.*
and a number of tests from
dEQP-GLES3.functional.shaders.texture_functions.*2darray
Signed-off-by: Gert Wo
Thanks for testing,
Gert
>
> Dave.
>
>
> On 22 June 2018 at 19:37, Gert Wollny
> wrote:
> > these two patches correct the offets and the rounding modes for the
> > index evaluation when accessing texture arrays. The patches were
> > tested
> > with th
Use caps to obtain the multisample sample positions for up to 16
positions and implement the according Gallium interface.
Signed-off-by: Gert Wollny
---
This patch requires another patch against virglrenderer to work.
src/gallium/drivers/virgl/virgl_context.c | 48 +++
src
Use caps to obtain the multisample sample positions for up to 16
positions and implement the according Gallium interface.
v2: remove unrelated chunk (thanks Ilia Mirkin)
Signed-off-by: Gert Wollny
---
This patch requires another patch against virglrenderer to work.
src/gallium/drivers/virgl
orward fixing these
tests (like described above), but it would probably okay to squash
them. I'll have to revise the first patch anyway.
best,
Gert
> Roland
>
> Am 25.06.2018 um 07:54 schrieb Dave Airlie:
> > /home/airlied/devel/piglit/bin/textureGather fs nonconst r 0 float
&g
Am Montag, den 25.06.2018, 23:47 +0200 schrieb Roland Scheidegger:
>
> Alright albeit you have logic to handle incoming z offsets, whereas
> that should always be 0.
I'm preparing for future standards that allow for these z-offsets ;)
> To be honest I'm actually kind of surprised the hw would ho
intermediate sample counts
- fix unused varible warning
- update description
Signed-off-by: Gert Wollny
---
I left the debug_printf in there, because this patch (together with the
related virglrenderer patch) is not sufficient to fix above tests on a GLES
host.
src/gallium/drivers/virgl
see this patch
for the host side: https://patchwork.freedesktop.org/patch/233354/)
best,
Gert
>
> On Thu, Jun 28, 2018 at 3:45 PM Gert Wollny m> wrote:
> >
> > Use caps to obtain the multisample sample positions for up to 16
> > positions and implement the accor
Am Donnerstag, den 28.06.2018, 17:40 +0200 schrieb Erik Faye-Lund:
> On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny m> wrote:
> >
> > There are two aspects:
> >
> > For each number of samples there is indeed a fixes set of sample
> > positions that o
Am Donnerstag, den 28.06.2018, 18:09 +0200 schrieb Erik Faye-Lund:
> It still seems kinda strange (and fragile) to me to try to enumerate
> all possible sample locations up-front instead of querying a given
> texture for it's sample-locations.
With virgl, querying a texture for host-side informatio
numbers
that are not directly advertised (thanks go to Erik Faye-Lund for making
me aware that this should be documented)
Signed-off-by: Gert Wollny
---
I left the debug_printf in there, because this patch (together with the
related virglrenderer patch) is not sufficient to fix above tests on a
;s also
why I
think that it is better to keep the patches apart, to better be able to biscet
possible
issues.
best,
Gert
Gert Wollny (2):
r600: correct texture offset for array index lookup
r600: set rounding mode for texture array layer selection
src/gallium/drivers/r6
t the texture offset to 1 (=0.5) because the shader
can't set an offset for the array index (Roland Scheidegger)
- Add Fixes comment to commit message
Signed-off-by: Gert Wollny
---
src/gallium/drivers/r600/r600_shader.c | 18 +-
1 file changed, 17 insertions(+), 1 deletio
ents and commit message
* clear S_03C008_TRUNC_COORD for all non-array types
Signed-off-by: Gert Wollny
---
src/gallium/drivers/r600/evergreen_state.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/gallium/drivers/r600/evergreen_state.c
b/src/gallium/drivers/r600
Am Freitag, den 29.06.2018, 17:42 +0200 schrieb Roland Scheidegger:
[...]
Thanks for the review
>
> So for gather4_O (where you'd need to do it differently) it must not
> be
> done, but for gather4 it has to be done?
> Still doesn't make all that much sense to me. The hw may be weird but
> I don
From: Gert Wollny
The evaluation of the array layer index is "floor(z+0.5)", and the default
rounding mode doesn't correctly evaluate this. Therefore, set the rounding
mode to "trunc" and and z-filter mode to "point".
For other textures make sure the the def
From: Gert Wollny
For texture array lookup the slice index is evaluated according to
idx = floor(z + 0.5)
This patch implements the first part by adding 0.5 to the according
texture coordinate when appropriate.
Fixes multi-sample tests out of:
dEQP-GLES3.functional.texture.shadow.2d_array
master and with this patch applied)
Best,
Gert
Gert Wollny (2):
r600: correct texture offset for array index lookup
r600: set rounding mode for texture array layer selection
src/gallium/drivers/r600/evergreen_state.c | 23 +++
src/gallium/drivers/r600/r6
From: Gert Wollny
restart_index is later always used in a comparison, so it should be
initialized properly.
Fixes valgrind warning:
Conditional jump or move depends on uninitialised value(s)
at 0xB8D682F: r600_draw_vbo (r600_state_common.c:2153)
by 0xB71F743: u_vbuf_draw_vbo (u_vbuf.c
From: Gert Wollny
Structures might be padded by the compiler and these padding bytes remain
un-initialized which in turn makes memcmp return a difference where from
the logical point of view there is none.
Fixes valgrind:
Conditional jump or move depends on uninitialised value(s
dEQP-GLES3.functional.texture.specification.texsubimage3d_pbo.rgba4_3d
dEQP-GLES3.functional.texture.specification.texsubimage3d_pbo.rgb5_a1_2d_array
dEQP-GLES3.functional.texture.specification.texsubimage3d_pbo.rgb5_a1_3d
Signed-off-by: Gert Wollny
---
src/gallium/drivers/r600/r600_asm.c | 15 +++
1 file changed, 15 insertion
that no mip-mapping takes place),
force the LOD range to contain only value.
Fixes:
dEQP-GLES3.functional.shaders.texture_functions.texture*.(i|u)sampler2d*
dEQP-GLES3.functional.texture.format.sized.cube.rgb*
out of VK_GL_CTS/android/cts/master/gles3-master.txt
Signed-off-by: Gert Wollny
This series fixes another bunch of tests from deqp gles3 and gles31.
I didn't see any regressions with
piglit gpu -t texture -t gather
thanks for reviewing,
Gert
Gert Wollny (3):
r600: force LOD range to be only one value when mip.min filter is NONE
r600: Add R4G4B4A4 and A1B5G5
LES31.functional.texture.border_clamp.formats.r* (non 32 bit integer)
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d*
Signed-off-by: Gert Wollny
---
src/gallium/drivers/r600/evergreen_state.c | 66 --
1 file changed, 63 insertions(+), 3 deletions(-)
diff --git a/src/gallium/dr
Signed-off-by: Gert Wollny
---
Note that I used (1 << 3) instead of (1 << 2) because Dave's experimental patch
already uses the latter for computer shader caps.
The host side patch starting to implement this can be found here:
https://patchwork.freedesktop.org/series/4
From: Gert Wollny
Make sure that clamping in the pixel transfer operations is enabled/disabled
for packed floating point values just like it is done for single normal and
half precision floating point values.
This fixes a series of CTS tests with virgl that use r11f_g11f_b10f
buffers as target
if (b)
t = ...
else
t = ...
x = t;
...
}
...
}
This patch adds a unit test for this case and corrects the minimal live range
estimation
accordingly.
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_temprename.cpp | 14 +
file is
opened in append mode so that statistics from various runs will be
accumulated.
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 55 ++
1 file changed, 55 insertions(+)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa
y problems any more, so comments are very
welcome.
Best,
Gert
PS: I have no git write access.
[1] https://patchwork.freedesktop.org/series/37991/
[2] https://patchwork.freedesktop.org/series/39471/
Gert Wollny (13):
mesa/st/glsl_to_tgsi: Add method to collect some statistics
mesa/
y if the driver requests register merge
v2: * rename method dissolve_arrays to split_arrays
* unify the tracking and remapping methods for src and st registers
* also track access to arrays via reladdr*
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/st_glsl_to
In preparation of the array live range tracking the evaluation of the read
mask is moved out the register live range tracking to the enclosing call
of the reneralized read access tracking.
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 15
todo explain
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 69 ++
.../state_tracker/st_glsl_to_tgsi_array_merge.h| 46 +++
2 files changed, 115 insertions(+)
diff --git a/src/mesa/state_tracker
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 389 -
.../state_tracker/st_glsl_to_tgsi_array_merge.h| 26 +-
2 files changed, 413 insertions(+), 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi_array_merge.cpp
b
Signed-off-by: Gert Wollny
---
src/mesa/Makefile.sources | 2 +
src/mesa/meson.build | 2 +
.../state_tracker/st_glsl_to_tgsi_array_merge.cpp | 283 +
.../state_tracker/st_glsl_to_tgsi_array_merge.h| 116
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_temprename.cpp | 61 +-
1 file changed, 49 insertions(+), 12 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp
index
v2: Define tests also in the meson.build file.
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/tests/Makefile.am | 20 +-
src/mesa/state_tracker/tests/meson.build | 14 +
src/mesa/state_tracker/tests/st_tests_common.h | 7 +-
.../tests
On one hand "live range" is the term used in the literature, and on the
other hand a distinction is needed from the array live ranges.
Signed-off-by: Gert Wollny
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 ++---
.../state_tracker/st_glsl_to_tgsi_temprename.
Signed-off-by: Gert Wollny
---
.../state_tracker/st_glsl_to_tgsi_temprename.cpp | 61 +++---
.../state_tracker/st_glsl_to_tgsi_temprename.h | 2 +-
2 files changed, 32 insertions(+), 31 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp
b/src
301 - 400 of 827 matches
Mail list logo
